30214 2009-10-08 09:02:10 -0700 [Qt] Windowless Plugins : Create Pixmap only when size changes. 2009-10-09 06:09:07 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 20081 0 girish webkit-unassigned commit-queue oldest_to_newest 153393 0 girish 2009-10-08 09:02:10 -0700 Currently, a pixmap is created when the cliprect/windowrect changes. 153394 1 40876 girish 2009-10-08 09:03:48 -0700 Created attachment 40876 Create X Pixmap only when size changes 153406 2 40876 eric 2009-10-08 09:36:46 -0700 Comment on attachment 40876 Create X Pixmap only when size changes Can plugins become windowed from being non-windowed? The old code used to free m_drawable unconditionally, the new code only does so if the plugin is currently non-windowed. 153585 3 girish 2009-10-08 18:07:25 -0700 (In reply to comment #2) > (From update of attachment 40876 [details]) > Can plugins become windowed from being non-windowed? The old code used to free > m_drawable unconditionally, the new code only does so if the plugin is > currently non-windowed. Good point. But no, they cannot switch from windowed to windowless (and vice-versa) after instantiation. The m_drawable check should have been inside the windowed case to start with i.e as it is in the patch. 153647 4 40876 hausmann 2009-10-09 04:11:05 -0700 Comment on attachment 40876 Create X Pixmap only when size changes 153649 5 40876 commit-queue 2009-10-09 04:33:06 -0700 Comment on attachment 40876 Create X Pixmap only when size changes Clearing flags on attachment: 40876 Committed r49386: <http://trac.webkit.org/changeset/49386> 153650 6 commit-queue 2009-10-09 04:33:10 -0700 All reviewed patches have been landed. Closing bug. 40876 2009-10-08 09:03:48 -0700 2009-10-09 04:33:06 -0700 Create X Pixmap only when size changes patch text/plain 1774 girish Y29tbWl0IGExNDg0ODQ4YWJlNWM2OGIwNTQ3MWNlZTE3NzJlNDM4MGY3NGExMDgKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVGh1IE9j dCA4IDIxOjI5OjQwIDIwMDkgKzA1MzAKCiAgICBbUXRdIFdpbmRvd2xlc3MgUGx1Z2lucyA6IENy ZWF0ZSBQaXhtYXAgb25seSB3aGVuIHNpemUgY2hhbmdlcy4KCmRpZmYgLS1naXQgYS9XZWJDb3Jl L0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDU3ZjZhNDkuLjA1MzZlMDAgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDUgKzEsMTYgQEAKIDIwMDktMTAtMDggIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9y d2FyZGJpYXMuaW4+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1F0XSBXaW5kb3dsZXNzIFBsdWdpbnMgOiBDcmVhdGUgUGl4bWFwIG9ubHkgd2hlbiBz aXplIGNoYW5nZXMuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMwMjE0CisKKyAgICAgICAgKiBwbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQpOgorCisyMDA5 LTEwLTA4ICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgorCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgogCiAgICAgICAgIFtRdF0gV2luZG93 bGVzcyBwbHVnaW5zOiBSZW1vdmUgdW5uZWNlc3NhcnkgWFN5bmMgZm9yIG9wYXF1ZSBtb2RlLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdRdC5jcHAgYi9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRleCA0N2M2NDMyLi41ZGViOWE0IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAorKysgYi9XZWJDb3Jl L3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcApAQCAtMTA3LDEwICsxMDcsMTAgQEAgdm9pZCBQ bHVnaW5WaWV3Ojp1cGRhdGVQbHVnaW5XaWRnZXQoKQogICAgIGlmIChtX3dpbmRvd1JlY3QgPT0g b2xkV2luZG93UmVjdCAmJiBtX2NsaXBSZWN0ID09IG9sZENsaXBSZWN0KQogICAgICAgICByZXR1 cm47CiAKLSAgICBpZiAobV9kcmF3YWJsZSkKLSAgICAgICAgWEZyZWVQaXhtYXAoUVgxMUluZm86 OmRpc3BsYXkoKSwgbV9kcmF3YWJsZSk7CisgICAgaWYgKCFtX2lzV2luZG93ZWQgJiYgbV93aW5k b3dSZWN0LnNpemUoKSAhPSBvbGRXaW5kb3dSZWN0LnNpemUoKSkgeworICAgICAgICBpZiAobV9k cmF3YWJsZSkKKyAgICAgICAgICAgIFhGcmVlUGl4bWFwKFFYMTFJbmZvOjpkaXNwbGF5KCksIG1f ZHJhd2FibGUpOwogCi0gICAgaWYgKCFtX2lzV2luZG93ZWQpIHsKICAgICAgICAgbV9kcmF3YWJs ZSA9IFhDcmVhdGVQaXhtYXAoUVgxMUluZm86OmRpc3BsYXkoKSwgUVgxMUluZm86OmFwcFJvb3RX aW5kb3coKSwgbV93aW5kb3dSZWN0LndpZHRoKCksIG1fd2luZG93UmVjdC5oZWlnaHQoKSwgCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgoTlBTZXRXaW5kb3dDYWxsYmFja1N0 cnVjdCopbV9ucFdpbmRvdy53c19pbmZvKS0+ZGVwdGgpOwogICAgICAgICBRQXBwbGljYXRpb246 OnN5bmNYKCk7IC8vIG1ha2Ugc3VyZSB0aGF0IHRoZSBzZXJ2ZXIga25vd3MgYWJvdXQgdGhlIERy YXdhYmxlCg==