30213 2009-10-08 08:36:27 -0700 [Qt] Avoid ErrorPageExtensionOption to hold empty 'url' field 2010-03-23 08:34:43 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED WORKSFORME Qt P3 Normal --- 30216 1 tonikitoo webkit-qt-unassigned hausmann jturcotte kenneth oldest_to_newest 153389 0 tonikitoo 2009-10-08 08:36:27 -0700 In some cases, QNetworkReplyHandler's m_reply holds an empty url. m_reply->url(); <--- empty. it happend for example in some non-successful page loads. e.g. if one do: <quote> frame>setUrl("http://any.thing.invalid.here/"); <quote/> When it happens, the ResourceError passed up to FrameLoadClientQt by QNetworkReplyHandle::finish (via MainResourceLoader -> DocumentLoader -> FrameLoader) will fill ErrorPageExtensionOption's url field with an empty url. it might not be a helpful situation for client application handling error pages ... 153392 1 40875 tonikitoo 2009-10-08 08:45:32 -0700 Created attachment 40875 patch 0.1 153678 2 40875 hausmann 2009-10-09 07:36:54 -0700 Comment on attachment 40875 patch 0.1 > - QUrl url = m_reply->url(); > + QUrl url = (m_reply->url().toString().isNull()) ? m_request.url(): m_reply->url(); Instead of converting the url to a QString first before checking if it's null, can you call isEmpty() on QUrl instead? I.e. QUrl url = m_reply->url(); if (url.isEmpty()) url = m_request.url(); Is there any way to write a unit test for this? :) 153988 3 tonikitoo 2009-10-11 21:17:07 -0700 thx for your comments, simon. > Instead of converting the url to a QString first before checking if it's null, > can you call isEmpty() on QUrl instead? sure thing. > I.e. > > QUrl url = m_reply->url(); > if (url.isEmpty()) > url = m_request.url(); ok > Is there any way to write a unit test for this? :) i will try to get a auto test for it, before a next iteration here ... 203052 4 tonikitoo 2010-03-23 08:34:43 -0700 never mind. I just tried it again, and it works fine now 40875 2009-10-08 08:45:32 -0700 2009-10-09 07:36:54 -0700 patch 0.1 0001--Qt-Avoid-ErrorPageExtensionOption-to-hold-empty-u.patch text/plain 2160 tonikitoo RnJvbSBmY2M3ODk4YzU3YTA1NjYwOGJhNjAzYWViMzBmYTBjZDZlZDZlZTk2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogVGh1LCA4IE9jdCAyMDA5IDExOjQzOjM3IC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gW1F0 XSBBdm9pZCBFcnJvclBhZ2VFeHRlbnNpb25PcHRpb24gdG8gaG9sZCBlbXB0eSAndXJsJyBmaWVs ZAogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMjEzCgpQYXRjaCBi eSBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4gb24gMjAwOS0xMC0wOApSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCklmIFFOZXR3b3JrUmVwbHlIYW5kbGVyJ3MgbV9yZXBs eSBoYXMgYSBlbXB0eS9udWxsIHVybCwKbGV0cyB1c2UgbV9yZXF1ZXN0J3MgaW5zdGVhZC4KCiog cGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHA6CihXZWJDb3JlOjpR TmV0d29ya1JlcGx5SGFuZGxlcjo6ZmluaXNoKToKLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTMgKysrKysrKysrKysrKwogLi4uL3Bs YXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwICAgfCAgICAyICstCiAy IGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAwNTQyMTEz Li4yZDVmYmIwIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0No YW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEwLTA4ICBBbnRvbmlvIEdvbWVzICA8dG9u aWtpdG9vQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1F0XSBBdm9pZCBFcnJvclBhZ2VFeHRlbnNpb25PcHRpb24gdG8gaG9sZCBl bXB0eSAndXJsJyBmaWVsZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzAyMTMKKworICAgICAgICBJZiBRTmV0d29ya1JlcGx5SGFuZGxlcidzIG1fcmVw bHkgaGFzIGEgZW1wdHkvbnVsbCB1cmwsCisgICAgICAgIGxldHMgdXNlIG1fcmVxdWVzdCdzIGlu c3RlYWQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5k bGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpmaW5pc2gp OgorCiAyMDA5LTEwLTA4ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkByaW0uY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IEdlb3JnZSBTdGFpa29zLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcCBiL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKaW5kZXggN2Ez NzAzZC4uNWI4ZmRhYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FO ZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv UU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCkBAIC0yNDMsNyArMjQzLDcgQEAgdm9pZCBRTmV0d29y a1JlcGx5SGFuZGxlcjo6ZmluaXNoKCkKICAgICB9IGVsc2UgaWYgKCFtX3JlcGx5LT5lcnJvcigp IHx8IGlnbm9yZUh0dHBFcnJvcihtX3JlcGx5LCBtX3Jlc3BvbnNlRGF0YVNlbnQpKSB7CiAgICAg ICAgIGNsaWVudC0+ZGlkRmluaXNoTG9hZGluZyhtX3Jlc291cmNlSGFuZGxlKTsKICAgICB9IGVs c2UgewotICAgICAgICBRVXJsIHVybCA9IG1fcmVwbHktPnVybCgpOworICAgICAgICBRVXJsIHVy bCA9IChtX3JlcGx5LT51cmwoKS50b1N0cmluZygpLmlzTnVsbCgpKSA/IG1fcmVxdWVzdC51cmwo KTogbV9yZXBseS0+dXJsKCk7CiAgICAgICAgIGludCBodHRwU3RhdHVzQ29kZSA9IG1fcmVwbHkt PmF0dHJpYnV0ZShRTmV0d29ya1JlcXVlc3Q6Okh0dHBTdGF0dXNDb2RlQXR0cmlidXRlKS50b0lu dCgpOwogCiAgICAgICAgIGlmIChodHRwU3RhdHVzQ29kZSkgewotLSAKMS42LjAuNAoK