30207 2009-10-08 05:47:12 -0700 Qt plugins : Don't sync in paint for opaque mode 2009-10-09 06:10:45 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 20081 0 girish webkit-unassigned commit-queue hausmann oldest_to_newest 153343 0 girish 2009-10-08 05:47:12 -0700 Moves XSync to the right place. 153344 1 40866 girish 2009-10-08 05:50:13 -0700 Created attachment 40866 Move XSync after XCreatePixmap 153350 2 40866 hausmann 2009-10-08 06:14:11 -0700 Comment on attachment 40866 Move XSync after XCreatePixmap r=me 153351 3 hausmann 2009-10-08 06:15:16 -0700 One thing that would be good to double-check: We should only re-create the drawable if we are actually changing the _size_ of the plugin/widget. If we only change the position (i.e. we are scrolling) we should not re-create the pixmap and also avoid the expensive syncX() call. 153352 4 40866 commit-queue 2009-10-08 06:26:01 -0700 Comment on attachment 40866 Move XSync after XCreatePixmap Clearing flags on attachment: 40866 Committed r49296: <http://trac.webkit.org/changeset/49296> 153353 5 commit-queue 2009-10-08 06:26:04 -0700 All reviewed patches have been landed. Closing bug. 153356 6 girish 2009-10-08 06:48:10 -0700 Simon, good catch! That check got lost in the QPixmap -> X Pixmap patch. I will create a patch for this one. 40866 2009-10-08 05:50:13 -0700 2009-10-08 06:26:01 -0700 Move XSync after XCreatePixmap patch text/plain 2880 girish Y29tbWl0IDdiM2Y1ODQ1NmE4Y2IyMWE1NzNkZTU2YzYzMTAyMmE5MzM1NWQyMTEKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVGh1IE9j dCA4IDE4OjA5OjI4IDIwMDkgKzA1MzAKCiAgICBbUXRdIFdpbmRvd2xlc3MgcGx1Z2luczogUmVt b3ZlIHVubmVjZXNzYXJ5IFhTeW5jIGZvciBvcGFxdWUgbW9kZS4KICAgIAogICAgVGhlIHJlYXNv biBmb3IgdGhlIFhTeW5jIHdhcyB0aGF0IHRoZSBwbHVnaW4gd291bGQgbm90IGtub3cgYWJvdXQg dGhlCiAgICBEcmF3YWJsZS4gSXQgdHVybnMgb3V0IHRoYXQgdGhlIHJlYWwgcmVhc29uIGJlaGlu ZCB0aGlzIGlzIHRoYXQgZXZlbgogICAgdGhvdWdoIFhDcmVhdGVQaXhtYXAgcmV0dXJucyBhIGhh bmRsZSwgdGhpcyBpZCBpcyB1bmtub3duIHRvIHRoZSBzZXJ2ZXIKICAgIHVudGlsIHdlIGZsdXNo IHRoZSBjb25uZWN0aW9uLgogICAgCiAgICBTbywgbW92ZSB0aGUgWFN5bmMgdG8gcmlnaHQgYWZ0 ZXIgd2UgY3JlYXRlIHRoZSBQaXhtYXAuCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cg Yi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCAxNjIzZTRkLi4wNmQ5OTMzIDEwMDY0NAotLS0gYS9X ZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBA CisyMDA5LTEwLTA4ICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmlu PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g V2luZG93bGVzcyBwbHVnaW5zOiBSZW1vdmUgdW5uZWNlc3NhcnkgWFN5bmMgZm9yIG9wYXF1ZSBt b2RlLgorICAgICAgICAKKyAgICAgICAgVGhlIHJlYXNvbiBmb3IgdGhlIFhTeW5jIHdhcyB0aGF0 IHRoZSBwbHVnaW4gd291bGQgbm90IGtub3cgYWJvdXQgdGhlCisgICAgICAgIERyYXdhYmxlLiBJ dCB0dXJucyBvdXQgdGhhdCB0aGUgcmVhbCByZWFzb24gYmVoaW5kIHRoaXMgaXMgdGhhdCBldmVu CisgICAgICAgIHRob3VnaCBYQ3JlYXRlUGl4bWFwIHJldHVybnMgYSBoYW5kbGUsIHRoaXMgaWQg aXMgdW5rbm93biB0byB0aGUgc2VydmVyCisgICAgICAgIHVudGlsIHdlIGZsdXNoIHRoZSBjb25u ZWN0aW9uLgorICAgICAgICAKKyAgICAgICAgU28sIG1vdmUgdGhlIFhTeW5jIHRvIHJpZ2h0IGFm dGVyIHdlIGNyZWF0ZSB0aGUgUGl4bWFwLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMDIwNworCisgICAgICAgICogcGx1Z2lucy9xdC9QbHVnaW5W aWV3UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlldzo6dXBkYXRlUGx1Z2luV2lk Z2V0KToKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OnBhaW50KToKKwogMjAwOS0xMC0w NyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbHVnaW5zL3F0L1BsdWdpblZpZXdR dC5jcHAgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcAppbmRleCA2YjI2YjQ1 Li40N2M2NDMyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNw cAorKysgYi9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcApAQCAtMTEwLDkgKzEx MCwxMSBAQCB2b2lkIFBsdWdpblZpZXc6OnVwZGF0ZVBsdWdpbldpZGdldCgpCiAgICAgaWYgKG1f ZHJhd2FibGUpCiAgICAgICAgIFhGcmVlUGl4bWFwKFFYMTFJbmZvOjpkaXNwbGF5KCksIG1fZHJh d2FibGUpOwogCi0gICAgaWYgKCFtX2lzV2luZG93ZWQpCisgICAgaWYgKCFtX2lzV2luZG93ZWQp IHsKICAgICAgICAgbV9kcmF3YWJsZSA9IFhDcmVhdGVQaXhtYXAoUVgxMUluZm86OmRpc3BsYXko KSwgUVgxMUluZm86OmFwcFJvb3RXaW5kb3coKSwgbV93aW5kb3dSZWN0LndpZHRoKCksIG1fd2lu ZG93UmVjdC5oZWlnaHQoKSwgCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICgo TlBTZXRXaW5kb3dDYWxsYmFja1N0cnVjdCopbV9ucFdpbmRvdy53c19pbmZvKS0+ZGVwdGgpOwor ICAgICAgICBRQXBwbGljYXRpb246OnN5bmNYKCk7IC8vIG1ha2Ugc3VyZSB0aGF0IHRoZSBzZXJ2 ZXIga25vd3MgYWJvdXQgdGhlIERyYXdhYmxlCisgICAgfQogCiAgICAgLy8gZG8gbm90IGNhbGwg c2V0TlBXaW5kb3dJZk5lZWRlZCBpbW1lZGlhdGVseSwgd2lsbCBiZSBjYWxsZWQgb24gcGFpbnQo KQogICAgIG1faGFzUGVuZGluZ0dlb21ldHJ5Q2hhbmdlID0gdHJ1ZTsKQEAgLTIwNiwxMyArMjA4 LDkgQEAgdm9pZCBQbHVnaW5WaWV3OjpwYWludChHcmFwaGljc0NvbnRleHQqIGNvbnRleHQsIGNv bnN0IEludFJlY3QmIHJlY3QpCiAgICAgICAgICAgICBRUGFpbnRlciBwYWludGVyKCZxdERyYXdh YmxlKTsKICAgICAgICAgICAgIHBhaW50ZXIuZmlsbFJlY3QobV9jbGlwUmVjdCwgUXQ6OndoaXRl KTsKICAgICAgICAgfQotICAgIH0KIAotICAgIGlmIChzeW5jWCkgewotICAgICAgICAvLyBXZSBh bHNvIHN5bmMgZm9yIG9wYXF1ZSBtb2RlIHRob3VnaCB3ZSBtYWRlIG5vIGNoYW5nZXMgdG8gdGhl IGRyYXdhYmxlLgotICAgICAgICAvLyBOb3Qgc3VyZSB3aHkgdGhpcyBpcyBuZWVkZWQgYnV0IGdk ayBmYWlscyB0byByZWNvZ25pemUgdGhlIFBpeG1hcCBoYW5kbGUKLSAgICAgICAgLy8gdGhhdCB3 ZSBzZW5kIGJlbG93IHdpdGhvdXQgdGhpcy4KLSAgICAgICAgUUFwcGxpY2F0aW9uOjpzeW5jWCgp OworICAgICAgICBpZiAoc3luY1gpCisgICAgICAgICAgICBRQXBwbGljYXRpb246OnN5bmNYKCk7 CiAgICAgfQogCiAgICAgWEV2ZW50IHhldmVudDsK