30189 2009-10-07 17:11:44 -0700 Back out StringImpl::m_buffer to make MSVC happy 2009-10-07 21:49:47 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows Vista RESOLVED FIXED P2 Major --- 1 jens jens jorlow oldest_to_newest 153222 0 40830 jens 2009-10-07 17:11:44 -0700 Created attachment 40830 patch It's not worth having the variable-length-array m_buffer in StringImpl if MSVC doesn't handle it well. So this patch removes it and goes back to the hack of offsetting the base pointer by sizeof(StringImpl). 153223 1 40831 jens 2009-10-07 17:16:46 -0700 Created attachment 40831 removed unwanted space char 153226 2 40832 jens 2009-10-07 17:20:12 -0700 Created attachment 40832 now with changelog entry, duh 153227 3 40832 levin 2009-10-07 17:21:03 -0700 Comment on attachment 40832 now with changelog entry, duh > + // const UChar m_fictitious_buffer[]; Whoever lands this, please delete this line. 153228 4 40833 jens 2009-10-07 17:21:22 -0700 Created attachment 40833 remove commented declaration 153230 5 jorlow 2009-10-07 17:41:38 -0700 Committed r49279: <http://trac.webkit.org/changeset/49279> 153264 6 40833 eric 2009-10-07 21:49:47 -0700 Comment on attachment 40833 remove commented declaration This was landed. Thank you Jens for the quick fix, and thank you Jeremy for the commit. 40830 2009-10-07 17:11:44 -0700 2009-10-07 17:16:46 -0700 patch fixstringimpl.patch text/plain 3370 jens SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nSW1wbC5jcHAJKHJldmlzaW9uIDQ5MjcyKQor KysgV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNiw3ICszNiw2IEBACiAjaW5jbHVkZSAiVGhyZWFkR2xvYmFsRGF0YS5oIgogI2luY2x1ZGUg PHd0Zi9kdG9hLmg+CiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KLSNpbmNsdWRlIDx3dGYv U3RkTGliRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgogI2luY2x1ZGUgPHd0 Zi91bmljb2RlL1VuaWNvZGUuaD4KIApAQCAtODMsNyArODIsNiBAQCBTdHJpbmdJbXBsOjpTdHJp bmdJbXBsKCkKICAgICA6IG1fZGF0YSgwKQogICAgICwgbV9sZW5ndGgoMCkKICAgICAsIG1faGFz aCgwKQotICAgICwgbV9idWZmZXIoKQogewogICAgIC8vIEVuc3VyZSB0aGF0IHRoZSBoYXNoIGlz IGNvbXB1dGVkIHNvIHRoYXQgQXRvbWljU3RyaW5nSGFzaCBjYW4gY2FsbCBleGlzdGluZ0hhc2go KQogICAgIC8vIHdpdGggaW1wdW5pdHkuIFRoZSBlbXB0eSBzdHJpbmcgaXMgc3BlY2lhbCBiZWNh dXNlIGl0IGlzIG5ldmVyIGVudGVyZWQgaW50bwpAQCAtOTUsNyArOTMsNiBAQCBpbmxpbmUgU3Ry aW5nSW1wbDo6U3RyaW5nSW1wbChVQ2hhciogY2hhCiAgICAgOiBtX2RhdGEoY2hhcmFjdGVycykK ICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1faGFzaCgwKQotICAgICwgbV9idWZmZXIo KQogewogICAgIEFTU0VSVChjaGFyYWN0ZXJzKTsKICAgICBBU1NFUlQobGVuZ3RoKTsKQEAgLTEw Niw3ICsxMDMsNiBAQCBTdHJpbmdJbXBsOjpTdHJpbmdJbXBsKGNvbnN0IFVDaGFyKiBjaGFyCiAg ICAgOiBtX2RhdGEoMCkKICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1faGFzaChoYXNo KQotICAgICwgbV9idWZmZXIoKQogewogICAgIEFTU0VSVChoYXNoKTsKICAgICBBU1NFUlQoY2hh cmFjdGVycyk7CkBAIC0xMjMsNyArMTE5LDYgQEAgU3RyaW5nSW1wbDo6U3RyaW5nSW1wbChjb25z dCBjaGFyKiBjaGFyYQogICAgIDogbV9kYXRhKDApCiAgICAgLCBtX2xlbmd0aChsZW5ndGgpCiAg ICAgLCBtX2hhc2goaGFzaCkKLSAgICAsIG1fYnVmZmVyKCkKIHsKICAgICBBU1NFUlQoaGFzaCk7 CiAgICAgQVNTRVJUKGNoYXJhY3RlcnMpOwpAQCAtOTU5LDkgKzk1NCw5IEBAIFBhc3NSZWZQdHI8 U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Y3JlYXQKICAgICAvLyBBbGxvY2F0ZSBhIHNpbmdsZSBi dWZmZXIgbGFyZ2UgZW5vdWdoIHRvIGNvbnRhaW4gdGhlIFN0cmluZ0ltcGwKICAgICAvLyBzdHJ1 Y3QgYXMgd2VsbCBhcyB0aGUgZGF0YSB3aGljaCBpdCBjb250YWlucy4gVGhpcyByZW1vdmVzIG9u ZSAKICAgICAvLyBoZWFwIGFsbG9jYXRpb24gZnJvbSB0aGlzIGNhbGwuCi0gICAgc2l6ZV90IHNp emUgPSBPQkpFQ1RfT0ZGU0VUT0YoU3RyaW5nSW1wbCwgbV9idWZmZXIpICsgbGVuZ3RoICogc2l6 ZW9mKFVDaGFyKTsKKyAgICBzaXplX3Qgc2l6ZSA9IHNpemVvZihTdHJpbmdJbXBsKSArIGxlbmd0 aCAqIHNpemVvZihVQ2hhcik7CiAgICAgU3RyaW5nSW1wbCogc3RyaW5nID0gc3RhdGljX2Nhc3Q8 U3RyaW5nSW1wbCo+KGZhc3RNYWxsb2Moc2l6ZSkpOwotICAgIGRhdGEgPSBjb25zdF9jYXN0PFVD aGFyKj4oJnN0cmluZy0+bV9idWZmZXJbMF0pOworICAgIGRhdGEgPSByZWludGVycHJldF9jYXN0 PFVDaGFyKj4oc3RyaW5nICsgMSk7CiAgICAgc3RyaW5nID0gbmV3IChzdHJpbmcpIFN0cmluZ0lt cGwoZGF0YSwgbGVuZ3RoLCBBZG9wdEJ1ZmZlcigpKTsKICAgICByZXR1cm4gYWRvcHRSZWYoc3Ry aW5nKTsKIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gNDky NzIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nSW1wbC5oCSh3b3JraW5nIGNvcHkp CkBAIC0xOTEsNyArMTkxLDcgQEAgcHJpdmF0ZToKICAgICAKICAgICAvLyBUaGUgU3RyaW5nSW1w bCBzdHJ1Y3QgYW5kIGl0cyBkYXRhIG1heSBiZSBhbGxvY2F0ZWQgd2l0aGluIGEgc2luZ2xlIGhl YXAgYmxvY2suCiAgICAgLy8gSW4gdGhpcyBjYXNlLCB0aGUgbV9kYXRhIHBvaW50ZXIgaXMgYW4g ImludGVybmFsIGJ1ZmZlciIsIGFuZCBkb2VzIG5vdCBuZWVkIHRvIGJlIGRlYWxsb2NhdGVkLgot ICAgIGJvb2wgYnVmZmVySXNJbnRlcm5hbCgpIHsgcmV0dXJuIG1fZGF0YSA9PSAmbV9idWZmZXJb MF07IH0KKyAgICBib29sIGJ1ZmZlcklzSW50ZXJuYWwoKSB7IHJldHVybiBtX2RhdGEgPT0gcmVp bnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+ICh0aGlzICsgMSk7IH0KIAogICAgIGVudW0gU3Ry aW5nSW1wbEZsYWdzIHsKICAgICAgICAgSGFzVGVybWluYXRpbmdOdWxsQ2hhcmFjdGVyLApAQCAt MjAyLDExICsyMDIsOSBAQCBwcml2YXRlOgogICAgIHVuc2lnbmVkIG1fbGVuZ3RoOwogICAgIG11 dGFibGUgdW5zaWduZWQgbV9oYXNoOwogICAgIFB0ckFuZEZsYWdzPFNoYXJlZFVDaGFyLCBTdHJp bmdJbXBsRmxhZ3M+IG1fc2hhcmVkQnVmZmVyQW5kRmxhZ3M7Ci0gICAgLy8gbV9idWZmZXIgaXMg ZGVjbGFyZWQgd2l0aCBubyBzaXplOyB0aGUgY29tcGlsZXIgdHJlYXRzIGl0IGFzIHplcm8gc2l6 ZSwKLSAgICAvLyBhbmQgdGhlIGFjdHVhbCBzaXplIGlzIGRldGVybWluZWQgd2hlbiB0aGUgaW5z dGFuY2UgaXMgY3JlYXRlZC4gCi0gICAgLy8gSXQgd2lsbCBiZSB6ZXJvIHVubGVzcyB1c2luZyBh biAiaW50ZXJuYWwgYnVmZmVyIiwgaW4gd2hpY2ggY2FzZSBtX2RhdGEKLSAgICAvLyB3aWxsIHBv aW50IHRvIG1fYnVmZmVyIGFuZCB0aGUgbGVuZ3RoIG9mIG1fYnVmZmVyIHdpbGwgYmUgZXF1YWwg dG8gbV9sZW5ndGguCi0gICAgY29uc3QgVUNoYXIgbV9idWZmZXJbXTsKKyAgICAvLyBUaGVyZSBp cyBhIGZpY3RpdGlvdXMgdmFyaWFibGUtbGVuZ3RoIFVDaGFyIGFycmF5IGF0IHRoZSBlbmQsIHdo aWNoIGlzIHVzZWQKKyAgICAvLyBhcyB0aGUgaW50ZXJuYWwgYnVmZmVyIGJ5IHRoZSBjcmVhdGVV bmluaXRpYWxpemVkIGFuZCBjcmVhdGUgbWV0aG9kczoKKyAgICAvLyBjb25zdCBVQ2hhciBtX2Zp Y3RpdGlvdXNfYnVmZmVyW107CiB9OwogCiBib29sIGVxdWFsKFN0cmluZ0ltcGwqLCBTdHJpbmdJ bXBsKik7Cg== 40831 2009-10-07 17:16:46 -0700 2009-10-07 17:20:12 -0700 removed unwanted space char fixstringimpl.patch text/plain 3369 jens SW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nSW1wbC5jcHAJKHJldmlzaW9uIDQ5MjcyKQor KysgV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0zNiw3ICszNiw2IEBACiAjaW5jbHVkZSAiVGhyZWFkR2xvYmFsRGF0YS5oIgogI2luY2x1ZGUg PHd0Zi9kdG9hLmg+CiAjaW5jbHVkZSA8d3RmL0Fzc2VydGlvbnMuaD4KLSNpbmNsdWRlIDx3dGYv U3RkTGliRXh0cmFzLmg+CiAjaW5jbHVkZSA8d3RmL1RocmVhZGluZy5oPgogI2luY2x1ZGUgPHd0 Zi91bmljb2RlL1VuaWNvZGUuaD4KIApAQCAtODMsNyArODIsNiBAQCBTdHJpbmdJbXBsOjpTdHJp bmdJbXBsKCkKICAgICA6IG1fZGF0YSgwKQogICAgICwgbV9sZW5ndGgoMCkKICAgICAsIG1faGFz aCgwKQotICAgICwgbV9idWZmZXIoKQogewogICAgIC8vIEVuc3VyZSB0aGF0IHRoZSBoYXNoIGlz IGNvbXB1dGVkIHNvIHRoYXQgQXRvbWljU3RyaW5nSGFzaCBjYW4gY2FsbCBleGlzdGluZ0hhc2go KQogICAgIC8vIHdpdGggaW1wdW5pdHkuIFRoZSBlbXB0eSBzdHJpbmcgaXMgc3BlY2lhbCBiZWNh dXNlIGl0IGlzIG5ldmVyIGVudGVyZWQgaW50bwpAQCAtOTUsNyArOTMsNiBAQCBpbmxpbmUgU3Ry aW5nSW1wbDo6U3RyaW5nSW1wbChVQ2hhciogY2hhCiAgICAgOiBtX2RhdGEoY2hhcmFjdGVycykK ICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1faGFzaCgwKQotICAgICwgbV9idWZmZXIo KQogewogICAgIEFTU0VSVChjaGFyYWN0ZXJzKTsKICAgICBBU1NFUlQobGVuZ3RoKTsKQEAgLTEw Niw3ICsxMDMsNiBAQCBTdHJpbmdJbXBsOjpTdHJpbmdJbXBsKGNvbnN0IFVDaGFyKiBjaGFyCiAg ICAgOiBtX2RhdGEoMCkKICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1faGFzaChoYXNo KQotICAgICwgbV9idWZmZXIoKQogewogICAgIEFTU0VSVChoYXNoKTsKICAgICBBU1NFUlQoY2hh cmFjdGVycyk7CkBAIC0xMjMsNyArMTE5LDYgQEAgU3RyaW5nSW1wbDo6U3RyaW5nSW1wbChjb25z dCBjaGFyKiBjaGFyYQogICAgIDogbV9kYXRhKDApCiAgICAgLCBtX2xlbmd0aChsZW5ndGgpCiAg ICAgLCBtX2hhc2goaGFzaCkKLSAgICAsIG1fYnVmZmVyKCkKIHsKICAgICBBU1NFUlQoaGFzaCk7 CiAgICAgQVNTRVJUKGNoYXJhY3RlcnMpOwpAQCAtOTU5LDkgKzk1NCw5IEBAIFBhc3NSZWZQdHI8 U3RyaW5nSW1wbD4gU3RyaW5nSW1wbDo6Y3JlYXQKICAgICAvLyBBbGxvY2F0ZSBhIHNpbmdsZSBi dWZmZXIgbGFyZ2UgZW5vdWdoIHRvIGNvbnRhaW4gdGhlIFN0cmluZ0ltcGwKICAgICAvLyBzdHJ1 Y3QgYXMgd2VsbCBhcyB0aGUgZGF0YSB3aGljaCBpdCBjb250YWlucy4gVGhpcyByZW1vdmVzIG9u ZSAKICAgICAvLyBoZWFwIGFsbG9jYXRpb24gZnJvbSB0aGlzIGNhbGwuCi0gICAgc2l6ZV90IHNp emUgPSBPQkpFQ1RfT0ZGU0VUT0YoU3RyaW5nSW1wbCwgbV9idWZmZXIpICsgbGVuZ3RoICogc2l6 ZW9mKFVDaGFyKTsKKyAgICBzaXplX3Qgc2l6ZSA9IHNpemVvZihTdHJpbmdJbXBsKSArIGxlbmd0 aCAqIHNpemVvZihVQ2hhcik7CiAgICAgU3RyaW5nSW1wbCogc3RyaW5nID0gc3RhdGljX2Nhc3Q8 U3RyaW5nSW1wbCo+KGZhc3RNYWxsb2Moc2l6ZSkpOwotICAgIGRhdGEgPSBjb25zdF9jYXN0PFVD aGFyKj4oJnN0cmluZy0+bV9idWZmZXJbMF0pOworICAgIGRhdGEgPSByZWludGVycHJldF9jYXN0 PFVDaGFyKj4oc3RyaW5nICsgMSk7CiAgICAgc3RyaW5nID0gbmV3IChzdHJpbmcpIFN0cmluZ0lt cGwoZGF0YSwgbGVuZ3RoLCBBZG9wdEJ1ZmZlcigpKTsKICAgICByZXR1cm4gYWRvcHRSZWYoc3Ry aW5nKTsKIH0KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmgKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0cmluZ0ltcGwuaAkocmV2aXNpb24gNDky NzIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5nSW1wbC5oCSh3b3JraW5nIGNvcHkp CkBAIC0xOTEsNyArMTkxLDcgQEAgcHJpdmF0ZToKICAgICAKICAgICAvLyBUaGUgU3RyaW5nSW1w bCBzdHJ1Y3QgYW5kIGl0cyBkYXRhIG1heSBiZSBhbGxvY2F0ZWQgd2l0aGluIGEgc2luZ2xlIGhl YXAgYmxvY2suCiAgICAgLy8gSW4gdGhpcyBjYXNlLCB0aGUgbV9kYXRhIHBvaW50ZXIgaXMgYW4g ImludGVybmFsIGJ1ZmZlciIsIGFuZCBkb2VzIG5vdCBuZWVkIHRvIGJlIGRlYWxsb2NhdGVkLgot ICAgIGJvb2wgYnVmZmVySXNJbnRlcm5hbCgpIHsgcmV0dXJuIG1fZGF0YSA9PSAmbV9idWZmZXJb MF07IH0KKyAgICBib29sIGJ1ZmZlcklzSW50ZXJuYWwoKSB7IHJldHVybiBtX2RhdGEgPT0gcmVp bnRlcnByZXRfY2FzdDxjb25zdCBVQ2hhcio+KHRoaXMgKyAxKTsgfQogCiAgICAgZW51bSBTdHJp bmdJbXBsRmxhZ3MgewogICAgICAgICBIYXNUZXJtaW5hdGluZ051bGxDaGFyYWN0ZXIsCkBAIC0y MDIsMTEgKzIwMiw5IEBAIHByaXZhdGU6CiAgICAgdW5zaWduZWQgbV9sZW5ndGg7CiAgICAgbXV0 YWJsZSB1bnNpZ25lZCBtX2hhc2g7CiAgICAgUHRyQW5kRmxhZ3M8U2hhcmVkVUNoYXIsIFN0cmlu Z0ltcGxGbGFncz4gbV9zaGFyZWRCdWZmZXJBbmRGbGFnczsKLSAgICAvLyBtX2J1ZmZlciBpcyBk ZWNsYXJlZCB3aXRoIG5vIHNpemU7IHRoZSBjb21waWxlciB0cmVhdHMgaXQgYXMgemVybyBzaXpl LAotICAgIC8vIGFuZCB0aGUgYWN0dWFsIHNpemUgaXMgZGV0ZXJtaW5lZCB3aGVuIHRoZSBpbnN0 YW5jZSBpcyBjcmVhdGVkLiAKLSAgICAvLyBJdCB3aWxsIGJlIHplcm8gdW5sZXNzIHVzaW5nIGFu ICJpbnRlcm5hbCBidWZmZXIiLCBpbiB3aGljaCBjYXNlIG1fZGF0YQotICAgIC8vIHdpbGwgcG9p bnQgdG8gbV9idWZmZXIgYW5kIHRoZSBsZW5ndGggb2YgbV9idWZmZXIgd2lsbCBiZSBlcXVhbCB0 byBtX2xlbmd0aC4KLSAgICBjb25zdCBVQ2hhciBtX2J1ZmZlcltdOworICAgIC8vIFRoZXJlIGlz IGEgZmljdGl0aW91cyB2YXJpYWJsZS1sZW5ndGggVUNoYXIgYXJyYXkgYXQgdGhlIGVuZCwgd2hp Y2ggaXMgdXNlZAorICAgIC8vIGFzIHRoZSBpbnRlcm5hbCBidWZmZXIgYnkgdGhlIGNyZWF0ZVVu aW5pdGlhbGl6ZWQgYW5kIGNyZWF0ZSBtZXRob2RzOgorICAgIC8vIGNvbnN0IFVDaGFyIG1fZmlj dGl0aW91c19idWZmZXJbXTsKIH07CiAKIGJvb2wgZXF1YWwoU3RyaW5nSW1wbCosIFN0cmluZ0lt cGwqKTsK 40832 2009-10-07 17:20:12 -0700 2009-10-07 17:21:22 -0700 now with changelog entry, duh fixstringimpl.patch text/plain 4136 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTI3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMDcgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg bXkgcHJldmlvdXMgU3RyaW5nSW1wbCBwYXRjaCB0byBhdm9pZCB1c2luZyBhbiBpbmRlZmluaXRl LWxlbmd0aCBhcnJheSBtZW1iZXIsCisgICAgICAgIHNpbmNlIE1TVkMgZG9lc24ndCBsaWtlIGl0 LiBJbnN0ZWFkLCBnbyBiYWNrIHRvIG9mZnNldHRpbmcgYnkgc2l6ZW9mKFN0cmluZ0ltcGwpLgor CisgICAgICAgICogcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlN0cmluZ0ltcGw6OlN0cmluZ0ltcGwpOgorICAgICAgICAoV2ViQ29yZTo6U3RyaW5nSW1w bDo6Y3JlYXRlVW5pbml0aWFsaXplZCk6CisgICAgICAgICogcGxhdGZvcm0vdGV4dC9TdHJpbmdJ bXBsLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdJbXBsOjpidWZmZXJJc0ludGVybmFsKToK KwogMjAwOS0xMC0wNyAgQWFyb24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0 cmluZ0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJ bXBsLmNwcAkocmV2aXNpb24gNDkyNzIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5n SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDYgQEAKICNpbmNsdWRlICJUaHJl YWRHbG9iYWxEYXRhLmgiCiAjaW5jbHVkZSA8d3RmL2R0b2EuaD4KICNpbmNsdWRlIDx3dGYvQXNz ZXJ0aW9ucy5oPgotI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KICNpbmNsdWRlIDx3dGYv VGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3VuaWNvZGUvVW5pY29kZS5oPgogCkBAIC04Myw3 ICs4Miw2IEBAIFN0cmluZ0ltcGw6OlN0cmluZ0ltcGwoKQogICAgIDogbV9kYXRhKDApCiAgICAg LCBtX2xlbmd0aCgwKQogICAgICwgbV9oYXNoKDApCi0gICAgLCBtX2J1ZmZlcigpCiB7CiAgICAg Ly8gRW5zdXJlIHRoYXQgdGhlIGhhc2ggaXMgY29tcHV0ZWQgc28gdGhhdCBBdG9taWNTdHJpbmdI YXNoIGNhbiBjYWxsIGV4aXN0aW5nSGFzaCgpCiAgICAgLy8gd2l0aCBpbXB1bml0eS4gVGhlIGVt cHR5IHN0cmluZyBpcyBzcGVjaWFsIGJlY2F1c2UgaXQgaXMgbmV2ZXIgZW50ZXJlZCBpbnRvCkBA IC05NSw3ICs5Myw2IEBAIGlubGluZSBTdHJpbmdJbXBsOjpTdHJpbmdJbXBsKFVDaGFyKiBjaGEK ICAgICA6IG1fZGF0YShjaGFyYWN0ZXJzKQogICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAgICwg bV9oYXNoKDApCi0gICAgLCBtX2J1ZmZlcigpCiB7CiAgICAgQVNTRVJUKGNoYXJhY3RlcnMpOwog ICAgIEFTU0VSVChsZW5ndGgpOwpAQCAtMTA2LDcgKzEwMyw2IEBAIFN0cmluZ0ltcGw6OlN0cmlu Z0ltcGwoY29uc3QgVUNoYXIqIGNoYXIKICAgICA6IG1fZGF0YSgwKQogICAgICwgbV9sZW5ndGgo bGVuZ3RoKQogICAgICwgbV9oYXNoKGhhc2gpCi0gICAgLCBtX2J1ZmZlcigpCiB7CiAgICAgQVNT RVJUKGhhc2gpOwogICAgIEFTU0VSVChjaGFyYWN0ZXJzKTsKQEAgLTEyMyw3ICsxMTksNiBAQCBT dHJpbmdJbXBsOjpTdHJpbmdJbXBsKGNvbnN0IGNoYXIqIGNoYXJhCiAgICAgOiBtX2RhdGEoMCkK ICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1faGFzaChoYXNoKQotICAgICwgbV9idWZm ZXIoKQogewogICAgIEFTU0VSVChoYXNoKTsKICAgICBBU1NFUlQoY2hhcmFjdGVycyk7CkBAIC05 NTksOSArOTU0LDkgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpjcmVhdAog ICAgIC8vIEFsbG9jYXRlIGEgc2luZ2xlIGJ1ZmZlciBsYXJnZSBlbm91Z2ggdG8gY29udGFpbiB0 aGUgU3RyaW5nSW1wbAogICAgIC8vIHN0cnVjdCBhcyB3ZWxsIGFzIHRoZSBkYXRhIHdoaWNoIGl0 IGNvbnRhaW5zLiBUaGlzIHJlbW92ZXMgb25lIAogICAgIC8vIGhlYXAgYWxsb2NhdGlvbiBmcm9t IHRoaXMgY2FsbC4KLSAgICBzaXplX3Qgc2l6ZSA9IE9CSkVDVF9PRkZTRVRPRihTdHJpbmdJbXBs LCBtX2J1ZmZlcikgKyBsZW5ndGggKiBzaXplb2YoVUNoYXIpOworICAgIHNpemVfdCBzaXplID0g c2l6ZW9mKFN0cmluZ0ltcGwpICsgbGVuZ3RoICogc2l6ZW9mKFVDaGFyKTsKICAgICBTdHJpbmdJ bXBsKiBzdHJpbmcgPSBzdGF0aWNfY2FzdDxTdHJpbmdJbXBsKj4oZmFzdE1hbGxvYyhzaXplKSk7 Ci0gICAgZGF0YSA9IGNvbnN0X2Nhc3Q8VUNoYXIqPigmc3RyaW5nLT5tX2J1ZmZlclswXSk7Cisg ICAgZGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8VUNoYXIqPihzdHJpbmcgKyAxKTsKICAgICBzdHJp bmcgPSBuZXcgKHN0cmluZykgU3RyaW5nSW1wbChkYXRhLCBsZW5ndGgsIEFkb3B0QnVmZmVyKCkp OwogICAgIHJldHVybiBhZG9wdFJlZihzdHJpbmcpOwogfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L1N0cmluZ0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3RleHQv U3RyaW5nSW1wbC5oCShyZXZpc2lvbiA0OTI3MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9T dHJpbmdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTE5MSw3ICsxOTEsNyBAQCBwcml2YXRlOgog ICAgIAogICAgIC8vIFRoZSBTdHJpbmdJbXBsIHN0cnVjdCBhbmQgaXRzIGRhdGEgbWF5IGJlIGFs bG9jYXRlZCB3aXRoaW4gYSBzaW5nbGUgaGVhcCBibG9jay4KICAgICAvLyBJbiB0aGlzIGNhc2Us IHRoZSBtX2RhdGEgcG9pbnRlciBpcyBhbiAiaW50ZXJuYWwgYnVmZmVyIiwgYW5kIGRvZXMgbm90 IG5lZWQgdG8gYmUgZGVhbGxvY2F0ZWQuCi0gICAgYm9vbCBidWZmZXJJc0ludGVybmFsKCkgeyBy ZXR1cm4gbV9kYXRhID09ICZtX2J1ZmZlclswXTsgfQorICAgIGJvb2wgYnVmZmVySXNJbnRlcm5h bCgpIHsgcmV0dXJuIG1fZGF0YSA9PSByZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4odGhp cyArIDEpOyB9CiAKICAgICBlbnVtIFN0cmluZ0ltcGxGbGFncyB7CiAgICAgICAgIEhhc1Rlcm1p bmF0aW5nTnVsbENoYXJhY3RlciwKQEAgLTIwMiwxMSArMjAyLDkgQEAgcHJpdmF0ZToKICAgICB1 bnNpZ25lZCBtX2xlbmd0aDsKICAgICBtdXRhYmxlIHVuc2lnbmVkIG1faGFzaDsKICAgICBQdHJB bmRGbGFnczxTaGFyZWRVQ2hhciwgU3RyaW5nSW1wbEZsYWdzPiBtX3NoYXJlZEJ1ZmZlckFuZEZs YWdzOwotICAgIC8vIG1fYnVmZmVyIGlzIGRlY2xhcmVkIHdpdGggbm8gc2l6ZTsgdGhlIGNvbXBp bGVyIHRyZWF0cyBpdCBhcyB6ZXJvIHNpemUsCi0gICAgLy8gYW5kIHRoZSBhY3R1YWwgc2l6ZSBp cyBkZXRlcm1pbmVkIHdoZW4gdGhlIGluc3RhbmNlIGlzIGNyZWF0ZWQuIAotICAgIC8vIEl0IHdp bGwgYmUgemVybyB1bmxlc3MgdXNpbmcgYW4gImludGVybmFsIGJ1ZmZlciIsIGluIHdoaWNoIGNh c2UgbV9kYXRhCi0gICAgLy8gd2lsbCBwb2ludCB0byBtX2J1ZmZlciBhbmQgdGhlIGxlbmd0aCBv ZiBtX2J1ZmZlciB3aWxsIGJlIGVxdWFsIHRvIG1fbGVuZ3RoLgotICAgIGNvbnN0IFVDaGFyIG1f YnVmZmVyW107CisgICAgLy8gVGhlcmUgaXMgYSBmaWN0aXRpb3VzIHZhcmlhYmxlLWxlbmd0aCBV Q2hhciBhcnJheSBhdCB0aGUgZW5kLCB3aGljaCBpcyB1c2VkCisgICAgLy8gYXMgdGhlIGludGVy bmFsIGJ1ZmZlciBieSB0aGUgY3JlYXRlVW5pbml0aWFsaXplZCBhbmQgY3JlYXRlIG1ldGhvZHM6 CisgICAgLy8gY29uc3QgVUNoYXIgbV9maWN0aXRpb3VzX2J1ZmZlcltdOwogfTsKIAogYm9vbCBl cXVhbChTdHJpbmdJbXBsKiwgU3RyaW5nSW1wbCopOwo= 40833 2009-10-07 17:21:22 -0700 2009-10-07 21:49:47 -0700 remove commented declaration fixstringimpl.patch text/plain 4093 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTI3OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTAtMDcgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXgg bXkgcHJldmlvdXMgU3RyaW5nSW1wbCBwYXRjaCB0byBhdm9pZCB1c2luZyBhbiBpbmRlZmluaXRl LWxlbmd0aCBhcnJheSBtZW1iZXIsCisgICAgICAgIHNpbmNlIE1TVkMgZG9lc24ndCBsaWtlIGl0 LiBJbnN0ZWFkLCBnbyBiYWNrIHRvIG9mZnNldHRpbmcgYnkgc2l6ZW9mKFN0cmluZ0ltcGwpLgor CisgICAgICAgICogcGxhdGZvcm0vdGV4dC9TdHJpbmdJbXBsLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlN0cmluZ0ltcGw6OlN0cmluZ0ltcGwpOgorICAgICAgICAoV2ViQ29yZTo6U3RyaW5nSW1w bDo6Y3JlYXRlVW5pbml0aWFsaXplZCk6CisgICAgICAgICogcGxhdGZvcm0vdGV4dC9TdHJpbmdJ bXBsLmg6CisgICAgICAgIChXZWJDb3JlOjpTdHJpbmdJbXBsOjpidWZmZXJJc0ludGVybmFsKToK KwogMjAwOS0xMC0wNyAgQWFyb24gQm9vZG1hbiAgPGFhQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1N0 cmluZ0ltcGwuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9TdHJpbmdJ bXBsLmNwcAkocmV2aXNpb24gNDkyNzIpCisrKyBXZWJDb3JlL3BsYXRmb3JtL3RleHQvU3RyaW5n SW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDYgQEAKICNpbmNsdWRlICJUaHJl YWRHbG9iYWxEYXRhLmgiCiAjaW5jbHVkZSA8d3RmL2R0b2EuaD4KICNpbmNsdWRlIDx3dGYvQXNz ZXJ0aW9ucy5oPgotI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KICNpbmNsdWRlIDx3dGYv VGhyZWFkaW5nLmg+CiAjaW5jbHVkZSA8d3RmL3VuaWNvZGUvVW5pY29kZS5oPgogCkBAIC04Myw3 ICs4Miw2IEBAIFN0cmluZ0ltcGw6OlN0cmluZ0ltcGwoKQogICAgIDogbV9kYXRhKDApCiAgICAg LCBtX2xlbmd0aCgwKQogICAgICwgbV9oYXNoKDApCi0gICAgLCBtX2J1ZmZlcigpCiB7CiAgICAg Ly8gRW5zdXJlIHRoYXQgdGhlIGhhc2ggaXMgY29tcHV0ZWQgc28gdGhhdCBBdG9taWNTdHJpbmdI YXNoIGNhbiBjYWxsIGV4aXN0aW5nSGFzaCgpCiAgICAgLy8gd2l0aCBpbXB1bml0eS4gVGhlIGVt cHR5IHN0cmluZyBpcyBzcGVjaWFsIGJlY2F1c2UgaXQgaXMgbmV2ZXIgZW50ZXJlZCBpbnRvCkBA IC05NSw3ICs5Myw2IEBAIGlubGluZSBTdHJpbmdJbXBsOjpTdHJpbmdJbXBsKFVDaGFyKiBjaGEK ICAgICA6IG1fZGF0YShjaGFyYWN0ZXJzKQogICAgICwgbV9sZW5ndGgobGVuZ3RoKQogICAgICwg bV9oYXNoKDApCi0gICAgLCBtX2J1ZmZlcigpCiB7CiAgICAgQVNTRVJUKGNoYXJhY3RlcnMpOwog ICAgIEFTU0VSVChsZW5ndGgpOwpAQCAtMTA2LDcgKzEwMyw2IEBAIFN0cmluZ0ltcGw6OlN0cmlu Z0ltcGwoY29uc3QgVUNoYXIqIGNoYXIKICAgICA6IG1fZGF0YSgwKQogICAgICwgbV9sZW5ndGgo bGVuZ3RoKQogICAgICwgbV9oYXNoKGhhc2gpCi0gICAgLCBtX2J1ZmZlcigpCiB7CiAgICAgQVNT RVJUKGhhc2gpOwogICAgIEFTU0VSVChjaGFyYWN0ZXJzKTsKQEAgLTEyMyw3ICsxMTksNiBAQCBT dHJpbmdJbXBsOjpTdHJpbmdJbXBsKGNvbnN0IGNoYXIqIGNoYXJhCiAgICAgOiBtX2RhdGEoMCkK ICAgICAsIG1fbGVuZ3RoKGxlbmd0aCkKICAgICAsIG1faGFzaChoYXNoKQotICAgICwgbV9idWZm ZXIoKQogewogICAgIEFTU0VSVChoYXNoKTsKICAgICBBU1NFUlQoY2hhcmFjdGVycyk7CkBAIC05 NTksOSArOTU0LDkgQEAgUGFzc1JlZlB0cjxTdHJpbmdJbXBsPiBTdHJpbmdJbXBsOjpjcmVhdAog ICAgIC8vIEFsbG9jYXRlIGEgc2luZ2xlIGJ1ZmZlciBsYXJnZSBlbm91Z2ggdG8gY29udGFpbiB0 aGUgU3RyaW5nSW1wbAogICAgIC8vIHN0cnVjdCBhcyB3ZWxsIGFzIHRoZSBkYXRhIHdoaWNoIGl0 IGNvbnRhaW5zLiBUaGlzIHJlbW92ZXMgb25lIAogICAgIC8vIGhlYXAgYWxsb2NhdGlvbiBmcm9t IHRoaXMgY2FsbC4KLSAgICBzaXplX3Qgc2l6ZSA9IE9CSkVDVF9PRkZTRVRPRihTdHJpbmdJbXBs LCBtX2J1ZmZlcikgKyBsZW5ndGggKiBzaXplb2YoVUNoYXIpOworICAgIHNpemVfdCBzaXplID0g c2l6ZW9mKFN0cmluZ0ltcGwpICsgbGVuZ3RoICogc2l6ZW9mKFVDaGFyKTsKICAgICBTdHJpbmdJ bXBsKiBzdHJpbmcgPSBzdGF0aWNfY2FzdDxTdHJpbmdJbXBsKj4oZmFzdE1hbGxvYyhzaXplKSk7 Ci0gICAgZGF0YSA9IGNvbnN0X2Nhc3Q8VUNoYXIqPigmc3RyaW5nLT5tX2J1ZmZlclswXSk7Cisg ICAgZGF0YSA9IHJlaW50ZXJwcmV0X2Nhc3Q8VUNoYXIqPihzdHJpbmcgKyAxKTsKICAgICBzdHJp bmcgPSBuZXcgKHN0cmluZykgU3RyaW5nSW1wbChkYXRhLCBsZW5ndGgsIEFkb3B0QnVmZmVyKCkp OwogICAgIHJldHVybiBhZG9wdFJlZihzdHJpbmcpOwogfQpJbmRleDogV2ViQ29yZS9wbGF0Zm9y bS90ZXh0L1N0cmluZ0ltcGwuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3RleHQv U3RyaW5nSW1wbC5oCShyZXZpc2lvbiA0OTI3MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vdGV4dC9T dHJpbmdJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTE5MSw3ICsxOTEsNyBAQCBwcml2YXRlOgog ICAgIAogICAgIC8vIFRoZSBTdHJpbmdJbXBsIHN0cnVjdCBhbmQgaXRzIGRhdGEgbWF5IGJlIGFs bG9jYXRlZCB3aXRoaW4gYSBzaW5nbGUgaGVhcCBibG9jay4KICAgICAvLyBJbiB0aGlzIGNhc2Us IHRoZSBtX2RhdGEgcG9pbnRlciBpcyBhbiAiaW50ZXJuYWwgYnVmZmVyIiwgYW5kIGRvZXMgbm90 IG5lZWQgdG8gYmUgZGVhbGxvY2F0ZWQuCi0gICAgYm9vbCBidWZmZXJJc0ludGVybmFsKCkgeyBy ZXR1cm4gbV9kYXRhID09ICZtX2J1ZmZlclswXTsgfQorICAgIGJvb2wgYnVmZmVySXNJbnRlcm5h bCgpIHsgcmV0dXJuIG1fZGF0YSA9PSByZWludGVycHJldF9jYXN0PGNvbnN0IFVDaGFyKj4odGhp cyArIDEpOyB9CiAKICAgICBlbnVtIFN0cmluZ0ltcGxGbGFncyB7CiAgICAgICAgIEhhc1Rlcm1p bmF0aW5nTnVsbENoYXJhY3RlciwKQEAgLTIwMiwxMSArMjAyLDggQEAgcHJpdmF0ZToKICAgICB1 bnNpZ25lZCBtX2xlbmd0aDsKICAgICBtdXRhYmxlIHVuc2lnbmVkIG1faGFzaDsKICAgICBQdHJB bmRGbGFnczxTaGFyZWRVQ2hhciwgU3RyaW5nSW1wbEZsYWdzPiBtX3NoYXJlZEJ1ZmZlckFuZEZs YWdzOwotICAgIC8vIG1fYnVmZmVyIGlzIGRlY2xhcmVkIHdpdGggbm8gc2l6ZTsgdGhlIGNvbXBp bGVyIHRyZWF0cyBpdCBhcyB6ZXJvIHNpemUsCi0gICAgLy8gYW5kIHRoZSBhY3R1YWwgc2l6ZSBp cyBkZXRlcm1pbmVkIHdoZW4gdGhlIGluc3RhbmNlIGlzIGNyZWF0ZWQuIAotICAgIC8vIEl0IHdp bGwgYmUgemVybyB1bmxlc3MgdXNpbmcgYW4gImludGVybmFsIGJ1ZmZlciIsIGluIHdoaWNoIGNh c2UgbV9kYXRhCi0gICAgLy8gd2lsbCBwb2ludCB0byBtX2J1ZmZlciBhbmQgdGhlIGxlbmd0aCBv ZiBtX2J1ZmZlciB3aWxsIGJlIGVxdWFsIHRvIG1fbGVuZ3RoLgotICAgIGNvbnN0IFVDaGFyIG1f YnVmZmVyW107CisgICAgLy8gVGhlcmUgaXMgYSBmaWN0aXRpb3VzIHZhcmlhYmxlLWxlbmd0aCBV Q2hhciBhcnJheSBhdCB0aGUgZW5kLCB3aGljaCBpcyB1c2VkCisgICAgLy8gYXMgdGhlIGludGVy bmFsIGJ1ZmZlciBieSB0aGUgY3JlYXRlVW5pbml0aWFsaXplZCBhbmQgY3JlYXRlIG1ldGhvZHMu CiB9OwogCiBib29sIGVxdWFsKFN0cmluZ0ltcGwqLCBTdHJpbmdJbXBsKik7Cg==