30188 2009-10-07 17:08:48 -0700 REGRESSION(r49203): Text Drag and Drop stopped working in latest nightly build 2009-10-07 23:57:50 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac (Intel) OS X 10.4 RESOLVED FIXED InRadar, Regression P1 Normal --- 1 cwg_007 webkit-unassigned dbates eric mrowe oldest_to_newest 153220 0 cwg_007 2009-10-07 17:08:48 -0700 Selected Text from a Chatzy.com Chatroom will not drag and drop into a Tex-Edit window. It always has in previous builds, and still does in straight Safari. 153224 1 mrowe 2009-10-07 17:17:03 -0700 I suspect this may be due to <http://trac.webkit.org/changeset/49203>. 153225 2 mrowe 2009-10-07 17:18:01 -0700 <rdar://problem/7285503> 153229 3 mrowe 2009-10-07 17:33:58 -0700 Confirmed that r49203 is at fault. 153243 4 40837 dbates 2009-10-07 20:20:52 -0700 Created attachment 40837 Work in progress Patch Work in progress. Waiting for build/layout test results to confirm. 153261 5 40843 dbates 2009-10-07 21:41:01 -0700 Created attachment 40843 Patch I know I may be given some grief in that I am treating the DragOperation enum as an unsigned. We should fix this because such operations are needed and done on variables of type DragOperation in other parts of the drag-and-drop code. The solution would be to follow a similar approach as in AppKit's NSDragging.h, that is typedef DragOperation as an unsigned and define an anonymous enum of DragOperations. I suggest deferring this fix for a separate bug. Also, this patch does not include a test case because since this issue is observed when dragging data inside the web browser to an external application a DRT test is not possible. Moreover, a non-trivial manual test case is not possible for the same reason. 153262 6 eric 2009-10-07 21:46:07 -0700 We could extend DRT to support drags out of the WebView. It just would be a pain. 153263 7 40843 eric 2009-10-07 21:48:17 -0700 Comment on attachment 40843 Patch Why should the default be DragOperationNone? Why shouldn't other code cause this to default to DragOperationAny? You need a comment in the code to explain why this is right. Also, I assume we already ahve a WebCore/manual-test for this? If not, then we need one. 153267 8 dbates 2009-10-07 21:55:47 -0700 Not exactly sure why this is DragOperationNone other than this is not a DHTML drag. That is, there is no drag source operation specified. The Mac specific code that I removed in bug #30107 performed what I added into this patch (but in the platform-specific Mac code). What is the manual-test? Do you know off hand? I'll try to look myself. If we need one then the manual test would be something of the form "Open TextEdit and select text X and drag it into TextEdit. If it copies the test PASSED. Otherwise, the test FAILED." (In reply to comment #7) > (From update of attachment 40843 [details]) > Why should the default be DragOperationNone? > > Why shouldn't other code cause this to default to DragOperationAny? > > You need a comment in the code to explain why this is right. > > Also, I assume we already ahve a WebCore/manual-test for this? If not, then we > need one. 153271 9 eric 2009-10-07 21:59:55 -0700 You would have to look in WebCore/manual-tests yourself. I don't know what tests are in there currently, no. 153273 10 dbates 2009-10-07 22:01:18 -0700 Never mind, looks like there is already a manual test case we can use for this issue: drag-out-of-background-window.html (In reply to comment #8) > Not exactly sure why this is DragOperationNone other than this is not a DHTML > drag. That is, there is no drag source operation specified. > > The Mac specific code that I removed in bug #30107 performed what I added into > this patch (but in the platform-specific Mac code). > > What is the manual-test? Do you know off hand? I'll try to look myself. If we > need one then the manual test would be something of the form "Open TextEdit and > select text X and drag it into TextEdit. If it copies the test PASSED. > Otherwise, the test FAILED." > > (In reply to comment #7) > > (From update of attachment 40843 [details] [details]) > > Why should the default be DragOperationNone? > > > > Why shouldn't other code cause this to default to DragOperationAny? > > > > You need a comment in the code to explain why this is right. > > > > Also, I assume we already ahve a WebCore/manual-test for this? If not, then we > > need one. 153275 11 eric 2009-10-07 22:07:09 -0700 OK. Ideally your ChangeLog should mention that this is covered by that manual test. 153279 12 dbates 2009-10-07 22:14:29 -0700 OK. On second read, what do you mean "Why shouldn't other code cause this to default to DragOperationAny?" (In reply to comment #11) > OK. Ideally your ChangeLog should mention that this is covered by that manual > test. 153282 13 dbates 2009-10-07 22:21:26 -0700 The reason I ask is that from what I gather tracing the drag-operation through EventHandler::handleDrag (where the source drag operation is passed to the DragController) <http://trac.webkit.org/browser/trunk/WebCore/page/EventHandler.cpp#L2286> AND <http://trac.webkit.org/browser/trunk/WebCore/page/EventHandler.cpp#L2318>, it looks like we can remove the condition that m_sourceDragOperation == DragOperationNone. (In reply to comment #12) > OK. On second read, what do you mean "Why shouldn't other code cause this to > default to DragOperationAny?" > > (In reply to comment #11) > > OK. Ideally your ChangeLog should mention that this is covered by that manual > > test. 153288 14 40851 dbates 2009-10-07 22:35:05 -0700 Created attachment 40851 Patch Removed if condition (m_sourceDragOperation == DragOperationNone) since it appears it is sufficient to just test whether this is not a DHTML drag operation. As per Eric's comment, added notice to ChangeLog about manual test case: drag-out-of-background-window.html 153293 15 40852 dbates 2009-10-07 22:38:54 -0700 Created attachment 40852 Patch Cleaned up ChangeLog 153297 16 40852 eric 2009-10-07 22:59:30 -0700 Comment on attachment 40852 Patch The empty comment line is not needed: 654 // I don't usually put < > around URLs. I think this is OK to fix the bug, but I think we need to set this in a better, clearer place. it's so strange that this is set here, instead of in some earlier if. Also, this code makes me wonder what other state we need to set for non-dhtml drags? And why shouldn't m_sourceDragOperation default to DragOperationAny and then get set more restrictive in the DHTML case? Again, this code is just ugly, and poorly designed here. Your argument over IRC that we should take this simple fix and work to clean it up later is valid, but slightly saddening. :) 153299 17 dbates 2009-10-07 23:04:50 -0700 I'll make these changes before I land. I agree, this is a bit ugly and I don't have a good reason why we should go with a more restrictive set of drag operations (this was from the code I removed in bug #30107 - maybe there is a reason for this, instead of just DragOperationAny, though the person who wrote it didn't comment why). I'll look into a better solution when I have some time tomorrow. (In reply to comment #16) > (From update of attachment 40852 [details]) > The empty comment line is not needed: > 654 // > > I don't usually put < > around URLs. > > I think this is OK to fix the bug, but I think we need to set this in a better, > clearer place. it's so strange that this is set here, instead of in some > earlier if. > > Also, this code makes me wonder what other state we need to set for non-dhtml > drags? > > And why shouldn't m_sourceDragOperation default to DragOperationAny and then > get set more restrictive in the DHTML case? Again, this code is just ugly, and > poorly designed here. Your argument over IRC that we should take this simple > fix and work to clean it up later is valid, but slightly saddening. :) 153307 18 dbates 2009-10-07 23:57:50 -0700 Committed r49292: <http://trac.webkit.org/changeset/49292> 40837 2009-10-07 20:20:52 -0700 2009-10-07 21:41:01 -0700 Work in progress Patch SpecFix.diff text/plain 672 dbates SW5kZXg6IFdlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNDkyNjkpCisrKyBXZWJDb3Jl L3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02NDksNiArNjQ5LDgg QEAKIAogICAgIGlmIChpc0RIVE1MRHJhZykKICAgICAgICAgZHJhZ0ltYWdlID0gY2xpcGJvYXJk LT5jcmVhdGVEcmFnSW1hZ2UoZHJhZ0ltYWdlT2Zmc2V0KTsKKyAgICBlbHNlIGlmIChtX3NvdXJj ZURyYWdPcGVyYXRpb24gPT0gRHJhZ09wZXJhdGlvbk5vbmUpCisgICAgICAgIG1fc291cmNlRHJh Z09wZXJhdGlvbiA9IChEcmFnT3BlcmF0aW9uKShEcmFnT3BlcmF0aW9uR2VuZXJpYyB8IERyYWdP cGVyYXRpb25Db3B5KTsKIAogICAgIC8vIFdlIGFsbG93IERIVE1ML0pTIHRvIHNldCB0aGUgZHJh ZyBpbWFnZSwgZXZlbiBpZiBpdHMgYSBsaW5rLCBpbWFnZSBvciB0ZXh0IHdlJ3JlIGRyYWdnaW5n LgogICAgIC8vIFRoaXMgaXMgaW4gdGhlIHNwaXJpdCBvZiB0aGUgSUUgQVBJLCB3aGljaCBhbGxv d3Mgb3ZlcnJpZGluZyBvZiBwYXN0ZWJvYXJkIGRhdGEgYW5kIERyYWdPcC4K 40843 2009-10-07 21:41:01 -0700 2009-10-07 22:35:05 -0700 Patch Bug30188.patch text/plain 1975 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTI4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDktMTAtMDcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDE4OAorICAgICAgICAKKyAg ICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgcGVyZm9ybWluZyBhIG5vbiBESFRNTCBkcmFnLWFu ZC1kcm9wIG9wZXJhdGlvbiAKKyAgICAgICAgZGlkIG5vdCB3b3JrIGFzIGV4cGVjdGVkLiBGb3Ig aW5zdGFuY2UsIGRyYWdnaW5nIHNvbWUgc2VsZWN0ZWQgdGV4dCAKKyAgICAgICAgdG8gYW4gZXh0 ZXJuYWwgYXBwbGljYXRpb24sIHN1Y2ggYXMgVGV4dEVkaXQuCisgICAgICAgIAorICAgICAgICBU aGlzIGlzc3VlIHdhcyBhIHJlZ3Jlc3Npb24gdGhhdCBhcm9zZSBmcm9tIHBhdGNoaW5nIGJ1ZyAj MzAxMDcuCisgICAgICAgIAorICAgICAgICBObyB0ZXN0IGNhc2UgaXMgcHJvdmlkZWQgYmVjYXVz ZSB0aGlzIGNhbm5vdCBiZSB0ZXN0ZWQgd2l0aCBEUlQKKyAgICAgICAgbm9yIGNhbiBhIG5vbi10 cml2aWFsIG1hbnVhbCB0ZXN0IGJlIGRlc2lnbmVkIGJlY2F1c2UgdGhpcyBpc3N1ZSBpcworICAg ICAgICBvYnNlcnZlZCB3aGVuIGRyYWdnaW5nIGEgc2VsZWN0aW9uIG91dHNpZGUgdGhlIGJyb3dz ZXIgd2luZG93IGludG8KKyAgICAgICAgYW5kIGV4dGVybmFsIGFwcGxpY2F0aW9uLgorCisgICAg ICAgICogcGFnZS9EcmFnQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEcmFnQ29u dHJvbGxlcjo6c3RhcnREcmFnKTogV2hlbiBwZXJmb3JtaW5nIGEgbm9uLURIVE1MIGRyYWcgCisg ICAgICAgIG9wZXJhdGlvbiBhbmQgdGhlIHNvdXJjZSBkcmFnIG9wZXJhdGlvbiBpcyBEcmFnT3Bl cmF0aW9uTm9uZSB0aGVuIGRlZmF1bHQKKyAgICAgICAgdG8gZHJhZyBvcGVyYXRpb25zIERyYWdP cGVyYXRpb25HZW5lcmljIGFuZCBEcmFnT3BlcmF0aW9uQ29weS4KKwogMjAwOS0xMC0wNyAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA0OTI2OSkKKysr IFdlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY0OSw2 ICs2NDksOCBAQCBib29sIERyYWdDb250cm9sbGVyOjpzdGFydERyYWcoRnJhbWUqIHNyCiAKICAg ICBpZiAoaXNESFRNTERyYWcpCiAgICAgICAgIGRyYWdJbWFnZSA9IGNsaXBib2FyZC0+Y3JlYXRl RHJhZ0ltYWdlKGRyYWdJbWFnZU9mZnNldCk7CisgICAgZWxzZSBpZiAobV9zb3VyY2VEcmFnT3Bl cmF0aW9uID09IERyYWdPcGVyYXRpb25Ob25lKQorICAgICAgICBtX3NvdXJjZURyYWdPcGVyYXRp b24gPSAoRHJhZ09wZXJhdGlvbikoRHJhZ09wZXJhdGlvbkdlbmVyaWMgfCBEcmFnT3BlcmF0aW9u Q29weSk7CiAKICAgICAvLyBXZSBhbGxvdyBESFRNTC9KUyB0byBzZXQgdGhlIGRyYWcgaW1hZ2Us IGV2ZW4gaWYgaXRzIGEgbGluaywgaW1hZ2Ugb3IgdGV4dCB3ZSdyZSBkcmFnZ2luZy4KICAgICAv LyBUaGlzIGlzIGluIHRoZSBzcGlyaXQgb2YgdGhlIElFIEFQSSwgd2hpY2ggYWxsb3dzIG92ZXJy aWRpbmcgb2YgcGFzdGVib2FyZCBkYXRhIGFuZCBEcmFnT3AuCg== 40851 2009-10-07 22:35:05 -0700 2009-10-07 22:38:54 -0700 Patch Bug30188_1.patch text/plain 2054 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTI4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMTAtMDcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDE4OAorICAgICAgICAKKyAg ICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgcGVyZm9ybWluZyBhIG5vbiBESFRNTCBkcmFnLWFu ZC1kcm9wIG9wZXJhdGlvbiAKKyAgICAgICAgZGlkIG5vdCB3b3JrIGFzIGV4cGVjdGVkLiBGb3Ig aW5zdGFuY2UsIGRyYWdnaW5nIHNvbWUgc2VsZWN0ZWQgdGV4dCAKKyAgICAgICAgdG8gYW4gZXh0 ZXJuYWwgYXBwbGljYXRpb24sIHN1Y2ggYXMgVGV4dEVkaXQuCisgICAgICAgIAorICAgICAgICBU aGlzIGlzc3VlIHdhcyBhIHJlZ3Jlc3Npb24gdGhhdCBhcm9zZSBmcm9tIHBhdGNoaW5nIGJ1ZyAj MzAxMDcuCisgICAgICAgIAorICAgICAgICBUaGlzIGNoYW5nZSBpcyBjb3ZlcmVkIGJ5IHRoZSBt YW51YWwgdGVzdDogCisgICAgICAgIGRyYWctb3V0LW9mLWJhY2tncm91bmQtd2luZG93Lmh0bWwK KworICAgICAgICAqIHBhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 RHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZyk6IFdoZW4gcGVyZm9ybWluZyBhIG5vbi1ESFRNTCBk cmFnIAorICAgICAgICBvcGVyYXRpb24gYW5kIHRoZSBzb3VyY2UgZHJhZyBvcGVyYXRpb24gaXMg RHJhZ09wZXJhdGlvbk5vbmUgdGhlbiBkZWZhdWx0CisgICAgICAgIHRvIGRyYWcgb3BlcmF0aW9u cyBEcmFnT3BlcmF0aW9uR2VuZXJpYyBhbmQgRHJhZ09wZXJhdGlvbkNvcHkuCisKIDIwMDktMTAt MDcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0RyYWdDb250cm9sbGVyLmNwcAkocmV2aXNpb24gNDky NjkpCisrKyBXZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC02NDksNiArNjQ5LDEzIEBAIGJvb2wgRHJhZ0NvbnRyb2xsZXI6OnN0YXJ0RHJhZyhGcmFtZSog c3IKIAogICAgIGlmIChpc0RIVE1MRHJhZykKICAgICAgICAgZHJhZ0ltYWdlID0gY2xpcGJvYXJk LT5jcmVhdGVEcmFnSW1hZ2UoZHJhZ0ltYWdlT2Zmc2V0KTsKKyAgICBlbHNlIHsKKyAgICAgICAg Ly8gVGhpcyBkcmFnIG9wZXJhdGlvbiBpcyBub3QgYSBESFRNTCBkcmFnIGFuZCBtYXkgZ28gb3V0 c2lkZSB0aGUgV2ViVmlldy4KKyAgICAgICAgLy8KKyAgICAgICAgLy8gV2UgcHJvdmlkZSBhIGRl ZmF1bHQgc2V0IG9mIGFsbG93ZWQgZHJhZyBvcGVyYXRpb25zIHRoYXQgZm9sbG93cyBmcm9tOgor ICAgICAgICAvLyA8aHR0cDovL3RyYWMud2Via2l0Lm9yZy9icm93c2VyL3RydW5rL1dlYktpdC9t YWMvV2ViVmlldy9XZWJIVE1MVmlldy5tbT9yZXY9NDg1MjYjTDM0MzA+LgorICAgICAgICBtX3Nv dXJjZURyYWdPcGVyYXRpb24gPSAoRHJhZ09wZXJhdGlvbikoRHJhZ09wZXJhdGlvbkdlbmVyaWMg fCBEcmFnT3BlcmF0aW9uQ29weSk7CisgICAgfQogCiAgICAgLy8gV2UgYWxsb3cgREhUTUwvSlMg dG8gc2V0IHRoZSBkcmFnIGltYWdlLCBldmVuIGlmIGl0cyBhIGxpbmssIGltYWdlIG9yIHRleHQg d2UncmUgZHJhZ2dpbmcuCiAgICAgLy8gVGhpcyBpcyBpbiB0aGUgc3Bpcml0IG9mIHRoZSBJRSBB UEksIHdoaWNoIGFsbG93cyBvdmVycmlkaW5nIG9mIHBhc3RlYm9hcmQgZGF0YSBhbmQgRHJhZ09w Lgo= 40852 2009-10-07 22:38:54 -0700 2009-10-07 22:59:30 -0700 Patch Bug30188_2.patch text/plain 2185 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTI4NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDktMTAtMDcgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3ZWJraXQu b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDE4OAorICAgICAgICAKKyAg ICAgICAgRml4ZXMgYW4gaXNzdWUgd2hlcmUgcGVyZm9ybWluZyBhIG5vbiBESFRNTCBkcmFnLWFu ZC1kcm9wIG9wZXJhdGlvbiAKKyAgICAgICAgZG9lcyBub3Qgd29yayBhcyBleHBlY3RlZC4gRm9y IGluc3RhbmNlLCBkcmFnZ2luZyBzb21lIHNlbGVjdGVkIHRleHQgCisgICAgICAgIHRvIGFuIGV4 dGVybmFsIGFwcGxpY2F0aW9uLCBzdWNoIGFzIFRleHRFZGl0LgorICAgICAgICAKKyAgICAgICAg VGhpcyBpc3N1ZSB3YXMgYSByZWdyZXNzaW9uIHRoYXQgYXJvc2UgZnJvbSBwYXRjaGluZyBidWcg IzMwMTA3LgorICAgICAgICAKKyAgICAgICAgVGhpcyBjaGFuZ2UgaXMgY292ZXJlZCBieSB0aGUg bWFudWFsIHRlc3Q6IAorICAgICAgICBkcmFnLW91dC1vZi1iYWNrZ3JvdW5kLXdpbmRvdy5odG1s CisKKyAgICAgICAgKiBwYWdlL0RyYWdDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkRyYWdDb250cm9sbGVyOjpzdGFydERyYWcpOiBXaGVuIHBlcmZvcm1pbmcgYSBub24tREhUTUwg ZHJhZyAKKyAgICAgICAgb3BlcmF0aW9uIHRoZW4gZGVmYXVsdCB0byBkcmFnIG9wZXJhdGlvbnMg RHJhZ09wZXJhdGlvbkdlbmVyaWMgYW5kIAorICAgICAgICBEcmFnT3BlcmF0aW9uQ29weSBhY2Nv cmRpbmcgdG8gc2ltaWxhciBmdW5jdGlvbmFsaXR5IHJlbW92ZWQgd2hlbiBmaXhpbmcKKyAgICAg ICAgYnVnICMzMDEwNywgc2VlOiAKKyAgICAgICAgPGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvYnJv d3Nlci90cnVuay9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0/cmV2PTQ4NTI2I0wz NDMwPiAKKwogMjAwOS0xMC0wNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViQ29yZS9wYWdlL0RyYWdD b250cm9sbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRHJhZ0NvbnRyb2xsZXIu Y3BwCShyZXZpc2lvbiA0OTI2OSkKKysrIFdlYkNvcmUvcGFnZS9EcmFnQ29udHJvbGxlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTY0OSw2ICs2NDksMTMgQEAgYm9vbCBEcmFnQ29udHJvbGxlcjo6 c3RhcnREcmFnKEZyYW1lKiBzcgogCiAgICAgaWYgKGlzREhUTUxEcmFnKQogICAgICAgICBkcmFn SW1hZ2UgPSBjbGlwYm9hcmQtPmNyZWF0ZURyYWdJbWFnZShkcmFnSW1hZ2VPZmZzZXQpOworICAg IGVsc2UgeworICAgICAgICAvLyBUaGlzIGRyYWcgb3BlcmF0aW9uIGlzIG5vdCBhIERIVE1MIGRy YWcgYW5kIG1heSBnbyBvdXRzaWRlIHRoZSBXZWJWaWV3LgorICAgICAgICAvLworICAgICAgICAv LyBXZSBwcm92aWRlIGEgZGVmYXVsdCBzZXQgb2YgYWxsb3dlZCBkcmFnIG9wZXJhdGlvbnMgdGhh dCBmb2xsb3dzIGZyb206CisgICAgICAgIC8vIDxodHRwOi8vdHJhYy53ZWJraXQub3JnL2Jyb3dz ZXIvdHJ1bmsvV2ViS2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tP3Jldj00ODUyNiNMMzQz MD4uCisgICAgICAgIG1fc291cmNlRHJhZ09wZXJhdGlvbiA9IChEcmFnT3BlcmF0aW9uKShEcmFn T3BlcmF0aW9uR2VuZXJpYyB8IERyYWdPcGVyYXRpb25Db3B5KTsKKyAgICB9CiAKICAgICAvLyBX ZSBhbGxvdyBESFRNTC9KUyB0byBzZXQgdGhlIGRyYWcgaW1hZ2UsIGV2ZW4gaWYgaXRzIGEgbGlu aywgaW1hZ2Ugb3IgdGV4dCB3ZSdyZSBkcmFnZ2luZy4KICAgICAvLyBUaGlzIGlzIGluIHRoZSBz cGlyaXQgb2YgdGhlIElFIEFQSSwgd2hpY2ggYWxsb3dzIG92ZXJyaWRpbmcgb2YgcGFzdGVib2Fy ZCBkYXRhIGFuZCBEcmFnT3AuCg==