30182 2009-10-07 13:54:33 -0700 Animation stalls for a few seconds partway through 2010-04-30 16:03:42 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser oldest_to_newest 153175 0 simon.fraser 2009-10-07 13:54:33 -0700 If you run the attached testcase with layer borders turned on, you'll see that the animating red box stalls for a couple of seconds part-way through. The issue is that we're calling -disableScreenUpdatesUntilFlush on the NSWindow when there is actually no view drawing to be done, so that the window flush never happens. This means that screen updates end up being disabled until the watchdog enables them again (after 2 seconds). 153178 1 40820 simon.fraser 2009-10-07 14:03:37 -0700 Created attachment 40820 Patch 153208 2 simon.fraser 2009-10-07 15:53:31 -0700 http://trac.webkit.org/changeset/49269 219640 3 54830 simon.fraser 2010-04-30 16:03:42 -0700 Created attachment 54830 I think this testcase reproduces the problem 40820 2009-10-07 14:03:37 -0700 2009-10-07 15:23:20 -0700 Patch 30182_patch.txt text/plain 1647 simon.fraser ZGlmZiAtLWdpdCBhL1dlYktpdC9tYWMvQ2hhbmdlTG9nIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cK aW5kZXggNTU2Y2U3Yi4uNWE0YzI2ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L21hYy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0wNyAg U2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBbmltYXRpb24gc3RhbGxzIGZvciBhIGZl dyBzZWNvbmRzIHBhcnR3YXkgdGhyb3VnaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzAxODIKKyAgICAgICAgCisgICAgICAgIE1ha2Ugc3VyZSB0aGF0 IHdlIG9ubHkgY2FsbCAtZGlzYWJsZVNjcmVlblVwZGF0ZXNVbnRpbEZsdXNoIHdoZW4gYSB3aW5k b3cKKyAgICAgICAgdXBkYXRlIGlzIGFjdHVhbGx5IGdvaW5nIHRvIGhhcHBlbiwgb3RoZXJ3aXNl IHNjcmVlbiB1cGRhdGVzIGFyZSBkaXNhYmxlZAorICAgICAgICBmb3IgdG9vIGxvbmcuCisKKyAg ICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm1tOgorICAgICAgICAoLVtXZWJIVE1MVmlldyBk cmF3UmVjdDpdKToKKwogMjAwOS0xMC0wNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1n aXQgYS9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0gYi9XZWJLaXQvbWFjL1dlYlZp ZXcvV2ViSFRNTFZpZXcubW0KaW5kZXggMmVkMGJhOC4uNWY3ZTRjZiAxMDA2NDQKLS0tIGEvV2Vi S2l0L21hYy9XZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisrKyBiL1dlYktpdC9tYWMvV2ViVmlldy9X ZWJIVE1MVmlldy5tbQpAQCAtMzE5Niw4ICszMTk2LDEwIEBAIFdFQkNPUkVfQ09NTUFORCh5YW5r QW5kU2VsZWN0KQogICAgIGlmIChbW3NlbGYgX3dlYlZpZXddIF9uZWVkc09uZVNob3REcmF3aW5n U3luY2hyb25pemF0aW9uXSkgewogICAgICAgICAvLyBEaXNhYmxlIHNjcmVlbiB1cGRhdGVzIHNv IHRoYXQgYW55IGxheWVyIGNoYW5nZXMgY29tbWl0dGVkIGhlcmUKICAgICAgICAgLy8gZG9uJ3Qg c2hvdyB1cCBvbiB0aGUgc2NyZWVuIGJlZm9yZSB0aGUgd2luZG93IGZsdXNoIGF0IHRoZSBlbmQK LSAgICAgICAgLy8gb2YgdGhlIGN1cnJlbnQgd2luZG93IGRpc3BsYXkuCi0gICAgICAgIFtbc2Vs ZiB3aW5kb3ddIGRpc2FibGVTY3JlZW5VcGRhdGVzVW50aWxGbHVzaF07CisgICAgICAgIC8vIG9m IHRoZSBjdXJyZW50IHdpbmRvdyBkaXNwbGF5LCBidXQgb25seSBpZiBhIHdpbmRvdyBmbHVzaCBp cyBhY3R1YWxseQorICAgICAgICAvLyBnb2luZyB0byBoYXBwZW4uCisgICAgICAgIGlmIChbW3Nl bGYgd2luZG93XSB2aWV3c05lZWREaXNwbGF5XSkKKyAgICAgICAgICAgIFtbc2VsZiB3aW5kb3dd IGRpc2FibGVTY3JlZW5VcGRhdGVzVW50aWxGbHVzaF07CiAgICAgICAgIAogICAgICAgICAvLyBN YWtlIHN1cmUgYW55IGxheWVyIGNoYW5nZXMgdGhhdCBoYXBwZW5lZCBhcyBhIHJlc3VsdCBvZiBs YXlvdXQKICAgICAgICAgLy8gdmlhIC12aWV3V2lsbERyYXcgYXJlIGNvbW1pdHRlZC4K 54830 2010-04-30 16:03:42 -0700 2010-04-30 16:03:42 -0700 I think this testcase reproduces the problem layers_for_animation_hw.html text/html 1451 simon.fraser PCFET0NUWVBFIGh0bWwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIKICAgImh0dHA6Ly93d3cudzMub3JnL1RSL2h0bWw0L2xvb3NlLmR0ZCI+Cgo8aHRtbCBs YW5nPSJlbiI+CjxoZWFkPgogIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29udGVu dD0idGV4dC9odG1sOyBjaGFyc2V0PXV0Zi04Ij4KICA8dGl0bGU+QW5pbWF0aW9ucyBhbmQgTGF5 ZXIgQ3JlYXRpb248L3RpdGxlPgogIDxzdHlsZSB0eXBlPSJ0ZXh0L2NzcyIgbWVkaWE9InNjcmVl biI+CiAgICAuYm94IHsKICAgICAgaGVpZ2h0OiAxNTBweDsKICAgICAgd2lkdGg6IDE1MHB4Owog ICAgICBiYWNrZ3JvdW5kLWNvbG9yOiBibHVlOwogICAgICBtYXJnaW46IDMwcHg7CiAgICB9CiAg ICAKICAgICN0ZXN0IHsKICAgICAgaGVpZ2h0OiAwcHg7CiAgICAgIHdpZHRoOiAwcHg7CiAgICB9 CiAgICAKICAgIC5jb21wb3NpdGVkIHsKICAgICAgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0 ZVooMCk7CiAgICB9CiAgICAKICAgIC5hbmltYXRlZCB7CiAgICAgIC13ZWJraXQtYW5pbWF0aW9u LW5hbWU6IHdvYmJsZTsKICAgICAgLXdlYmtpdC1hbmltYXRpb24tZGVsYXk6IDEwMG1zOwogICAg ICAtd2Via2l0LWFuaW1hdGlvbi1kdXJhdGlvbjogMnM7CiAgICAgIC13ZWJraXQtYW5pbWF0aW9u LWl0ZXJhdGlvbi1jb3VudDogaW5maW5pdGU7CiAgICAgIC13ZWJraXQtYW5pbWF0aW9uLWRpcmVj dGlvbjogYWx0ZXJuYXRlOwogICAgfQogICAgCiAgICBALXdlYmtpdC1rZXlmcmFtZXMgJ3dvYmJs ZScgewogICAgICBmcm9tICB7IC13ZWJraXQtdHJhbnNmb3JtOiB0cmFuc2xhdGVYKDApOyB9CiAg ICAgIHRvICAgIHsgLXdlYmtpdC10cmFuc2Zvcm06IHRyYW5zbGF0ZVgoNDAwcHgpOyB9CiAgICB9 CiAgPC9zdHlsZT4KICA8c2NyaXB0IHR5cGU9InRleHQvamF2YXNjcmlwdCIgY2hhcnNldD0idXRm LTgiPgogICAgCiAgICAvLyBUaGUgdGltaW5nIGhlcmUgaXMgc2Vuc2l0aXZlIHRvIHRoZSB0aW1p bmcgb2YgU2FmYXJpJ3Mgc25hcHNob3R0aW5nIG1hY2hpbmVyeQogICAgZnVuY3Rpb24gZG9UZXN0 KCkKICAgIHsKICAgICAgd2luZG93LnNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CiAgICAgICAgZG9j dW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3Rlc3QnKS5jbGFzc05hbWUgPSAnY29tcG9zaXRlZCBib3gn OwogICAgICB9LCAxMDApOwogICAgfQogICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQn LCBkb1Rlc3QsIGZhbHNlKTsKICA8L3NjcmlwdD4KPC9oZWFkPgo8Ym9keT4KCjxoMz5Jbi1mbG93 PC9oMz4KPGRpdiBpZD0idGVzdCIgY2xhc3M9ImJveCI+CjwvZGl2PgoKPGgzPlBvc2l0aW9uZWQ8 L2gzPgo8ZGl2IGNsYXNzPSJhbmltYXRlZCBib3giIHN0eWxlPSJwb3NpdGlvbjogcmVsYXRpdmUi Pgo8L2Rpdj4KCjwvYm9keT4KPC9odG1sPgo=