30174 2009-10-07 09:52:51 -0700 Web Inspector: Wrap Database into ScriptObject in v8 bindings. 2009-10-09 09:36:33 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman dglazkov oldest_to_newest 153087 0 pfeldman 2009-10-07 09:52:51 -0700 There is a TODO that should be replaced with the real implementation for database tab to work in Chromium. 153091 1 40801 pfeldman 2009-10-07 09:58:42 -0700 Created attachment 40801 patch 153134 2 40801 abarth 2009-10-07 11:39:46 -0700 Comment on attachment 40801 patch Test? + Frame* frame = database->document()->frame(); This line has a tab. What if frame() is null? + // FIXME: What if context.IsEmpty()? You need to handle this case! + ScriptState* scriptState = frame->page()->inspectorController()->frontendScriptState(); What if page() is null? 153137 3 40809 pfeldman 2009-10-07 11:50:11 -0700 Created attachment 40809 patch with comments addressed 153691 4 40809 dglazkov 2009-10-09 08:49:45 -0700 Comment on attachment 40809 patch with comments addressed r=me. Pls add a line to ChangeLog entry explaining that there's no way to test this atm. 153696 5 pfeldman 2009-10-09 09:36:33 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/bindings/v8/ScriptObjectQuarantine.cpp Committed r49393 40801 2009-10-07 09:58:42 -0700 2009-10-07 11:50:11 -0700 patch db_wrap text/plain 1798 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWNmZjNkYy4uNDhjZjU2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMC0wNyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJp IEdsYXprb3YuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV3JhcCBEYXRhYmFzZSBpbnRvIFNj cmlwdE9iamVjdCBpbiB2OCBiaW5kaW5ncy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNzQKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Njcmlw dE9iamVjdFF1YXJhbnRpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0UXVhcmFudGluZWRT Y3JpcHRPYmplY3QpOgorCiAyMDA5LTEwLTA3ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNv bT4KIAogICAgICAgICBGaXggdHlwbyBpbiBQbHVnaW5WaWV3Ojpsb2FkIHRoYXQgd2FzIGNhdXNp bmcgY3Jvc3Mtb3JpZ2luIGxvYWRzIHRvCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRP YmplY3RRdWFyYW50aW5lLmNwcAppbmRleCA1ZGQwZGM1Li5hNTJiMzg5IDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCisrKyBiL1dlYkNv cmUvYmluZGluZ3MvdjgvU2NyaXB0T2JqZWN0UXVhcmFudGluZS5jcHAKQEAgLTU3LDEwICs1Nywy MSBAQCBib29sIGdldFF1YXJhbnRpbmVkU2NyaXB0T2JqZWN0KERhdGFiYXNlKiBkYXRhYmFzZSwg U2NyaXB0T2JqZWN0JiBxdWFyYW50aW5lZE9iagogewogICAgIEFTU0VSVChkYXRhYmFzZSk7CiAK LSAgICAvLyBGSVhNRTogSW1wbGVtZW50IHdoZW4gRGF0YWJhc2UgVjggYmluZGluZ3MgYXJlIGVu YWJsZWQKKyNpZiBFTkFCTEUoREFUQUJBU0UpCisgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNj b3BlOworCUZyYW1lKiBmcmFtZSA9IGRhdGFiYXNlLT5kb2N1bWVudCgpLT5mcmFtZSgpOworICAg IHY4OjpMb2NhbDx2ODo6Q29udGV4dD4gY29udGV4dCA9IFY4UHJveHk6OmNvbnRleHQoZnJhbWUp OworICAgIC8vIEZJWE1FOiBXaGF0IGlmIGNvbnRleHQuSXNFbXB0eSgpPworICAgIHY4OjpDb250 ZXh0OjpTY29wZSBzY29wZShjb250ZXh0KTsKKworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2 OERhdGFiYXNlID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6 OkRBVEFCQVNFLCBkYXRhYmFzZSk7CisgICAgU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlID0gZnJh bWUtPnBhZ2UoKS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5mcm9udGVuZFNjcmlwdFN0YXRlKCk7 CisgICAgcXVhcmFudGluZWRPYmplY3QgPSBTY3JpcHRPYmplY3Qoc2NyaXB0U3RhdGUsIHY4OjpM b2NhbDx2ODo6T2JqZWN0Pih2ODo6T2JqZWN0OjpDYXN0KCp2OERhdGFiYXNlKSkpOworI2Vsc2UK ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICBxdWFyYW50aW5lZE9iamVjdCA9IFNjcmlw dE9iamVjdCgpOwotICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorICAgIHJldHVybiB0cnVlOwog fQogCiBib29sIGdldFF1YXJhbnRpbmVkU2NyaXB0T2JqZWN0KFN0b3JhZ2UqIHN0b3JhZ2UsIFNj cmlwdE9iamVjdCYgcXVhcmFudGluZWRPYmplY3QpCg== 40809 2009-10-07 11:50:11 -0700 2009-10-09 08:49:45 -0700 patch with comments addressed db_wrap text/plain 2314 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWNmZjNkYy4uNDhjZjU2ZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAwOS0xMC0wNyAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJp IEdsYXprb3YuCisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogV3JhcCBEYXRhYmFzZSBpbnRvIFNj cmlwdE9iamVjdCBpbiB2OCBiaW5kaW5ncy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNzQKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Njcmlw dE9iamVjdFF1YXJhbnRpbmUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Z2V0UXVhcmFudGluZWRT Y3JpcHRPYmplY3QpOgorCiAyMDA5LTEwLTA3ICBBZGFtIFJvYmVuICA8YXJvYmVuQGFwcGxlLmNv bT4KIAogICAgICAgICBGaXggdHlwbyBpbiBQbHVnaW5WaWV3Ojpsb2FkIHRoYXQgd2FzIGNhdXNp bmcgY3Jvc3Mtb3JpZ2luIGxvYWRzIHRvCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9TY3JpcHRP YmplY3RRdWFyYW50aW5lLmNwcAppbmRleCA1ZGQwZGM1Li42NTI4YzlkIDEwMDY0NAotLS0gYS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1NjcmlwdE9iamVjdFF1YXJhbnRpbmUuY3BwCisrKyBiL1dlYkNv cmUvYmluZGluZ3MvdjgvU2NyaXB0T2JqZWN0UXVhcmFudGluZS5jcHAKQEAgLTU3LDEwICs1Nywy NSBAQCBib29sIGdldFF1YXJhbnRpbmVkU2NyaXB0T2JqZWN0KERhdGFiYXNlKiBkYXRhYmFzZSwg U2NyaXB0T2JqZWN0JiBxdWFyYW50aW5lZE9iagogewogICAgIEFTU0VSVChkYXRhYmFzZSk7CiAK LSAgICAvLyBGSVhNRTogSW1wbGVtZW50IHdoZW4gRGF0YWJhc2UgVjggYmluZGluZ3MgYXJlIGVu YWJsZWQKKyNpZiBFTkFCTEUoREFUQUJBU0UpCisgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNj b3BlOworICAgIEZyYW1lKiBmcmFtZSA9IGRhdGFiYXNlLT5kb2N1bWVudCgpLT5mcmFtZSgpOwor ICAgIGlmICghZnJhbWUpCisgICAgICAgIHJldHVybiBmYWxzZTsKKworICAgIHY4OjpMb2NhbDx2 ODo6Q29udGV4dD4gY29udGV4dCA9IFY4UHJveHk6OmNvbnRleHQoZnJhbWUpOworICAgIGlmIChj b250ZXh0LklzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgdjg6OkNvbnRl eHQ6OlNjb3BlIHNjb3BlKGNvbnRleHQpOworICAgIHY4OjpIYW5kbGU8djg6OlZhbHVlPiB2OERh dGFiYXNlID0gVjhET01XcmFwcGVyOjpjb252ZXJ0VG9WOE9iamVjdChWOENsYXNzSW5kZXg6OkRB VEFCQVNFLCBkYXRhYmFzZSk7CisgICAgU2NyaXB0U3RhdGUqIHNjcmlwdFN0YXRlID0gZnJhbWUt PnBhZ2UoKS0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5mcm9udGVuZFNjcmlwdFN0YXRlKCk7Cisg ICAgcXVhcmFudGluZWRPYmplY3QgPSBTY3JpcHRPYmplY3Qoc2NyaXB0U3RhdGUsIHY4OjpMb2Nh bDx2ODo6T2JqZWN0Pih2ODo6T2JqZWN0OjpDYXN0KCp2OERhdGFiYXNlKSkpOworI2Vsc2UKICAg ICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICBxdWFyYW50aW5lZE9iamVjdCA9IFNjcmlwdE9i amVjdCgpOwotICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgorICAgIHJldHVybiB0cnVlOwogfQog CiBib29sIGdldFF1YXJhbnRpbmVkU2NyaXB0T2JqZWN0KFN0b3JhZ2UqIHN0b3JhZ2UsIFNjcmlw dE9iamVjdCYgcXVhcmFudGluZWRPYmplY3QpCkBAIC03Miw3ICs4Nyw5IEBAIGJvb2wgZ2V0UXVh cmFudGluZWRTY3JpcHRPYmplY3QoU3RvcmFnZSogc3RvcmFnZSwgU2NyaXB0T2JqZWN0JiBxdWFy YW50aW5lZE9iamVjCiAjaWYgRU5BQkxFKERPTV9TVE9SQUdFKQogICAgIHY4OjpIYW5kbGVTY29w ZSBoYW5kbGVTY29wZTsKICAgICB2ODo6TG9jYWw8djg6OkNvbnRleHQ+IGNvbnRleHQgPSBWOFBy b3h5Ojpjb250ZXh0KGZyYW1lKTsKLSAgICAvLyBGSVhNRTogV2hhdCBpZiBjb250ZXh0LklzRW1w dHkoKT8KKyAgICBpZiAoY29udGV4dC5Jc0VtcHR5KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsK KwogICAgIHY4OjpDb250ZXh0OjpTY29wZSBzY29wZShjb250ZXh0KTsKIAogICAgIHY4OjpIYW5k bGU8djg6OlZhbHVlPiB2OFN0b3JhZ2UgPSBWOERPTVdyYXBwZXI6OmNvbnZlcnRUb1Y4T2JqZWN0 KFY4Q2xhc3NJbmRleDo6U1RPUkFHRSwgc3RvcmFnZSk7Cg==