30167 2009-10-07 07:59:19 -0700 [Qt] Memory leak caught in WebCore/platform/network/qt/QNetworkReplyHandler.cpp 2009-10-22 12:56:20 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) S60 Hardware S60 3rd edition RESOLVED FIXED Qt P2 Normal --- 0 cshu webkit-unassigned commit-queue eric oldest_to_newest 153040 0 cshu 2009-10-07 07:59:19 -0700 Memory leak caught in WebCore/platform/network/qt/QNetworkReplyHandler.cpp. Function QNetworkReply::abort() 153051 1 40790 cshu 2009-10-07 08:32:25 -0700 Created attachment 40790 patch 153061 2 40790 eric 2009-10-07 09:18:10 -0700 Comment on attachment 40790 patch Wow. deleteLater() is a very scary memory management model. But OK I trust you. rubber-stamp=me. 153376 3 cshu 2009-10-08 08:17:40 -0700 (In reply to comment #2) > (From update of attachment 40790 [details]) > Wow. deleteLater() is a very scary memory management model. But OK I trust > you. rubber-stamp=me. Eric, Please set this to r- as it may cause problem. I am working on that. Sorry. 156903 4 41662 cshu 2009-10-22 09:14:00 -0700 Created attachment 41662 2nd patch 156933 5 eric 2009-10-22 10:51:31 -0700 What sort of problems did the other patch cause? Can we test those problems with a unit test/layout test? 156937 6 cshu 2009-10-22 10:56:38 -0700 (In reply to comment #5) > What sort of problems did the other patch cause? Can we test those problems > with a unit test/layout test? If m_reply is NOT unhooked from QNetworkReplyHandler in release() function, it may reference QNetworkReplyHandler after the latter is deleted. This is the problem of the first patch. Not sure how to come up with a test case... It's related to download. 156940 7 41662 eric 2009-10-22 10:58:55 -0700 Comment on attachment 41662 2nd patch Ideally your ChangeLog would give explanations like this, and make some small statement about why this change is untestable. 156949 8 41670 cshu 2009-10-22 11:29:37 -0700 Created attachment 41670 update ChangeLog 156951 9 41670 eric 2009-10-22 11:33:15 -0700 Comment on attachment 41670 update ChangeLog OK. I'm not a Qt expert, but as far as I can tell this looks sane. 156980 10 41670 commit-queue 2009-10-22 12:56:16 -0700 Comment on attachment 41670 update ChangeLog Clearing flags on attachment: 41670 Committed r49951: <http://trac.webkit.org/changeset/49951> 156981 11 commit-queue 2009-10-22 12:56:20 -0700 All reviewed patches have been landed. Closing bug. 40790 2009-10-07 08:32:25 -0700 2009-10-22 09:14:00 -0700 patch bug30167.patch text/plain 1149 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTI0NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMDcgIFNodSBDaGFuZyAgPENoYW5nLlNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBGaXggbWVtb3J5IGxlYWsgaW4gdGhlIGZvbGxvd2luZyBmdW5jdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNjcKKworICAgICAgICAqIHBs YXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6OmFib3J0KToKKwogMjAwOS0xMC0wNyAgQWRhbSBS b2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHR5cG8gaW4gUGx1Z2luVmll dzo6bG9hZCB0aGF0IHdhcyBjYXVzaW5nIGNyb3NzLW9yaWdpbiBsb2FkcyB0bwpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIu Y3BwCShyZXZpc2lvbiA0OTI0MikKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9RTmV0 d29ya1JlcGx5SGFuZGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4Nyw4ICsxODcsOCBAQCB2 b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjphYm9ydCgpCiAgICAgICAgIFFOZXR3b3JrUmVwbHkq IHJlcGx5ID0gcmVsZWFzZSgpOwogICAgICAgICByZXBseS0+YWJvcnQoKTsKICAgICAgICAgcmVw bHktPmRlbGV0ZUxhdGVyKCk7Ci0gICAgICAgIGRlbGV0ZUxhdGVyKCk7CiAgICAgfQorICAgIGRl bGV0ZUxhdGVyKCk7CiB9CiAKIFFOZXR3b3JrUmVwbHkqIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpy ZWxlYXNlKCkK 41662 2009-10-22 09:14:00 -0700 2009-10-22 11:29:37 -0700 2nd patch bug30167_2.patch text/plain 1514 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTk0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMjIgIFNodSBDaGFuZyAgPENoYW5nLlNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBGaXggbWVtb3J5IGxlYWsgaW4gUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNjcKKworICAgICAgICAq IHBsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UU5ldHdvcmtSZXBseUhhbmRsZXI6OmFib3J0KToKKyAgICAgICAgKFdlYkNvcmU6 OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjpyZWxlYXNlKToKKwogMjAwOS0xMC0yMiAgS2Vpc2hpIEhh dHRvcmkgIDxjYXNleS5oYXR0b3JpQGdtYWlsLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBQ YXZlbCBGZWxkbWFuLgpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3Jr UmVwbHlIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv cXQvUU5ldHdvcmtSZXBseUhhbmRsZXIuY3BwCShyZXZpc2lvbiA0OTg3OSkKKysrIFdlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTE3NSw4ICsxNzUsOCBAQCB2b2lkIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjphYm9ydCgp CiAgICAgICAgIFFOZXR3b3JrUmVwbHkqIHJlcGx5ID0gcmVsZWFzZSgpOwogICAgICAgICByZXBs eS0+YWJvcnQoKTsKICAgICAgICAgcmVwbHktPmRlbGV0ZUxhdGVyKCk7Ci0gICAgICAgIGRlbGV0 ZUxhdGVyKCk7CiAgICAgfQorICAgIGRlbGV0ZUxhdGVyKCk7CiB9CiAKIFFOZXR3b3JrUmVwbHkq IFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpyZWxlYXNlKCkKQEAgLTE4OCw2ICsxODgsNyBAQCBRTmV0 d29ya1JlcGx5KiBRTmV0d29ya1JlcGx5SGFuZGxlcjo6cmVsCiAgICAgICAgIC8vIHBvc3RlZCBt ZXRhIGNhbGwgZXZlbnRzIHRoYXQgd2VyZSB0aGUgcmVzdWx0IG9mIGEgc2lnbmFsIGVtaXNzaW9u CiAgICAgICAgIC8vIGRvbid0IHJlYWNoIHRoZSBzbG90cyBpbiBvdXIgaW5zdGFuY2UuCiAgICAg ICAgIFFDb3JlQXBwbGljYXRpb246OnJlbW92ZVBvc3RlZEV2ZW50cyh0aGlzLCBRRXZlbnQ6Ok1l dGFDYWxsKTsKKyAgICAgICAgbV9yZXBseS0+c2V0UGFyZW50KDApOwogICAgICAgICBtX3JlcGx5 ID0gMDsKICAgICB9CiAgICAgcmV0dXJuIHJlcGx5Owo= 41670 2009-10-22 11:29:37 -0700 2009-10-22 12:56:15 -0700 update ChangeLog bug30167_3.patch text/plain 1701 cshu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTk0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMDktMTAtMjIgIFNodSBDaGFuZyAgPENoYW5nLlNodUBub2tpYS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBGaXggbWVtb3J5IGxlYWsgaW4gUU5ldHdvcmtSZXBseUhhbmRsZXI6OmFib3J0KCkuCisgICAg ICAgIEluIFFOZXR3b3JrUmVwbHlIYW5kbGVyOjpyZWxlYXNlKCksIG1fcmVwbHkgc2hvdWxkIG5v IGxvbmdlciBwb2ludCB0byBpdHMgcGFyZW50CisgICAgICAgIGFmdGVyIGJlaW5nIHJlbGVhc2Vk LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNjcK KworICAgICAgICBObyBsYXlvdXQgdGVzdCBhdmFpbGFibGUgYXMgYSBub24tZnVuY3Rpb25hbCBm aXguCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVy LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlFOZXR3b3JrUmVwbHlIYW5kbGVyOjphYm9ydCk6Cisg ICAgICAgIChXZWJDb3JlOjpRTmV0d29ya1JlcGx5SGFuZGxlcjo6cmVsZWFzZSk6CisKIDIwMDkt MTAtMjIgIEtlaXNoaSBIYXR0b3JpICA8Y2FzZXkuaGF0dG9yaUBnbWFpbC5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgUGF2ZWwgRmVsZG1hbi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9xdC9RTmV0d29ya1JlcGx5SGFuZGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3F0L1FOZXR3b3JrUmVwbHlIYW5kbGVyLmNwcAkocmV2aXNpb24gNDk4 NzkpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUU5ldHdvcmtSZXBseUhhbmRsZXIu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNzUsOCArMTc1LDggQEAgdm9pZCBRTmV0d29ya1JlcGx5 SGFuZGxlcjo6YWJvcnQoKQogICAgICAgICBRTmV0d29ya1JlcGx5KiByZXBseSA9IHJlbGVhc2Uo KTsKICAgICAgICAgcmVwbHktPmFib3J0KCk7CiAgICAgICAgIHJlcGx5LT5kZWxldGVMYXRlcigp OwotICAgICAgICBkZWxldGVMYXRlcigpOwogICAgIH0KKyAgICBkZWxldGVMYXRlcigpOwogfQog CiBRTmV0d29ya1JlcGx5KiBRTmV0d29ya1JlcGx5SGFuZGxlcjo6cmVsZWFzZSgpCkBAIC0xODgs NiArMTg4LDcgQEAgUU5ldHdvcmtSZXBseSogUU5ldHdvcmtSZXBseUhhbmRsZXI6OnJlbAogICAg ICAgICAvLyBwb3N0ZWQgbWV0YSBjYWxsIGV2ZW50cyB0aGF0IHdlcmUgdGhlIHJlc3VsdCBvZiBh IHNpZ25hbCBlbWlzc2lvbgogICAgICAgICAvLyBkb24ndCByZWFjaCB0aGUgc2xvdHMgaW4gb3Vy IGluc3RhbmNlLgogICAgICAgICBRQ29yZUFwcGxpY2F0aW9uOjpyZW1vdmVQb3N0ZWRFdmVudHMo dGhpcywgUUV2ZW50OjpNZXRhQ2FsbCk7CisgICAgICAgIG1fcmVwbHktPnNldFBhcmVudCgwKTsK ICAgICAgICAgbV9yZXBseSA9IDA7CiAgICAgfQogICAgIHJldHVybiByZXBseTsK