30166 2009-10-07 07:40:48 -0700 [Qt] Get rid of useless loadFailed signal in QGraphicsWebView 2009-10-07 08:25:50 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 1 tonikitoo tonikitoo hausmann kenneth oldest_to_newest 153035 0 tonikitoo 2009-10-07 07:40:48 -0700 In QWebView we have only loadFinished(bool success), but we tried to improved that for QGraphicsWebView introducing a new loadFailed signal. This signal is now useless since error handling is being possible through somewhere else (ErrorPageExtension). we should remove this loadFailed signal from QGraphicsWebView, making it compatible to QWebView in that sense. 153036 1 40787 tonikitoo 2009-10-07 07:44:50 -0700 Created attachment 40787 (committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success 153048 2 tonikitoo 2009-10-07 08:24:54 -0700 r49245 153050 3 40787 tonikitoo 2009-10-07 08:25:50 -0700 Comment on attachment 40787 (committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success clearing r+ flag since it landed. 40787 2009-10-07 07:44:50 -0700 2009-10-07 08:25:50 -0700 (committed r49245) patch 0.1 - remove loadFailed in favor of loadFineshed + bool success 0001-2009-10-07-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 3436 tonikitoo RnJvbSAxMDM3ODUzM2ZjZDU1YTFjODgwNTcxYjQ0YmI3ZjJlYTZmOTdkMWRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogV2VkLCA3IE9jdCAyMDA5IDEwOjQyOjIzIC0wNDAwClN1YmplY3Q6IFtQQVRDSF0gMjAw OS0xMC0wNyAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgoKICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KCiAgICAgICAgW1F0XSBHZXQgcmlkIG9mIHVzZWxl c3MgbG9hZEZhaWxlZCBzaWduYWwgaW4gUUdyYXBoaWNzV2ViVmlldwogICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDE2NgoKICAgICAgICAqIEFwaS9xZ3Jh cGhpY3N3ZWJ2aWV3LmNwcDoKICAgICAgICAoUUdyYXBoaWNzV2ViVmlld1ByaXZhdGU6Ol9xX2Rv TG9hZEZpbmlzaGVkKToKICAgICAgICAqIEFwaS9xZ3JhcGhpY3N3ZWJ2aWV3Lmg6CiAgICAgICAg KiBRR1ZMYXVuY2hlci9tYWluLmNwcDoKICAgICAgICAoTWFpbldpbmRvdzo6aW5pdCk6CiAgICAg ICAgKE1haW5XaW5kb3c6OmxvYWRGaW5pc2hlZCk6Ci0tLQogV2ViS2l0L3F0L0FwaS9xZ3JhcGhp Y3N3ZWJ2aWV3LmNwcCB8ICAgIDUgKy0tLS0KIFdlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmll dy5oICAgfCAgICAzICstLQogV2ViS2l0L3F0L0NoYW5nZUxvZyAgICAgICAgICAgICAgICB8ICAg MTQgKysrKysrKysrKysrKysKIFdlYktpdC9xdC9RR1ZMYXVuY2hlci9tYWluLmNwcCAgICAgfCAg ICA0ICsrLS0KIDQgZmlsZXMgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwIGIvV2Vi S2l0L3F0L0FwaS9xZ3JhcGhpY3N3ZWJ2aWV3LmNwcAppbmRleCBhYTc2ODBmLi5jMjY3NzQ1IDEw MDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuY3BwCisrKyBiL1dlYktp dC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5jcHAKQEAgLTgzLDEwICs4Myw3IEBAIHZvaWQgUUdy YXBoaWNzV2ViVmlld1ByaXZhdGU6Ol9xX2RvTG9hZEZpbmlzaGVkKGJvb2wgc3VjY2VzcykKICAg ICBpZiAocS0+dGl0bGUoKS5pc0VtcHR5KCkpCiAgICAgICAgIGVtaXQgcS0+dXJsQ2hhbmdlZChx LT51cmwoKSk7CiAKLSAgICBpZiAoc3VjY2VzcykKLSAgICAgICAgZW1pdCBxLT5sb2FkRmluaXNo ZWQoKTsKLSAgICBlbHNlCi0gICAgICAgIGVtaXQgcS0+bG9hZEZhaWxlZCgpOworICAgIGVtaXQg cS0+bG9hZEZpbmlzaGVkKHN1Y2Nlc3MpOwogfQogCiB2b2lkIFFHcmFwaGljc1dlYlZpZXdQcml2 YXRlOjpzY3JvbGwoaW50IGR4LCBpbnQgZHksIGNvbnN0IFFSZWN0JiByZWN0VG9TY3JvbGwpCmRp ZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3FncmFwaGljc3dlYnZpZXcuaCBiL1dlYktpdC9xdC9B cGkvcWdyYXBoaWNzd2Vidmlldy5oCmluZGV4IGE4NDc4ZDguLjI2ZjczNzQgMTAwNjQ0Ci0tLSBh L1dlYktpdC9xdC9BcGkvcWdyYXBoaWNzd2Vidmlldy5oCisrKyBiL1dlYktpdC9xdC9BcGkvcWdy YXBoaWNzd2Vidmlldy5oCkBAIC05NSw4ICs5NSw3IEBAIHB1YmxpYyBRX1NMT1RTOgogCiBRX1NJ R05BTFM6CiAgICAgdm9pZCBsb2FkU3RhcnRlZCgpOwotICAgIHZvaWQgbG9hZEZpbmlzaGVkKCk7 Ci0gICAgdm9pZCBsb2FkRmFpbGVkKCk7CisgICAgdm9pZCBsb2FkRmluaXNoZWQoYm9vbCk7CiAK ICAgICB2b2lkIHByb2dyZXNzQ2hhbmdlZChxcmVhbCk7CiAgICAgdm9pZCBpbnRlcmFjdGl2aXR5 Q2hhbmdlZCgpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9D aGFuZ2VMb2cKaW5kZXggMjk4MDczNi4uY2RjMTFhNyAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0No YW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDkt MTAtMDcgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEdldCByaWQgb2YgdXNl bGVzcyBsb2FkRmFpbGVkIHNpZ25hbCBpbiBRR3JhcGhpY3NXZWJWaWV3CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDE2NgorCisgICAgICAgICogQXBp L3FncmFwaGljc3dlYnZpZXcuY3BwOgorICAgICAgICAoUUdyYXBoaWNzV2ViVmlld1ByaXZhdGU6 Ol9xX2RvTG9hZEZpbmlzaGVkKToKKyAgICAgICAgKiBBcGkvcWdyYXBoaWNzd2Vidmlldy5oOgor ICAgICAgICAqIFFHVkxhdW5jaGVyL21haW4uY3BwOgorICAgICAgICAoTWFpbldpbmRvdzo6aW5p dCk6CisgICAgICAgIChNYWluV2luZG93Ojpsb2FkRmluaXNoZWQpOgorCiAyMDA5LTEwLTA3ICBH aXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogCiAgICAgICAgIFJl dmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1FHVkxhdW5j aGVyL21haW4uY3BwIGIvV2ViS2l0L3F0L1FHVkxhdW5jaGVyL21haW4uY3BwCmluZGV4IDg0MzY0 OTcuLjFkNjdjMzUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9RR1ZMYXVuY2hlci9tYWluLmNwcAor KysgYi9XZWJLaXQvcXQvUUdWTGF1bmNoZXIvbWFpbi5jcHAKQEAgLTE3NSw3ICsxNzUsNyBAQCBw dWJsaWM6CiAKICAgICAgICAgdmlldy0+c2V0TWFpbldpZGdldChzY2VuZS0+d2ViVmlldygpKTsK IAotICAgICAgICBjb25uZWN0KHNjZW5lLT53ZWJWaWV3KCksIFNJR05BTChsb2FkRmluaXNoZWQo KSksIHRoaXMsIFNMT1QobG9hZEZpbmlzaGVkKCkpKTsKKyAgICAgICAgY29ubmVjdChzY2VuZS0+ d2ViVmlldygpLCBTSUdOQUwobG9hZEZpbmlzaGVkKGJvb2wpKSwgdGhpcywgU0xPVChsb2FkRmlu aXNoZWQoYm9vbCkpKTsKICAgICAgICAgY29ubmVjdChzY2VuZS0+d2ViVmlldygpLCBTSUdOQUwo dGl0bGVDaGFuZ2VkKGNvbnN0IFFTdHJpbmcmKSksIHRoaXMsIFNMT1Qoc2V0V2luZG93VGl0bGUo Y29uc3QgUVN0cmluZyYpKSk7CiAgICAgICAgIGNvbm5lY3Qoc2NlbmUtPndlYlZpZXcoKS0+cGFn ZSgpLCBTSUdOQUwod2luZG93Q2xvc2VSZXF1ZXN0ZWQoKSksIHRoaXMsIFNMT1QoY2xvc2UoKSkp OwogCkBAIC0yMTUsNyArMjE1LDcgQEAgcHJvdGVjdGVkIHNsb3RzOgogICAgICAgICBsb2FkKHVy bEVkaXQtPnRleHQoKSk7CiAgICAgfQogCi0gICAgdm9pZCBsb2FkRmluaXNoZWQoKQorICAgIHZv aWQgbG9hZEZpbmlzaGVkKGJvb2wpCiAgICAgewogICAgICAgICBRVXJsIHVybCA9IHNjZW5lLT53 ZWJWaWV3KCktPnVybCgpOwogICAgICAgICB1cmxFZGl0LT5zZXRUZXh0KHVybC50b1N0cmluZygp KTsKLS0gCjEuNi4wLjQKCg==