30148 2009-10-06 19:54:29 -0700 Applying h1 format to text node after HR tag fails to include first letter of text node. 2010-03-11 18:47:49 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 michaelthomas webkit-unassigned commit-queue enrica eric jparent rniwa sullivan tony oldest_to_newest 152931 0 michaelthomas 2009-10-06 19:54:29 -0700 STEPS TO REPRODUCE: 1. Go to midas demo: http://www.mozilla.org/editor/midasdemo/ 2. Enter the following HTML: '<hr>test' 3. Place the cursor after the word 'test'. 4. Select 'Heading 1' from the menu. RESULT: The heading style is applied to the entire line except the first character: <hr><h1><span class="Apple-style-span" style="font-weight: normal; font-size: medium; ">t</span>est</h1> EXPECTED: The heading style is applied to the entire line: <hr><h1>test</h1> Automated test case: http://www.plexode.com/cgi-bin/eval3.py#ht=%3Cdiv%20id%3D%22editor%22%20contenteditable%3Dtrue%3E%3Chr%3Etest%3C%2Fdiv%3E%0A&ohh=1&ohj=1&jt=var%20div%20%3D%20document.getElementById('editor')%3B%0A%0A%2F%2F%20Change%20this%20to%20select%20a%20range%0AselectRange(div.childNodes%5B1%5D%2C%204%2C%20div.childNodes%5B1%5D%2C%204)%3B%0A%0A%2F%2F%20Change%20this%20to%20run%20execCommand%0Adocument.execCommand('FormatBlock'%2C%20false%2C%20'%3Ch1%3E')%3B%0A%0Afunction%20selectRange(startNode%2C%20startOffset%2C%20endNode%2C%20endOffset)%20%7B%0A%20%20var%20sel%20%3D%20window.getSelection()%3B%0A%20%20var%20range%20%3D%20null%3B%0A%20%20try%20%7B%0A%20%20%20%20range%20%3D%20sel.getRangeAt(0)%3B%0A%20%20%7D%20catch(ex)%20%7B%0A%20%20%20%20range%20%3D%20document.createRange()%3B%0A%20%20%7D%0A%20%20range.setStart(startNode%2C%20startOffset)%3B%0A%20%20range.setEnd(endNode%2C%20endOffset)%3B%0A%20%20sel.removeAllRanges()%3B%0A%20%20sel.addRange(range)%3B%0A%7D&ojh=1&ojj=1&ms=100&oth=0&otj=0&cex=1 183035 1 tony 2010-01-20 19:16:21 -0800 The patch on bug 32131 fixes this test as well. It's another case where we call applyStyle then restore the selection incorrectly. In this case, we're off by a character so the selection no longer contains the first letter after the HR tag. 197444 2 tony 2010-03-08 21:09:04 -0800 I think this bug is now fixed, but we should add a layout test so it doesn't regress. 197789 3 50354 rniwa 2010-03-09 14:49:40 -0800 Created attachment 50354 adds a test case We could make this a js test and add more test cases. 197790 4 50354 darin 2010-03-09 14:50:52 -0800 Comment on attachment 50354 adds a test case > +This tests removing underline which is applied outside of unsplittable element. We shouldn't be removing underline. Huh? > +<p>This tests removing underline which is applied outside of unsplittable element. We shouldn't be removing underline.</p> Wrong description here. 197855 5 50364 rniwa 2010-03-09 18:52:27 -0800 Created attachment 50364 fixed the test description (In reply to comment #4) > (From update of attachment 50354 [details]) > > +<p>This tests removing underline which is applied outside of unsplittable element. We shouldn't be removing underline.</p> > > Wrong description here. Sorry, I was too careless. Fixed. 198197 6 50364 rniwa 2010-03-10 10:28:34 -0800 Comment on attachment 50364 fixed the test description Added to the commit queue. 198894 7 50364 commit-queue 2010-03-11 18:47:44 -0800 Comment on attachment 50364 fixed the test description Clearing flags on attachment: 50364 Committed r55876: <http://trac.webkit.org/changeset/55876> 198895 8 commit-queue 2010-03-11 18:47:49 -0800 All reviewed patches have been landed. Closing bug. 50354 2010-03-09 14:49:40 -0800 2010-03-09 18:52:27 -0800 adds a test case fix30148 text/plain 2289 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NzQ5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDkgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXBwbHlpbmcgaDEgZm9ybWF0IHRvIHRleHQgbm9kZSBhZnRlciBIUiB0YWcgZmFp bHMgdG8gaW5jbHVkZSBmaXJzdCBsZXR0ZXIgb2YgdGV4dCBub2RlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNDgKKworCQlUaGlzIGJ1ZyBoYXMg YmVlbiBmaXhlZCBieSBodHRwOi8vdHJhYy53ZWJraXQub3JnL2NoYW5nZXNldC81NTcwNS4KKwkJ VGhpcyBwYXRjaCBhZGRzIGEgdGVzdCBjYXNlIHRvIHByZXZlbnQgdGhlIHJlZ3Jlc3Npb24uCisK KyAgICAgICAgKiBlZGl0aW5nL3N0eWxlL2hlYWRpbmctdGV4dC1hZnRlci1oci1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc3R5bGUvaGVhZGluZy10ZXh0LWFmdGVyLWhy Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTAzLTA5ICBBbnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogTGF5b3V0 VGVzdHMvZWRpdGluZy9zdHlsZS9oZWFkaW5nLXRleHQtYWZ0ZXItaHItZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc3R5bGUvaGVhZGluZy10ZXh0LWFmdGVy LWhyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc3R5 bGUvaGVhZGluZy10ZXh0LWFmdGVyLWhyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw2IEBACitUaGlzIHRlc3RzIHJlbW92aW5nIHVuZGVybGluZSB3aGljaCBpcyBhcHBsaWVk IG91dHNpZGUgb2YgdW5zcGxpdHRhYmxlIGVsZW1lbnQuIFdlIHNob3VsZG4ndCBiZSByZW1vdmlu ZyB1bmRlcmxpbmUuCisKK3Rlc3QKKworQmVmb3JlOjxocj50ZXN0CitBZnRlcjo8aHI+PGgxPnRl c3Q8L2gxPgpJbmRleDogTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9oZWFkaW5nLXRleHQtYWZ0 ZXItaHIuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9lZGl0aW5nL3N0eWxlL2hlYWRp bmctdGV4dC1hZnRlci1oci5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZWRpdGlu Zy9zdHlsZS9oZWFkaW5nLXRleHQtYWZ0ZXItaHIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCAr MSwyNSBAQAorPGh0bWw+Cis8Ym9keT4KKzxwPlRoaXMgdGVzdHMgcmVtb3ZpbmcgdW5kZXJsaW5l IHdoaWNoIGlzIGFwcGxpZWQgb3V0c2lkZSBvZiB1bnNwbGl0dGFibGUgZWxlbWVudC4gIFdlIHNo b3VsZG4ndCBiZSByZW1vdmluZyB1bmRlcmxpbmUuPC9wPgorPGRpdiBpZD0iZSIgY29udGVudGVk aXRhYmxlPjxocj50ZXN0PC9kaXY+CisKKzx1bD4KKzxsaT5CZWZvcmU6PHNwYW4gaWQ9ImMxIj48 L3NwYW4+PC9saT4KKzxsaT5BZnRlcjo8c3BhbiBpZD0iYzIiPjwvc3Bhbj48L2xpPgorPC91bD4K KworPHNjcmlwdCB0eXBlPSJ0ZXh0L2phdmFzY3JpcHQiPgorCitpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyKQorICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKwor dmFyIGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZScpOworZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoJ2MxJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZS5pbm5lckhU TUwpKTsKKwordmFyIHMgPSB3aW5kb3cuZ2V0U2VsZWN0aW9uKCk7CitzLnNldFBvc2l0aW9uKGRv Y3VtZW50LmdldEVsZW1lbnRCeUlkKCdlJyksIDEpOworZG9jdW1lbnQuZXhlY0NvbW1hbmQoImZv cm1hdGJsb2NrIiwgZmFsc2UsICJoMSIpOworCitkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnYzIn KS5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZShlLmlubmVySFRNTCkpOworCis8 L3NjcmlwdD4K 50364 2010-03-09 18:52:27 -0800 2010-03-11 18:47:44 -0800 fixed the test description fix30148b text/plain 2182 rniwa SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU1NzQ5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDMtMDkgIFJ5b3N1a2UgTml3YSAgPHJu aXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQXBwbHlpbmcgaDEgZm9ybWF0IHRvIHRleHQgbm9kZSBhZnRlciBIUiB0YWcgZmFp bHMgdG8gaW5jbHVkZSBmaXJzdCBsZXR0ZXIgb2YgdGV4dCBub2RlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAxNDgKKworICAgICAgICBUaGlzIHBh dGNoIGFkZHMgYSB0ZXN0IGNhc2UgdG8gdGhlIGFib3ZlIGJ1Zywgd2hpY2ggaGFzIGJlZW4gZml4 ZWQgYnkKKyAgICAgICAgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTU3MDUuCisK KyAgICAgICAgKiBlZGl0aW5nL3N0eWxlL2hlYWRpbmctdGV4dC1hZnRlci1oci1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvc3R5bGUvaGVhZGluZy10ZXh0LWFmdGVyLWhy Lmh0bWw6IEFkZGVkLgorCiAyMDEwLTAzLTA5ICBBbnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogTGF5b3V0 VGVzdHMvZWRpdGluZy9zdHlsZS9oZWFkaW5nLXRleHQtYWZ0ZXItaHItZXhwZWN0ZWQudHh0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2VkaXRpbmcvc3R5bGUvaGVhZGluZy10ZXh0LWFmdGVy LWhyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc3R5 bGUvaGVhZGluZy10ZXh0LWFmdGVyLWhyLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw2IEBACitUaGlzIHRlc3RzIGZvcm1hdHRpbmcgYSB0ZXh0IGltbWVkaWF0ZWx5IGFmdGVy IGhyIHdpdGggaDEgdGFnLgorCit0ZXN0CisKK0JlZm9yZTo8aHI+dGVzdAorQWZ0ZXI6PGhyPjxo MT50ZXN0PC9oMT4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcvc3R5bGUvaGVhZGluZy10ZXh0 LWFmdGVyLWhyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZWRpdGluZy9zdHlsZS9o ZWFkaW5nLXRleHQtYWZ0ZXItaHIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Vk aXRpbmcvc3R5bGUvaGVhZGluZy10ZXh0LWFmdGVyLWhyLmh0bWwJKHJldmlzaW9uIDApCkBAIC0w LDAgKzEsMjUgQEAKKzxodG1sPgorPGJvZHk+Cis8cD5UaGlzIHRlc3RzIGZvcm1hdHRpbmcgYSB0 ZXh0IGltbWVkaWF0ZWx5IGFmdGVyIGhyIHdpdGggaDEgdGFnLjwvcD4KKzxkaXYgaWQ9ImUiIGNv bnRlbnRlZGl0YWJsZT48aHI+dGVzdDwvZGl2PgorCis8dWw+Cis8bGk+QmVmb3JlOjxzcGFuIGlk PSJjMSI+PC9zcGFuPjwvbGk+Cis8bGk+QWZ0ZXI6PHNwYW4gaWQ9ImMyIj48L3NwYW4+PC9saT4K KzwvdWw+CisKKzxzY3JpcHQgdHlwZT0idGV4dC9qYXZhc2NyaXB0Ij4KKworaWYgKHdpbmRvdy5s YXlvdXRUZXN0Q29udHJvbGxlcikKKyAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0 KCk7CisKK3ZhciBlID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2UnKTsKK2RvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCdjMScpLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKGUu aW5uZXJIVE1MKSk7CisKK3ZhciBzID0gd2luZG93LmdldFNlbGVjdGlvbigpOworcy5zZXRQb3Np dGlvbihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnZScpLCAxKTsKK2RvY3VtZW50LmV4ZWNDb21t YW5kKCJmb3JtYXRibG9jayIsIGZhbHNlLCAiaDEiKTsKKworZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoJ2MyJykuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUoZS5pbm5lckhUTUwp KTsKKworPC9zY3JpcHQ+Cg==