301388 2025-10-23 17:42:56 -0700 [ews-build] DetermineLandedIdentifier should support Canonical-link trailer 2026-06-05 17:57:47 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gsnedders gsnedders webkit-bug-importer oldest_to_newest 2153879 0 gsnedders 2025-10-23 17:42:56 -0700 As part of bug 266028, we need to migrate everything to supporting actual git trailers. On EWS, we have: ``` Tools/CISupport/ews-build/steps.py 6314: command = ['/bin/bash', '--posix', '-o', 'pipefail', '-c', "git log -1 --no-decorate | grep 'Canonical link: https://commits\\.webkit\\.org/'"] 6315: CANONICAL_LINK_RE = re.compile(r'\ACanonical link: https://commits\.webkit\.org/(?P<identifier>\d+.?\d*@\S+)\Z') 6341: match = self.CANONICAL_LINK_RE.match(line[4:]) ``` (Plus associated, currently disabled, unit tests.) We probably want to run something more like the following, and change the regex to include a hyphen: ``` git log --format=%B -1 | \ sed -e 's/Canonical link:/Canonical-link:/' | \ git -c trailer.Canonical-link.key=Canonical-link -c trailer.Identifier.key=Identifier -c trailer.git-svn-id.key=git-svn-id interpret-trailers --parse --no-divider ``` We need to specify the trailer.xxx.key config options because: > Existing trailers are extracted from the input message by looking for a group of one or more lines that (i) is all trailers, or (ii) contains at least one Git-generated or user-configured trailer and consists of at least 25% trailers. And we have plenty of groups which aren't all trailers in WebKit. 2153880 1 webkit-bug-importer 2025-10-23 17:43:02 -0700 <rdar://problem/163304249> 2209914 2 gsnedders 2026-05-11 17:07:10 -0700 Pull request: https://github.com/WebKit/WebKit/pull/64715 2218199 3 ews-feeder 2026-06-05 17:57:45 -0700 Committed 314674@main (4e8d725445b3): <https://commits.webkit.org/314674@main> Reviewed commits have been landed. Closing PR #64715 and removing active labels.