301089 2025-10-20 05:35:34 -0700 [GTK][WPE] Add WebKitImage utility class to the public API 2025-11-07 05:35:39 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 301086 1 aperez spena bugs-noreply jmurphy mcatanzaro oldest_to_newest 2152555 0 aperez 2025-10-20 05:35:34 -0700 The goal is to use it as representation of site icons (favicons) and WebExtension icons. Here's the list of requirements, extracted from bug #301086: - It least it needs to allow querying width, height, stride, and provide a method to obtain a GBytes wrapping a buffer with 32bpp RGBA/BGRA pixels. - Implementing the GIcon and GLoadableIcon interfaces would be desirable. - For the GTK port, it may have a method to obtain a GdkTexture out of it, for the sake of convenience (optional?). - Provide a nullable “url” property which may be filled with the URL from which the image was loaded (doubtful: would it better belong in a WebKitFavicon subclass?) 2152582 1 jmurphy 2025-10-20 08:36:37 -0700 One thing I'd like to see if possible would be the ability to scale an image, as the WebExtensions code does have the capability of resizing an image to fit a better screen size. Implementing GIcon would be desirable, yes, and WebExtensions already uses GIcon so this makes it easier on the API side to port. I don't think the "url" property would be super useful for the overall class, it should be added to a sublcass. While extensions do have a concept of a URL that the image could be loaded from, it doesn't really make sense to expose that unless the extension itself wants to. 2152586 2 mcatanzaro 2025-10-20 09:05:08 -0700 Subclasses are complex, though. If it's really useful to have subclasses, then OK. But otherwise we should avoid it. 2152587 3 jmurphy 2025-10-20 09:08:13 -0700 I don't think the property is useful for WebExtensions usage, but if it's more difficult to use a subclass, we could include it and just document that it's not used with WebExtensions 2153131 4 spena 2025-10-21 14:55:33 -0700 Pull request: https://github.com/WebKit/WebKit/pull/52767 2156711 5 aperez 2025-11-05 13:46:57 -0800 Pull request: https://github.com/WebKit/WebKit/pull/53480 2157237 6 ews-feeder 2025-11-07 05:35:36 -0800 Committed 302720@main (f53dba1d3a1d): <https://commits.webkit.org/302720@main> Reviewed commits have been landed. Closing PR #52767 and removing active labels.