301088 2025-10-20 05:32:29 -0700 [GLib] Make IconDatabase handle multiple per-page icons 2025-11-02 03:31:37 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=301822 P2 Normal --- 301359 301086 301624 1 aperez aperez bugs-noreply oldest_to_newest 2152552 0 aperez 2025-10-20 05:32:29 -0700 In Source/WebKit/UIProcess/API/glib/IconDatabase.{h,cpp} we would need to: - Store multiple entries per page in IconDatabase::m_pageURLToIconURLMap - IconDatabase::iconURLForPageURL() method may return multiple URLs. - IconDatabase::loadIconsForPageURL() may load and pass multiple items to the completion handler. - IconDatabase::setIconForPageURL() ideally would update all page icons in a single shot, instead of one-by-one incrementally. - IconDatabase::checkIconURLAndSetPageURLIfNeeded(): Ditto. 2154945 1 aperez 2025-10-29 02:58:41 -0700 Pull request: https://github.com/WebKit/WebKit/pull/53135 2154947 2 aperez 2025-10-29 03:15:04 -0700 (In reply to Adrian Perez from comment #1) > Pull request: https://github.com/WebKit/WebKit/pull/53135 This patch tackles items 1-2-3 above, updating all the icons in one-shot, to avoid setting the WebKitWebView::favicon property multiple time IMO it will be better done in a separate patch because it needs to touch IPC code and add a mechanism in the IconDatabase (or WebKitFaviconDatabase, not sure yet what's the best place) to track a set of icons to load and setting properties only once all of them have been provided, either by the FrameLoader, or lifting them from the cached versions (from the database, or the in-memory cache). 2155060 3 ews-feeder 2025-10-29 13:05:05 -0700 Committed 302307@main (a388e15a5725): <https://commits.webkit.org/302307@main> Reviewed commits have been landed. Closing PR #53135 and removing active labels.