301083 2025-10-20 05:03:59 -0700 ☂️ [META][CMake] Finish migrating find-modules to use imported targets 2026-01-26 00:15:19 -0800 1 1 1 Unclassified WebKit CMake WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 302580 302581 302824 302846 302860 306028 306097 1 aperez bugs-noreply oldest_to_newest 2152543 0 aperez 2025-10-20 05:03:59 -0700 We have been slowly improving the find-modules (Source/cmake/Find*.cmake) to use imported targets. It should be possible to give the task a final push and have the pending modules updated as well. As of 2025/10/20 the pending ones are: - Source/cmake/FindATK.cmake - Source/cmake/FindATSPI.cmake - Source/cmake/FindEGL.cmake * - Source/cmake/FindEnchant.cmake - Source/cmake/FindFlite.cmake *** - Source/cmake/FindGStreamer.cmake *** - Source/cmake/FindHyphen.cmake - Source/cmake/FindLibsecret.cmake - Source/cmake/FindLibtasn1.cmake - Source/cmake/FindLibxkbcommon.cmake - Source/cmake/FindThunder.cmake * - Source/cmake/FindWayland.cmake ** The asterisks above mean: *) Might be tricky to test that it works in all possible build configurations, and/or in embedded devices. **) Medium complexity, the updated module would have have an imported target for each component. ***) Complex, on top of needed targets for each component, it has many components to handle. So at least the unmarked ones should be low-hanging fruit. 2175036 1 aperez 2026-01-26 00:15:19 -0800 List of modules pending to migrate, as of 2026-01-26: - Source/cmake/FindEGL.cmake * - Source/cmake/FindFlite.cmake *** - Source/cmake/FindGStreamer.cmake *** - Source/cmake/FindThunder.cmake * - Source/cmake/FindWayland.cmake **