30108 2009-10-05 21:48:50 -0700 accessibility/media-element.html crashes 2009-10-06 21:33:15 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser eric.carlson pdherbemont oldest_to_newest 152574 0 simon.fraser 2009-10-05 21:48:50 -0700 Crash here: Thread 0 Crashed: Dispatch queue: com.apple.main-thread 0 com.apple.WebKit 0x000000010077eae7 -[WebViewFactory localizedMediaControlElementString:] + 1120 (WebViewFactory.mm:683) 1 com.apple.WebCore 0x0000000101235a30 WebCore::localizedMediaControlElementString(WebCore::String const&) + 79 (LocalizedStringsMac.mm:729) 2 com.apple.WebCore 0x0000000100b525a2 WebCore::AccessibilityMediaControl::accessibilityDescription() const + 46 (AccessibilityMediaControls.cpp:159) 3 com.apple.WebCore 0x0000000100b60ebf -[AccessibilityObjectWrapper accessibilityAttributeValue:] + 4708 (AccessibilityObjectWrapper.mm:1357) 4 DumpRenderTree 0x00000001000057cd AccessibilityUIElement::description() + 49 (AccessibilityUIElementMac.mm:328) Need to add strings for the fullscreen button. 152846 1 40739 simon.fraser 2009-10-06 13:30:04 -0700 Created attachment 40739 Patch 152849 2 40739 mrowe 2009-10-06 13:42:30 -0700 Comment on attachment 40739 Patch I made some minor comments on IRC. r=me 152943 3 simon.fraser 2009-10-06 21:33:15 -0700 http://trac.webkit.org/changeset/49206 40739 2009-10-06 13:30:04 -0700 2009-10-06 13:42:30 -0700 Patch 30108_patch.txt text/plain 5333 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBhMTFhMWY2Li4wYTM2NDdiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTAt MDYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBhY2Nlc3NpYmlsaXR5 L21lZGlhLWVsZW1lbnQuaHRtbCBjcmFzaGVzIChhbmQgaGFzIGluY29ycmVjdCByZXN1bHQpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDEwOAorCisg ICAgICAgIEZpeCB1cCB0aGUgYWNjZXNzaWJpbHR5IGxhYmVsIGZvciB0aGUgbmV3bHkgYWRkZWQg ZnVsbHNjcmVlbiBidXR0b24sCisgICAgICAgIGFuZCB1cGRhdGUgdGhlIHRlc3QgcmVzdWx0IGFj Y29yZGluZ2x5LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvbWVkaWEt ZWxlbWVudC1leHBlY3RlZC50eHQ6CisKIDIwMDktMTAtMDYgIERhdmUgSHlhdHQgIDxoeWF0dEBh cHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBSb2Jlbi4KZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L21lZGlhLWVsZW1lbnQtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvbWVkaWEt ZWxlbWVudC1leHBlY3RlZC50eHQKaW5kZXggN2VhY2ZiYS4uZjg1Zjc2OSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvbWVkaWEtZWxlbWVudC1leHBl Y3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvbWVk aWEtZWxlbWVudC1leHBlY3RlZC50eHQKQEAgLTMyLDYgKzMyLDEwIEBAIFN0YXRlIGF0ICdsb2Fk JyBldmVudDoKICAgICAgICAgcm9sZTogQVhSb2xlOiBBWFN0YXRpY1RleHQKIAogCisgICAgICAg IGRlc2NyaXB0aW9uOiBBWERlc2NyaXB0aW9uOiBmdWxsc2NyZWVuCisgICAgICAgIHJvbGU6IEFY Um9sZTogQVhCdXR0b24KKworCiAgICAgICAgIGRlc2NyaXB0aW9uOiBBWERlc2NyaXB0aW9uOiBt dXRlCiAgICAgICAgIHJvbGU6IEFYUm9sZTogQVhCdXR0b24KIApkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA0MGUxZTA3Li45ZWRhODY2IDEw MDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE2IEBACisyMDA5LTEwLTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGFjY2Vzc2liaWxpdHkvbWVkaWEtZWxlbWVudC5odG1sIGNyYXNoZXMgKGFuZCBoYXMgaW5jb3Jy ZWN0IHJlc3VsdCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwMTA4CisKKyAgICAgICAgRml4IHVwIHRoZSBhY2Nlc3NpYmlsdHkgbGFiZWwgZm9yIHRo ZSBuZXdseSBhZGRlZCBmdWxsc2NyZWVuIGJ1dHRvbiwKKyAgICAgICAgYW5kIHVwZGF0ZSB0aGUg dGVzdCByZXN1bHQgYWNjb3JkaW5nbHkuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L0FjY2Vz c2liaWxpdHlNZWRpYUNvbnRyb2xzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlNZWRpYUNvbnRyb2w6OmNvbnRyb2xUeXBlTmFtZSk6CisKIDIwMDktMTAtMDYgIENhcm9sIFN6 YWJvICA8Y2Fyb2wuc3phYm9Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFyaXlh IEhpZGF5YXQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU1lZGlhQ29udHJvbHMuY3BwIGIvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlN ZWRpYUNvbnRyb2xzLmNwcAppbmRleCBhODA3YWI5Li43MjAwZGU5IDEwMDY0NAotLS0gYS9XZWJD b3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU1lZGlhQ29udHJvbHMuY3BwCisrKyBiL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5TWVkaWFDb250cm9scy5jcHAKQEAgLTEw MSw2ICsxMDEsNyBAQCBNZWRpYUNvbnRyb2xFbGVtZW50VHlwZSBBY2Nlc3NpYmlsaXR5TWVkaWFD b250cm9sOjpjb250cm9sVHlwZSgpIGNvbnN0CiAKIFN0cmluZyBBY2Nlc3NpYmlsaXR5TWVkaWFD b250cm9sOjpjb250cm9sVHlwZU5hbWUoKSBjb25zdAogeworICAgIERFRklORV9TVEFUSUNfTE9D QUwoY29uc3QgU3RyaW5nLCBtZWRpYUZ1bGxzY3JlZW5CdXR0b25OYW1lLCAoIkZ1bGxzY3JlZW5C dXR0b24iKSk7CiAgICAgREVGSU5FX1NUQVRJQ19MT0NBTChjb25zdCBTdHJpbmcsIG1lZGlhTXV0 ZUJ1dHRvbk5hbWUsICgiTXV0ZUJ1dHRvbiIpKTsKICAgICBERUZJTkVfU1RBVElDX0xPQ0FMKGNv bnN0IFN0cmluZywgbWVkaWFQbGF5QnV0dG9uTmFtZSwgKCJQbGF5QnV0dG9uIikpOwogICAgIERF RklORV9TVEFUSUNfTE9DQUwoY29uc3QgU3RyaW5nLCBtZWRpYVNlZWtCYWNrQnV0dG9uTmFtZSwg KCJTZWVrQmFja0J1dHRvbiIpKTsKQEAgLTExNCw2ICsxMTUsOCBAQCBTdHJpbmcgQWNjZXNzaWJp bGl0eU1lZGlhQ29udHJvbDo6Y29udHJvbFR5cGVOYW1lKCkgY29uc3QKICAgICBERUZJTkVfU1RB VElDX0xPQ0FMKGNvbnN0IFN0cmluZywgbWVkaWFUaW1lUmVtYWluaW5nRGlzcGxheSwgKCJUaW1l UmVtYWluaW5nRGlzcGxheSIpKTsKIAogICAgIHN3aXRjaCAoY29udHJvbFR5cGUoKSkgeworICAg IGNhc2UgTWVkaWFGdWxsc2NyZWVuQnV0dG9uOgorICAgICAgICByZXR1cm4gbWVkaWFGdWxsc2Ny ZWVuQnV0dG9uTmFtZTsKICAgICBjYXNlIE1lZGlhTXV0ZUJ1dHRvbjoKICAgICAgICAgcmV0dXJu IG1lZGlhTXV0ZUJ1dHRvbk5hbWU7CiAgICAgY2FzZSBNZWRpYVBsYXlCdXR0b246CmRpZmYgLS1n aXQgYS9XZWJLaXQvQ2hhbmdlTG9nIGIvV2ViS2l0L0NoYW5nZUxvZwppbmRleCA2NmIzMjEzLi5l ZjdhYTlmIDEwMDY0NAotLS0gYS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0wNiAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJh c2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBhY2Nlc3NpYmlsaXR5L21lZGlhLWVsZW1lbnQuaHRtbCBjcmFzaGVzIChhbmQgaGFz IGluY29ycmVjdCByZXN1bHQpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMDEwOAorCisgICAgICAgIEZpeCB1cCB0aGUgYWNjZXNzaWJpbHR5IGxhYmVs IGZvciB0aGUgbmV3bHkgYWRkZWQgZnVsbHNjcmVlbiBidXR0b24sCisgICAgICAgIGFuZCB1cGRh dGUgdGhlIHRlc3QgcmVzdWx0IGFjY29yZGluZ2x5LgorCisgICAgICAgICogRW5nbGlzaC5scHJv ai9Mb2NhbGl6YWJsZS5zdHJpbmdzOgorCiAyMDA5LTEwLTA1ICBLZXZpbiBEZWNrZXIgIDxrZGVj a2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZm IC0tZ2l0IGEvV2ViS2l0L0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUuc3RyaW5ncyBiL1dlYktp dC9FbmdsaXNoLmxwcm9qL0xvY2FsaXphYmxlLnN0cmluZ3MKaW5kZXggNzRmYzMyNy4uZTRhMTcy YiAxMDA2NDQKQmluYXJ5IGZpbGVzIGEvV2ViS2l0L0VuZ2xpc2gubHByb2ovTG9jYWxpemFibGUu c3RyaW5ncyBhbmQgYi9XZWJLaXQvRW5nbGlzaC5scHJvai9Mb2NhbGl6YWJsZS5zdHJpbmdzIGRp ZmZlcgpkaWZmIC0tZ2l0IGEvV2ViS2l0L21hYy9DaGFuZ2VMb2cgYi9XZWJLaXQvbWFjL0NoYW5n ZUxvZwppbmRleCA5MzdlZThjLi5kYmI0NTQxIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL0NoYW5n ZUxvZworKysgYi9XZWJLaXQvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDA5LTEw LTA2ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGFjY2Vzc2liaWxpdHkvbWVkaWEt ZWxlbWVudC5odG1sIGNyYXNoZXMgKGFuZCBoYXMgaW5jb3JyZWN0IHJlc3VsdCkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMTA4CisKKyAgICAgICAg Rml4IHVwIHRoZSBhY2Nlc3NpYmlsdHkgbGFiZWwgZm9yIHRoZSBuZXdseSBhZGRlZCBmdWxsc2Ny ZWVuIGJ1dHRvbiwKKyAgICAgICAgYW5kIHVwZGF0ZSB0aGUgdGVzdCByZXN1bHQgYWNjb3JkaW5n bHkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJWaWV3RmFjdG9yeS5tbToKKyAgICAg ICAgKC1bV2ViVmlld0ZhY3RvcnkgbG9jYWxpemVkTWVkaWFDb250cm9sRWxlbWVudFN0cmluZzpd KToKKwogMjAwOS0xMC0wNiAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4K IAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1naXQgYS9XZWJL aXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlZpZXdGYWN0b3J5Lm1tIGIvV2ViS2l0L21hYy9XZWJD b3JlU3VwcG9ydC9XZWJWaWV3RmFjdG9yeS5tbQppbmRleCAwNDgxNmQzLi4yNGY3ZjIyIDEwMDY0 NAotLS0gYS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYlZpZXdGYWN0b3J5Lm1tCisrKyBi L1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViVmlld0ZhY3RvcnkubW0KQEAgLTY1Miw2ICs2 NTIsOSBAQAogICAgIGlmIChbbmFtZSBpc0VxdWFsVG9TdHJpbmc6QCJWaWRlb0VsZW1lbnQiXSkK ICAgICAgICAgcmV0dXJuIFVJX1NUUklORygidmlkZW8gZWxlbWVudCBjb250cm9sbGVyIiwgImFj Y2Vzc2liaWxpdHkgcm9sZSBkZXNjcmlwdGlvbiBmb3IgdmlkZW8gZWxlbWVudCBjb250cm9sbGVy Iik7CiAKKyAgICBpZiAoW25hbWUgaXNFcXVhbFRvU3RyaW5nOkAiQ29udHJvbHNQYW5lbCJdKQor ICAgICAgICByZXR1cm4gQCIiOworCiAgICAgaWYgKFtuYW1lIGlzRXF1YWxUb1N0cmluZzpAIk11 dGVCdXR0b24iXSkKICAgICAgICAgcmV0dXJuIFVJX1NUUklORygibXV0ZSIsICJhY2Nlc3NpYmls aXR5IHJvbGUgZGVzY3JpcHRpb24gZm9yIG11dGUgYnV0dG9uIik7CiAgICAgaWYgKFtuYW1lIGlz RXF1YWxUb1N0cmluZzpAIlVuTXV0ZUJ1dHRvbiJdKQo=