30100 2009-10-05 15:49:58 -0700 1-char fix for obviously reverse condition. 2009-10-05 17:07:17 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 dimich webkit-unassigned oldest_to_newest 152497 0 dimich 2009-10-05 15:49:58 -0700 the patch is forthcoming. 152498 1 40669 dimich 2009-10-05 15:54:09 -0700 Created attachment 40669 Proposed fix. 152500 2 40669 darin 2009-10-05 15:56:42 -0700 Comment on attachment 40669 Proposed fix. It would be even better if we had some test that was failing because of this backward code. This was harmless. Why? r=me 152508 3 dimich 2009-10-05 16:03:41 -0700 the only place it was called from was destructor of ScriptCachedFramedata - so the RetainedPtr was destructed anyways and a window was released. The only difference was that gcController().garbageCollectSoon(); was not invoked, as WebKit usually tries to do after releasing a DOMWindow. 152518 4 dimich 2009-10-05 16:36:58 -0700 sorry, should be 'after releasing JSDOMWindow'. 152525 5 dimich 2009-10-05 17:07:17 -0700 landed: http://trac.webkit.org/changeset/49134 40669 2009-10-05 15:54:09 -0700 2009-10-05 15:56:42 -0700 Proposed fix. patch.txt text/plain 1032 dimich ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGI5MGFhYy4uN2Q3NzBlMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0wNSAgRG1pdHJ5IFRpdG92 ICA8ZGltaWNoQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAxLWNoYXIgZml4IGZvciBvYnZpb3VzbHkgcmV2ZXJzZSBjb25kaXRp b24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDEw MAorCisgICAgICAgICogYmluZGluZ3MvanMvU2NyaXB0Q2FjaGVkRnJhbWVEYXRhLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlNjcmlwdENhY2hlZEZyYW1lRGF0YTo6Y2xlYXIpOiBSZXZlcnQgY29u ZGl0aW9uLiBBbG1vc3QgYSB0eXBvLgorCiAyMDA5LTA5LTIyICBEdW1pdHJ1IERhbmlsaXVjICA8 ZHVtaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292 LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWNoZWRGcmFtZURhdGEu Y3BwIGIvV2ViQ29yZS9iaW5kaW5ncy9qcy9TY3JpcHRDYWNoZWRGcmFtZURhdGEuY3BwCmluZGV4 IDg4NTI2MTEuLjc3YjhjYTQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0 Q2FjaGVkRnJhbWVEYXRhLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL2pzL1NjcmlwdENhY2hl ZEZyYW1lRGF0YS5jcHAKQEAgLTg2LDcgKzg2LDcgQEAgdm9pZCBTY3JpcHRDYWNoZWRGcmFtZURh dGE6OmNsZWFyKCkKIHsKICAgICBKU0xvY2sgbG9jayhTaWxlbmNlQXNzZXJ0aW9uc09ubHkpOwog Ci0gICAgaWYgKCFtX3dpbmRvdykgeworICAgIGlmIChtX3dpbmRvdykgewogICAgICAgICBtX3dp bmRvdyA9IDA7CiAgICAgICAgIGdjQ29udHJvbGxlcigpLmdhcmJhZ2VDb2xsZWN0U29vbigpOwog ICAgIH0K