30094 2009-10-05 13:51:00 -0700 Incorrect forward declaration of 'struct FrameLoadRequest' as 'class FrameLoadRequest' leads to compile warnings 2009-10-05 21:17:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jamesr webkit-unassigned abarth commit-queue darin eric jparent oldest_to_newest 152439 0 jamesr 2009-10-05 13:51:00 -0700 Summary says it all. 152440 1 40658 jamesr 2009-10-05 13:53:05 -0700 Created attachment 40658 Patch to fix decl 152450 2 40658 commit-queue 2009-10-05 14:17:35 -0700 Comment on attachment 40658 Patch to fix decl Rejecting patch 40658 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html 152455 3 40661 jamesr 2009-10-05 14:28:41 -0700 Created attachment 40661 Patch including ChangeLog entry 152456 4 40661 eric 2009-10-05 14:31:01 -0700 Comment on attachment 40661 Patch including ChangeLog entry LGTM. I'm assuming you meant cq? as well. (Sadly bugzilla-tool post-diff has no --commit-queue option yet. bug 29202.) 152458 5 darin 2009-10-05 14:32:07 -0700 The struct one should go down in the next paragraph with the other struct rather than in the class paragraph. 152462 6 40661 commit-queue 2009-10-05 14:36:17 -0700 Comment on attachment 40661 Patch including ChangeLog entry Rejecting patch 40661 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11378 test cases. fast/dom/prototype-inheritance.html -> failed Exiting early after 1 failures. 5487 tests run. 95.67s total testing time 5486 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output 152464 7 40663 jamesr 2009-10-05 14:39:26 -0700 Created attachment 40663 Moves the decl down with the other 'struct ...' declaration 152478 8 eric 2009-10-05 14:57:27 -0700 Sorry, the bots were behind. They were showing green but the build was actually red. Hence the invalid rejection. I'll file a bug about the commit-queue not noticing that hte bots were behind. 152484 9 eric 2009-10-05 15:02:22 -0700 False rejection was caused by bug 30098. 152499 10 40663 commit-queue 2009-10-05 15:54:39 -0700 Comment on attachment 40663 Moves the decl down with the other 'struct ...' declaration Rejecting patch 40663 from commit-queue. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/loader/RedirectScheduler.h A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/libexec/git-core//git-svn line 469 152501 11 darin 2009-10-05 15:57:24 -0700 Need to remove the "No new tests (OOPS)" line from the change log. 152503 12 40670 jamesr 2009-10-05 16:00:28 -0700 Created attachment 40670 Removes "No new tests (OOPS) line from ChangeLog" 152526 13 40670 commit-queue 2009-10-05 17:27:20 -0700 Comment on attachment 40670 Removes "No new tests (OOPS) line from ChangeLog" Rejecting patch 40670 from commit-queue. Failed to run "WebKitTools/Scripts/build-webkit" exit_code: 1 Last 500 characters of output: rivedSources/WebCore/JSCanvasRenderingContext3D.cpp -o /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/JSCanvasRenderingContext3D.o ** BUILD FAILED ** The following build commands failed: WebCore: Distributed-CompileC /Users/eseidel/Projects/build/WebCore.build/Release/WebCore.build/Objects-normal/i386/RenderThemeMac.o /Users/eseidel/Projects/CommitQueue/WebCore/rendering/RenderThemeMac.mm normal i386 objective-c++ com.apple.compilers.gcc.4_2 (1 failure) 152556 14 40670 eric 2009-10-05 21:01:15 -0700 Comment on attachment 40670 Removes "No new tests (OOPS) line from ChangeLog" The commit-queue has landed nearly 400 patches by now, and this is the first time I've seen false failures like these. So either this is a real failure caused by this patch, or you've hit bug 30098 twice (I saw bug 30098 for the first time today!). Not sure yet. Either way, my apologies for the inconvenience. 152560 15 40670 commit-queue 2009-10-05 21:12:49 -0700 Comment on attachment 40670 Removes "No new tests (OOPS) line from ChangeLog" Clearing flags on attachment: 40670 Committed r49144: <http://trac.webkit.org/changeset/49144> 152561 16 commit-queue 2009-10-05 21:12:53 -0700 All reviewed patches have been landed. Closing bug. 152562 17 abarth 2009-10-05 21:17:02 -0700 Thanks! I was just abou to fix this. ;) 40658 2009-10-05 13:53:05 -0700 2009-10-05 14:28:41 -0700 Patch to fix decl patch.diff text/plain 766 jamesr MjAwOS0xMC0wNSAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAZ29vZ2xlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggZm9yd2FyZCBkZWNs YXJhdGlvbiAoc3RydWN0IHZzIGNsYXNzIG1pc21hdGNoKQorCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDA5NAorCisgICAgICAgIE5vIG5ldyB0ZXN0 cy4gKE9PUFMhKQorCisgICAgICAgICogbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmg6CisKIDIw MDktMTAtMDUgIEtldmluIERlY2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1 YmJlcnN0YW1wZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2Fk ZXIvUmVkaXJlY3RTY2hlZHVsZXIuaCBiL1dlYkNvcmUvbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVy LmgKaW5kZXggMTFhYWIxMC4uMDM0NjQxNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvUmVk aXJlY3RTY2hlZHVsZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9SZWRpcmVjdFNjaGVkdWxlci5o CkBAIC00MSw3ICs0MSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEZvcm1T dGF0ZTsKICAgICBjbGFzcyBGcmFtZTsKLSAgICBjbGFzcyBGcmFtZUxvYWRSZXF1ZXN0OworICAg IHN0cnVjdCBGcmFtZUxvYWRSZXF1ZXN0OwogICAgIGNsYXNzIFN0cmluZzsKIAogICAgIHN0cnVj dCBTY2hlZHVsZWRSZWRpcmVjdGlvbjsKCg== 40661 2009-10-05 14:28:41 -0700 2009-10-05 14:39:26 -0700 Patch including ChangeLog entry patch.diff text/plain 912 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWFiNWUzZS4uMDdkNzY3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0wNSAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggZm9yd2FyZCBkZWNsYXJhdGlvbiAoc3RydWN0IHZzIGNsYXNz IG1pc21hdGNoKQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDA5NAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICog bG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmg6CisKIDIwMDktMTAtMDUgIEtldmluIERlY2tlciAg PGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlcnN0YW1wZWQgYnkgQW5kZXJzIENh cmxzc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIuaCBi L1dlYkNvcmUvbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmgKaW5kZXggMTFhYWIxMC4uMDM0NjQx NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIuaAorKysgYi9X ZWJDb3JlL2xvYWRlci9SZWRpcmVjdFNjaGVkdWxlci5oCkBAIC00MSw3ICs0MSw3IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEZvcm1TdGF0ZTsKICAgICBjbGFzcyBGcmFtZTsK LSAgICBjbGFzcyBGcmFtZUxvYWRSZXF1ZXN0OworICAgIHN0cnVjdCBGcmFtZUxvYWRSZXF1ZXN0 OwogICAgIGNsYXNzIFN0cmluZzsKIAogICAgIHN0cnVjdCBTY2hlZHVsZWRSZWRpcmVjdGlvbjsK 40663 2009-10-05 14:39:26 -0700 2009-10-05 16:00:28 -0700 Moves the decl down with the other 'struct ...' declaration patch.diff text/plain 966 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWFiNWUzZS4uMDdkNzY3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMC0wNSAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggZm9yd2FyZCBkZWNsYXJhdGlvbiAoc3RydWN0IHZzIGNsYXNz IG1pc21hdGNoKQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDA5NAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gKE9PUFMhKQorCisgICAgICAgICog bG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmg6CisKIDIwMDktMTAtMDUgIEtldmluIERlY2tlciAg PGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1YmJlcnN0YW1wZWQgYnkgQW5kZXJzIENh cmxzc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIuaCBi L1dlYkNvcmUvbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmgKaW5kZXggMTFhYWIxMC4uYmYwNzZk NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvUmVkaXJlY3RTY2hlZHVsZXIuaAorKysgYi9X ZWJDb3JlL2xvYWRlci9SZWRpcmVjdFNjaGVkdWxlci5oCkBAIC00MSw5ICs0MSw5IEBAIG5hbWVz cGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEZvcm1TdGF0ZTsKICAgICBjbGFzcyBGcmFtZTsK LSAgICBjbGFzcyBGcmFtZUxvYWRSZXF1ZXN0OwogICAgIGNsYXNzIFN0cmluZzsKIAorICAgIHN0 cnVjdCBGcmFtZUxvYWRSZXF1ZXN0OwogICAgIHN0cnVjdCBTY2hlZHVsZWRSZWRpcmVjdGlvbjsK IAogICAgIGNsYXNzIFJlZGlyZWN0U2NoZWR1bGVyIDogcHVibGljIE5vbmNvcHlhYmxlIHsK 40670 2009-10-05 16:00:28 -0700 2009-10-05 21:12:49 -0700 Removes "No new tests (OOPS) line from ChangeLog" patch.diff text/plain 933 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OWFiNWUzZS4uZmMxYWZhYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0wNSAgSmFtZXMgUm9iaW5z b24gIDxqYW1lc3JAZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggZm9yd2FyZCBkZWNsYXJhdGlvbiAoc3RydWN0IHZzIGNsYXNz IG1pc21hdGNoKQorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zMDA5NAorCisgICAgICAgICogbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVyLmg6CisKIDIw MDktMTAtMDUgIEtldmluIERlY2tlciAgPGtkZWNrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJ1 YmJlcnN0YW1wZWQgYnkgQW5kZXJzIENhcmxzc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9sb2Fk ZXIvUmVkaXJlY3RTY2hlZHVsZXIuaCBiL1dlYkNvcmUvbG9hZGVyL1JlZGlyZWN0U2NoZWR1bGVy LmgKaW5kZXggMTFhYWIxMC4uYmYwNzZkNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9sb2FkZXIvUmVk aXJlY3RTY2hlZHVsZXIuaAorKysgYi9XZWJDb3JlL2xvYWRlci9SZWRpcmVjdFNjaGVkdWxlci5o CkBAIC00MSw5ICs0MSw5IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIGNsYXNzIEZvcm1T dGF0ZTsKICAgICBjbGFzcyBGcmFtZTsKLSAgICBjbGFzcyBGcmFtZUxvYWRSZXF1ZXN0OwogICAg IGNsYXNzIFN0cmluZzsKIAorICAgIHN0cnVjdCBGcmFtZUxvYWRSZXF1ZXN0OwogICAgIHN0cnVj dCBTY2hlZHVsZWRSZWRpcmVjdGlvbjsKIAogICAgIGNsYXNzIFJlZGlyZWN0U2NoZWR1bGVyIDog cHVibGljIE5vbmNvcHlhYmxlIHsK