30073 2009-10-05 07:14:27 -0700 Need to scale the canvas, not resize it on CSS width/height change 2010-01-18 15:09:47 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin mrowe oliver webkit.review.bot oldest_to_newest 152287 0 cmarrin 2009-10-05 07:14:27 -0700 Canvas should only resize when canvas width and height attributes are changed 156045 1 cmarrin 2009-10-19 20:44:46 -0700 Another odd characteristic of this bug happens if you open (for instance): http://webkit.org/blog-files/webgl/ManyPlanetsDeep.html and then hit cmd-+. The planets get smaller. This is happening because I am looking at the CSS size to set the canvas, but at the canvas width and height to set the viewport. The canvas size doesn't change but the css size gets bigger, so the viewport is small relative to the canvas size. This is all fixed by not changing the canvas based on the CSS size, which is what fixing this bug will do. 181983 2 46844 cmarrin 2010-01-18 13:56:59 -0800 Created attachment 46844 Patch 181984 3 webkit.review.bot 2010-01-18 13:59:01 -0800 Attachment 46844 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebCore/html/HTMLCanvasElement.cpp:277: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] WebCore/html/HTMLCanvasElement.cpp:277: Use 0 instead of NULL. [readability/null] [5] Total errors found: 2 If any of these errors are false positives, please file a bug against check-webkit-style. 182015 4 cmarrin 2010-01-18 15:09:47 -0800 Landed in http://trac.webkit.org/changeset/53434 46844 2010-01-18 13:56:59 -0800 2010-01-18 14:09:12 -0800 Patch 30073.patch text/plain 1801 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MzQyNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMDEtMTggIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMDA3MworICAgICAgICBNb3Zl ZCByZXNoYXBlIHRvIEhUTUxDYW52YXNFbGVtZW50OjpyZXNldCBhbmQgaGF2ZSBpdCBhbHdheXMK KyAgICAgICAgc2V0IHRoZSBzaXplIHRvIHRoZSBjYW52YXMgd2lkdGggYW5kIGhlaWdodCBhdHRy cy4KKworICAgICAgICBUaGlzIGlzIG5vdCB0ZXN0YWJsZSB3aXRoIExheW91dFRlc3RzLCBzbyBJ IGluc3RlYWQgYWRkZWQgbG9naWMKKyAgICAgICAgdG8gdGhlIGRlbW8gYXQ6CisKKyAgICAgICAg aHR0cHM6Ly9jdnMua2hyb25vcy5vcmcvc3ZuL3JlcG9zL3JlZ2lzdHJ5L3RydW5rL3B1YmxpYy93 ZWJnbC9zZGsvZGVtb3Mvd2Via2l0L1NwaW5uaW5nQm94Lmh0bWwKKworICAgICAgICAqIGh0bWwv SFRNTENhbnZhc0VsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTENhbnZhc0VsZW1l bnQ6OnJlc2V0KToKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxDYW52YXNFbGVtZW50OjpwYWludCk6 CisKIDIwMTAtMDEtMTggIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkanVzdCB0aGUgc2Nyb2xsIHBvc2l0aW9uIHdoZW4gZG9pbmcgYSBmdWxsIHBhZ2Ug em9vbSwgc28gdGhlIGNvbnRlbnQKSW5kZXg6IFdlYkNvcmUvaHRtbC9IVE1MQ2FudmFzRWxlbWVu dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL0hUTUxDYW52YXNFbGVtZW50LmNwcAko cmV2aXNpb24gNTMzMzQpCisrKyBXZWJDb3JlL2h0bWwvSFRNTENhbnZhc0VsZW1lbnQuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMjcsNiArMjI3LDExIEBAIHZvaWQgSFRNTENhbnZhc0VsZW1lbnQ6 OnJlc2V0KCkKICAgICBJbnRTaXplIG9sZFNpemUgPSBtX3NpemU7CiAgICAgbV9zaXplID0gSW50 U2l6ZSh3LCBoKTsKIAorI2lmIEVOQUJMRSgzRF9DQU5WQVMpCisgICAgaWYgKG1fY29udGV4dCAm JiBtX2NvbnRleHQtPmlzM2QoKSkKKyAgICAgICAgc3RhdGljX2Nhc3Q8V2ViR0xSZW5kZXJpbmdD b250ZXh0Kj4obV9jb250ZXh0LmdldCgpKS0+cmVzaGFwZSh3aWR0aCgpLCBoZWlnaHQoKSk7Cisj ZW5kaWYKKwogICAgIGJvb2wgaGFkSW1hZ2VCdWZmZXIgPSBtX2NyZWF0ZWRJbWFnZUJ1ZmZlcjsK ICAgICBtX2NyZWF0ZWRJbWFnZUJ1ZmZlciA9IGZhbHNlOwogICAgIG1faW1hZ2VCdWZmZXIuY2xl YXIoKTsKQEAgLTI2OSwxMCArMjc0LDggQEAgdm9pZCBIVE1MQ2FudmFzRWxlbWVudDo6cGFpbnQo R3JhcGhpY3NDbwogICAgIH0KIAogI2lmIEVOQUJMRSgzRF9DQU5WQVMpCi0gICAgaWYgKGNvbnRl eHQzRCAhPSBOVUxMKSB7Ci0gICAgICAgIGNvbnRleHQzRC0+cmVzaGFwZShyLndpZHRoKCksIHIu aGVpZ2h0KCkpOworICAgIGlmIChjb250ZXh0M0QgIT0gTlVMTCkKICAgICAgICAgY29udGV4dDNE LT5lbmRQYWludCgpOwotICAgIH0KICNlbmRpZgogfQogCg==