<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>30069</bug_id>
          
          <creation_ts>2009-10-05 03:51:06 -0700</creation_ts>
          <short_desc>[Qt] Remove precompiled header from JavaScriptCore compilation to allow autonomous compilation.</short_desc>
          <delta_ts>2009-10-05 16:19:07 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Qt</keywords>
          <priority>P2</priority>
          <bug_severity>Enhancement</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Jocelyn Turcotte">jturcotte</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>commit-queue</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>152252</commentid>
    <comment_count>0</comment_count>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2009-10-05 03:51:06 -0700</bug_when>
    <thetext>JavaScriptCore.pro includes its pch from WebKit/qt/WebKit_pch.h, which displays a warning when compiling an extracted standalone JavaScriptCore.

This is the simple solution, needed at least while we need JavaScriptCore to be compiled out of WebKit inside Qt.
It would be possible to create a pch especially for JavaScriptCore to keep the compilation time reduction, however this may polute the directory (or any of the reason why WebKit_pch.h is currently in WebKit/qt/)

Please have a thought about it while reviewing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152253</commentid>
    <comment_count>1</comment_count>
      <attachid>40618</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2009-10-05 03:52:56 -0700</bug_when>
    <thetext>Created attachment 40618
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152255</commentid>
    <comment_count>2</comment_count>
      <attachid>40620</attachid>
    <who name="Jocelyn Turcotte">jturcotte</who>
    <bug_when>2009-10-05 03:57:00 -0700</bug_when>
    <thetext>Created attachment 40620
Patch v0.2

Better changelog message</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152477</commentid>
    <comment_count>3</comment_count>
      <attachid>40620</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-10-05 14:57:04 -0700</bug_when>
    <thetext>Comment on attachment 40620
Patch v0.2

r=me, that header isn&apos;t needed anymore for this .pro file.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152511</commentid>
    <comment_count>4</comment_count>
      <attachid>40620</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-05 16:19:04 -0700</bug_when>
    <thetext>Comment on attachment 40620
Patch v0.2

Clearing flags on attachment: 40620

Committed r49128: &lt;http://trac.webkit.org/changeset/49128&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>152512</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-05 16:19:07 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>40618</attachid>
            <date>2009-10-05 03:52:56 -0700</date>
            <delta_ts>2009-10-05 03:57:00 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>javascriptcore_removeprecompiledheader.patch</filename>
            <type>text/plain</type>
            <size>970</size>
            <attacher name="Jocelyn Turcotte">jturcotte</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCAwYjdmNWExLi41ZmZiNGQxIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMDktMTAtMDUgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh
LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb
UXRdIFJlbW92ZSBwcmVjb21waWxlZCBoZWFkZXIgZnJvbSBKYXZhU2NyaXB0Q29yZSBjb21waWxh
dGlvbiB0byBhbGxvdworICAgICAgICBhdXRvbm9tb3VzIGNvbXBpbGF0aW9uLgorICAgICAgICBo
dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAwNjkKKworICAgICAgICAq
IEphdmFTY3JpcHRDb3JlLnBybzoKKwogMjAwOS0xMC0wMiAgR2VvZmZyZXkgR2FyZW4gIDxnZ2Fy
ZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCmRpZmYgLS1n
aXQgYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8gYi9KYXZhU2NyaXB0Q29yZS9K
YXZhU2NyaXB0Q29yZS5wcm8KaW5kZXggMGNkMmUxYS4uYTFhZmZkNCAxMDA2NDQKLS0tIGEvSmF2
YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCisrKyBiL0phdmFTY3JpcHRDb3JlL0phdmFT
Y3JpcHRDb3JlLnBybwpAQCAtMTYsNyArMTYsNiBAQCBDT05GSUcoUVRESVJfYnVpbGQpIHsKICAg
ICBpbmNsdWRlKCQkUVRfU09VUkNFX1RSRUUvc3JjL3FiYXNlLnByaSkKICAgICBJTlNUQUxMUyA9
CiAgICAgREVTVERJUiA9ICQkT0xEREVTVERJUgotICAgIFBSRUNPTVBJTEVEX0hFQURFUiA9ICQk
UFdELy4uL1dlYktpdC9xdC9XZWJLaXRfcGNoLmgKICAgICBERUZJTkVTICo9IE5ERUJVRwogfQog
Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>40620</attachid>
            <date>2009-10-05 03:57:00 -0700</date>
            <delta_ts>2009-10-05 16:19:04 -0700</delta_ts>
            <desc>Patch v0.2</desc>
            <filename>javascriptcore_removeprecompiledheader.patch</filename>
            <type>text/plain</type>
            <size>993</size>
            <attacher name="Jocelyn Turcotte">jturcotte</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No
YW5nZUxvZwppbmRleCAwYjdmNWExLi5kYzRjZGQ2IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y
ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg
QEAKKzIwMDktMTAtMDUgIEpvY2VseW4gVHVyY290dGUgIDxqb2NlbHluLnR1cmNvdHRlQG5va2lh
LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb
UXRdIFJlbW92ZSBwcmVjb21waWxlZCBoZWFkZXIgZnJvbSBKYXZhU2NyaXB0Q29yZSBjb21waWxh
dGlvbiB0bworICAgICAgICBwcmV2ZW50IHFtYWtlIHdhcm5pbmcgZHVyaW5nIGF1dG9ub21vdXMg
Y29tcGlsYXRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0zMDA2OQorCisgICAgICAgICogSmF2YVNjcmlwdENvcmUucHJvOgorCiAyMDA5LTEwLTAy
ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg
YnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3Jl
LnBybyBiL0phdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnBybwppbmRleCAwY2QyZTFhLi5h
MWFmZmQ0IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcm8KKysr
IGIvSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJvCkBAIC0xNiw3ICsxNiw2IEBAIENP
TkZJRyhRVERJUl9idWlsZCkgewogICAgIGluY2x1ZGUoJCRRVF9TT1VSQ0VfVFJFRS9zcmMvcWJh
c2UucHJpKQogICAgIElOU1RBTExTID0KICAgICBERVNURElSID0gJCRPTERERVNURElSCi0gICAg
UFJFQ09NUElMRURfSEVBREVSID0gJCRQV0QvLi4vV2ViS2l0L3F0L1dlYktpdF9wY2guaAogICAg
IERFRklORVMgKj0gTkRFQlVHCiB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>