30067 2009-10-05 03:43:38 -0700 Add a screenshot option to the menubar of QtLauncher 2009-10-05 16:03:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED Qt P3 Enhancement --- 0 girish webkit-unassigned commit-queue oldest_to_newest 152248 0 girish 2009-10-05 03:43:38 -0700 Takes a screenshot of the current webview and optionally save it on disk. 152249 1 40617 girish 2009-10-05 03:48:34 -0700 Created attachment 40617 Patch for adding snapshot option Patch is also available at http://gitorious.org/~girish/qtwebkit/girishs-clone/commits/qtlauncher_snapshot_30067. 152266 2 vestbo 2009-10-05 04:46:05 -0700 Thanks for your bug report. In the future, please follow the QtWebKit bug reporting guidelines: http://trac.webkit.org/wiki/QtWebKitContrib#ReportingBugs In particular: - All bugs related to the Qt port of WebKit should have the keyword 'Qt' - The 'WebKit Qt' component should only be used for the QtWebKit API layer 152442 3 mrowe 2009-10-05 14:02:46 -0700 QtLauncher is intended only for testing of WebKit and not as a fully-featured browser. How does this patch fit in to that? 152480 4 40617 hausmann 2009-10-05 14:59:07 -0700 Comment on attachment 40617 Patch for adding snapshot option r=me. This helps towards making the launcher more useful for debugging. Wow, now it even has a shortcut ;) 152506 5 40617 commit-queue 2009-10-05 16:03:28 -0700 Comment on attachment 40617 Patch for adding snapshot option Clearing flags on attachment: 40617 Committed r49124: <http://trac.webkit.org/changeset/49124> 152507 6 commit-queue 2009-10-05 16:03:31 -0700 All reviewed patches have been landed. Closing bug. 40617 2009-10-05 03:48:34 -0700 2009-10-05 16:03:28 -0700 Patch for adding snapshot option qtlauncher_snapshot.patch text/plain 2772 girish Y29tbWl0IGFlNmFiZDc0YjVmNWUxMTFkMGQyYWJlOTE3NWJiMGZhZDRlZTNmM2IKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgV2VkIFNl cCAzMCAwMDo0NDo0MiAyMDA5ICswNTMwCgogICAgQWRkIHNjcmVlbnNob3QgdG8gbWVudWJhcgoK ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IDcwMDU5MTYuLjdjNGRjOTAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTEwLTA1ICBHaXJp c2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBzY3JlZW5zaG90IG9wdGlvbiB0 byBtZW51YmFyCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTMwMDY3CisKKyAgICAgICAgKiBRdExhdW5jaGVyL21haW4uY3BwOgorICAgICAgICAoTWFp bldpbmRvdzo6c2NyZWVuc2hvdCk6CisgICAgICAgIChNYWluV2luZG93OjpzZXR1cFVJKToKKwog MjAwOS0xMC0wMiAgTm9yYmVydCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0 L1F0TGF1bmNoZXIvbWFpbi5jcHAgYi9XZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcAppbmRl eCAwYjA2NzY5Li4wMWE2ODk3IDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvUXRMYXVuY2hlci9tYWlu LmNwcAorKysgYi9XZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcApAQCAtMSw1ICsxLDYgQEAK IC8qCiAgKiBDb3B5cmlnaHQgKEMpIDIwMDkgTm9raWEgQ29ycG9yYXRpb24gYW5kL29yIGl0cyBz dWJzaWRpYXJ5KC1pZXMpCisgKiBDb3B5cmlnaHQgKEMpIDIwMDkgR2lyaXNoIFJhbWFrcmlzaG5h biA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogICogQ29weXJpZ2h0IChDKSAyMDA2IEdlb3JnZSBT dGFpa29zIDxzdGFpa29zQGtkZS5vcmc+CiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYgRGlyayBNdWVs bGVyIDxtdWVsbGVyQGtkZS5vcmc+CiAgKiBDb3B5cmlnaHQgKEMpIDIwMDYgWmFjayBSdXNpbiA8 emFja0BrZGUub3JnPgpAQCAtMjA4LDYgKzIwOSwyMiBAQCBwcm90ZWN0ZWQgc2xvdHM6CiAjZW5k aWYKICAgICB9CiAKKyAgICB2b2lkIHNjcmVlbnNob3QoKQorICAgIHsKKyAgICAgICAgUVBpeG1h cCBwaXhtYXAgPSBRUGl4bWFwOjpncmFiV2lkZ2V0KHZpZXcpOworICAgICAgICBRTGFiZWwqIGxh YmVsID0gbmV3IFFMYWJlbDsKKyAgICAgICAgbGFiZWwtPnNldEF0dHJpYnV0ZShRdDo6V0FfRGVs ZXRlT25DbG9zZSk7CisgICAgICAgIGxhYmVsLT5zZXRXaW5kb3dUaXRsZSgiU2NyZWVuc2hvdCAt IFByZXZpZXciKTsKKyAgICAgICAgbGFiZWwtPnNldFBpeG1hcChwaXhtYXApOworICAgICAgICBs YWJlbC0+c2hvdygpOworCisgICAgICAgIFFTdHJpbmcgZmlsZU5hbWUgPSBRRmlsZURpYWxvZzo6 Z2V0U2F2ZUZpbGVOYW1lKGxhYmVsLCAiU2NyZWVuc2hvdCIpOworICAgICAgICBpZiAoIWZpbGVO YW1lLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgcGl4bWFwLnNhdmUoZmlsZU5hbWUsICJwbmci KTsKKyAgICAgICAgICAgIGxhYmVsLT5zZXRXaW5kb3dUaXRsZShRU3RyaW5nKCJTY3JlZW5zaG90 IC0gU2F2ZWQgYXQgJTEiKS5hcmcoZmlsZU5hbWUpKTsKKyAgICAgICAgfQorICAgIH0KKwogICAg IHZvaWQgc2V0RWRpdGFibGUoYm9vbCBvbikgewogICAgICAgICB2aWV3LT5wYWdlKCktPnNldENv bnRlbnRFZGl0YWJsZShvbik7CiAgICAgICAgIGZvcm1hdE1lbnVBY3Rpb24tPnNldFZpc2libGUo b24pOwpAQCAtMjc1LDYgKzI5Miw3IEBAIHByaXZhdGU6CiAjaWYgUVRfVkVSU0lPTiA+PSAweDA0 MDQwMAogICAgICAgICBmaWxlTWVudS0+YWRkQWN0aW9uKHRyKCJQcmludCIpLCB0aGlzLCBTTE9U KHByaW50KCkpKTsKICNlbmRpZgorICAgICAgICBRQWN0aW9uKiBzY3JlZW5zaG90ID0gZmlsZU1l bnUtPmFkZEFjdGlvbigiU2NyZWVuc2hvdCIsIHRoaXMsIFNMT1Qoc2NyZWVuc2hvdCgpKSk7CiAg ICAgICAgIGZpbGVNZW51LT5hZGRBY3Rpb24oIkNsb3NlIiwgdGhpcywgU0xPVChjbG9zZSgpKSk7 CiAKICAgICAgICAgUU1lbnUgKmVkaXRNZW51ID0gbWVudUJhcigpLT5hZGRNZW51KCImRWRpdCIp OwpAQCAtMzEzLDYgKzMzMSw3IEBAIHByaXZhdGU6CiAgICAgICAgIHdyaXRpbmdNZW51LT5hZGRB Y3Rpb24odmlldy0+cGFnZUFjdGlvbihRV2ViUGFnZTo6U2V0VGV4dERpcmVjdGlvblJpZ2h0VG9M ZWZ0KSk7CiAKICAgICAgICAgbmV3V2luZG93LT5zZXRTaG9ydGN1dChRS2V5U2VxdWVuY2UoUXQ6 OkNUUkwgfCBRdDo6S2V5X04pKTsKKyAgICAgICAgc2NyZWVuc2hvdC0+c2V0U2hvcnRjdXQoUUtl eVNlcXVlbmNlKFF0OjpDVFJMIHwgUXQ6OktleV9TKSk7CiAgICAgICAgIHZpZXctPnBhZ2VBY3Rp b24oUVdlYlBhZ2U6OkJhY2spLT5zZXRTaG9ydGN1dChRS2V5U2VxdWVuY2U6OkJhY2spOwogICAg ICAgICB2aWV3LT5wYWdlQWN0aW9uKFFXZWJQYWdlOjpTdG9wKS0+c2V0U2hvcnRjdXQoUXQ6Oktl eV9Fc2NhcGUpOwogICAgICAgICB2aWV3LT5wYWdlQWN0aW9uKFFXZWJQYWdlOjpGb3J3YXJkKS0+ c2V0U2hvcnRjdXQoUUtleVNlcXVlbmNlOjpGb3J3YXJkKTsK