30061 2009-10-04 11:20:35 -0700 [Gtk][Layout tests] Generate results for editing tests 2009-10-06 10:24:45 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 zan webkit-unassigned commit-queue oldest_to_newest 152181 0 zan 2009-10-04 11:20:35 -0700 Currently, about 730 tests in editing/ directory need to have results generated. 152182 1 40598 zan 2009-10-04 11:37:02 -0700 Created attachment 40598 Generated results This patch adds generated test results for about 350 tests. Only these tests produce 'rendering-equal' results to those from the mac port. With 'rendering-equal' phrase, these guarantees are meant: - Equal render objects are created in the same places (not necessarrily in the exact same position and with exact same size) - These objects have equal CSS attributes (borders, color etc.) - In the case of text runs, they contain equal text - Equal caret and selection attributes dump Basically, they're semantically equal, there can be differences in the size and position of render objects because of different font metrics. Tests that do not produce 'rendering-equal' results should be listed in another bug, examined and then fixed if fixable or added as generated if they're not fixable and acceptable as such. 152321 2 40598 eric 2009-10-05 09:27:43 -0700 Comment on attachment 40598 Generated results It is very sad that so many of these are render tree dumps instead of being dumpAsText (but that's not your fault). rubber-stamp=me. 152771 3 40598 gustavo 2009-10-06 10:08:13 -0700 Comment on attachment 40598 Generated results Setting cq+, since Zan is not a committer. 152776 4 40598 commit-queue 2009-10-06 10:24:41 -0700 Comment on attachment 40598 Generated results Clearing flags on attachment: 40598 Committed r49192: <http://trac.webkit.org/changeset/49192> 152777 5 commit-queue 2009-10-06 10:24:45 -0700 All reviewed patches have been landed. Closing bug. 40598 2009-10-04 11:37:02 -0700 2009-10-06 10:24:41 -0700 Generated results generated-final-editing-0.diff text/plain 0 zan