30060 2009-10-04 09:11:00 -0700 [V8] Fixed Function leak in V8LazyEventListener. 2009-10-04 10:12:48 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vitalyr webkit-unassigned abarth commit-queue dglazkov oldest_to_newest 152171 0 vitalyr 2009-10-04 09:11:00 -0700 [V8] Fixed Function leak in V8LazyEventListener. 152172 1 40596 vitalyr 2009-10-04 09:18:06 -0700 Created attachment 40596 patch 152173 2 abarth 2009-10-04 09:49:55 -0700 Is it safe to share the toString template across all instances? Does that cause us to share the __proto__ across security origins? 152174 3 40596 abarth 2009-10-04 09:56:09 -0700 Comment on attachment 40596 patch Vitalyr convinced me on chat that sharing the template is fine (we do this for lots of objects). 152175 4 40596 commit-queue 2009-10-04 10:12:45 -0700 Comment on attachment 40596 patch Clearing flags on attachment: 40596 Committed r49074: <http://trac.webkit.org/changeset/49074> 152176 5 commit-queue 2009-10-04 10:12:48 -0700 All reviewed patches have been landed. Closing bug. 40596 2009-10-04 09:18:06 -0700 2009-10-04 10:12:45 -0700 patch template_leak.patch text/plain 7372 vitalyr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDEzMDMwNi4uMDlkNjdjNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAwOS0xMC0wNCAgVml0YWx5IFJlcGVz aGtvICA8dml0YWx5ckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW1Y4XSBGaXhlZCBGdW5jdGlvbiBsZWFrIGluIFY4TGF6eUV2 ZW50TGlzdGVuZXIuCisgICAgICAgIChTaG91bGQgZml4IHRoZSByZW1hbmluZyBsZWFrIGluCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTA5MykuCisg ICAgICAgIFY4TGF6eUV2ZW50TGlzdGVuZXJzIHVzZWQgdG8gY3JlYXRlIEZ1bmN0aW9uVGVtcGxh dGVzIGZvciBlYWNoCisgICAgICAgIHdyYXBwZWQgbGlzdGVuZXIgd2hpY2ggaW4gdHVybiBjcmVh dGVkIEZ1bmN0aW9ucyB0aGF0IHdlcmUgY2FjaGVkCisgICAgICAgIGZvcmV2ZXIgaW4gVjggQ29u dGV4dC4gTm93IHRoZXJlIGlzIGF0IG1vc3Qgb25lIHN1Y2ggRnVuY3Rpb24gcGVyCisgICAgICAg IENvbnRleHQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0zMDA2MAorCisgICAgICAgIEFkZGVkIG5ldyBoaWRkZW4gcHJvcGVydHkgbmFtZSB0byBzdG9y ZSB0b1N0cmluZyByZXN1bHQ6CisgICAgICAgICogYmluZGluZ3MvdjgvVjhIaWRkZW5Qcm9wZXJ0 eU5hbWUuY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4SGlkZGVuUHJvcGVydHlOYW1lLmg6 CisKKyAgICAgICAgU3dpdGNoZWQgdG8gc3RhdGljIEZ1bmN0aW9uVGVtcGxhdGU6CisgICAgICAg ICogYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpWOExhenlFdmVudExpc3RlbmVyVG9TdHJpbmcpOgorICAgICAgICAoV2ViQ29yZTo6VjhMYXp5 RXZlbnRMaXN0ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KToKKwogMjAwOS0xMC0wMSAgQWRh bSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEhpZGRlblByb3BlcnR5 TmFtZS5jcHAgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SGlkZGVuUHJvcGVydHlOYW1lLmNwcApp bmRleCA3ZWEyYTRjLi5kODM1NzNmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4 SGlkZGVuUHJvcGVydHlOYW1lLmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SGlkZGVu UHJvcGVydHlOYW1lLmNwcApAQCAtMzMsMjkgKzMzLDE3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAotdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBWOEhpZGRlblByb3BlcnR5TmFtZTo6b2JqZWN0 UHJvdG90eXBlKCkKLXsKLSAgICBzdGF0aWMgdjg6OlBlcnNpc3RlbnQ8djg6OlN0cmluZz4qIHN0 cmluZyA9IGNyZWF0ZVN0cmluZygiV2ViQ29yZTo6VjhIaWRkZW5Qcm9wZXJ0eU5hbWU6Om9iamVj dFByb3RvdHlwZSIpOwotICAgIHJldHVybiAqc3RyaW5nOworI2RlZmluZSBWOF9BU19TVFJJTkco eCkgVjhfQVNfU1RSSU5HX0lNUEwoeCkKKyNkZWZpbmUgVjhfQVNfU1RSSU5HX0lNUEwoeCkgI3gK KworI2RlZmluZSBWOF9ERUZJTkVfUFJPUEVSVFkobmFtZSkgXAordjg6OkhhbmRsZTx2ODo6U3Ry aW5nPiBWOEhpZGRlblByb3BlcnR5TmFtZTo6bmFtZSgpIFwKK3sgXAorICAgIHN0YXRpYyB2ODo6 UGVyc2lzdGVudDx2ODo6U3RyaW5nPiogc3RyaW5nID0gY3JlYXRlU3RyaW5nKCJXZWJDb3JlOjpW OEhpZGRlblByb3BlcnR5TmFtZTo6IiBWOF9BU19TVFJJTkcobmFtZSkpOyBcCisgICAgcmV0dXJu ICpzdHJpbmc7IFwKIH0KIAotdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBWOEhpZGRlblByb3BlcnR5 TmFtZTo6aXNvbGF0ZWRXb3JsZCgpCi17Ci0gICAgc3RhdGljIHY4OjpQZXJzaXN0ZW50PHY4OjpT dHJpbmc+KiBzdHJpbmcgPSBjcmVhdGVTdHJpbmcoIldlYkNvcmU6OlY4SGlkZGVuUHJvcGVydHlO YW1lOjppc29sYXRlZFdvcmxkIik7Ci0gICAgcmV0dXJuICpzdHJpbmc7Ci19Ci0KLXY4OjpIYW5k bGU8djg6OlN0cmluZz4gVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6Omxpc3RlbmVyKCkKLXsKLSAgICBz dGF0aWMgdjg6OlBlcnNpc3RlbnQ8djg6OlN0cmluZz4qIHN0cmluZyA9IGNyZWF0ZVN0cmluZygi V2ViQ29yZTo6VjhIaWRkZW5Qcm9wZXJ0eU5hbWU6Omxpc3RlbmVyIik7Ci0gICAgcmV0dXJuICpz dHJpbmc7Ci19Ci0KLXY4OjpIYW5kbGU8djg6OlN0cmluZz4gVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6 OmF0dHJpYnV0ZUxpc3RlbmVyKCkKLXsKLSAgICBzdGF0aWMgdjg6OlBlcnNpc3RlbnQ8djg6OlN0 cmluZz4qIHN0cmluZyA9IGNyZWF0ZVN0cmluZygiV2ViQ29yZTo6VjhIaWRkZW5Qcm9wZXJ0eU5h bWU6OmF0dHJpYnV0ZUxpc3RlbmVyIik7Ci0gICAgcmV0dXJuICpzdHJpbmc7Ci19CitWOF9ISURE RU5fUFJPUEVSVElFUyhWOF9ERUZJTkVfUFJPUEVSVFkpOwogCiB2ODo6UGVyc2lzdGVudDx2ODo6 U3RyaW5nPiogVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6OmNyZWF0ZVN0cmluZyhjb25zdCBjaGFyKiBr ZXkpCiB7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SGlkZGVuUHJvcGVydHlO YW1lLmggYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4SGlkZGVuUHJvcGVydHlOYW1lLmgKaW5kZXgg ZGJlOTkyZi4uNThjMDFlYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOEhpZGRl blByb3BlcnR5TmFtZS5oCisrKyBiL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhIaWRkZW5Qcm9wZXJ0 eU5hbWUuaApAQCAtMzUsMTIgKzM1LDE4IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorI2Rl ZmluZSBWOF9ISURERU5fUFJPUEVSVElFUyhWKSBcCisgICAgVihvYmplY3RQcm90b3R5cGUpIFwK KyAgICBWKGlzb2xhdGVkV29ybGQpIFwKKyAgICBWKGxpc3RlbmVyKSBcCisgICAgVihhdHRyaWJ1 dGVMaXN0ZW5lcikgXAorICAgIFYodG9TdHJpbmdTdHJpbmcpCisKICAgICBjbGFzcyBWOEhpZGRl blByb3BlcnR5TmFtZSB7CiAgICAgcHVibGljOgotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2 ODo6U3RyaW5nPiBvYmplY3RQcm90b3R5cGUoKTsKLSAgICAgICAgc3RhdGljIHY4OjpIYW5kbGU8 djg6OlN0cmluZz4gaXNvbGF0ZWRXb3JsZCgpOwotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2 ODo6U3RyaW5nPiBsaXN0ZW5lcigpOwotICAgICAgICBzdGF0aWMgdjg6OkhhbmRsZTx2ODo6U3Ry aW5nPiBhdHRyaWJ1dGVMaXN0ZW5lcigpOworI2RlZmluZSBWOF9ERUNMQVJFX1BST1BFUlRZKG5h bWUpIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpTdHJpbmc+IG5hbWUoKTsKKyAgICAgICAgVjhfSElE REVOX1BST1BFUlRJRVMoVjhfREVDTEFSRV9QUk9QRVJUWSk7CisjdW5kZWYgVjhfREVDTEFSRV9Q Uk9QRVJUWQogCiAgICAgcHJpdmF0ZToKICAgICAgICAgc3RhdGljIHY4OjpQZXJzaXN0ZW50PHY4 OjpTdHJpbmc+KiBjcmVhdGVTdHJpbmcoY29uc3QgY2hhcioga2V5KTsKZGlmZiAtLWdpdCBhL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAgYi9XZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IDQ2ZjU2NDkuLmQ5ZjAzMDUgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhMYXp5RXZlbnRMaXN0ZW5lci5jcHAKKysr IGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmNwcApAQCAtMzMsOCAr MzMsMTEgQEAKIAogI2luY2x1ZGUgIkZyYW1lLmgiCiAjaW5jbHVkZSAiVjhCaW5kaW5nLmgiCisj aW5jbHVkZSAiVjhIaWRkZW5Qcm9wZXJ0eU5hbWUuaCIKICNpbmNsdWRlICJWOFByb3h5LmgiCiAK KyNpbmNsdWRlIDx3dGYvU3RkTGliRXh0cmFzLmg+CisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAog VjhMYXp5RXZlbnRMaXN0ZW5lcjo6VjhMYXp5RXZlbnRMaXN0ZW5lcihGcmFtZSogZnJhbWUsIGNv bnN0IFN0cmluZyYgY29kZSwgY29uc3QgU3RyaW5nJiBmdW5jdGlvbk5hbWUsIGJvb2wgaXNTVkdF dmVudCkKQEAgLTYwLDcgKzYzLDcgQEAgdjg6OkxvY2FsPHY4OjpWYWx1ZT4gVjhMYXp5RXZlbnRM aXN0ZW5lcjo6Y2FsbExpc3RlbmVyRnVuY3Rpb24odjg6OkhhbmRsZTx2ODo6VmEKIAogc3RhdGlj IHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOExhenlFdmVudExpc3RlbmVyVG9TdHJpbmcoY29uc3Qg djg6OkFyZ3VtZW50cyYgYXJncykKIHsKLSAgICByZXR1cm4gYXJncy5DYWxsZWUoKS0+R2V0SGlk ZGVuVmFsdWUodjg6OlN0cmluZzo6TmV3KCJ0b1N0cmluZ1N0cmluZyIpKTsKKyAgICByZXR1cm4g YXJncy5Ib2xkZXIoKS0+R2V0SGlkZGVuVmFsdWUoVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6OnRvU3Ry aW5nU3RyaW5nKCkpOwogfQogCiB2b2lkIFY4TGF6eUV2ZW50TGlzdGVuZXI6OnByZXBhcmVMaXN0 ZW5lck9iamVjdCgpCkBAIC0xMDgsMTEgKzExMSwxNyBAQCB2b2lkIFY4TGF6eUV2ZW50TGlzdGVu ZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdCgpCiAKICAgICAgICAgICAgIHY4OjpMb2NhbDx2ODo6 RnVuY3Rpb24+IHdyYXBwZWRGdW5jdGlvbiA9IHY4OjpMb2NhbDx2ODo6RnVuY3Rpb24+OjpDYXN0 KHZhbHVlKTsKIAotICAgICAgICAgICAgLy8gQ2hhbmdlIHRoZSB0b1N0cmluZyBmdW5jdGlvbiBv biB0aGUgd3JhcHBlciBmdW5jdGlvbiB0byBhdm9pZCBpdCByZXR1cm5pbmcgdGhlIHNvdXJjZSBm b3IgdGhlIGFjdHVhbCB3cmFwcGVyIGZ1bmN0aW9uLiBJbnN0ZWFkCi0gICAgICAgICAgICAvLyBp dCByZXR1cm5zIHNvdXJjZSBmb3IgYSBjbGVhbiB3cmFwcGVyIGZ1bmN0aW9uIHdpdGggdGhlIGV2 ZW50IGFyZ3VtZW50IHdyYXBwaW5nIHRoZSBldmVudCBzb3VyY2UgY29kZS4gVGhlIHJlYXNvbiBm b3IgdGhpcwotICAgICAgICAgICAgLy8gaXMgdGhhdCBzb21lIHdlYiBzaXRlcyB1c2VzIHRvU3Ry aW5nIG9uIGV2ZW50IGZ1bmN0aW9ucyBhbmQgdGhlIGV2YWxzIHRoZSBzb3VyY2UgcmV0dXJuZWQg KHNvbWUgdGltZXMgYSBSZWdFeHAgaXMgYXBwbGllZCBhcwotICAgICAgICAgICAgLy8gd2VsbCkg Zm9yIHNvbWUgb3RoZXIgdXNlLiBUaGF0IGZhaWxzIG1pc2VyYWJseSBpZiB0aGUgYWN0dWFsIHdy YXBwZXIgc291cmNlIGlzIHJldHVybmVkLgotICAgICAgICAgICAgdjg6OkxvY2FsPHY4OjpGdW5j dGlvblRlbXBsYXRlPiB0b1N0cmluZ1RlbXBsYXRlID0gdjg6OkZ1bmN0aW9uVGVtcGxhdGU6Ok5l dyhWOExhenlFdmVudExpc3RlbmVyVG9TdHJpbmcpOworICAgICAgICAgICAgLy8gQ2hhbmdlIHRo ZSB0b1N0cmluZyBmdW5jdGlvbiBvbiB0aGUgd3JhcHBlciBmdW5jdGlvbiB0byBhdm9pZCBpdAor ICAgICAgICAgICAgLy8gcmV0dXJuaW5nIHRoZSBzb3VyY2UgZm9yIHRoZSBhY3R1YWwgd3JhcHBl ciBmdW5jdGlvbi4gSW5zdGVhZCBpdAorICAgICAgICAgICAgLy8gcmV0dXJucyBzb3VyY2UgZm9y IGEgY2xlYW4gd3JhcHBlciBmdW5jdGlvbiB3aXRoIHRoZSBldmVudAorICAgICAgICAgICAgLy8g YXJndW1lbnQgd3JhcHBpbmcgdGhlIGV2ZW50IHNvdXJjZSBjb2RlLiBUaGUgcmVhc29uIGZvciB0 aGlzIGlzCisgICAgICAgICAgICAvLyB0aGF0IHNvbWUgd2ViIHNpdGVzIHVzZSB0b1N0cmluZyBv biBldmVudCBmdW5jdGlvbnMgYW5kIGV2YWwgdGhlCisgICAgICAgICAgICAvLyBzb3VyY2UgcmV0 dXJuZWQgKHNvbWV0aW1lcyBhIFJlZ0V4cCBpcyBhcHBsaWVkIGFzIHdlbGwpIGZvciBzb21lCisg ICAgICAgICAgICAvLyBvdGhlciB1c2UuIFRoYXQgZmFpbHMgbWlzZXJhYmx5IGlmIHRoZSBhY3R1 YWwgd3JhcHBlciBzb3VyY2UgaXMKKyAgICAgICAgICAgIC8vIHJldHVybmVkLgorICAgICAgICAg ICAgREVGSU5FX1NUQVRJQ19MT0NBTCh2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0 ZT4sIHRvU3RyaW5nVGVtcGxhdGUsICgpKTsKKyAgICAgICAgICAgIGlmICh0b1N0cmluZ1RlbXBs YXRlLklzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICB0b1N0cmluZ1RlbXBsYXRlID0gdjg6OlBl cnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxhdGU+OjpOZXcodjg6OkZ1bmN0aW9uVGVtcGxhdGU6 Ok5ldyhWOExhenlFdmVudExpc3RlbmVyVG9TdHJpbmcpKTsKICAgICAgICAgICAgIHY4OjpMb2Nh bDx2ODo6RnVuY3Rpb24+IHRvU3RyaW5nRnVuY3Rpb247CiAgICAgICAgICAgICBpZiAoIXRvU3Ry aW5nVGVtcGxhdGUuSXNFbXB0eSgpKQogICAgICAgICAgICAgICAgIHRvU3RyaW5nRnVuY3Rpb24g PSB0b1N0cmluZ1RlbXBsYXRlLT5HZXRGdW5jdGlvbigpOwpAQCAtMTIwLDE0ICsxMjksMTEgQEAg dm9pZCBWOExhenlFdmVudExpc3RlbmVyOjpwcmVwYXJlTGlzdGVuZXJPYmplY3QoKQogICAgICAg ICAgICAgICAgIFN0cmluZyB0b1N0cmluZ1Jlc3VsdCA9ICJmdW5jdGlvbiAiOwogICAgICAgICAg ICAgICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVuZChtX2Z1bmN0aW9uTmFtZSk7CiAgICAgICAgICAg ICAgICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5kKCIoIik7Ci0gICAgICAgICAgICAgICAgaWYgKG1f aXNTVkdFdmVudCkKLSAgICAgICAgICAgICAgICAgICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5kKCJl dnQiKTsKLSAgICAgICAgICAgICAgICBlbHNlCi0gICAgICAgICAgICAgICAgICAgIHRvU3RyaW5n UmVzdWx0LmFwcGVuZCgiZXZlbnQiKTsKKyAgICAgICAgICAgICAgICB0b1N0cmluZ1Jlc3VsdC5h cHBlbmQobV9pc1NWR0V2ZW50ID8gImV2dCIgOiAiZXZlbnQiKTsKICAgICAgICAgICAgICAgICB0 b1N0cmluZ1Jlc3VsdC5hcHBlbmQoIikge1xuICAiKTsKICAgICAgICAgICAgICAgICB0b1N0cmlu Z1Jlc3VsdC5hcHBlbmQobV9jb2RlKTsKICAgICAgICAgICAgICAgICB0b1N0cmluZ1Jlc3VsdC5h cHBlbmQoIlxufSIpOwotICAgICAgICAgICAgICAgIHRvU3RyaW5nRnVuY3Rpb24tPlNldEhpZGRl blZhbHVlKHY4OjpTdHJpbmc6Ok5ldygidG9TdHJpbmdTdHJpbmciKSwgdjhFeHRlcm5hbFN0cmlu Zyh0b1N0cmluZ1Jlc3VsdCkpOworICAgICAgICAgICAgICAgIHdyYXBwZWRGdW5jdGlvbi0+U2V0 SGlkZGVuVmFsdWUoVjhIaWRkZW5Qcm9wZXJ0eU5hbWU6OnRvU3RyaW5nU3RyaW5nKCksIHY4RXh0 ZXJuYWxTdHJpbmcodG9TdHJpbmdSZXN1bHQpKTsKICAgICAgICAgICAgICAgICB3cmFwcGVkRnVu Y3Rpb24tPlNldCh2ODo6U3RyaW5nOjpOZXcoInRvU3RyaW5nIiksIHRvU3RyaW5nRnVuY3Rpb24p OwogICAgICAgICAgICAgfQogCg==