30044 2009-10-03 07:26:11 -0700 [Qt] EventSender::keyDown() cannot send function-key events. 2009-10-05 15:37:44 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 jwieczorek webkit-unassigned commit-queue oldest_to_newest 152072 0 jwieczorek 2009-10-03 07:26:11 -0700 This is required for the fast/events/keydown-function-keys.html layout test. 152073 1 40573 jwieczorek 2009-10-03 07:28:51 -0700 Created attachment 40573 patch 152317 2 40573 eric 2009-10-05 09:20:31 -0700 Comment on attachment 40573 patch Looks OK, but the ChangeLog should say what layout test this fixes. 152333 3 40638 jwieczorek 2009-10-05 09:59:26 -0700 Created attachment 40638 patch (In reply to comment #2) > (From update of attachment 40573 [details]) > Looks OK, but the ChangeLog should say what layout test this fixes. The patch itself does not fix the above mentioned test failure because there's one more bug in Qt DRT that makes the test fail: https://bugs.webkit.org/show_bug.cgi?id=30043 I've also added ' && functionKey <= 35' to the assertion, just in case. 152470 4 40638 hausmann 2009-10-05 14:47:20 -0700 Comment on attachment 40638 patch r=me, but please also make a patch that removes the skipped test from the list. Or in the future you could do that in one single change :-) 152491 5 40638 commit-queue 2009-10-05 15:37:41 -0700 Comment on attachment 40638 patch Clearing flags on attachment: 40638 Committed r49118: <http://trac.webkit.org/changeset/49118> 152492 6 commit-queue 2009-10-05 15:37:44 -0700 All reviewed patches have been landed. Closing bug. 40573 2009-10-03 07:28:51 -0700 2009-10-05 09:59:26 -0700 patch 0001-Qt-EventSender-keyDown-cannot-send-function-key-even.patch text/plain 2025 jwieczorek RnJvbSA2ZjY4MWNjZDVlMjc5MWIxYmFkY2Q3NzAwMWI5YTYxMTQ3ZWQyYzJiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFNhdCwgMyBPY3QgMjAwOSAxODoyMzo0NiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0g RXZlbnRTZW5kZXI6OmtleURvd24oKSBjYW5ub3Qgc2VuZCBmdW5jdGlvbi1rZXkgZXZlbnRzLgog aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMDQ0CgotLS0KIFdlYktp dFRvb2xzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEwICsrKysrKysrKysK IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0cy5jcHAgfCAgICA4ICsrKysr KystCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMoKyksIDEgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n CmluZGV4IDI0YmY1NjEuLjBiYjg2NmEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5nZUxv ZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMC0w MyAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIEV2ZW50U2VuZGVyOjprZXlEb3du KCkgY2Fubm90IHNlbmQgZnVuY3Rpb24ta2V5IGV2ZW50cy4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMDQ0CisKKyAgICAgICAgKiBEdW1wUmVuZGVy VHJlZS9xdC9qc29iamVjdHMuY3BwOgorICAgICAgICAoRXZlbnRTZW5kZXI6OmtleURvd24pOgor CiAyMDA5LTEwLTAyICBKdWxpZSBQYXJlbnQgIDxqcGFyZW50QGNocm9taXVtLm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUv cXQvanNvYmplY3RzLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0 cy5jcHAKaW5kZXggZmMxYzM1Zi4uYmRiMDQzNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvcXQvanNvYmplY3RzLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVy VHJlZS9xdC9qc29iamVjdHMuY3BwCkBAIC00ODIsOCArNDgyLDE0IEBAIHZvaWQgRXZlbnRTZW5k ZXI6OmtleURvd24oY29uc3QgUVN0cmluZyAmc3RyaW5nLCBjb25zdCBRU3RyaW5nTGlzdCAmbW9k aWZpZXJzKQogICAgICAgICAgICAgY29kZSA9IHN0cmluZy51bmljb2RlKCktPnRvVXBwZXIoKS51 bmljb2RlKCk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgcURlYnVnKCkgPDwgIj4+Pj4+Pj4+PiBr ZXlEb3duIiA8PCBzdHJpbmc7CisKKyAgICAgICAgaWYgKHN0cmluZy5zdGFydHNXaXRoKFFMYXRp bjFDaGFyKCdGJykpICYmIHN0cmluZy5jb3VudCgpIDw9IDMpIHsKKyAgICAgICAgICAgIHMgPSBz Lm1pZCgxKTsKKyAgICAgICAgICAgIGludCBmdW5jdGlvbktleSA9IHMudG9JbnQoKTsKKyAgICAg ICAgICAgIFFfQVNTRVJUKGZ1bmN0aW9uS2V5ID49IDEpOworICAgICAgICAgICAgY29kZSA9IFF0 OjpLZXlfRjEgKyAoZnVuY3Rpb25LZXkgLSAxKTsKICAgICAgICAgLy8gbWFwIHNwZWNpYWwga2V5 Y29kZSBzdHJpbmdzIHVzZWQgYnkgdGhlIHRlc3RzIHRvIHNvbWV0aGluZyB0aGF0IHdvcmtzIGZv ciBRdC9YMTEKLSAgICAgICAgaWYgKHN0cmluZyA9PSBRTGF0aW4xU3RyaW5nKCJsZWZ0QXJyb3ci KSkgeworICAgICAgICB9IGVsc2UgaWYgKHN0cmluZyA9PSBRTGF0aW4xU3RyaW5nKCJsZWZ0QXJy b3ciKSkgewogICAgICAgICAgICAgcyA9IFFTdHJpbmcoKTsKICAgICAgICAgICAgIGNvZGUgPSBR dDo6S2V5X0xlZnQ7CiAgICAgICAgIH0gZWxzZSBpZiAoc3RyaW5nID09IFFMYXRpbjFTdHJpbmco InJpZ2h0QXJyb3ciKSkgewotLSAKMS42LjQuNAoK 40638 2009-10-05 09:59:26 -0700 2009-10-05 15:37:41 -0700 patch Qt-EventSender-keyDown-function-keys.patch text/plain 2363 jwieczorek RnJvbSA0ZTdkNjc4ZTg4YWJjOTU1ZmJhNDJlZDA4MDQyNDU1NWI0NTNlNjMxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IE1vbiwgNSBPY3QgMjAwOSAyMDo0NjowMyArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0g RXZlbnRTZW5kZXI6OmtleURvd24oKSBjYW5ub3Qgc2VuZCBmdW5jdGlvbi1rZXkgZXZlbnRzLgog aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMDQ0CgpQYXRjaCBieSBK YWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+IG9uIDIwMDktMTAtMDUKUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCgpUaGlzIGFmZmVjdHMgdGhlIGZhc3QvZXZlbnRzL2tleWRvd24t ZnVuY3Rpb24ta2V5cy5odG1sIGxheW91dCB0ZXN0LgoKKiBEdW1wUmVuZGVyVHJlZS9xdC9qc29i amVjdHMuY3BwOgooRXZlbnRTZW5kZXI6OmtleURvd24pOgotLS0KIFdlYktpdFRvb2xzL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgfCAgIDEyICsrKysrKysrKysrKwogV2ViS2l0VG9v bHMvRHVtcFJlbmRlclRyZWUvcXQvanNvYmplY3RzLmNwcCB8ICAgIDggKysrKysrKy0KIDIgZmls ZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKaW5kZXggNzA1 NWNjZC4uNWY1MzA0MyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCisrKyBiL1dl YktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTEwLTA1ICBKYWt1YiBX aWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRXZlbnRTZW5kZXI6OmtleURvd24oKSBjYW5ub3Qg c2VuZCBmdW5jdGlvbi1rZXkgZXZlbnRzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MzAwNDQKKworICAgICAgICBUaGlzIGFmZmVjdHMgdGhlIGZhc3Qv ZXZlbnRzL2tleWRvd24tZnVuY3Rpb24ta2V5cy5odG1sIGxheW91dCB0ZXN0LgorCisgICAgICAg ICogRHVtcFJlbmRlclRyZWUvcXQvanNvYmplY3RzLmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVy OjprZXlEb3duKToKKwogMjAwOS0xMC0wNSAgUGF2ZWwgRmVsZG1hbiAgPHBmZWxkbWFuQGNocm9t aXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5IEhhdGNoZXIuCmRpZmYgLS1n aXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9qc29iamVjdHMuY3BwIGIvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvanNvYmplY3RzLmNwcAppbmRleCBmYzFjMzVmLi5jZDkx ZTVhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9qc29iamVjdHMu Y3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0cy5jcHAKQEAg LTQ4Miw4ICs0ODIsMTQgQEAgdm9pZCBFdmVudFNlbmRlcjo6a2V5RG93bihjb25zdCBRU3RyaW5n ICZzdHJpbmcsIGNvbnN0IFFTdHJpbmdMaXN0ICZtb2RpZmllcnMpCiAgICAgICAgICAgICBjb2Rl ID0gc3RyaW5nLnVuaWNvZGUoKS0+dG9VcHBlcigpLnVuaWNvZGUoKTsKICAgICB9IGVsc2Ugewog ICAgICAgICBxRGVidWcoKSA8PCAiPj4+Pj4+Pj4+IGtleURvd24iIDw8IHN0cmluZzsKKworICAg ICAgICBpZiAoc3RyaW5nLnN0YXJ0c1dpdGgoUUxhdGluMUNoYXIoJ0YnKSkgJiYgc3RyaW5nLmNv dW50KCkgPD0gMykgeworICAgICAgICAgICAgcyA9IHMubWlkKDEpOworICAgICAgICAgICAgaW50 IGZ1bmN0aW9uS2V5ID0gcy50b0ludCgpOworICAgICAgICAgICAgUV9BU1NFUlQoZnVuY3Rpb25L ZXkgPj0gMSAmJiBmdW5jdGlvbktleSA8PSAzNSk7CisgICAgICAgICAgICBjb2RlID0gUXQ6Oktl eV9GMSArIChmdW5jdGlvbktleSAtIDEpOwogICAgICAgICAvLyBtYXAgc3BlY2lhbCBrZXljb2Rl IHN0cmluZ3MgdXNlZCBieSB0aGUgdGVzdHMgdG8gc29tZXRoaW5nIHRoYXQgd29ya3MgZm9yIFF0 L1gxMQotICAgICAgICBpZiAoc3RyaW5nID09IFFMYXRpbjFTdHJpbmcoImxlZnRBcnJvdyIpKSB7 CisgICAgICAgIH0gZWxzZSBpZiAoc3RyaW5nID09IFFMYXRpbjFTdHJpbmcoImxlZnRBcnJvdyIp KSB7CiAgICAgICAgICAgICBzID0gUVN0cmluZygpOwogICAgICAgICAgICAgY29kZSA9IFF0OjpL ZXlfTGVmdDsKICAgICAgICAgfSBlbHNlIGlmIChzdHJpbmcgPT0gUUxhdGluMVN0cmluZygicmln aHRBcnJvdyIpKSB7Ci0tIAoxLjYuNC40Cgo=