30043 2009-10-03 07:16:37 -0700 [Qt] Fix the EventSender::keyDown() implementation 2009-10-06 04:35:19 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED Qt P2 Normal --- 0 jwieczorek webkit-unassigned commit-queue oldest_to_newest 152068 0 jwieczorek 2009-10-03 07:16:37 -0700 Currently it only triggers a key press event, while it should also send a key release event. That's also what other ports do. 152069 1 40571 jwieczorek 2009-10-03 07:17:41 -0700 Created attachment 40571 patch 152071 2 40572 jwieczorek 2009-10-03 07:21:37 -0700 Created attachment 40572 patch Add the missing ChangeLog. 152075 3 40574 jwieczorek 2009-10-03 07:56:52 -0700 Created attachment 40574 patch Fixed the style. 152316 4 40574 eric 2009-10-05 09:19:31 -0700 Comment on attachment 40574 patch Please list what layout tests this affects. If it doesn't affect any, please explain why, or add one which it affects. :) 152349 5 jwieczorek 2009-10-05 10:46:23 -0700 (In reply to comment #4) > (From update of attachment 40574 [details]) > Please list what layout tests this affects. If it doesn't affect any, please > explain why, or add one which it affects. :) Similarly to https://bugs.webkit.org/show_bug.cgi?id=30044, it also addresses the fast/events/keydown-function-keys.html failure. I'm not 100% sure if it fixed any other tests but it doesn't seem so. Later on, I will be going through the tests that use it and that are skipped currently to see if there are any that are fine now. 152441 6 40574 hausmann 2009-10-05 13:58:51 -0700 Comment on attachment 40574 patch Thanks! 152658 7 40574 commit-queue 2009-10-06 04:35:15 -0700 Comment on attachment 40574 patch Clearing flags on attachment: 40574 Committed r49166: <http://trac.webkit.org/changeset/49166> 152659 8 commit-queue 2009-10-06 04:35:19 -0700 All reviewed patches have been landed. Closing bug. 40571 2009-10-03 07:17:41 -0700 2009-10-03 07:21:37 -0700 patch 0001-Qt-Fix-the-EventSender-keyDown-implementation.patch text/plain 1064 jwieczorek RnJvbSBkNGViOTYwMjk2MjhlYjc5ZDUxODIwMTk0N2E5NGNhYjRjYmFmYzEyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFNhdCwgMyBPY3QgMjAwOSAxODoxMzowNSArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0g Rml4IHRoZSBFdmVudFNlbmRlcjo6a2V5RG93bigpIGltcGxlbWVudGF0aW9uCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAwNDMKCkl0IHNob3VsZCBwb3N0IGJvdGgg YSBrZXkgcHJlc3MgZXZlbnQgYW5kIGEga2V5IHJlbGVhc2UgZXZlbnQsCmp1c3QgbGlrZSBvdGhl ciBwb3J0cyBkby4KLS0tCiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9qc29iamVjdHMu Y3BwIHwgICAgMiArKwogMSBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDAgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvanNvYmpl Y3RzLmNwcCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0cy5jcHAKaW5k ZXggZmMxYzM1Zi4uNTNiYmM0OCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRy ZWUvcXQvanNvYmplY3RzLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9q c29iamVjdHMuY3BwCkBAIC01MTQsNiArNTE0LDggQEAgdm9pZCBFdmVudFNlbmRlcjo6a2V5RG93 bihjb25zdCBRU3RyaW5nICZzdHJpbmcsIGNvbnN0IFFTdHJpbmdMaXN0ICZtb2RpZmllcnMpCiAg ICAgfQogICAgIFFLZXlFdmVudCBldmVudChRRXZlbnQ6OktleVByZXNzLCBjb2RlLCBtb2RpZnMs IHMpOwogICAgIFFBcHBsaWNhdGlvbjo6c2VuZEV2ZW50KG1fcGFnZSwgJmV2ZW50KTsKKyAgICBR S2V5RXZlbnQgZXZlbnQyKFFFdmVudDo6S2V5UmVsZWFzZSxjb2RlLCBtb2RpZnMsIHMpOworICAg IFFBcHBsaWNhdGlvbjo6c2VuZEV2ZW50KG1fcGFnZSwgJmV2ZW50Mik7CiB9CiAKIHZvaWQgRXZl bnRTZW5kZXI6OmNvbnRleHRDbGljaygpCi0tIAoxLjYuNC40Cgo= 40572 2009-10-03 07:21:37 -0700 2009-10-03 07:56:52 -0700 patch 0001-Qt-Fix-the-EventSender-keyDown-implementation.patch text/plain 1761 jwieczorek RnJvbSAzZGY2MDE4OWJiOTkwYTBiYjgzNzM2YTExNzBmNjUxNTUwZmEyMzViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFNhdCwgMyBPY3QgMjAwOSAxODoyMDo0NiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0g Rml4IHRoZSBFdmVudFNlbmRlcjo6a2V5RG93bigpIGltcGxlbWVudGF0aW9uCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAwNDMKCkl0IHNob3VsZCBwb3N0IGJvdGgg YSBrZXkgcHJlc3MgZXZlbnQgYW5kIGEga2V5IHJlbGVhc2UgZXZlbnQsCmp1c3QgbGlrZSBvdGhl ciBwb3J0cyBkby4KLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9q c29iamVjdHMuY3BwIHwgICAgMiArKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCsp LCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dl YktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAyNGJmNTYxLi43MGEwNTk2IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMDktMTAtMDMgIEpha3ViIFdpZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBG aXggdGhlIEV2ZW50U2VuZGVyOjprZXlEb3duKCkgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMDQzCisKKyAgICAgICAgSXQg c2hvdWxkIHBvc3QgYm90aCBhIGtleSBwcmVzcyBldmVudCBhbmQgYSBrZXkgcmVsZWFzZSBldmVu dCwKKyAgICAgICAganVzdCBsaWtlIG90aGVyIHBvcnRzIGRvLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvcXQvanNvYmplY3RzLmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjprZXlEb3du KToKKwogMjAwOS0xMC0wMiAgSnVsaWUgUGFyZW50ICA8anBhcmVudEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L2pzb2JqZWN0cy5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9qc29i amVjdHMuY3BwCmluZGV4IGZjMWMzNWYuLjUzYmJjNDggMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0cy5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvanNvYmplY3RzLmNwcApAQCAtNTE0LDYgKzUxNCw4IEBAIHZvaWQgRXZlbnRT ZW5kZXI6OmtleURvd24oY29uc3QgUVN0cmluZyAmc3RyaW5nLCBjb25zdCBRU3RyaW5nTGlzdCAm bW9kaWZpZXJzKQogICAgIH0KICAgICBRS2V5RXZlbnQgZXZlbnQoUUV2ZW50OjpLZXlQcmVzcywg Y29kZSwgbW9kaWZzLCBzKTsKICAgICBRQXBwbGljYXRpb246OnNlbmRFdmVudChtX3BhZ2UsICZl dmVudCk7CisgICAgUUtleUV2ZW50IGV2ZW50MihRRXZlbnQ6OktleVJlbGVhc2UsY29kZSwgbW9k aWZzLCBzKTsKKyAgICBRQXBwbGljYXRpb246OnNlbmRFdmVudChtX3BhZ2UsICZldmVudDIpOwog fQogCiB2b2lkIEV2ZW50U2VuZGVyOjpjb250ZXh0Q2xpY2soKQotLSAKMS42LjQuNAoK 40574 2009-10-03 07:56:52 -0700 2009-10-06 04:35:15 -0700 patch 0001-Qt-Fix-the-EventSender-keyDown-implementation.patch text/plain 1762 jwieczorek RnJvbSAwZDE2YzY2NDdhMjJmMmM3N2VjYzFkZTlhZTBiYTIyZjZlMDkyNjk1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFNhdCwgMyBPY3QgMjAwOSAxODoyMDo0NiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIFtRdF0g Rml4IHRoZSBFdmVudFNlbmRlcjo6a2V5RG93bigpIGltcGxlbWVudGF0aW9uCiBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAwNDMKCkl0IHNob3VsZCBwb3N0IGJvdGgg YSBrZXkgcHJlc3MgZXZlbnQgYW5kIGEga2V5IHJlbGVhc2UgZXZlbnQsCmp1c3QgbGlrZSBvdGhl ciBwb3J0cyBkby4KLS0tCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAg ICAgIHwgICAxMyArKysrKysrKysrKysrCiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9q c29iamVjdHMuY3BwIHwgICAgMiArKwogMiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCsp LCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dl YktpdFRvb2xzL0NoYW5nZUxvZwppbmRleCAyNGJmNTYxLi43MGEwNTk2IDEwMDY0NAotLS0gYS9X ZWJLaXRUb29scy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMDktMTAtMDMgIEpha3ViIFdpZWN6b3JlayAgPGZhdzIxN0BnbWFpbC5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBG aXggdGhlIEV2ZW50U2VuZGVyOjprZXlEb3duKCkgaW1wbGVtZW50YXRpb24KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMDQzCisKKyAgICAgICAgSXQg c2hvdWxkIHBvc3QgYm90aCBhIGtleSBwcmVzcyBldmVudCBhbmQgYSBrZXkgcmVsZWFzZSBldmVu dCwKKyAgICAgICAganVzdCBsaWtlIG90aGVyIHBvcnRzIGRvLgorCisgICAgICAgICogRHVtcFJl bmRlclRyZWUvcXQvanNvYmplY3RzLmNwcDoKKyAgICAgICAgKEV2ZW50U2VuZGVyOjprZXlEb3du KToKKwogMjAwOS0xMC0wMiAgSnVsaWUgUGFyZW50ICA8anBhcmVudEBjaHJvbWl1bS5vcmc+CiAK ICAgICAgICAgVW5yZXZpZXdlZC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L2pzb2JqZWN0cy5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9qc29i amVjdHMuY3BwCmluZGV4IGZjMWMzNWYuLjNhZTIwNjcgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL3F0L2pzb2JqZWN0cy5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvanNvYmplY3RzLmNwcApAQCAtNTE0LDYgKzUxNCw4IEBAIHZvaWQgRXZlbnRT ZW5kZXI6OmtleURvd24oY29uc3QgUVN0cmluZyAmc3RyaW5nLCBjb25zdCBRU3RyaW5nTGlzdCAm bW9kaWZpZXJzKQogICAgIH0KICAgICBRS2V5RXZlbnQgZXZlbnQoUUV2ZW50OjpLZXlQcmVzcywg Y29kZSwgbW9kaWZzLCBzKTsKICAgICBRQXBwbGljYXRpb246OnNlbmRFdmVudChtX3BhZ2UsICZl dmVudCk7CisgICAgUUtleUV2ZW50IGV2ZW50MihRRXZlbnQ6OktleVJlbGVhc2UsIGNvZGUsIG1v ZGlmcywgcyk7CisgICAgUUFwcGxpY2F0aW9uOjpzZW5kRXZlbnQobV9wYWdlLCAmZXZlbnQyKTsK IH0KIAogdm9pZCBFdmVudFNlbmRlcjo6Y29udGV4dENsaWNrKCkKLS0gCjEuNi40LjQKCg==