30026 2009-10-02 13:15:59 -0700 [Chromium] Improve _NPN_SetException's handling of unexpected NPClass types 2009-10-13 10:31:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 japhet japhet dglazkov oldest_to_newest 151962 0 japhet 2009-10-02 13:15:59 -0700 Currently, if _NPN_SetException is passed any NPObject* not created from NPV8Object.cpp's npScriptObjectClass, it will exit early without actually throwing an exception. This check is to ensure that the NPObject* can be cast to an V8NPObject*, which we use to throw the exception in the relevant scope. Since both JSC and Mozilla appear to throw global exceptions, we should probably do the same if we can't find the right context. 151963 1 40543 japhet 2009-10-02 13:20:19 -0700 Created attachment 40543 patch 152000 2 40543 eric 2009-10-02 15:38:29 -0700 Comment on attachment 40543 patch So long as this is already tested, then this looks fine. 40543 2009-10-02 13:20:19 -0700 2009-10-02 15:38:29 -0700 patch patch.txt text/plain 1667 japhet SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTAzMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTAtMDIgIE5hdGUgQ2hhcGluICA8amFwaGV0QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB bGxvdyBWOCB0byB0aHJvdyBhbiBleGNlcHRpb24gaW4gX05QTl9TZXRFeGNlcHRpb24gd2l0aG91 dCB3b3JyeWluZyBhYm91dCBjb250ZXh0CisgICAgICAgIGlmIHdlIGRvbid0IGhhdmUgZW5vdWdo IGluZm9ybWF0aW9uIHRvIGZpbmQgdGhlIGNvcnJlY3QgY29udGV4dC4KKworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzAwMjYKKworICAgICAgICBQYXJ0 IG9mIHRoZSBmaXggZm9yIENocm9taXVtJ3MgZmFpbHVyZSBvZiBMYXlvdVRlc3RzL3BsdWdpbnMv bmV0c2NhcGUtdGhyb3ctZXhjZXB0aW9uLmh0bWwuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9O UFY4T2JqZWN0LmNwcDogCisgICAgICAgIChfTlBOX1NldEV4Y2VwdGlvbik6IERvbid0IHN1cHBy ZXNzIHRoZSBleGNlcHRpb24gaWYgd2UgY2FuJ3QgZmluZCB0aGUgcmVsZXZhbnQgY29udGV4dC4K KwogMjAwOS0xMC0wMiAgRGF2ZSBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9OUFY4T2Jq ZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L05QVjhPYmplY3QuY3Bw CShyZXZpc2lvbiA0OTAzMykKKysrIFdlYkNvcmUvYmluZGluZ3MvdjgvTlBWOE9iamVjdC5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTQwMCw4ICs0MDAsMTIgQEAgYm9vbCBfTlBOX0hhc01ldGhvZChO UFAgbnBwLCBOUE9iamVjdCogbgogCiB2b2lkIF9OUE5fU2V0RXhjZXB0aW9uKE5QT2JqZWN0KiBu cE9iamVjdCwgY29uc3QgTlBVVEY4ICptZXNzYWdlKQogewotICAgIGlmIChucE9iamVjdC0+X2Ns YXNzICE9IG5wU2NyaXB0T2JqZWN0Q2xhc3MpCisgICAgaWYgKG5wT2JqZWN0LT5fY2xhc3MgIT0g bnBTY3JpcHRPYmplY3RDbGFzcykgeworICAgICAgICAvLyBXZSB3b24ndCBiZSBhYmxlIHRvIGZp bmQgYSBwcm9wZXIgc2NvcGUgZm9yIHRoaXMgZXhjZXB0aW9uLCBzbyBqdXN0IHRocm93IGl0Lgor ICAgICAgICAvLyBUaGlzIGlzIGNvbnNpc3RlbnQgd2l0aCBKU0MsIHdoaWNoIHRocm93cyBhIGds b2JhbCBleGNlcHRpb24gYWxsIHRoZSB0aW1lLgorICAgICAgICBWOFByb3h5Ojp0aHJvd0Vycm9y KFY4UHJveHk6OkdlbmVyYWxFcnJvciwgbWVzc2FnZSk7CiAgICAgICAgIHJldHVybjsKKyAgICB9 CiAgICAgdjg6OkhhbmRsZVNjb3BlIGhhbmRsZVNjb3BlOwogICAgIHY4OjpIYW5kbGU8djg6OkNv bnRleHQ+IGNvbnRleHQgPSB0b1Y4Q29udGV4dCgwLCBucE9iamVjdCk7CiAgICAgaWYgKGNvbnRl eHQuSXNFbXB0eSgpKQo=