30020 2009-10-02 09:32:55 -0700 [chromium] Fix WebGL build after CustomGetter constructor changes 2009-12-15 14:43:32 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 kbr kbr cmarrin commit-queue dglazkov oliver oldest_to_newest 151869 0 kbr 2009-10-02 09:32:55 -0700 https://bugs.webkit.org/show_bug.cgi?id=29940 changed the form of V8 bindings for constructors marked CustomGetter. The constructors being proposed in the WebGL spec for new array-like objects don't need this special treatment so the CustomGetter should be changed to JSCCustomGetter. I'm not 100% sure even this attribute is needed but I've built both WebKit and Chromium with this change and verified that it fixes the Chromium WebGL build without affecting the WebKit build. 151872 1 40530 kbr 2009-10-02 09:37:31 -0700 Created attachment 40530 Patch 151923 2 dglazkov 2009-10-02 11:55:16 -0700 Can we just make these non-custom? Doesn't look like they're doing much. 151969 3 kbr 2009-10-02 14:16:51 -0700 I tried removing the JSCCustomGetter attribute and doing so breaks the WebKit build. It seems this patch is correct for both Chrome and WebKit. 151982 4 40530 dglazkov 2009-10-02 15:06:57 -0700 Comment on attachment 40530 Patch ok. 151996 5 40530 commit-queue 2009-10-02 15:33:48 -0700 Comment on attachment 40530 Patch Clearing flags on attachment: 40530 Committed r49049: <http://trac.webkit.org/changeset/49049> 151997 6 commit-queue 2009-10-02 15:33:51 -0700 All reviewed patches have been landed. Closing bug. 40530 2009-10-02 09:37:31 -0700 2009-10-02 15:33:47 -0700 Patch dom-window.patch text/plain 3291 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0OTAyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMDIgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gRml4IFdlYkdMIGJ1aWxkIGFmdGVyIEN1c3RvbUdldHRlciBjb25zdHJ1Y3RvciBj aGFuZ2VzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z MDAyMAorCisgICAgICAgICogcGFnZS9ET01XaW5kb3cuaWRsOgorICAgICAgICBDaGFuZ2VkIEN1 c3RvbUdldHRlciB0byBKU0NDdXN0b21HZXR0ZXIgZm9yIENhbnZhc0FycmF5IGNvbnN0cnVjdG9y cy4KKwogMjAwOS0xMC0wMiAgTm9yYmVydCBMZXNlciAgPG5vcmJlcnQubGVzZXJAbm9raWEuY29t PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2ViQ29yZS9w YWdlL0RPTVdpbmRvdy5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5p ZGwJKHJldmlzaW9uIDQ5MDA2KQorKysgV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5pZGwJKHdvcmtp bmcgY29weSkKQEAgLTQzNCwxNCArNDM0LDE0IEBAIG1vZHVsZSB3aW5kb3cgewogICAgICAgICBh dHRyaWJ1dGUgW0NvbmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDNE Q29uc3RydWN0b3IgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDNEOwogICAgICAgICBhdHRyaWJ1dGUg VGV4dE1ldHJpY3NDb25zdHJ1Y3RvciBUZXh0TWV0cmljczsKIAotICAgICAgICBhdHRyaWJ1dGUg W0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZhc0FycmF5QnVmZmVyQ29u c3RydWN0b3IgQ2FudmFzQXJyYXlCdWZmZXI7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgot ICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENh bnZhc0J5dGVBcnJheUNvbnN0cnVjdG9yIENhbnZhc0J5dGVBcnJheTsgLy8gVXNhYmxlIHdpdGgg bmV3IG9wZXJhdG9yCi0gICAgICAgIGF0dHJpYnV0ZSBbQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFs PTNEX0NBTlZBU10gQ2FudmFzVW5zaWduZWRCeXRlQXJyYXlDb25zdHJ1Y3RvciBDYW52YXNVbnNp Z25lZEJ5dGVBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCi0gICAgICAgIGF0dHJp YnV0ZSBbQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzU2hvcnRBcnJh eUNvbnN0cnVjdG9yIENhbnZhc1Nob3J0QXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRv cgotICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNd IENhbnZhc1Vuc2lnbmVkU2hvcnRBcnJheUNvbnN0cnVjdG9yIENhbnZhc1Vuc2lnbmVkU2hvcnRB cnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCi0gICAgICAgIGF0dHJpYnV0ZSBbQ3Vz dG9tR2V0dGVyLENvbmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzSW50QXJyYXlDb25zdHJ1Y3Rv ciBDYW52YXNJbnRBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCi0gICAgICAgIGF0 dHJpYnV0ZSBbQ3VzdG9tR2V0dGVyLENvbmRpdGlvbmFsPTNEX0NBTlZBU10gQ2FudmFzVW5zaWdu ZWRJbnRBcnJheUNvbnN0cnVjdG9yIENhbnZhc1Vuc2lnbmVkSW50QXJyYXk7IC8vIFVzYWJsZSB3 aXRoIG5ldyBvcGVyYXRvcgotICAgICAgICBhdHRyaWJ1dGUgW0N1c3RvbUdldHRlcixDb25kaXRp b25hbD0zRF9DQU5WQVNdIENhbnZhc0Zsb2F0QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNGbG9hdEFy cmF5OyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKKyAgICAgICAgYXR0cmlidXRlIFtKU0ND dXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBDYW52YXNBcnJheUJ1ZmZlckNvbnN0 cnVjdG9yIENhbnZhc0FycmF5QnVmZmVyOyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKKyAg ICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBD YW52YXNCeXRlQXJyYXlDb25zdHJ1Y3RvciBDYW52YXNCeXRlQXJyYXk7IC8vIFVzYWJsZSB3aXRo IG5ldyBvcGVyYXRvcgorICAgICAgICBhdHRyaWJ1dGUgW0pTQ0N1c3RvbUdldHRlcixDb25kaXRp b25hbD0zRF9DQU5WQVNdIENhbnZhc1Vuc2lnbmVkQnl0ZUFycmF5Q29uc3RydWN0b3IgQ2FudmFz VW5zaWduZWRCeXRlQXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgorICAgICAgICBh dHRyaWJ1dGUgW0pTQ0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZhc1No b3J0QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNTaG9ydEFycmF5OyAvLyBVc2FibGUgd2l0aCBuZXcg b3BlcmF0b3IKKyAgICAgICAgYXR0cmlidXRlIFtKU0NDdXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9 M0RfQ0FOVkFTXSBDYW52YXNVbnNpZ25lZFNob3J0QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNVbnNp Z25lZFNob3J0QXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRvcgorICAgICAgICBhdHRy aWJ1dGUgW0pTQ0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5WQVNdIENhbnZhc0ludEFy cmF5Q29uc3RydWN0b3IgQ2FudmFzSW50QXJyYXk7IC8vIFVzYWJsZSB3aXRoIG5ldyBvcGVyYXRv cgorICAgICAgICBhdHRyaWJ1dGUgW0pTQ0N1c3RvbUdldHRlcixDb25kaXRpb25hbD0zRF9DQU5W QVNdIENhbnZhc1Vuc2lnbmVkSW50QXJyYXlDb25zdHJ1Y3RvciBDYW52YXNVbnNpZ25lZEludEFy cmF5OyAvLyBVc2FibGUgd2l0aCBuZXcgb3BlcmF0b3IKKyAgICAgICAgYXR0cmlidXRlIFtKU0ND dXN0b21HZXR0ZXIsQ29uZGl0aW9uYWw9M0RfQ0FOVkFTXSBDYW52YXNGbG9hdEFycmF5Q29uc3Ry dWN0b3IgQ2FudmFzRmxvYXRBcnJheTsgLy8gVXNhYmxlIHdpdGggbmV3IG9wZXJhdG9yCiAKICAg ICAgICAgYXR0cmlidXRlIEV2ZW50Q29uc3RydWN0b3IgRXZlbnQ7CiAgICAgICAgIGF0dHJpYnV0 ZSBLZXlib2FyZEV2ZW50Q29uc3RydWN0b3IgS2V5Ym9hcmRFdmVudDsK