300090 2025-10-03 03:19:59 -0700 REGRESSION(296017@main): AX: at-spi role mapping is broken 2026-01-06 09:39:41 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 lukastyrychtr webkit-unassigned andresg_22 cgarcia mcatanzaro mgorse rahim_abdi webkit-bug-importer oldest_to_newest 2148088 0 lukastyrychtr 2025-10-03 03:19:59 -0700 After 3d8ea36b3cc8 (the commit adding support for sectionhead and sectionfooter roles), the at-spi2 role mapping is wrong, because the commit allso removed the footer role, so each of the ones following is wrong, including, for example, the document web role. I am unfortunately not knowledgeable enough about the contribution procedure, so I am reporting it instead of making the one line patch which would fix it. 2148089 1 webkit-bug-importer 2025-10-03 03:20:44 -0700 <rdar://problem/161885093> 2149461 2 mcatanzaro 2025-10-08 08:29:51 -0700 You say that a one-line patch would fix this, but... where? I see AccessibilityAtspi.cpp‎, AccessibilityAtspiEnums.h‎, AccessibilityObjectAtspi.cpp‎, and AccessibilityUIElementAtspi.cpp‎ were all updated. What else needs to be updated? 2149640 3 lukastyrychtr 2025-10-08 23:47:38 -0700 his one is the removed Footer member from the Role enum - as a result, the enum got out of sync from the upstream at-spi2 definition. 2149736 4 mcatanzaro 2025-10-09 11:07:48 -0700 OK, I see you're talking about the Role enum defined in AccessibilityAtspiEnums.h‎, which no longer matches the AtspiRole enum defined in atspi-constants.h. Removing Footer is not the only problem. The addition of SectionFooter and SectionHeader is also going to break it. There is zero indication that the WebCore enum is supposed to be kept in sync with the at-spi2 enum, so it's not reasonable to expect WebKit developers to not change it. And it looks like there are many other similar enums in this header that we could similarly break in the future. Hi Carlos Garcia, can you look at this please? Why do we have to redefine the enums at all? At the very least, we should add warning comments to each one. 2165507 5 mgorse 2025-12-12 13:18:01 -0800 I wonder why the tests in TestWebKitAccessibility.cpp wouldn't have caught this. Is this test run automatically? It has several tests that call atspi_accessible_get_role and assert that it returns the correct value, including some that are past ATSPI_ROLE_FOOTER in the enum. 2165567 6 mgorse 2025-12-12 17:21:13 -0800 Pull request: https://github.com/WebKit/WebKit/pull/55343 2167418 7 ews-feeder 2025-12-19 15:35:22 -0800 Committed 304783@main (7a4fc4e0025a): <https://commits.webkit.org/304783@main> Reviewed commits have been landed. Closing PR #55343 and removing active labels. 2169643 8 mcatanzaro 2026-01-06 09:39:41 -0800 (In reply to Mike Gorse from comment #5) > I wonder why the tests in TestWebKitAccessibility.cpp wouldn't have caught > this. Is this test run automatically? It has several tests that call > atspi_accessible_get_role and assert that it returns the correct value, > including some that are past ATSPI_ROLE_FOOTER in the enum. They are run automatically, but looks like they're all expected to fail, except for a few that are skipped. We would only notice if the non-skipped tests were to begin unexpectedly passing. See Tools/TestWebKitAPI/glib/TestExpectations.json, bug #279009, and bug #273682.