30003 2009-10-02 01:45:16 -0700 [GStreamer] READY state doesn't mean "enough data" 2009-10-15 07:47:00 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 slomo webkit-unassigned commit-queue pnormand oldest_to_newest 151794 0 slomo 2009-10-02 01:45:16 -0700 Hi, currently in MediaPlayerPrivate::updateStates() it is assumed that READY means that there is enough data. That's not true, READY only means that devices could be opened successfully, not that the sinks already has the first data. That's only true for PAUSED or PLAYING. 154747 1 41214 pnormand 2009-10-15 02:23:45 -0700 Created attachment 41214 proposed patch 154773 2 41214 gustavo 2009-10-15 06:00:18 -0700 Comment on attachment 41214 proposed patch Can you add the bug URL to the ChangeLog? =) 154774 3 41222 pnormand 2009-10-15 06:05:59 -0700 Created attachment 41222 now with bug link 154796 4 41222 commit-queue 2009-10-15 07:46:56 -0700 Comment on attachment 41222 now with bug link Clearing flags on attachment: 41222 Committed r49626: <http://trac.webkit.org/changeset/49626> 154797 5 commit-queue 2009-10-15 07:47:00 -0700 All reviewed patches have been landed. Closing bug. 41214 2009-10-15 02:23:45 -0700 2009-10-15 06:05:59 -0700 proposed patch 0001-STATE_READY-means-MediaPlayer-HaveNothing.patch text/plain 2610 pnormand RnJvbSAyOGU1NzM4MGZmZjZjMTU5MmQwNTRkM2I2ODE4YjM5OGIwMmI3OWNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDE1IE9jdCAyMDA5IDExOjAwOjI1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U1RBVEVfUkVBRFkgbWVhbnMgTWVkaWFQbGF5ZXI6OkhhdmVOb3RoaW5nCgotLS0KIFdlYkNvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMCArKysrKysr KysrCiAuLi4vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgICB8 ICAgMTcgKysrKysrKysrLS0tLS0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMTkgaW5zZXJ0aW9ucygr KSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNv cmUvQ2hhbmdlTG9nCmluZGV4IGY3YWNkNjguLjRiZDIyODMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDkt MTAtMTUgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHU3RyZWFtZXJdIFJFQURZ IHN0YXRlIGRvZXNuJ3QgbWVhbiAiZW5vdWdoIGRhdGEiCisgICAgICAgIFNUQVRFX1JFQURZIG1l YW5zIE1lZGlhUGxheWVyOjpIYXZlTm90aGluZworCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpNZWRpYVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcyk6CisKIDIwMDktMTAtMTUgIEpvc2Vw aCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggV2luZG93cyBi dWlsZC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCmluZGV4IDc2Yjk5MmYuLjc4ZTA1NjEgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcApAQCAtNTE0LDE0ICs1MTQsMTUgQEAgdm9pZCBNZWRp YVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcygpCiAgICAgICAgICAgICBnc3RfZWxlbWVudF9z dGF0ZV9nZXRfbmFtZShzdGF0ZSksCiAgICAgICAgICAgICBnc3RfZWxlbWVudF9zdGF0ZV9nZXRf bmFtZShwZW5kaW5nKSk7CiAKLSAgICAgICAgaWYgKHN0YXRlID09IEdTVF9TVEFURV9SRUFEWSkg ewotICAgICAgICAgICAgbV9yZWFkeVN0YXRlID0gTWVkaWFQbGF5ZXI6OkhhdmVFbm91Z2hEYXRh OwotICAgICAgICB9IGVsc2UgaWYgKHN0YXRlID09IEdTVF9TVEFURV9QQVVTRUQpCisgICAgICAg IGlmIChzdGF0ZSA9PSBHU1RfU1RBVEVfUkVBRFkpCisgICAgICAgICAgICBtX3JlYWR5U3RhdGUg PSBNZWRpYVBsYXllcjo6SGF2ZU5vdGhpbmc7CisgICAgICAgIGVsc2UgaWYgKHN0YXRlID09IEdT VF9TVEFURV9QQVVTRUQpCiAgICAgICAgICAgICBtX3JlYWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6 SGF2ZUVub3VnaERhdGE7CiAKLSAgICAgICAgaWYgKHN0YXRlID09IEdTVF9TVEFURV9QTEFZSU5H KQorICAgICAgICBpZiAoc3RhdGUgPT0gR1NUX1NUQVRFX1BMQVlJTkcpIHsKKyAgICAgICAgICAg IG1fcmVhZHlTdGF0ZSA9IE1lZGlhUGxheWVyOjpIYXZlRW5vdWdoRGF0YTsKICAgICAgICAgICAg IG1fcGF1c2VkID0gZmFsc2U7Ci0gICAgICAgIGVsc2UKKyAgICAgICAgfSBlbHNlCiAgICAgICAg ICAgICBtX3BhdXNlZCA9IHRydWU7CiAKICAgICAgICAgaWYgKG1fc2Vla2luZykgewpAQCAtNTUy LDkgKzU1Myw5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjp1cGRhdGVTdGF0ZXMoKQogICAg ICAgICAgICAgZ3N0X2VsZW1lbnRfc3RhdGVfZ2V0X25hbWUoc3RhdGUpLAogICAgICAgICAgICAg Z3N0X2VsZW1lbnRfc3RhdGVfZ2V0X25hbWUocGVuZGluZykpOwogCi0gICAgICAgIGlmIChzdGF0 ZSA9PSBHU1RfU1RBVEVfUkVBRFkpIHsKLSAgICAgICAgICAgIG1fcmVhZHlTdGF0ZSA9IE1lZGlh UGxheWVyOjpIYXZlRnV0dXJlRGF0YTsKLSAgICAgICAgfSBlbHNlIGlmIChzdGF0ZSA9PSBHU1Rf U1RBVEVfUEFVU0VEKQorICAgICAgICBpZiAoc3RhdGUgPT0gR1NUX1NUQVRFX1JFQURZKQorICAg ICAgICAgICAgbV9yZWFkeVN0YXRlID0gTWVkaWFQbGF5ZXI6OkhhdmVOb3RoaW5nOworICAgICAg ICBlbHNlIGlmIChzdGF0ZSA9PSBHU1RfU1RBVEVfUEFVU0VEKQogICAgICAgICAgICAgbV9yZWFk eVN0YXRlID0gTWVkaWFQbGF5ZXI6OkhhdmVDdXJyZW50RGF0YTsKIAogICAgICAgICBtX25ldHdv cmtTdGF0ZSA9IE1lZGlhUGxheWVyOjpMb2FkaW5nOwotLSAKMS42LjMuMwoK 41222 2009-10-15 06:05:59 -0700 2009-10-15 07:46:56 -0700 now with bug link 0001-STATE_READY-means-MediaPlayer-HaveNothing.patch text/plain 2669 pnormand RnJvbSA5ZmNiN2Q4MTc2MGMyNGRkYjFjY2RjOGU0M2U2ZjlmNDM1ZWFiYTQwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDE1IE9jdCAyMDA5IDExOjAwOjI1ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g U1RBVEVfUkVBRFkgbWVhbnMgTWVkaWFQbGF5ZXI6OkhhdmVOb3RoaW5nCgotLS0KIFdlYkNvcmUv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiArKysrKysr KysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAg IHwgICAxNyArKysrKysrKystLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25z KCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKaW5kZXggZjdhY2Q2OC4uYTkxNWEyNCAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAw OS0xMC0xNSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dTdHJlYW1lcl0gUkVB RFkgc3RhdGUgZG9lc24ndCBtZWFuICJlbm91Z2ggZGF0YSIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMwMDAzCisKKyAgICAgICAgU1RBVEVfUkVBRFkg bWVhbnMgTWVkaWFQbGF5ZXI6OkhhdmVOb3RoaW5nCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFw aGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6Ok1lZGlhUGxheWVyUHJpdmF0ZTo6dXBkYXRlU3RhdGVzKToKKwogMjAwOS0xMC0xNSAgSm9z ZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAgICAgICAgIEZpeCBXaW5kb3dz IGJ1aWxkLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQ bGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3Rr L01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXggNzZiOTkyZi4uNzhlMDU2MSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2 YXRlR1N0cmVhbWVyLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRp YVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwCkBAIC01MTQsMTQgKzUxNCwxNSBAQCB2b2lkIE1l ZGlhUGxheWVyUHJpdmF0ZTo6dXBkYXRlU3RhdGVzKCkKICAgICAgICAgICAgIGdzdF9lbGVtZW50 X3N0YXRlX2dldF9uYW1lKHN0YXRlKSwKICAgICAgICAgICAgIGdzdF9lbGVtZW50X3N0YXRlX2dl dF9uYW1lKHBlbmRpbmcpKTsKIAotICAgICAgICBpZiAoc3RhdGUgPT0gR1NUX1NUQVRFX1JFQURZ KSB7Ci0gICAgICAgICAgICBtX3JlYWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6SGF2ZUVub3VnaERh dGE7Ci0gICAgICAgIH0gZWxzZSBpZiAoc3RhdGUgPT0gR1NUX1NUQVRFX1BBVVNFRCkKKyAgICAg ICAgaWYgKHN0YXRlID09IEdTVF9TVEFURV9SRUFEWSkKKyAgICAgICAgICAgIG1fcmVhZHlTdGF0 ZSA9IE1lZGlhUGxheWVyOjpIYXZlTm90aGluZzsKKyAgICAgICAgZWxzZSBpZiAoc3RhdGUgPT0g R1NUX1NUQVRFX1BBVVNFRCkKICAgICAgICAgICAgIG1fcmVhZHlTdGF0ZSA9IE1lZGlhUGxheWVy OjpIYXZlRW5vdWdoRGF0YTsKIAotICAgICAgICBpZiAoc3RhdGUgPT0gR1NUX1NUQVRFX1BMQVlJ TkcpCisgICAgICAgIGlmIChzdGF0ZSA9PSBHU1RfU1RBVEVfUExBWUlORykgeworICAgICAgICAg ICAgbV9yZWFkeVN0YXRlID0gTWVkaWFQbGF5ZXI6OkhhdmVFbm91Z2hEYXRhOwogICAgICAgICAg ICAgbV9wYXVzZWQgPSBmYWxzZTsKLSAgICAgICAgZWxzZQorICAgICAgICB9IGVsc2UKICAgICAg ICAgICAgIG1fcGF1c2VkID0gdHJ1ZTsKIAogICAgICAgICBpZiAobV9zZWVraW5nKSB7CkBAIC01 NTIsOSArNTUzLDkgQEAgdm9pZCBNZWRpYVBsYXllclByaXZhdGU6OnVwZGF0ZVN0YXRlcygpCiAg ICAgICAgICAgICBnc3RfZWxlbWVudF9zdGF0ZV9nZXRfbmFtZShzdGF0ZSksCiAgICAgICAgICAg ICBnc3RfZWxlbWVudF9zdGF0ZV9nZXRfbmFtZShwZW5kaW5nKSk7CiAKLSAgICAgICAgaWYgKHN0 YXRlID09IEdTVF9TVEFURV9SRUFEWSkgewotICAgICAgICAgICAgbV9yZWFkeVN0YXRlID0gTWVk aWFQbGF5ZXI6OkhhdmVGdXR1cmVEYXRhOwotICAgICAgICB9IGVsc2UgaWYgKHN0YXRlID09IEdT VF9TVEFURV9QQVVTRUQpCisgICAgICAgIGlmIChzdGF0ZSA9PSBHU1RfU1RBVEVfUkVBRFkpCisg ICAgICAgICAgICBtX3JlYWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6SGF2ZU5vdGhpbmc7CisgICAg ICAgIGVsc2UgaWYgKHN0YXRlID09IEdTVF9TVEFURV9QQVVTRUQpCiAgICAgICAgICAgICBtX3Jl YWR5U3RhdGUgPSBNZWRpYVBsYXllcjo6SGF2ZUN1cnJlbnREYXRhOwogCiAgICAgICAgIG1fbmV0 d29ya1N0YXRlID0gTWVkaWFQbGF5ZXI6OkxvYWRpbmc7Ci0tIAoxLjYuMy4zCgo=