299972 2025-10-01 11:38:57 -0700 [Style] Replace isZero/isNegative/isPositive functions inherited from WebCore::Length 2025-11-03 11:19:00 -0800 1 1 1 Unclassified WebKit CSS Safari 18 Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=301873 InRadar P2 Normal --- 1 sam dpino dpino koivisto simon.fraser webkit-bug-importer oldest_to_newest 2147605 0 sam 2025-10-01 11:38:57 -0700 StyleLengthPercentage<> and Style::LengthWrapperBase<> inherited (to help things continue to work without too much churn) the isZero/isNegative/isPositive functions and along with them their quirky behavior with calc and keywords. For a type that includes a Length, Percentage, Calc, and Keywords, the functions have the following behavior: isZero: - Length (compare value, makes sense) - Percentage (compare value, makes sense) - Calc (always FALSE) - Keyword (always TRUE, due to keywords having a value of 0). isPositive: - Length (compare value, makes sense) - Percentage (compare value, makes sense) - Calc (always TRUE) - Keyword (always FALSE, due to keywords having a value of 0). isNegative: - Length (compare value, makes sense) - Percentage (compare value, makes sense) - Calc (always FALSE) - Keyword (always FALSE, due to keywords having a value of 0). We should remove them, and, if necessary, replace them with more accurately named functions. 2147606 1 sam 2025-10-01 11:50:15 -0700 Pull request: https://github.com/WebKit/WebKit/pull/51635 2147999 2 ews-feeder 2025-10-02 18:01:06 -0700 Committed 300911@main (33b130ec17ce): <https://commits.webkit.org/300911@main> Reviewed commits have been landed. Closing PR #51635 and removing active labels. 2148000 3 webkit-bug-importer 2025-10-02 18:02:18 -0700 <rdar://problem/161861437> 2149044 4 dpino 2025-10-07 03:31:43 -0700 This change broke WPEWebKit/WebKitGTK builds with GCC12. The build error is: https://build.webkit.org/#/builders/46/builds/55581 ``` /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/StyleLengthWrapper.h:146:67: error: invalid use of non-static data member ‘WebCore::Style::PrimitiveNumeric<WebCore::CSS::Percentage<WebCore::CSS::Range{0.0, +Inf, WebCore::CSS::RangeClampOptions::Default, WebCore::CSS::RangeZoomOptions::Default}, float> >::value’ 146 | else if (opaqueType == indexForPercentage) return visitor(Percentage { m_value.value() }); | ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/StylePrimitiveNumericTypes.h:28, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/CSSColorDescriptors.h:35, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/CSSColor.h:29, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/CSSGradient.h:29, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/CSSCircleFunction.h:27, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/CSSBasicShape.h:27, from /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/StyleBasicShape.h:27: /home/buildbot/worker/GTK-Linux-64-bit-Release-Debian-12-Build/build/WebKitBuild/GTK/Release/WebCore/PrivateHeaders/WebCore/StylePrimitiveNumeric.h:60:23: note: declared here 60 | ResolvedValueType value { 0 }; ``` 2149050 5 dpino 2025-10-07 04:17:31 -0700 Re-opening for pull request https://github.com/WebKit/WebKit/pull/51934 2149732 6 ews-feeder 2025-10-09 10:21:31 -0700 Committed 301265@main (0e023c832420): <https://commits.webkit.org/301265@main> Reviewed commits have been landed. Closing PR #51934 and removing active labels. 2156028 7 simon.fraser 2025-11-03 11:19:00 -0800 This caused bug 301873.