<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29986</bug_id>
          
          <creation_ts>2009-10-01 15:19:56 -0700</creation_ts>
          <short_desc>chromium port should use its own gyp_xxx instead of gyp_chromium</short_desc>
          <delta_ts>2009-10-02 11:41:57 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yaar Schnitman">yaar</reporter>
          <assigned_to name="Yaar Schnitman">yaar</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>mark</cc>
    
    <cc>yaar</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>151713</commentid>
    <comment_count>0</comment_count>
    <who name="Yaar Schnitman">yaar</who>
    <bug_when>2009-10-01 15:19:56 -0700</bug_when>
    <thetext>We don&apos;t want to use gyp_chromium out of its original context.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151911</commentid>
    <comment_count>1</comment_count>
      <attachid>40535</attachid>
    <who name="Yaar Schnitman">yaar</who>
    <bug_when>2009-10-02 11:22:11 -0700</bug_when>
    <thetext>Created attachment 40535
patch ads gyp_webkit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151914</commentid>
    <comment_count>2</comment_count>
      <attachid>40535</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-10-02 11:28:12 -0700</bug_when>
    <thetext>Comment on attachment 40535
patch ads gyp_webkit

nice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151919</commentid>
    <comment_count>3</comment_count>
      <attachid>40535</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-02 11:41:48 -0700</bug_when>
    <thetext>Comment on attachment 40535
patch ads gyp_webkit

Clearing flags on attachment: 40535

Committed r49032: &lt;http://trac.webkit.org/changeset/49032&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151920</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-02 11:41:57 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>40535</attachid>
            <date>2009-10-02 11:22:11 -0700</date>
            <delta_ts>2009-10-02 11:41:47 -0700</delta_ts>
            <desc>patch ads gyp_webkit</desc>
            <filename>WK29986.diff</filename>
            <type>text/plain</type>
            <size>4967</size>
            <attacher name="Yaar Schnitman">yaar</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9DaGFuZ2VMb2cgYi9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDAx
MmNhNGEuLjBhNmNmMDcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTEwLTAyICBZYWFyIFNjaG5pdG1hbiAg
PHlhYXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIEFkZGVkIGd5cF93ZWJraXQgdGhhdCBkb2VzIGEgc3Vic2V0IG9mIHRoZSB0
aGluZ3MgZ3lwX2Nocm9taXVtIGRvZXMKKyAgICAgICAgcGx1cyBzb21lIHNwZWNpYWxpemF0aW9u
IGZvciBhbiB1cHN0cmVhbSBjaHJvbWl1bSBidWlsZC4KKworICAgICAgICBodHRwczovL2J1Z3Mu
d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk5ODYKKworICAgICAgICAqIGNocm9taXVtL0RF
UFM6IFBvaW50cyB0byBneXBfd2Via2l0IGluc3RlYWQgb2YgZ3lwX2Nocm9taXVtLgorICAgICAg
ICAqIGNocm9taXVtL2d5cF93ZWJraXQ6IEEgbmV3IHB5dGhvbiBmaWxlLgorCiAyMDA5LTEwLTAx
ICBZYWFyIFNjaG5pdG1hbiAgPHlhYXJAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2Vk
IGJ5IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9ERVBTIGIv
V2ViS2l0L2Nocm9taXVtL0RFUFMKaW5kZXggNmIwMzI5ZC4uODg1ZWZiNSAxMDA2NDQKLS0tIGEv
V2ViS2l0L2Nocm9taXVtL0RFUFMKKysrIGIvV2ViS2l0L2Nocm9taXVtL0RFUFMKQEAgLTE3NCwx
MiArMTc0LDYgQEAgaG9va3MgPSBbCiAgIHsKICAgICAjIEEgY2hhbmdlIHRvIGFueSBmaWxlIGlu
IHRoaXMgZGlyZWN0b3J5IHNob3VsZCBydW4gdGhlIGd5cCBnZW5lcmF0b3IuCiAgICAgJ3BhdHRl
cm4nOiAnLicsCi0gICAgJ2FjdGlvbic6IFsncHl0aG9uJywKLSAgICAgICAgICAgICAgICdidWls
ZC9neXBfY2hyb21pdW0nLAotICAgICAgICAgICAgICAgJy1EaW5zaWRlX2Nocm9taXVtX2J1aWxk
PTAnLAotICAgICAgICAgICAgICAgJy1EdjhfdXNlX3NuYXBzaG90PWZhbHNlJywKLSAgICAgICAg
ICAgICAgICctRG1zdnNfdXNlX2NvbW1vbl9yZWxlYXNlPTAnLAotICAgICAgICAgICAgICAgJy0t
ZGVwdGg9Li8nLAotICAgICAgICAgICAgICAgJ3dlYmtpdC5neXAnXSwKKyAgICAnYWN0aW9uJzog
WydweXRob24nLCAnZ3lwX3dlYmtpdCddLAogICB9LAogXQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2No
cm9taXVtL2d5cF93ZWJraXQgYi9XZWJLaXQvY2hyb21pdW0vZ3lwX3dlYmtpdApuZXcgZmlsZSBt
b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwLi44MTBhZjU0Ci0tLSAvZGV2L251bGwKKysrIGIvV2Vi
S2l0L2Nocm9taXVtL2d5cF93ZWJraXQKQEAgLTAsMCArMSw5NiBAQAorIworIyBDb3B5cmlnaHQg
KEMpIDIwMDkgR29vZ2xlIEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyMKKyMgUmVkaXN0cmli
dXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0
CisjIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dp
bmcgY29uZGl0aW9ucyBhcmUKKyMgbWV0OgorIworIyAgICogUmVkaXN0cmlidXRpb25zIG9mIHNv
dXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQgbm90aWNlLAorIyAgICAg
dGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lci4KKyMg
ICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJv
dmUgY29weXJpZ2h0CisjICAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0
aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisjICAgICBkb2N1bWVudGF0aW9uIGFuZC9v
ciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorIyAgICog
TmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0cyBjb250
cmlidXRvcnMKKyMgICAgIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9kdWN0
cyBkZXJpdmVkIGZyb20gdGhpcyBzb2Z0d2FyZQorIyAgICAgd2l0aG91dCBzcGVjaWZpYyBwcmlv
ciB3cml0dGVuIHBlcm1pc3Npb24uCisjCisjIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkg
VEhFIENPUFlSSUdIVCBIT0xERVJTIEFORCBDT05UUklCVVRPUlMKKyMgIkFTIElTIiBBTkQgQU5Z
IEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElN
SVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJ
VE5FU1MgRk9SCisjIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiBJTiBOTyBF
VkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUCisjIE9XTkVSIE9SIENPTlRSSUJVVE9SUyBCRSBMSUFC
TEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLAorIyBTUEVDSUFMLCBFWEVN
UExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UCisjIExJ
TUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExP
U1MgT0YgVVNFLAorIyBEQVRBLCBPUiBQUk9GSVRTOyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04p
IEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkKKyMgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhF
UiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorIyAoSU5DTFVESU5HIE5F
R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK
KyMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBP
RiBTVUNIIERBTUFHRS4KKyMKKworIyBUaGlzIGZpbGUgaXMgdXNlZCBieSBnY2xpZW50IGV4ZWN1
dGUgZ3lwIHdpdGggdGhlIHByb3BlciBjb21tYW5kCisjIGxpbmUgYXJndW1lbnRzLgorCitpbXBv
cnQgZ2xvYgoraW1wb3J0IG9zCitpbXBvcnQgc2hsZXgKK2ltcG9ydCBzeXMKKworc2NyaXB0X2Rp
ciA9IG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXykKKworc3lzLnBhdGguYXBwZW5kKG9zLnBhdGgu
am9pbihzY3JpcHRfZGlyLCAndG9vbHMnLCAnZ3lwJywgJ3B5bGliJykpCitpbXBvcnQgZ3lwCisK
K2RlZiBhZGRpdGlvbmFsX2luY2x1ZGVfZmlsZXMoYXJncz1bXSk6CisgICIiIgorICBSZXR1cm5z
IGEgbGlzdCBvZiBhZGRpdGlvbmFsICguZ3lwaSkgZmlsZXMgdG8gaW5jbHVkZSwgd2l0aG91dAor
ICBkdXBsaWNhdGluZyBvbmVzIHRoYXQgYXJlIGFscmVhZHkgc3BlY2lmaWVkIG9uIHRoZSBjb21t
YW5kIGxpbmUuCisgICIiIgorICAjIERldGVybWluZSB0aGUgaW5jbHVkZSBmaWxlcyBzcGVjaWZp
ZWQgb24gdGhlIGNvbW1hbmQgbGluZS4KKyAgIyBUaGlzIGRvZXNuJ3QgY292ZXIgYWxsIHRoZSBk
aWZmZXJlbnQgb3B0aW9uIGZvcm1hdHMgeW91IGNhbiB1c2UsCisgICMgYnV0IGl0J3MgbWFpbmx5
IGludGVuZGVkIHRvIGF2b2lkIGR1cGxpY2F0aW5nIGZsYWdzIG9uIHRoZSBhdXRvbWF0aWMKKyAg
IyBtYWtlZmlsZSByZWdlbmVyYXRpb24gd2hpY2ggb25seSB1c2VzIHRoaXMgZm9ybWF0LgorICBz
cGVjaWZpZWRfaW5jbHVkZXMgPSBzZXQoKQorICBmb3IgYXJnIGluIGFyZ3M6CisgICAgaWYgYXJn
LnN0YXJ0c3dpdGgoJy1JJykgYW5kIGxlbihhcmcpID4gMjoKKyAgICAgIHNwZWNpZmllZF9pbmNs
dWRlcy5hZGQob3MucGF0aC5yZWFscGF0aChhcmdbMjpdKSkKKworICByZXN1bHQgPSBbXQorICBk
ZWYgQWRkSW5jbHVkZShwYXRoKToKKyAgICBpZiBvcy5wYXRoLnJlYWxwYXRoKHBhdGgpIG5vdCBp
biBzcGVjaWZpZWRfaW5jbHVkZXM6CisgICAgICByZXN1bHQuYXBwZW5kKHBhdGgpCisKKyAgIyBB
bHdheXMgaW5jbHVkZSBjb21tb24uZ3lwaQorICBBZGRJbmNsdWRlKG9zLnBhdGguam9pbihzY3Jp
cHRfZGlyLCAnYnVpbGQnLCAnY29tbW9uLmd5cGknKSkKKworICAjIE9wdGlvbmFsbHkgYWRkIHN1
cHBsZW1lbnRhbCAuZ3lwaSBmaWxlcyBpZiBwcmVzZW50LgorICBzdXBwbGVtZW50cyA9IGdsb2Iu
Z2xvYihvcy5wYXRoLmpvaW4oc2NyaXB0X2RpciwgJyonLCAnc3VwcGxlbWVudC5neXBpJykpCisg
IGZvciBzdXBwbGVtZW50IGluIHN1cHBsZW1lbnRzOgorICAgIEFkZEluY2x1ZGUoc3VwcGxlbWVu
dCkKKworICByZXR1cm4gcmVzdWx0CisKK2lmIF9fbmFtZV9fID09ICdfX21haW5fXyc6CisKKyAg
YXJncyA9IHN5cy5hcmd2WzE6XQorCisgICMgQWRkIGluY2x1ZGVzLgorICBhcmdzLmV4dGVuZChb
Jy1JJyArIGkgZm9yIGkgaW4gYWRkaXRpb25hbF9pbmNsdWRlX2ZpbGVzKGFyZ3MpXSkKKworICAj
IE90aGVyIGNvbW1hbmQgYXJnczoKKyAgYXJncy5leHRlbmQoWworICAgICAgICAgICAgICAgIyBn
eXAgdmFyaWFibGUgZGVmaW5lcy4KKyAgICAgICAgICAgICAgICctRGluc2lkZV9jaHJvbWl1bV9i
dWlsZD0wJywKKyAgICAgICAgICAgICAgICctRHY4X3VzZV9zbmFwc2hvdD1mYWxzZScsCisgICAg
ICAgICAgICAgICAnLURtc3ZzX3VzZV9jb21tb25fcmVsZWFzZT0wJywKKworICAgICAgICAgICAg
ICAgIyBneXAgaGFjazogb3RoZXJ3aXNlIGd5cCBhc3N1bWVzIGl0cyBpbiBjaHJvbWl1bSdzIHNy
Yy8gZGlyLgorICAgICAgICAgICAgICAgJy0tZGVwdGg9Li8nLAorCisgICAgICAgICAgICAgICAj
IGd5cCBmaWxlIHRvIGV4ZWN1dGUuCisgICAgICAgICAgICAgICAnd2Via2l0Lmd5cCddKQorCisg
IHByaW50ICdVcGRhdGluZyB3ZWJraXQgcHJvamVjdHMgZnJvbSBneXAgZmlsZXMuLi4nCisgIHN5
cy5zdGRvdXQuZmx1c2goKQorCisgICMgT2ZmIHdlIGdvLi4uCisgIHN5cy5leGl0KGd5cC5tYWlu
KGFyZ3MpKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>