29985 2009-10-01 15:17:23 -0700 Make LayoutTests/editing/selection/hit-test-anonymous.html resistant to GDI/CG differences 2009-10-05 16:10:56 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jparent jparent commit-queue darin eric oldest_to_newest 151712 0 jparent 2009-10-01 15:17:23 -0700 This test measures the offsetLeft of an element, adds 200, and then clicks in that position, and expects the click to happen at a specific character (specifically, for the selection offset to be at a certain character). However, the character occurs at a different x position when using GDI or CG (off by 8 pixels), so this test fails for platforms using GDI. Possible solutions: 1. Add in a fudge factor, documented with an explanation, for the selection offset, aka, it can be either character at offset 24 or 25. 2. Make the click more specific about where it occurs. Since we can't easily measure where a character is, we could wrap it in an inline tag, measure the location of the inline tag, and specifically click there, rather than just adding 200. This shouldn't effect the quality of the test. 3. GDI platforms just expect failure here. Thoughts? Other solutions? I lean towards #2. cc'ing Darin since he authored the test in https://bugs.webkit.org/show_bug.cgi?id=24726. 151727 1 darin 2009-10-01 15:55:32 -0700 We should just make the font size larger and tweak the numeric offset and change the expected result to match. We're just getting unlucky here that the slight differences in fonts are giving us different results. With a larger font I think we'd be fine. 151736 2 40484 jparent 2009-10-01 17:02:32 -0700 Created attachment 40484 Updates the test to use a larger font size and updates the offsets accordingly. 151737 3 40485 jparent 2009-10-01 17:05:35 -0700 Created attachment 40485 Fixes whitespace changes. 152037 4 40485 commit-queue 2009-10-02 19:02:01 -0700 Comment on attachment 40485 Fixes whitespace changes. Rejecting patch 40485 from commit-queue. jparent@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 152038 5 40485 commit-queue 2009-10-02 19:07:07 -0700 Comment on attachment 40485 Fixes whitespace changes. Rejecting patch 40485 from commit-queue. ojan@chromium.org does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 152039 6 jparent 2009-10-02 19:11:25 -0700 Sorry for all the commit queue noise here. I just realized that my bugs.webkit.org account is with my @google address and my committer account is with @chromium, so I can't set my own commit queue bit. I asked Ojan to set it for me since his accounts match, but I think the commit-queue is using a stale copy of the committers list, since I had just updated it ~30 mins ago to include Ojan and myself. Will try again once queue syncs that file. 152325 7 eric 2009-10-05 09:34:10 -0700 The commit-queue is not smart enough to update the committers list before checking the list. I should make it do so. Right now it updates it when landing a patch though, so you have to wait for anohter patch to land via the queue after you add yourself to committers.py. I'll file a bug and fix it. :( The email address in committers.py should be your *bugzilla* email, not your committer email. committers.py attempts to document this, but doesn't do a very good job. 152383 8 eric 2009-10-05 11:17:16 -0700 Actually, I'm not sure my previous assessment was correct. It's possible the queue will cache the committers list even across updates... Filed bug 30084. 152385 9 40485 eric 2009-10-05 11:19:42 -0700 Comment on attachment 40485 Fixes whitespace changes. Julie is busy as Chromium Sheriff today, so she asked that I set this for her. 152452 10 40485 commit-queue 2009-10-05 14:23:41 -0700 Comment on attachment 40485 Fixes whitespace changes. Rejecting patch 40485 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11378 test cases. fast/dom/prototype-inheritance.html -> failed Exiting early after 1 failures. 5487 tests run. 90.74s total testing time 5486 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output 152453 11 40485 eric 2009-10-05 14:26:48 -0700 Comment on attachment 40485 Fixes whitespace changes. Hyatt broke the tree, and the bots had not caught up yet. --- /tmp/layout-test-results/fast/dom/prototype-inheritance-expected.txt 2009-10-05 14:23:37.000000000 -0700 +++ /tmp/layout-test-results/fast/dom/prototype-inheritance-actual.txt 2009-10-05 14:23:37.000000000 -0700 @@ -7,6 +7,8 @@ PASS inner.Attr.constructor.isInner is true PASS inner.Audio.isInner is true PASS inner.Audio.constructor.isInner is true +PASS inner.BeforeLoadEvent.isInner is true +PASS inner.BeforeLoadEvent.constructor.isInner is true PASS inner.CDATASection.isInner is true PASS inner.CDATASection.constructor.isInner is true PASS inner.CSSCharsetRule.isInner is true 152457 12 40485 commit-queue 2009-10-05 14:31:28 -0700 Comment on attachment 40485 Fixes whitespace changes. Rejecting patch 40485 from commit-queue. Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--quiet', '--exit-after-n-failures=1']" exit_code: 1 Running build-dumprendertree Running tests from /Users/eseidel/Projects/CommitQueue/LayoutTests Testing 11378 test cases. fast/dom/prototype-inheritance.html -> failed Exiting early after 1 failures. 5487 tests run. 101.12s total testing time 5486 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 1 test case (<1%) had stderr output 152466 13 40485 eric 2009-10-05 14:41:16 -0700 Comment on attachment 40485 Fixes whitespace changes. The buildbots were behind. bugzilla-tool checked them, saw they were green, but they shouldn't have been. This was not your fault. 152482 14 eric 2009-10-05 15:02:14 -0700 False rejection was caused by bug 30098. 152509 15 40485 commit-queue 2009-10-05 16:10:52 -0700 Comment on attachment 40485 Fixes whitespace changes. Clearing flags on attachment: 40485 Committed r49127: <http://trac.webkit.org/changeset/49127> 152510 16 commit-queue 2009-10-05 16:10:56 -0700 All reviewed patches have been landed. Closing bug. 40484 2009-10-01 17:02:32 -0700 2009-10-01 17:05:35 -0700 Updates the test to use a larger font size and updates the offsets accordingly. gdi-cg-patch.txt text/plain 2440 jparent SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5MDA0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMDEgIEp1bGllIFBhcmVudCAgPGpw YXJlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1ha2UgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaGl0LXRlc3Qt YW5vbnltb3VzLmh0bWwgcmVzaXN0YW50IHRvCisgICAgICAgIEdESS9DRyBkaWZmZXJlbmNlcywg YnkgaW5jcmVhc2luZyB0aGUgZm9udCBzaXplIHNvIHRoZSBzbGlnaHQKKyAgICAgICAgZGlmZmVy ZW5jZSBpbiBmb250cyBkb2Vzbid0IHJlc3VsdCBpbiBhIGRpZmZlcmVudCBjaGFyYWN0ZXIgY2xp Y2tlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5 OTg1CisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9oaXQtdGVzdC1hbm9ueW1vdXMuaHRt bDoKKwogMjAwOS0xMC0wMSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL2hpdC10ZXN0LWFub255bW91cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2VkaXRpbmcvc2VsZWN0aW9uL2hpdC10ZXN0LWFub255bW91cy5odG1sCShyZXZpc2lvbiA0 ODk5MykKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2hpdC10ZXN0LWFub255bW91 cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00NCwyMyArNDQsMjYgQEAgc3BhbjphZnRlciB7CiAg ICAgICAgIHZhciB5ID0gYmxvY2sub2Zmc2V0VG9wICsgNTsKIAogICAgICAgICBpZiAod2luZG93 LmV2ZW50U2VuZGVyKSB7CisgICAgICAgICAgICAvLyBDbGljayBpbiB0aGUgYW5vbnltb3VzIGNv bnRlbnQsIGNoZWNrIHRoYXQgY3Vyc29yIGdvZXMgdG8KKyAgICAgICAgICAgIC8vIHRoZSBzdGFy dCBvZiB0aGUgc3Bhbi4KICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkp OwogICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CiAgICAgICAgICAgICBldmVu dFNlbmRlci5tb3VzZVVwKCk7CiAgICAgICAgIH0KLQorICAgICAgICAKICAgICAgICAgaWYgKGNo ZWNrU2VsZWN0aW9uKDEsICIodGV4dCBpbiBzcGFuLCAwKSwgKHRleHQgaW4gc3BhbiwgMCkiKSkK ICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICB4ID0gYmxvY2sub2Zmc2V0TGVmdCArIDIw MDsKIAogICAgICAgICBpZiAod2luZG93LmV2ZW50U2VuZGVyKSB7CisgICAgICAgICAgICAvLyBD bGljayBpbiB0aGUgcmVndWxhciB0ZXh0LCBtYWtlIHN1cmUgaXQgZ29lcyBpbnRvIHRoZSBzcGFu LgogICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CiAgICAgICAgICAg ICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNl VXAoKTsKICAgICAgICAgfQotCi0gICAgICAgIGlmIChjaGVja1NlbGVjdGlvbigyLCAiKHRleHQg aW4gc3BhbiwgMjQpLCAodGV4dCBpbiBzcGFuLCAyNCkiKSkKKyAgICAgICAKKyAgICAgICAgaWYg KGNoZWNrU2VsZWN0aW9uKDIsICIodGV4dCBpbiBzcGFuLCA3KSwgKHRleHQgaW4gc3BhbiwgNyki KSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJ ZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIlNVQ0NFU1MiOwpAQCAtNjksNiArNzIsNiBAQCBzcGFu OmFmdGVyIHsKIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0icnVuVGVzdCgpIj4KIDxwPlRoaXMgdGVz dHMgY2xpY2tpbmcgaW4gYW5vbnltb3VzIGNvbnRlbnQgdG8gc2VlIGlmIGEgc2VsZWN0aW9uIGlz IHN1Y2Nlc3NmdWxseSBjcmVhdGVkLjwvcD4KLTxwIGlkPSJibG9jayIgY29udGVudEVkaXRhYmxl IHN0eWxlPSJib3JkZXI6IDFweCBzb2xpZCBibHVlIj48c3BhbiBpZD0ic3BhbiI+VGhpcyBpcyB0 aGUgc2VsZWN0YWJsZSB0ZXh0Ljwvc3Bhbj48L2Rpdj4KKzxwIGlkPSJibG9jayIgY29udGVudEVk aXRhYmxlIHN0eWxlPSJib3JkZXI6IDFweCBzb2xpZCBibHVlOyBmb250LXNpemU6MzBweCI+PHNw YW4gaWQ9InNwYW4iPlRoaXMgaXMgdGhlIHNlbGVjdGFibGUgdGV4dC48L3NwYW4+PC9kaXY+CiA8 cCBpZD0icmVzdWx0Ij5URVNUIERJRCBOT1QgUlVOPC9kaXY+CiA8L2JvZHk+Cg== 40485 2009-10-01 17:05:35 -0700 2009-10-05 16:10:52 -0700 Fixes whitespace changes. gdi-cg-patch.txt text/plain 2344 jparent SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQ5MDA0KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTAtMDEgIEp1bGllIFBhcmVudCAgPGpw YXJlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIE1ha2UgTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vaGl0LXRlc3Qt YW5vbnltb3VzLmh0bWwgcmVzaXN0YW50IHRvCisgICAgICAgIEdESS9DRyBkaWZmZXJlbmNlcywg YnkgaW5jcmVhc2luZyB0aGUgZm9udCBzaXplIHNvIHRoZSBzbGlnaHQKKyAgICAgICAgZGlmZmVy ZW5jZSBpbiBmb250cyBkb2Vzbid0IHJlc3VsdCBpbiBhIGRpZmZlcmVudCBjaGFyYWN0ZXIgY2xp Y2tlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5 OTg1CisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9oaXQtdGVzdC1hbm9ueW1vdXMuaHRt bDoKKwogMjAwOS0xMC0wMSAgQmV0aCBEYWtpbiAgPGJkYWtpbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KSW5kZXg6IExheW91dFRlc3RzL2VkaXRpbmcv c2VsZWN0aW9uL2hpdC10ZXN0LWFub255bW91cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2VkaXRpbmcvc2VsZWN0aW9uL2hpdC10ZXN0LWFub255bW91cy5odG1sCShyZXZpc2lvbiA0 ODk5MykKKysrIExheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2hpdC10ZXN0LWFub255bW91 cy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC00NCw2ICs0NCw4IEBAIHNwYW46YWZ0ZXIgewogICAg ICAgICB2YXIgeSA9IGJsb2NrLm9mZnNldFRvcCArIDU7CiAKICAgICAgICAgaWYgKHdpbmRvdy5l dmVudFNlbmRlcikgeworICAgICAgICAgICAgLy8gQ2xpY2sgaW4gdGhlIGFub255bW91cyBjb250 ZW50LCBjaGVjayB0aGF0IGN1cnNvciBnb2VzIHRvCisgICAgICAgICAgICAvLyB0aGUgc3RhcnQg b2YgdGhlIHNwYW4uCiAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh4LCB5KTsK ICAgICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwogICAgICAgICAgICAgZXZlbnRT ZW5kZXIubW91c2VVcCgpOwpAQCAtNTUsMTIgKzU3LDEzIEBAIHNwYW46YWZ0ZXIgewogICAgICAg ICB4ID0gYmxvY2sub2Zmc2V0TGVmdCArIDIwMDsKIAogICAgICAgICBpZiAod2luZG93LmV2ZW50 U2VuZGVyKSB7CisgICAgICAgICAgICAvLyBDbGljayBpbiB0aGUgcmVndWxhciB0ZXh0LCBtYWtl IHN1cmUgaXQgZ29lcyBpbnRvIHRoZSBzcGFuLgogICAgICAgICAgICAgZXZlbnRTZW5kZXIubW91 c2VNb3ZlVG8oeCwgeSk7CiAgICAgICAgICAgICBldmVudFNlbmRlci5tb3VzZURvd24oKTsKICAg ICAgICAgICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKICAgICAgICAgfQogCi0gICAgICAgIGlm IChjaGVja1NlbGVjdGlvbigyLCAiKHRleHQgaW4gc3BhbiwgMjQpLCAodGV4dCBpbiBzcGFuLCAy NCkiKSkKKyAgICAgICAgaWYgKGNoZWNrU2VsZWN0aW9uKDIsICIodGV4dCBpbiBzcGFuLCA3KSwg KHRleHQgaW4gc3BhbiwgNykiKSkKICAgICAgICAgICAgIHJldHVybjsKIAogICAgICAgICBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0IikuaW5uZXJIVE1MID0gIlNVQ0NFU1MiOwpAQCAt NjksNiArNzIsNiBAQCBzcGFuOmFmdGVyIHsKIDwvaGVhZD4KIDxib2R5IG9ubG9hZD0icnVuVGVz dCgpIj4KIDxwPlRoaXMgdGVzdHMgY2xpY2tpbmcgaW4gYW5vbnltb3VzIGNvbnRlbnQgdG8gc2Vl IGlmIGEgc2VsZWN0aW9uIGlzIHN1Y2Nlc3NmdWxseSBjcmVhdGVkLjwvcD4KLTxwIGlkPSJibG9j ayIgY29udGVudEVkaXRhYmxlIHN0eWxlPSJib3JkZXI6IDFweCBzb2xpZCBibHVlIj48c3BhbiBp ZD0ic3BhbiI+VGhpcyBpcyB0aGUgc2VsZWN0YWJsZSB0ZXh0Ljwvc3Bhbj48L2Rpdj4KKzxwIGlk PSJibG9jayIgY29udGVudEVkaXRhYmxlIHN0eWxlPSJib3JkZXI6IDFweCBzb2xpZCBibHVlOyBm b250LXNpemU6MzBweCI+PHNwYW4gaWQ9InNwYW4iPlRoaXMgaXMgdGhlIHNlbGVjdGFibGUgdGV4 dC48L3NwYW4+PC9kaXY+CiA8cCBpZD0icmVzdWx0Ij5URVNUIERJRCBOT1QgUlVOPC9kaXY+CiA8 L2JvZHk+Cg==