<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>29979</bug_id>
          
          <creation_ts>2009-10-01 13:48:20 -0700</creation_ts>
          <short_desc>chromium port features.gypi override mechanism</short_desc>
          <delta_ts>2009-10-01 15:21:49 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yaar Schnitman">yaar</reporter>
          <assigned_to name="Yaar Schnitman">yaar</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>dglazkov</cc>
    
    <cc>yaar</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>151683</commentid>
    <comment_count>0</comment_count>
    <who name="Yaar Schnitman">yaar</who>
    <bug_when>2009-10-01 13:48:20 -0700</bug_when>
    <thetext>we want to be able to have different feature_defines when we build chromium webkit downstream (e.g. experimental features).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151684</commentid>
    <comment_count>1</comment_count>
      <attachid>40474</attachid>
    <who name="Yaar Schnitman">yaar</who>
    <bug_when>2009-10-01 13:54:27 -0700</bug_when>
    <thetext>Created attachment 40474
patch

Patch doesn&apos;t depend on upcoming downstream change, so it won&apos;t break any builds.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151688</commentid>
    <comment_count>2</comment_count>
      <attachid>40474</attachid>
    <who name="Dimitri Glazkov (Google)">dglazkov</who>
    <bug_when>2009-10-01 14:04:23 -0700</bug_when>
    <thetext>Comment on attachment 40474
patch

ok.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151714</commentid>
    <comment_count>3</comment_count>
      <attachid>40474</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-01 15:21:45 -0700</bug_when>
    <thetext>Comment on attachment 40474
patch

Clearing flags on attachment: 40474

Committed r49002: &lt;http://trac.webkit.org/changeset/49002&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>151715</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-10-01 15:21:49 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>40474</attachid>
            <date>2009-10-01 13:54:27 -0700</date>
            <delta_ts>2009-10-01 15:21:45 -0700</delta_ts>
            <desc>patch</desc>
            <filename>WK29979.diff</filename>
            <type>text/plain</type>
            <size>2843</size>
            <attacher name="Yaar Schnitman">yaar</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9DaGFuZ2VMb2cgYi9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGUx
ODQ5NTkuLmY2NzcwMDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0
L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDA5LTEwLTAxICBZYWFyIFNjaG5pdG1hbiAg
PHlhYXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIE1ha2UgaXQgcG9zc2libGUgdG8gb3ZlcnJpZGUgdGhlIGxpc3Qgb2YgZmVh
dHVyZSBkZWZpbmVzIHdoZW4gYnVpbGRpbmcKKyAgICAgICAgZG93bnN0cmVhbS4KKworICAgICAg
ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk5NzkKKworICAgICAg
ICAqIGNocm9taXVtL2ZlYXR1cmVzLmd5cGk6CisKIDIwMDktMDktMzAgIFlhYXIgU2Nobml0bWFu
ICA8eWFhckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6
a292LgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkgYi9XZWJLaXQv
Y2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCBhZGNiNTI3Li5hNTU5NjgwIDEwMDY0NAotLS0g
YS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9XZWJLaXQvY2hyb21pdW0vZmVh
dHVyZXMuZ3lwaQpAQCAtMjksMzIgKzI5LDQxIEBACiAjCiAKIHsKLSAgIyBUaGUgZm9sbG93aW5n
IGRlZmluZXMgdHVybiB3ZWJraXQgZmVhdHVyZXMgb24gb3Igb2ZmLiAKKyAgIyBUaGUgZm9sbG93
aW5nIGRlZmluZXMgdHVybiB3ZWJraXQgZmVhdHVyZXMgb24gYW5kIG9mZi4KICAgJ3ZhcmlhYmxl
cyc6IHsKLSAgICAnZmVhdHVyZV9kZWZpbmVzJzogWwotICAgICAgJ0VOQUJMRV8zRF9DQU5WQVM9
MCcsCi0gICAgICAnRU5BQkxFX0NIQU5ORUxfTUVTU0FHSU5HPTEnLAotICAgICAgJ0VOQUJMRV9E
QVRBQkFTRT0xJywKLSAgICAgICdFTkFCTEVfREFUQUdSSUQ9MCcsCi0gICAgICAnRU5BQkxFX09G
RkxJTkVfV0VCX0FQUExJQ0FUSU9OUz0xJywKLSAgICAgICdFTkFCTEVfREFTSEJPQVJEX1NVUFBP
UlQ9MCcsCi0gICAgICAnRU5BQkxFX0RPTV9TVE9SQUdFPTEnLAotICAgICAgJ0VOQUJMRV9KQVZB
U0NSSVBUX0RFQlVHR0VSPTAnLAotICAgICAgJ0VOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFEUz0w
JywKLSAgICAgICdFTkFCTEVfSUNPTkRBVEFCQVNFPTAnLAotICAgICAgJ0VOQUJMRV9OT1RJRklD
QVRJT05TPTAnLAotICAgICAgJ0VOQUJMRV9PUklFTlRBVElPTl9FVkVOVFM9MCcsCi0gICAgICAn
RU5BQkxFX1hTTFQ9MScsCi0gICAgICAnRU5BQkxFX1hQQVRIPTEnLAotICAgICAgJ0VOQUJMRV9T
SEFSRURfV09SS0VSUz0wJywKLSAgICAgICdFTkFCTEVfU1ZHPTEnLAotICAgICAgJ0VOQUJMRV9T
VkdfQU5JTUFUSU9OPTEnLAotICAgICAgJ0VOQUJMRV9TVkdfQVNfSU1BR0U9MScsCi0gICAgICAn
RU5BQkxFX1NWR19VU0U9MScsCi0gICAgICAnRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVD0xJywK
LSAgICAgICdFTkFCTEVfU1ZHX0ZPTlRTPTEnLAotICAgICAgJ0VOQUJMRV9WSURFTz0xJywKLSAg
ICAgICdFTkFCTEVfV09SS0VSUz0xJywKLSAgICBdLAorICAgICd2YXJpYWJsZXMnOiB7CisgICAg
ICAjIFdlIGhhdmUgdG8gbmVzdCB2YXJpYWJsZXMgaW5zaWRlIHZhcmlhYmxlcyBhcyBhIGhhY2sg
Zm9yIHZhcmlhYmxlcworICAgICAgIyBvdmVycmlkZS4KKworICAgICAgIyBXQVJOSU5HOiBidWls
ZC9mZWF0dXJlc19vdmVycmlkZS5neXBpIHdoaWNoIGlzIGluY2x1ZGVkIGluIGEgZnVsbAorICAg
ICAgIyBjaHJvbWl1bSBidWlsZCwgb3ZlcnJpZGVzIHRoaXMgbGlzdCB3aXRoIGl0cyBvd24gdmFs
dWVzLiBTZWUKKyAgICAgICMgZmVhdHVyZXNfb3ZlcnJpZGUuZ3lwaSBpbmxpbmUgZG9jdW1lbnRh
dGlvbiBmb3IgbW9yZSBkZXRhaWxzLgorICAgICAgJ2ZlYXR1cmVfZGVmaW5lcyUnOiBbCisgICAg
ICAgICdFTkFCTEVfM0RfQ0FOVkFTPTAnLAorICAgICAgICAnRU5BQkxFX0NIQU5ORUxfTUVTU0FH
SU5HPTEnLAorICAgICAgICAnRU5BQkxFX0RBVEFCQVNFPTEnLAorICAgICAgICAnRU5BQkxFX0RB
VEFHUklEPTAnLAorICAgICAgICAnRU5BQkxFX09GRkxJTkVfV0VCX0FQUExJQ0FUSU9OUz0xJywK
KyAgICAgICAgJ0VOQUJMRV9EQVNIQk9BUkRfU1VQUE9SVD0wJywKKyAgICAgICAgJ0VOQUJMRV9E
T01fU1RPUkFHRT0xJywKKyAgICAgICAgJ0VOQUJMRV9KQVZBU0NSSVBUX0RFQlVHR0VSPTAnLAor
ICAgICAgICAnRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTPTAnLAorICAgICAgICAnRU5BQkxF
X0lDT05EQVRBQkFTRT0wJywKKyAgICAgICAgJ0VOQUJMRV9OT1RJRklDQVRJT05TPTAnLAorICAg
ICAgICAnRU5BQkxFX09SSUVOVEFUSU9OX0VWRU5UUz0wJywKKyAgICAgICAgJ0VOQUJMRV9YU0xU
PTEnLAorICAgICAgICAnRU5BQkxFX1hQQVRIPTEnLAorICAgICAgICAnRU5BQkxFX1NIQVJFRF9X
T1JLRVJTPTAnLAorICAgICAgICAnRU5BQkxFX1NWRz0xJywKKyAgICAgICAgJ0VOQUJMRV9TVkdf
QU5JTUFUSU9OPTEnLAorICAgICAgICAnRU5BQkxFX1NWR19BU19JTUFHRT0xJywKKyAgICAgICAg
J0VOQUJMRV9TVkdfVVNFPTEnLAorICAgICAgICAnRU5BQkxFX1NWR19GT1JFSUdOX09CSkVDVD0x
JywKKyAgICAgICAgJ0VOQUJMRV9TVkdfRk9OVFM9MScsCisgICAgICAgICdFTkFCTEVfVklERU89
MScsCisgICAgICAgICdFTkFCTEVfV09SS0VSUz0xJywKKyAgICAgIF0sCisgICAgfSwKKyAgICAn
ZmVhdHVyZV9kZWZpbmVzJSc6ICc8KGZlYXR1cmVfZGVmaW5lcyknLAogICB9LAogfQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>