29971 2009-10-01 10:23:00 -0700 Clean up warnings in WebCore/bindings/v8/npruntime.cpp 2009-10-02 00:42:02 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P5 Trivial --- 0 dmaclach webkit-unassigned commit-queue oldest_to_newest 151602 0 40457 dmaclach 2009-10-01 10:23:00 -0700 Created attachment 40457 Path to get rid of warnings. Gets rid of warnings on gcc about using anonymous namespaces warning: 'StringKeyHashTraits' has a base 'WTF::GenericHashTraits<<unnamed>::StringKey>' whose type uses the anonymous namespace warning: 'WTF::PairHashTraits<StringKeyHashTraits, WTF::HashTraits<PrivateIdentifier*> >' has a base 'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey, PrivateIdentifier*> >' whose type uses the anonymous namespace 151763 1 40457 levin 2009-10-01 21:16:31 -0700 Comment on attachment 40457 Path to get rid of warnings. minor change log fixes suggested. > Index: WebCore/ChangeLog > +2009-10-01 Dave MacLachlan <dmaclach@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + Add: bug title bug link blank line then your description. > + Gets rid of warnings on gcc about using anonymous namespaces > + warning: 'StringKeyHashTraits' has a base > + 'WTF::GenericHashTraits<<unnamed>::StringKey>' > + whose type uses the anonymous namespace > + and The spacing on this looks off. I think every in descriptions is indented beyond this in the changelog. > + warning: 'WTF::PairHashTraits<StringKeyHashTraits, > + WTF::HashTraits<PrivateIdentifier*> >' has a base > + 'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey, > + PrivateIdentifier*> >' whose type uses the anonymous namespace > + > + No tests required. > + > + * bindings/v8/npruntime.cpp: > + 151765 2 40495 dmaclach 2009-10-01 21:27:18 -0700 Created attachment 40495 Patch with revisions 151777 3 40495 commit-queue 2009-10-02 00:41:58 -0700 Comment on attachment 40495 Patch with revisions Clearing flags on attachment: 40495 Committed r49011: <http://trac.webkit.org/changeset/49011> 151778 4 commit-queue 2009-10-02 00:42:02 -0700 All reviewed patches have been landed. Closing bug. 40457 2009-10-01 10:23:00 -0700 2009-10-01 21:16:31 -0700 Path to get rid of warnings. npruntimewarnings.patch text/plain 1785 dmaclach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODk3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjEgQEAKKzIwMDktMTAtMDEgIERhdmUgTWFjTGFjaGxhbiAgPGRtYWNsYWNoQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHZXRzIHJpZCBvZiB3YXJuaW5ncyBvbiBnY2MgYWJvdXQgdXNpbmcgYW5vbnltb3VzIG5hbWVz cGFjZXMgCisgICAgICAgICAgd2FybmluZzogJ1N0cmluZ0tleUhhc2hUcmFpdHMnIGhhcyBhIGJh c2UKKyAgICAgICAgICdXVEY6OkdlbmVyaWNIYXNoVHJhaXRzPDx1bm5hbWVkPjo6U3RyaW5nS2V5 PicgCisgICAgICAgICAgd2hvc2UgdHlwZSB1c2VzIHRoZSBhbm9ueW1vdXMgbmFtZXNwYWNlCisJ YW5kCisgICAgICAgICAgd2FybmluZzogJ1dURjo6UGFpckhhc2hUcmFpdHM8U3RyaW5nS2V5SGFz aFRyYWl0cywKKyAgICAgICAgICBXVEY6Okhhc2hUcmFpdHM8UHJpdmF0ZUlkZW50aWZpZXIqPiA+ JyBoYXMgYSBiYXNlCisgICAgICAgICAnV1RGOjpHZW5lcmljSGFzaFRyYWl0czxzdGQ6OnBhaXI8 PHVubmFtZWQ+OjpTdHJpbmdLZXksCisgICAgICAgICBQcml2YXRlSWRlbnRpZmllcio+ID4nIHdo b3NlIHR5cGUgdXNlcyB0aGUgYW5vbnltb3VzIG5hbWVzcGFjZQorCisgICAgICAgIE5vIHRlc3Rz IHJlcXVpcmVkLgorCisgICAgICAgICogYmluZGluZ3MvdjgvbnBydW50aW1lLmNwcDoKKwogMjAw OS0xMC0wMSAgUGhpbGlwcGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgR3VzdGF2byBOb3JvbmhhLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92 OC9ucHJ1bnRpbWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvbnBydW50 aW1lLmNwcAkocmV2aXNpb24gNDg5NjApCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L25wcnVudGlt ZS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDcgKzM5LDcgQEAKIC8vIFRoZSBzdGF0aWMgaW5p dGlhbGl6ZXIgaGVyZSBzaG91bGQgd29yayBva2F5LCBidXQgd2Ugd2FudCB0byBhdm9pZAogLy8g c3RhdGljIGluaXRpYWxpemF0aW9uIGluIGdlbmVyYWwuCiAKLW5hbWVzcGFjZSB7CituYW1lc3Bh Y2UgbnBydW50aW1lIHsKIAogLy8gV2UgdXNlIFN0cmluZ0tleSBoZXJlIGFzIHRoZSBrZXktdHlw ZSB0byBhdm9pZCBhIHN0cmluZyBjb3B5IHRvCiAvLyBjb25zdHJ1Y3QgdGhlIG1hcCBrZXkgYW5k IGZvciBmYXN0ZXIgY29tcGFyaXNvbnMgdGhhbiBzdHJjbXAuCkBAIC0xMTIsNyArMTEyLDEwIEBA IHN0cnVjdCBTdHJpbmdLZXlIYXNoIHsKICAgICBzdGF0aWMgY29uc3QgYm9vbCBzYWZlVG9Db21w YXJlVG9FbXB0eU9yRGVsZXRlZCA9IHRydWU7CiB9OwogCi19ICAvLyBuYW1lc3BhY2UKK30gIC8v IG5hbWVzcGFjZSBucHJ1bnRpbWUKKwordXNpbmcgbnBydW50aW1lOjpTdHJpbmdLZXk7Cit1c2lu ZyBucHJ1bnRpbWU6OlN0cmluZ0tleUhhc2g7CiAKIC8vIEltcGxlbWVudCBIYXNoVHJhaXRzPFN0 cmluZ0tleT4KIHN0cnVjdCBTdHJpbmdLZXlIYXNoVHJhaXRzIDogV1RGOjpHZW5lcmljSGFzaFRy YWl0czxTdHJpbmdLZXk+IHsK 40495 2009-10-01 21:27:18 -0700 2009-10-02 00:41:58 -0700 Patch with revisions WebCore.patch text/plain 1915 dmaclach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODk3OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjQgQEAKKzIwMDktMTAtMDEgIERhdmUgTWFjTGFjaGxhbiAgPGRtYWNsYWNoQGdt YWlsLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBDbGVhbiB1cCB3YXJuaW5ncyBpbiBXZWJDb3JlL2JpbmRpbmdzL3Y4L25wcnVudGltZS5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5OTcxCisK KyAgICAgICAgR2V0cyByaWQgb2Ygd2FybmluZ3Mgb24gZ2NjIGFib3V0IHVzaW5nIGFub255bW91 cyBuYW1lc3BhY2VzIAorICAgICAgICAgIHdhcm5pbmc6ICdTdHJpbmdLZXlIYXNoVHJhaXRzJyBo YXMgYSBiYXNlCisgICAgICAgICAgJ1dURjo6R2VuZXJpY0hhc2hUcmFpdHM8PHVubmFtZWQ+OjpT dHJpbmdLZXk+JyAKKyAgICAgICAgICB3aG9zZSB0eXBlIHVzZXMgdGhlIGFub255bW91cyBuYW1l c3BhY2UKKyAgICAgICAgYW5kCisgICAgICAgICAgd2FybmluZzogJ1dURjo6UGFpckhhc2hUcmFp dHM8U3RyaW5nS2V5SGFzaFRyYWl0cywKKyAgICAgICAgICBXVEY6Okhhc2hUcmFpdHM8UHJpdmF0 ZUlkZW50aWZpZXIqPiA+JyBoYXMgYSBiYXNlCisgICAgICAgICAgJ1dURjo6R2VuZXJpY0hhc2hU cmFpdHM8c3RkOjpwYWlyPDx1bm5hbWVkPjo6U3RyaW5nS2V5LAorICAgICAgICAgIFByaXZhdGVJ ZGVudGlmaWVyKj4gPicgd2hvc2UgdHlwZSB1c2VzIHRoZSBhbm9ueW1vdXMgbmFtZXNwYWNlCisK KyAgICAgICAgTm8gdGVzdHMgcmVxdWlyZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy92OC9ucHJ1 bnRpbWUuY3BwOgorCiAyMDA5LTEwLTAxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdh bGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCkluZGV4OiBX ZWJDb3JlL2JpbmRpbmdzL3Y4L25wcnVudGltZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9i aW5kaW5ncy92OC9ucHJ1bnRpbWUuY3BwCShyZXZpc2lvbiA0ODk2MCkKKysrIFdlYkNvcmUvYmlu ZGluZ3MvdjgvbnBydW50aW1lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzksNyArMzksNyBAQAog Ly8gVGhlIHN0YXRpYyBpbml0aWFsaXplciBoZXJlIHNob3VsZCB3b3JrIG9rYXksIGJ1dCB3ZSB3 YW50IHRvIGF2b2lkCiAvLyBzdGF0aWMgaW5pdGlhbGl6YXRpb24gaW4gZ2VuZXJhbC4KIAotbmFt ZXNwYWNlIHsKK25hbWVzcGFjZSBucHJ1bnRpbWUgewogCiAvLyBXZSB1c2UgU3RyaW5nS2V5IGhl cmUgYXMgdGhlIGtleS10eXBlIHRvIGF2b2lkIGEgc3RyaW5nIGNvcHkgdG8KIC8vIGNvbnN0cnVj dCB0aGUgbWFwIGtleSBhbmQgZm9yIGZhc3RlciBjb21wYXJpc29ucyB0aGFuIHN0cmNtcC4KQEAg LTExMiw3ICsxMTIsMTAgQEAgc3RydWN0IFN0cmluZ0tleUhhc2ggewogICAgIHN0YXRpYyBjb25z dCBib29sIHNhZmVUb0NvbXBhcmVUb0VtcHR5T3JEZWxldGVkID0gdHJ1ZTsKIH07CiAKLX0gIC8v IG5hbWVzcGFjZQorfSAgLy8gbmFtZXNwYWNlIG5wcnVudGltZQorCit1c2luZyBucHJ1bnRpbWU6 OlN0cmluZ0tleTsKK3VzaW5nIG5wcnVudGltZTo6U3RyaW5nS2V5SGFzaDsKIAogLy8gSW1wbGVt ZW50IEhhc2hUcmFpdHM8U3RyaW5nS2V5Pgogc3RydWN0IFN0cmluZ0tleUhhc2hUcmFpdHMgOiBX VEY6OkdlbmVyaWNIYXNoVHJhaXRzPFN0cmluZ0tleT4gew==