29960 2009-10-01 06:27:42 -0700 [GTK] media player: better mute support 2009-10-01 10:17:26 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 pnormand webkit-unassigned commit-queue slomo oldest_to_newest 151527 0 pnormand 2009-10-01 06:27:42 -0700 As pointed out by slomo :) MediaPlayerPrivateGStreamer.cpp in setMuted() it should really use the "mute" property of playbin2. That keeps the current volume and just mutes the audio ;) 151531 1 40438 pnormand 2009-10-01 06:40:33 -0700 Created attachment 40438 proposed patch 151570 2 40438 gustavo 2009-10-01 08:59:58 -0700 Comment on attachment 40438 proposed patch Very good. 151597 3 40438 commit-queue 2009-10-01 10:17:21 -0700 Comment on attachment 40438 proposed patch Clearing flags on attachment: 40438 Committed r48980: <http://trac.webkit.org/changeset/48980> 151598 4 commit-queue 2009-10-01 10:17:26 -0700 All reviewed patches have been landed. Closing bug. 40438 2009-10-01 06:40:33 -0700 2009-10-01 10:17:21 -0700 proposed patch 0001-Handle-volume-and-mute-state-with-the-two-correspond.patch text/plain 2277 pnormand RnJvbSA2ZjE5ZDkzZjFhNDRiNTAyZGIzNzNlMzFiOTBiMjI0NDk5Yjg1MmUyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEgT2N0IDIwMDkgMTU6Mzg6MzAgKzAyMDAKU3ViamVjdDogW1BBVENIXSBI YW5kbGUgdm9sdW1lIGFuZCBtdXRlIHN0YXRlIHdpdGggdGhlIHR3byBjb3JyZXNwb25kaW5nIHBy b3BlcnRpZXMgb2YgcGxheWJpbjIuCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogLi4uL2dyYXBoaWNz L2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwICAgfCAgIDE1ICsrKysrKystLS0t LS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAyMSBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGI1ZDlhYi4uODUwYmI0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMC0wMSAgUGhpbGlwcGUgTm9y bWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgW0dUS10gbWVkaWEgcGxheWVyOiBiZXR0ZXIgbXV0ZSBzdXBw b3J0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTk2 MAorCisgICAgICAgIEhhbmRsZSB2b2x1bWUgYW5kIG11dGUgc3RhdGUgd2l0aCB0aGUgdHdvIGNv cnJlc3BvbmRpbmcgcHJvcGVydGllcworICAgICAgICBvZiBwbGF5YmluMi4KKworICAgICAgICAq IHBsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQcml2YXRlOjpzZXRNdXRlZCk6CisgICAgICAg IChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGU6OnNldFZvbHVtZSk6CisKIDIwMDktMDktMzAg IFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBsaXN0 IGJveCBzY3JvbGxpbmcgYnkgY29ycmVjdGx5IG92ZXJyaWRpbmcgdGhlIHNjcm9sbCgpCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCA2NGM0MWQxLi41NTI1ZTY4IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAKQEAgLTM2MywyMCArMzYzLDE5IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlOjpzZXRWb2x1bWUoZmxvYXQgdm9sdW1lKQogewogICAgIG1fdm9sdW1lID0gdm9sdW1lOwog ICAgIExPR19WRVJCT1NFKE1lZGlhLCAiVm9sdW1lIHRvICVmIiwgdm9sdW1lKTsKLSAgICBzZXRN dXRlZChmYWxzZSk7CisKKyAgICBpZiAoIW1fcGxheUJpbikKKyAgICAgICAgcmV0dXJuOworCisg ICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKG1fcGxheUJpbiksICJ2b2x1bWUiLCBtX3ZvbHVtZSwg TlVMTCk7CiB9CiAKLXZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlOjpzZXRNdXRlZChib29sIGIpCit2 b2lkIE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0TXV0ZWQoYm9vbCBtdXRlKQogewogICAgIGlmICgh bV9wbGF5QmluKQogICAgICAgICByZXR1cm47CiAKLSAgICBpZiAoYikgewotICAgICAgICBnX29i amVjdF9nZXQoR19PQkpFQ1QobV9wbGF5QmluKSwgInZvbHVtZSIsICZtX3ZvbHVtZSwgTlVMTCk7 Ci0gICAgICAgIGdfb2JqZWN0X3NldChHX09CSkVDVChtX3BsYXlCaW4pLCAidm9sdW1lIiwgKGRv dWJsZSkwLjAsIE5VTEwpOwotICAgIH0gZWxzZQotICAgICAgICBnX29iamVjdF9zZXQoR19PQkpF Q1QobV9wbGF5QmluKSwgInZvbHVtZSIsIG1fdm9sdW1lLCBOVUxMKTsKLQorICAgIGdfb2JqZWN0 X3NldChHX09CSkVDVChtX3BsYXlCaW4pLCAibXV0ZSIsIG11dGUsIE5VTEwpOwogfQogCiB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZTo6c2V0UmF0ZShmbG9hdCByYXRlKQotLSAKMS42LjAuNAoK