29956 2009-10-01 02:40:26 -0700 Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined 2009-10-02 16:35:42 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 jonni.rainisto webkit-unassigned commit-queue oldest_to_newest 151487 0 jonni.rainisto 2009-10-01 02:40:26 -0700 Windows rand() gives 15bit random number (with MSVC and MinGW), if you build webkit with MinGW or with MSVC (without _CRT_RAND_S define) then code execution goes to #else where they assume that rand() returns 31bits. In that case calling javascript Math.random() always gives values in range of 0.0000xxx and not [0,1]. I will attach patch where this is fixed. 151489 1 40430 jonni.rainisto 2009-10-01 02:49:29 -0700 Created attachment 40430 Patch which fixes the bug. 151620 2 40430 darin 2009-10-01 11:06:47 -0700 Comment on attachment 40430 Patch which fixes the bug. I think we need more bits of randomness. I'm not sure how many. It seems we are using 32 bits of randomness in the first two cases, and 53 bits in the next two. Having a Windows code path that uses only 30 bits seems wrong, but perhaps the 32-bit ones are also wrong. review- for now based on that issue, but I could be convinced I am wrong. 151656 3 jonni.rainisto 2009-10-01 12:22:13 -0700 Well in weakRandomNumber its using 15bit rand() 2 times, so imho normal case (when _CRT_RAND_S is defined) in MSVC randomless is even weaker (or same) than 30bits. Im a bit worried that calling rand() 4 times to get 53bit randomness could have some performance impacts. I can make the patch to use rand 4 times, or copypaste the weak random, if 30bit random is not enough? 151673 4 40473 jonni.rainisto 2009-10-01 12:52:16 -0700 Created attachment 40473 Rand() patch which uses 53bits 152022 5 40473 commit-queue 2009-10-02 16:35:38 -0700 Comment on attachment 40473 Rand() patch which uses 53bits Clearing flags on attachment: 40473 Committed r49056: <http://trac.webkit.org/changeset/49056> 152023 6 commit-queue 2009-10-02 16:35:42 -0700 All reviewed patches have been landed. Closing bug. 40430 2009-10-01 02:49:29 -0700 2009-10-01 12:52:16 -0700 Patch which fixes the bug. RandPatch.txt text/plain 1529 jonni.rainisto SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ4OTY0KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMDEgIEpvbm5pIFJh aW5pc3RvICA8am9ubmkucmFpbmlzdG9Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hdGgucmFuZG9tKCkgZ2l2ZXMgdG9vIGxvdyB2 YWx1ZXMgb24gV2luMzIgd2hlbiBfQ1JUX1JBTkRfUyBpcyBub3QgZGVmaW5lZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk5NTYKKworICAgICAgICAq IHd0Zi9SYW5kb21OdW1iZXIuY3BwOgorICAgICAgICAoV1RGOjpyYW5kb21OdW1iZXIpOiBBZGRl ZCBQTEFURk9STShXSU5fT1MpIHRvIGhhbmRsZSAxNWJpdCByYW5kKCkKKwogMjAwOS0wOS0zMCAg R2Fib3IgTG9raSAgPGxva2lAaW5mLnUtc3plZ2VkLmh1PgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEdlb3JnZSBTdGFpa29zLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1JhbmRvbU51bWJlci5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1JhbmRvbU51bWJlci5jcHAJKHJl dmlzaW9uIDQ4OTY0KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1JhbmRvbU51bWJlci5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTgyLDYgKzgyLDE3IEBAIGRvdWJsZSByYW5kb21OdW1iZXIoKQogICAg IHJldHVybiBzdGF0aWNfY2FzdDxkb3VibGU+KGZ1bGxSYW5kb20pL3N0YXRpY19jYXN0PGRvdWJs ZT4oMUxMIDw8IDUzKTsKICNlbGlmIFBMQVRGT1JNKFdJTkNFKQogICAgIHJldHVybiBnZW5yYW5k X3JlczUzKCk7CisjZWxpZiBQTEFURk9STShXSU5fT1MpCisgICAgdWludDMyX3QgcGFydDEgPSBy YW5kKCkgJiAoUkFORF9NQVggLSAxKTsKKyAgICB1aW50MzJfdCBwYXJ0MiA9IHJhbmQoKSAmIChS QU5EX01BWCAtIDEpOworICAgIC8vIHJhbmQgb25seSBwcm92aWRlcyAxNSBiaXRzIG9uIFdpbjMy CisgICAgdWludDMyX3QgZnVsbFJhbmRvbSA9IHBhcnQxOworICAgIGZ1bGxSYW5kb20gPDw9IDE1 OworICAgIGZ1bGxSYW5kb20gfD0gcGFydDI7CisKKyAgICAvLyBNYXNrIG9mZiB0aGUgbG93IDMw Yml0cworICAgIGZ1bGxSYW5kb20gJj0gKDFMTCA8PCAzMCkgLSAxOworICAgIHJldHVybiBzdGF0 aWNfY2FzdDxkb3VibGU+KGZ1bGxSYW5kb20pL3N0YXRpY19jYXN0PGRvdWJsZT4oMUxMIDw8IDMw KTsKICNlbHNlCiAgICAgdWludDMyX3QgcGFydDEgPSByYW5kKCkgJiAoUkFORF9NQVggLSAxKTsK ICAgICB1aW50MzJfdCBwYXJ0MiA9IHJhbmQoKSAmIChSQU5EX01BWCAtIDEpOwo= 40473 2009-10-01 12:52:16 -0700 2009-10-02 16:35:38 -0700 Rand() patch which uses 53bits RandPatch53bits.txt text/plain 1726 jonni.rainisto SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQ4OTkwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTAtMDEgIEpvbm5pIFJh aW5pc3RvICA8am9ubmkucmFpbmlzdG9Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1hdGgucmFuZG9tKCkgZ2l2ZXMgdG9vIGxvdyB2 YWx1ZXMgb24gV2luMzIgd2hlbiBfQ1JUX1JBTkRfUyBpcyBub3QgZGVmaW5lZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk5NTYKKworICAgICAgICAq IHd0Zi9SYW5kb21OdW1iZXIuY3BwOgorICAgICAgICAoV1RGOjpyYW5kb21OdW1iZXIpOiBBZGRl ZCBQTEFURk9STShXSU5fT1MpIHRvIGhhbmRsZSAxNWJpdCByYW5kKCkKKwogMjAwOS0xMC0wMSAg WW9uZ2p1biBaaGFuZyAgPHlvbmdqdW4uemhhbmdAbm9raWEuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1JhbmRvbU51bWJl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1JhbmRvbU51bWJlci5jcHAJ KHJldmlzaW9uIDQ4OTkwKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1JhbmRvbU51bWJlci5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTgyLDYgKzgyLDIzIEBAIGRvdWJsZSByYW5kb21OdW1iZXIoKQog ICAgIHJldHVybiBzdGF0aWNfY2FzdDxkb3VibGU+KGZ1bGxSYW5kb20pL3N0YXRpY19jYXN0PGRv dWJsZT4oMUxMIDw8IDUzKTsKICNlbGlmIFBMQVRGT1JNKFdJTkNFKQogICAgIHJldHVybiBnZW5y YW5kX3JlczUzKCk7CisjZWxpZiBQTEFURk9STShXSU5fT1MpCisgICAgdWludDMyX3QgcGFydDEg PSByYW5kKCkgJiAoUkFORF9NQVggLSAxKTsKKyAgICB1aW50MzJfdCBwYXJ0MiA9IHJhbmQoKSAm IChSQU5EX01BWCAtIDEpOworICAgIHVpbnQzMl90IHBhcnQzID0gcmFuZCgpICYgKFJBTkRfTUFY IC0gMSk7CisgICAgdWludDMyX3QgcGFydDQgPSByYW5kKCkgJiAoUkFORF9NQVggLSAxKTsKKyAg ICAvLyByYW5kIG9ubHkgcHJvdmlkZXMgMTUgYml0cyBvbiBXaW4zMgorICAgIHVpbnQ2NF90IGZ1 bGxSYW5kb20gPSBwYXJ0MTsKKyAgICBmdWxsUmFuZG9tIDw8PSAxNTsKKyAgICBmdWxsUmFuZG9t IHw9IHBhcnQyOworICAgIGZ1bGxSYW5kb20gPDw9IDE1OworICAgIGZ1bGxSYW5kb20gfD0gcGFy dDM7CisgICAgZnVsbFJhbmRvbSA8PD0gMTU7CisgICAgZnVsbFJhbmRvbSB8PSBwYXJ0NDsKKwor ICAgIC8vIE1hc2sgb2ZmIHRoZSBsb3cgNTNiaXRzCisgICAgZnVsbFJhbmRvbSAmPSAoMUxMIDw8 IDUzKSAtIDE7CisgICAgcmV0dXJuIHN0YXRpY19jYXN0PGRvdWJsZT4oZnVsbFJhbmRvbSkvc3Rh dGljX2Nhc3Q8ZG91YmxlPigxTEwgPDwgNTMpOwogI2Vsc2UKICAgICB1aW50MzJfdCBwYXJ0MSA9 IHJhbmQoKSAmIChSQU5EX01BWCAtIDEpOwogICAgIHVpbnQzMl90IHBhcnQyID0gcmFuZCgpICYg KFJBTkRfTUFYIC0gMSk7Cg==