29953 2009-10-01 00:12:12 -0700 [GTK] video sink pad template colorspace is wrong 2009-10-01 10:09:46 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 pnormand webkit-unassigned commit-queue slomo oldest_to_newest 151470 0 pnormand 2009-10-01 00:12:12 -0700 As pointed out by slomo, our sink suports xRGB and BGRx always. Cairo doesn't. CAIRO_FORMAT_RGB24 is xRGB on big endian machines, and BGRx on little endian. So this should really be #if G_BYTE_ORDER == G_LITTLE_ENDIAN GST_VIDEO_CAPS_BGRx #else GST_VIDEO_CAPS_xRGB #endif 151526 1 40437 pnormand 2009-10-01 06:22:49 -0700 Created attachment 40437 proposed patch 151569 2 40437 gustavo 2009-10-01 08:59:03 -0700 Comment on attachment 40437 proposed patch Hmm. I tried to read some documentation about this problem, but could not find any useful stuff in a quick search. Looks correct to me, though. 151593 3 40437 commit-queue 2009-10-01 10:09:43 -0700 Comment on attachment 40437 proposed patch Clearing flags on attachment: 40437 Committed r48979: <http://trac.webkit.org/changeset/48979> 151594 4 commit-queue 2009-10-01 10:09:46 -0700 All reviewed patches have been landed. Closing bug. 40437 2009-10-01 06:22:49 -0700 2009-10-01 10:09:43 -0700 proposed patch 0001-Set-sink-pad-template-colorspace-depending-on-byte-o.patch text/plain 2559 pnormand RnJvbSA2OTY0MTFmNzRhZWRlMzIxN2I1MTNkMTBkNDYyYWNiZjA2ZWFjNTE5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUaHUsIDEgT2N0IDIwMDkgMTU6MjI6MDQgKzAyMDAKU3ViamVjdDogW1BBVENIXSBT ZXQgc2luayBwYWQgdGVtcGxhdGUgY29sb3JzcGFjZSBkZXBlbmRpbmcgb24gYnl0ZSBvcmRlci4K Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgIDEyICsrKysrKysrKysrKwogLi4uL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9WaWRlb1NpbmtH U3RyZWFtZXIuY3BwICAgfCAgIDExICsrKysrKysrLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDIwIGlu c2VydGlvbnMoKyksIDMgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VM b2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA4N2JjOWMyLi5kZjRhZTYyIDEwMDY0NAotLS0g YS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDA5LTEwLTAxICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSB2 aWRlbyBzaW5rIHBhZCB0ZW1wbGF0ZSBjb2xvcnNwYWNlIGlzIHdyb25nCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTk1MworCisgICAgICAgIFNldCBz aW5rIHBhZCB0ZW1wbGF0ZSBjb2xvcnNwYWNlIGRlcGVuZGluZyBvbiBieXRlIG9yZGVyLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL1ZpZGVvU2lua0dTdHJlYW1lci5jcHA6Cisg ICAgICAgICh3ZWJraXRfdmlkZW9fc2lua19pZGxlX2Z1bmMpOgorCiAyMDA5LTEwLTAxICBNYXJ0 aW4gUm9iaW5zb24gIDxtYXJ0aW4uamFtZXMucm9iaW5zb25AZ21haWwuY29tPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFhhbiBMb3Blei4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvZ3RrL1ZpZGVvU2lua0dTdHJlYW1lci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBo aWNzL2d0ay9WaWRlb1NpbmtHU3RyZWFtZXIuY3BwCmluZGV4IDUxNWYzZjIuLmFkNDhlYzQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL1ZpZGVvU2lua0dTdHJlYW1l ci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvVmlkZW9TaW5rR1N0cmVh bWVyLmNwcApAQCAtMzMsOCArMzMsMTQgQEAKICNpbmNsdWRlIDxnc3QvdmlkZW8vdmlkZW8uaD4K IAogc3RhdGljIEdzdFN0YXRpY1BhZFRlbXBsYXRlIHNpbmt0ZW1wbGF0ZSA9IEdTVF9TVEFUSUNf UEFEX1RFTVBMQVRFKCJzaW5rIiwKLSAgICAgICAgR1NUX1BBRF9TSU5LLCBHU1RfUEFEX0FMV0FZ UywKLSAgICAgICAgR1NUX1NUQVRJQ19DQVBTKEdTVF9WSURFT19DQVBTX1JHQnggIjsiIEdTVF9W SURFT19DQVBTX0JHUngpKTsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBHU1RfUEFEX1NJTkssIEdTVF9QQURfQUxXQVlT LAorLy8gQ0FJUk9fRk9STUFUX1JHQjI0IHVzZWQgdG8gcmVuZGVyIHRoZSB2aWRlbyBidWZmZXJz IGlzIGxpdHRsZS9iaWcgZW5kaWFuIGRlcGVuZGFudC4KKyNpZiBHX0JZVEVfT1JERVIgPT0gR19M SVRUTEVfRU5ESUFOCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgR1NUX1NUQVRJQ19DQVBTKEdTVF9WSURFT19DQVBTX0JH UngpCisjZWxzZQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIEdTVF9TVEFUSUNfQ0FQUyhHU1RfVklERU9fQ0FQU194UkdC KQorI2VuZGlmCispOwogCiBHU1RfREVCVUdfQ0FURUdPUllfU1RBVElDKHdlYmtpdF92aWRlb19z aW5rX2RlYnVnKTsKICNkZWZpbmUgR1NUX0NBVF9ERUZBVUxUIHdlYmtpdF92aWRlb19zaW5rX2Rl YnVnCkBAIC0xMTIsNyArMTE4LDYgQEAgd2Via2l0X3ZpZGVvX3NpbmtfaWRsZV9mdW5jKGdwb2lu dGVyIGRhdGEpCiAgICAgaWYgKCFidWZmZXIgfHwgR19VTkxJS0VMWSghR1NUX0lTX0JVRkZFUihi dWZmZXIpKSkKICAgICAgICAgcmV0dXJuIEZBTFNFOwogCi0gICAgLy8gVE9ETzogY29uc2lkZXIg cHJpdi0+cmdiX29yZGVyaW5nPwogICAgIGNhaXJvX3N1cmZhY2VfdCogc3JjID0gY2Fpcm9faW1h Z2Vfc3VyZmFjZV9jcmVhdGVfZm9yX2RhdGEoR1NUX0JVRkZFUl9EQVRBKGJ1ZmZlciksIENBSVJP X0ZPUk1BVF9SR0IyNCwgcHJpdi0+d2lkdGgsIHByaXYtPmhlaWdodCwgKDQgKiBwcml2LT53aWR0 aCArIDMpICYgfjMpOwogCiAgICAgLy8gVE9ETzogV2UgY29weSB0aGUgZGF0YSB0d2ljZSByaWdo dCBub3cuIFRoaXMgY291bGQgYmUgZWFzaWx5IGltcHJvdmVkLgotLSAKMS42LjAuNAoK