29949 2009-09-30 19:30:34 -0700 set ENABLE_NOTIFICATIONS=1 for Chromium 2009-10-19 21:02:08 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 johnnyg johnnyg abarth oldest_to_newest 151427 0 johnnyg 2009-09-30 19:30:34 -0700 Part of adding desktop notifications support to chromium means setting this flag. This is a 2-sided patch, and needs to land concurrently with http://codereview.chromium.org/194079/show. 151429 1 40418 johnnyg 2009-09-30 19:36:22 -0700 Created attachment 40418 patch 151682 2 40418 dglazkov 2009-10-01 13:47:13 -0700 Comment on attachment 40418 patch rs=me. 152864 3 40418 johnnyg 2009-10-06 14:31:54 -0700 Comment on attachment 40418 patch No longer 2-sided since the flag is already set in features_override.gypi. Adding to the commit queue. 152865 4 40418 commit-queue 2009-10-06 14:36:42 -0700 Comment on attachment 40418 patch Rejecting patch 40418 from commit-queue. johnnyg@google.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 152893 5 40418 commit-queue 2009-10-06 16:32:46 -0700 Comment on attachment 40418 patch Rejecting patch 40418 from commit-queue. Patch https://bugs.webkit.org/attachment.cgi?id=40418 from bug 29949 failed to download and apply. 156047 6 abarth 2009-10-19 21:02:08 -0700 Committed r49834: <http://trac.webkit.org/changeset/49834> 40418 2009-09-30 19:36:22 -0700 2009-10-06 16:32:46 -0700 patch bug29949.patch text/plain 989 johnnyg SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gNDg5NTQpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTIgQEAKKzIwMDktMDktMzAgIEpvaG4gR3JlZ2cgIDxqb2hubnlnQGdvb2dsZS5jb20+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgc2V0IEVO QUJMRV9OT1RJRklDQVRJT05TPTEgZm9yIENocm9taXVtCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTk0OQorCisgICAgICAgICogY2hyb21pdW0vZmVh dHVyZXMuZ3lwaToKKwogMjAwOS0wOS0zMCAgWWFhciBTY2huaXRtYW4gIDx5YWFyQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJL aXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0v ZmVhdHVyZXMuZ3lwaQkocmV2aXNpb24gNDg5NTApCisrKyBXZWJLaXQvY2hyb21pdW0vZmVhdHVy ZXMuZ3lwaQkod29ya2luZyBjb3B5KQpAQCAtNDIsNyArNDIsNyBAQAogICAgICAgJ0VOQUJMRV9K QVZBU0NSSVBUX0RFQlVHR0VSPTAnLAogICAgICAgJ0VOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFE Uz0wJywKICAgICAgICdFTkFCTEVfSUNPTkRBVEFCQVNFPTAnLAotICAgICAgJ0VOQUJMRV9OT1RJ RklDQVRJT05TPTAnLAorICAgICAgJ0VOQUJMRV9OT1RJRklDQVRJT05TPTEnLAogICAgICAgJ0VO QUJMRV9PUklFTlRBVElPTl9FVkVOVFM9MCcsCiAgICAgICAnRU5BQkxFX1hTTFQ9MScsCiAgICAg ICAnRU5BQkxFX1hQQVRIPTEnLAo=