29936 2009-09-30 14:52:30 -0700 [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h 2009-12-15 14:42:31 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 kbr kbr cmarrin dglazkov fishd kbr oldest_to_newest 151364 0 kbr 2009-09-30 14:52:30 -0700 In https://bugs.webkit.org/show_bug.cgi?id=29664 certain Chromium-specific #ifdefs were put under PLATFORM(SKIA). These should have been PLATFORM(CHROMIUM). Patch attached. Note that this abstraction mechanism for factoring out the internals of the GraphicsContext3D could be used on all platforms. 151365 1 40402 kbr 2009-09-30 15:00:53 -0700 Created attachment 40402 Patch updating Chromium ifdefs 151449 2 40402 fishd 2009-09-30 21:49:24 -0700 Comment on attachment 40402 Patch updating Chromium ifdefs > Index: WebCore/ChangeLog ... > +2009-09-30 Kenneth Russell <kbr@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [chromium] Update platform-specific #ifdefs in GraphicsContext3D.h > + https://bugs.webkit.org/show_bug.cgi?id=29936 oops... the tab stop there will prevent this from being committed by the commit-queue. i'll commit this manually, but please watch out for tabs in the future. r=me 152522 3 fishd 2009-10-05 16:58:21 -0700 Landed as http://trac.webkit.org/changeset/49132 40402 2009-09-30 15:00:53 -0700 2009-09-30 21:49:24 -0700 Patch updating Chromium ifdefs ifdefs.patch text/plain 1745 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODk0OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDktMzAgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gVXBkYXRlIHBsYXRmb3JtLXNwZWNpZmljICNpZmRlZnMgaW4gR3JhcGhpY3NDb250 ZXh0M0QuaAorCWh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTkzNgor CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NDb250ZXh0M0QuaDoKKyAgICAg ICAgQ2hhbmdlZCAjaWYgUExBVEZPUk0oU0tJQSkgdG8gUExBVEZPUk0oQ0hST01JVU0pLgorCiAy MDA5LTA5LTMwICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3Jh cGhpY3NDb250ZXh0M0QuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L0dyYXBoaWNzQ29udGV4dDNELmgJKHJldmlzaW9uIDQ4OTQ4KQorKysgV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oCSh3b3JraW5nIGNvcHkpCkBAIC02Myw3ICs2 Myw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICBjbGFzcyBXZWJLaXRDU1NNYXRyaXg7CiAg ICAgCiAgICAgLy8gRklYTUU6IGlkZWFsbHkgdGhpcyB3b3VsZCBiZSB1c2VkIG9uIGFsbCBwbGF0 Zm9ybXMuCi0jaWYgUExBVEZPUk0oU0tJQSkKKyNpZiBQTEFURk9STShDSFJPTUlVTSkKICAgICBj bGFzcyBHcmFwaGljc0NvbnRleHQzREludGVybmFsOwogI2VuZGlmCiAKQEAgLTc3LDcgKzc3LDcg QEAgbmFtZXNwYWNlIFdlYkNvcmUgewogI2lmIFBMQVRGT1JNKE1BQykKICAgICAgICAgUGxhdGZv cm1HcmFwaGljc0NvbnRleHQzRCBwbGF0Zm9ybUdyYXBoaWNzQ29udGV4dDNEKCkgY29uc3QgeyBy ZXR1cm4gbV9jb250ZXh0T2JqOyB9CiAgICAgICAgIFBsYXRmb3JtM0RPYmplY3QgcGxhdGZvcm1U ZXh0dXJlKCkgY29uc3QgeyByZXR1cm4gbV90ZXh0dXJlOyB9Ci0jZWxpZiBQTEFURk9STShTS0lB KQorI2VsaWYgUExBVEZPUk0oQ0hST01JVU0pCiAgICAgICAgIFBsYXRmb3JtR3JhcGhpY3NDb250 ZXh0M0QgcGxhdGZvcm1HcmFwaGljc0NvbnRleHQzRCgpIGNvbnN0OwogICAgICAgICBQbGF0Zm9y bTNET2JqZWN0IHBsYXRmb3JtVGV4dHVyZSgpIGNvbnN0OwogI2Vsc2UKQEAgLTMyMyw3ICszMjMs NyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAjZW5kaWYgICAgICAgIAogCiAgICAgICAgIC8vIEZJ WE1FOiBpZGVhbGx5IHRoaXMgd291bGQgYmUgdXNlZCBvbiBhbGwgcGxhdGZvcm1zLgotI2lmIFBM QVRGT1JNKFNLSUEpCisjaWYgUExBVEZPUk0oQ0hST01JVU0pCiAgICAgICAgIGZyaWVuZCBjbGFz cyBHcmFwaGljc0NvbnRleHQzREludGVybmFsOwogICAgICAgICBPd25QdHI8R3JhcGhpY3NDb250 ZXh0M0RJbnRlcm5hbD4gbV9pbnRlcm5hbDsKICNlbmRpZgo=