29933 2009-09-30 12:20:20 -0700 Clean up use of const and mutable in StorageMap 2009-10-01 12:54:47 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jorlow jorlow beidson fishd oldest_to_newest 151320 0 jorlow 2009-09-30 12:20:20 -0700 What's the point of having every single member variable be mutable and nearly every method be const? Let's clean it up. 151322 1 40390 jorlow 2009-09-30 12:24:14 -0700 Created attachment 40390 Patch v1 151674 2 jorlow 2009-10-01 12:54:47 -0700 Committed r48992: <http://trac.webkit.org/changeset/48992> 40390 2009-09-30 12:24:14 -0700 2009-10-01 09:47:15 -0700 Patch v1 bug-29933-20090930122413.patch text/plain 3384 jorlow SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODkzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDktMDktMzAgIEplcmVteSBPcmxvdyAgPGpvcmxvd0BjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Q2xlYW4gdXAgdXNlIG9mIGNvbnN0IGFuZCBtdXRhYmxlIGluIFN0b3JhZ2VNYXAKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5OTMzCisKKyAgICAgICAg V2hhdCdzIHRoZSBwb2ludCBvZiBoYXZpbmcgZXZlcnkgc2luZ2xlIG1lbWJlciB2YXJpYWJsZSBi ZSBtdXRhYmxlIGFuZCBuZWFybHkKKyAgICAgICAgZXZlcnkgbWV0aG9kIGJlIGNvbnN0PyAgTGV0 J3MgY2xlYW4gaXQgdXAuCisKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VNYXAuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6U3RvcmFnZU1hcDo6c2V0SXRlcmF0b3JUb0luZGV4KToKKyAgICAgICAg KFdlYkNvcmU6OlN0b3JhZ2VNYXA6OmtleSk6CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlTWFw OjppbXBvcnRJdGVtKToKKyAgICAgICAgKiBzdG9yYWdlL1N0b3JhZ2VNYXAuaDoKKwogMjAwOS0w OS0yMSAgSmVyZW15IE9ybG93ICA8am9ybG93QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBBZGFtIEJhcnRoLgpJbmRleDogV2ViQ29yZS9zdG9yYWdlL1N0b3JhZ2VNYXAuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFdlYkNvcmUvc3RvcmFnZS9TdG9yYWdlTWFwLmNwcAkocmV2aXNpb24g NDg5MTIpCisrKyBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU1hcC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTU0LDcgKzU0LDcgQEAgdm9pZCBTdG9yYWdlTWFwOjppbnZhbGlkYXRlSXRlcmF0b3IoKQog ICAgIG1faXRlcmF0b3JJbmRleCA9IFVJTlRfTUFYOwogfQogCi12b2lkIFN0b3JhZ2VNYXA6OnNl dEl0ZXJhdG9yVG9JbmRleCh1bnNpZ25lZCBpbmRleCkgY29uc3QKK3ZvaWQgU3RvcmFnZU1hcDo6 c2V0SXRlcmF0b3JUb0luZGV4KHVuc2lnbmVkIGluZGV4KQogewogICAgIC8vIEZJWE1FOiBPbmNl IHdlIGhhdmUgYmlkaXJlY3Rpb25hbCBpdGVyYXRvcnMgZm9yIEhhc2hNYXAgd2UgY2FuIGJlIG1v cmUgaW50ZWxsaWdlbnQgYWJvdXQgdGhpcy4KICAgICAvLyBUaGUgcmVxdWVzdGVkIGluZGV4IHdp bGwgYmUgY2xvc2VzdCB0byBiZWdpbigpLCBvdXIgY3VycmVudCBpdGVyYXRvciwgb3IgZW5kKCks IGFuZCB3ZQpAQCAtODIsNyArODIsNyBAQCB1bnNpZ25lZCBTdG9yYWdlTWFwOjpsZW5ndGgoKSBj b25zdAogICAgIHJldHVybiBtX21hcC5zaXplKCk7CiB9CiAKLVN0cmluZyBTdG9yYWdlTWFwOjpr ZXkodW5zaWduZWQgaW5kZXgpIGNvbnN0CitTdHJpbmcgU3RvcmFnZU1hcDo6a2V5KHVuc2lnbmVk IGluZGV4KQogewogICAgIGlmIChpbmRleCA+PSBsZW5ndGgoKSkKICAgICAgICAgcmV0dXJuIFN0 cmluZygpOwpAQCAtMTQ1LDcgKzE0NSw3IEBAIGJvb2wgU3RvcmFnZU1hcDo6Y29udGFpbnMoY29u c3QgU3RyaW5nJiAKICAgICByZXR1cm4gbV9tYXAuY29udGFpbnMoa2V5KTsKIH0KIAotdm9pZCBT dG9yYWdlTWFwOjppbXBvcnRJdGVtKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZh bHVlKSBjb25zdAordm9pZCBTdG9yYWdlTWFwOjppbXBvcnRJdGVtKGNvbnN0IFN0cmluZyYga2V5 LCBjb25zdCBTdHJpbmcmIHZhbHVlKQogewogICAgIC8vIEJlIHN1cmUgdG8gY29weSB0aGUga2V5 cy92YWx1ZXMgYXMgaXRlbXMgaW1wb3J0ZWQgb24gYSBiYWNrZ3JvdW5kIHRocmVhZCBhcmUgZGVz dGluZWQKICAgICAvLyB0byBjcm9zcyBhIHRocmVhZCBib3VuZGFyeQpJbmRleDogV2ViQ29yZS9z dG9yYWdlL1N0b3JhZ2VNYXAuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3N0b3JhZ2UvU3RvcmFn ZU1hcC5oCShyZXZpc2lvbiA0ODkxMikKKysrIFdlYkNvcmUvc3RvcmFnZS9TdG9yYWdlTWFwLmgJ KHdvcmtpbmcgY29weSkKQEAgLTQyLDI0ICs0MiwyNCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAg ICAgICAgIHN0YXRpYyBQYXNzUmVmUHRyPFN0b3JhZ2VNYXA+IGNyZWF0ZSgpOwogCiAgICAgICAg IHVuc2lnbmVkIGxlbmd0aCgpIGNvbnN0OwotICAgICAgICBTdHJpbmcga2V5KHVuc2lnbmVkIGlu ZGV4KSBjb25zdDsKKyAgICAgICAgU3RyaW5nIGtleSh1bnNpZ25lZCBpbmRleCk7CiAgICAgICAg IFN0cmluZyBnZXRJdGVtKGNvbnN0IFN0cmluZyYpIGNvbnN0OwogICAgICAgICBQYXNzUmVmUHRy PFN0b3JhZ2VNYXA+IHNldEl0ZW0oY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFs dWUsIFN0cmluZyYgb2xkVmFsdWUpOwogICAgICAgICBQYXNzUmVmUHRyPFN0b3JhZ2VNYXA+IHJl bW92ZUl0ZW0oY29uc3QgU3RyaW5nJiwgU3RyaW5nJiBvbGRWYWx1ZSk7CiAKICAgICAgICAgYm9v bCBjb250YWlucyhjb25zdCBTdHJpbmcmIGtleSkgY29uc3Q7CiAKLSAgICAgICAgdm9pZCBpbXBv cnRJdGVtKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZhbHVlKSBjb25zdDsKKyAg ICAgICAgdm9pZCBpbXBvcnRJdGVtKGNvbnN0IFN0cmluZyYga2V5LCBjb25zdCBTdHJpbmcmIHZh bHVlKTsKIAogICAgIHByaXZhdGU6CiAgICAgICAgIFN0b3JhZ2VNYXAoKTsKICAgICAgICAgUGFz c1JlZlB0cjxTdG9yYWdlTWFwPiBjb3B5KCk7CiAgICAgICAgIHZvaWQgaW52YWxpZGF0ZUl0ZXJh dG9yKCk7Ci0gICAgICAgIHZvaWQgc2V0SXRlcmF0b3JUb0luZGV4KHVuc2lnbmVkKSBjb25zdDsK KyAgICAgICAgdm9pZCBzZXRJdGVyYXRvclRvSW5kZXgodW5zaWduZWQpOwogCi0gICAgICAgIG11 dGFibGUgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz4gbV9tYXA7Ci0gICAgICAgIG11dGFibGUgSGFz aE1hcDxTdHJpbmcsIFN0cmluZz46Oml0ZXJhdG9yIG1faXRlcmF0b3I7Ci0gICAgICAgIG11dGFi bGUgdW5zaWduZWQgbV9pdGVyYXRvckluZGV4OworICAgICAgICBIYXNoTWFwPFN0cmluZywgU3Ry aW5nPiBtX21hcDsKKyAgICAgICAgSGFzaE1hcDxTdHJpbmcsIFN0cmluZz46Oml0ZXJhdG9yIG1f aXRlcmF0b3I7CisgICAgICAgIHVuc2lnbmVkIG1faXRlcmF0b3JJbmRleDsKICAgICB9OwogCiB9 IC8vIG5hbWVzcGFjZSBXZWJDb3Jl