29920 2009-09-30 05:56:19 -0700 Make a copy of listeners array before dispatching an event 2009-10-01 06:17:16 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys commit-queue pmuellr timothy oldest_to_newest 151232 0 yurys 2009-09-30 05:56:19 -0700 Make a copy of listeners array before dispatching an event in WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current listener removes itself from the array next listener will be skipped. 151234 1 40366 yurys 2009-09-30 06:05:24 -0700 Created attachment 40366 patch 151267 2 40366 timothy 2009-09-30 09:18:45 -0700 Comment on attachment 40366 patch Why did you remove the bind calls? Those are needed to pass the event as the this object. 151310 3 pmuellr 2009-09-30 11:43:23 -0700 Looks like the bind() should be on preventDefault, but not on stopPropagation. Not harmful on stopPropagation, but it's not needed, and otherwise creates a new function closure for no good reason. 151469 4 yurys 2009-09-30 23:48:07 -0700 (In reply to comment #2) > (From update of attachment 40366 [details]) > Why did you remove the bind calls? > > Those are needed to pass the event as the this object. There is no need to bind the functions to event since 'this' variable will be resolved dynamically and as long as preventDefault and stopPropagation are invoked on 'event' 'this' object will be === 'event'. Please tell me if you still want me to revert the changes. 151522 5 40366 commit-queue 2009-10-01 06:17:12 -0700 Comment on attachment 40366 patch Clearing flags on attachment: 40366 Committed r48970: <http://trac.webkit.org/changeset/48970> 151523 6 commit-queue 2009-10-01 06:17:16 -0700 All reviewed patches have been landed. Closing bug. 40366 2009-09-30 06:05:24 -0700 2009-10-01 06:17:12 -0700 patch copy-listeners.patch text/plain 1642 yurys ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWFjYzNkYy4uODZlYTlmNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wOS0zMCAgWXVyeSBTZW1pa2hh dHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBUaW1vdGh5 IEhhdGNoZXIuCisKKyAgICAgICAgTWFrZSBhIGNvcHkgb2YgbGlzdGVuZXJzIGFycmF5IGJlZm9y ZSBkaXNwYXRjaGluZyBhbiBldmVudCBpbgorICAgICAgICBXZWJJbnNwZWN0b3IuT2JqZWN0LnBy b3RvdHlwZS5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMuIE90aGVyd2lzZSBpZiBjdXJyZW50Cisg ICAgICAgIGxpc3RlbmVyIHJlbW92ZXMgaXRzZWxmIGZyb20gdGhlIGFycmF5IG5leHQgbGlzdGVu ZXIgd2lsbCBiZSBza2lwcGVkLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yOTkyMAorCisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9PYmpl Y3QuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuT2JqZWN0LnByb3RvdHlwZS5kaXNwYXRjaEV2 ZW50VG9MaXN0ZW5lcnMpOiBtYWtlIGEgY29weSBvZiBsaXN0ZW5lcnMgYXJyYXkgYmVmb3JlIGRp c3BhdGNoaW5nIGFuIGV2ZW50CisKIDIwMDktMDktMjkgIERhdmUgSHlhdHQgIDxoeWF0dEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSm9uIEhvbmV5Y3V0dC4KZGlmZiAtLWdpdCBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3QuanMgYi9XZWJDb3JlL2luc3BlY3Rv ci9mcm9udC1lbmQvT2JqZWN0LmpzCmluZGV4IDgwMjAyYjAuLjc0ZmI1NmUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9PYmplY3QuanMKKysrIGIvV2ViQ29yZS9pbnNw ZWN0b3IvZnJvbnQtZW5kL09iamVjdC5qcwpAQCAtNjcsMTAgKzY3LDEwIEBAIFdlYkluc3BlY3Rv ci5PYmplY3QucHJvdG90eXBlID0gewogICAgICAgICB9CiAKICAgICAgICAgdmFyIGV2ZW50ID0g e3RhcmdldDogdGhpcywgdHlwZTogZXZlbnRUeXBlLCBkZWZhdWx0UHJldmVudGVkOiBmYWxzZX07 Ci0gICAgICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbiA9IHN0b3BQcm9wYWdhdGlvbi5iaW5kKGV2 ZW50KTsKLSAgICAgICAgZXZlbnQucHJldmVudERlZmF1bHQgPSBwcmV2ZW50RGVmYXVsdC5iaW5k KGV2ZW50KTsKKyAgICAgICAgZXZlbnQuc3RvcFByb3BhZ2F0aW9uID0gc3RvcFByb3BhZ2F0aW9u OworICAgICAgICBldmVudC5wcmV2ZW50RGVmYXVsdCA9IHByZXZlbnREZWZhdWx0OwogCi0gICAg ICAgIHZhciBsaXN0ZW5lcnMgPSB0aGlzLl9saXN0ZW5lcnNbZXZlbnRUeXBlXTsKKyAgICAgICAg dmFyIGxpc3RlbmVycyA9IHRoaXMuX2xpc3RlbmVyc1tldmVudFR5cGVdLnNsaWNlKDApOwogICAg ICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGxpc3RlbmVycy5sZW5ndGg7ICsraSkgewogICAgICAg ICAgICAgbGlzdGVuZXJzW2ldLmxpc3RlbmVyLmNhbGwobGlzdGVuZXJzW2ldLnRoaXNPYmplY3Qs IGV2ZW50KTsKICAgICAgICAgICAgIGlmIChzdG9wcGVkUHJvcGFnYXRpb24pCg==