29917 2009-09-30 04:01:31 -0700 Enable Web Sockets in chromium build 2009-10-06 14:52:37 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned ap oldest_to_newest 151211 0 ukai 2009-09-30 04:01:31 -0700 Enable Web Sockets in chromium build. 151214 1 40358 ukai 2009-09-30 04:22:02 -0700 Created attachment 40358 enable web sockets in chromium build 151216 2 ukai 2009-09-30 04:22:53 -0700 (In reply to comment #1) > Created an attachment (id=40358) [details] > enable web sockets in chromium build This patch requires http://codereview.chromium.org/256010 151809 3 ukai 2009-10-02 03:10:47 -0700 (In reply to comment #2) > (In reply to comment #1) > > Created an attachment (id=40358) [details] [details] > > enable web sockets in chromium build > > This patch requires http://codereview.chromium.org/256010 The patch of chromium side has been landed as http://src.chromium.org/viewvc/chrome?view=rev&revision=27835. Could you review it, please? Thanks. 151945 4 40358 eric 2009-10-02 12:44:05 -0700 Comment on attachment 40358 enable web sockets in chromium build LGTM. I'm not sure build "fixes" like this need review. 152199 5 ukai 2009-10-04 19:53:43 -0700 (In reply to comment #4) > (From update of attachment 40358 [details]) > LGTM. > > I'm not sure build "fixes" like this need review. Thanks for review. Landed as r49080. 152869 6 ap 2009-10-06 14:52:37 -0700 I do not think that this should have been done before testing infrastructure was in place. Having untested code for large features in svn repository while it's being developed is one thing, but shipping it (even in nightly builds) is crossing the line, in my opinion. That said, I do realize that the testing infrastructure is being actively worked on, and it took a great deal of effort already. 40358 2009-09-30 04:22:02 -0700 2009-10-02 12:44:05 -0700 enable web sockets in chromium build bug-29917-20090930202200.patch text/plain 1911 ukai ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YmMzMzUxZi4uYmY2NDM5YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAwOS0wOS0zMCAgRnVtaXRvc2hpIFVr YWkgIDx1a2FpQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBFbmFibGUgV2ViIFNvY2tldHMgaW4gY2hyb21pdW0gYnVpbGQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTkxNworCisg ICAgICAgICogV2ViQ29yZS5neXAvV2ViQ29yZS5neXA6CisKIDIwMDktMDktMjkgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUnViYmVyLXN0YW1wZWQgYnkg QnJhZHkgRWlkc29uLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5 cCBiL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAKaW5kZXggM2RlYzkyYS4uMTA4ZGZh MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAorKysgYi9XZWJD b3JlL1dlYkNvcmUuZ3lwL1dlYkNvcmUuZ3lwCkBAIC0xMDMsNiArMTAzLDcgQEAKICAgICAgICcu Li9zdmcnLAogICAgICAgJy4uL3N2Zy9hbmltYXRpb24nLAogICAgICAgJy4uL3N2Zy9ncmFwaGlj cycsCisgICAgICAnLi4vd2Vic29ja2V0cycsCiAgICAgICAnLi4vd29ya2VycycsCiAgICAgICAn Li4veG1sJywKICAgICBdLApAQCAtMzg3LDYgKzM4OCw3IEBACiAgICAgICAgICAgICAgICctLWlu Y2x1ZGUnLCAnLi4vcGFnZScsCiAgICAgICAgICAgICAgICctLWluY2x1ZGUnLCAnLi4vcGx1Z2lu cycsCiAgICAgICAgICAgICAgICctLWluY2x1ZGUnLCAnLi4vc3ZnJywKKyAgICAgICAgICAgICAg Jy0taW5jbHVkZScsICcuLi93ZWJzb2NrZXRzJywKICAgICAgICAgICAgICAgJy0taW5jbHVkZScs ICcuLi93b3JrZXJzJywKICAgICAgICAgICAgICAgJy0taW5jbHVkZScsICcuLi94bWwnLAogICAg ICAgICAgICAgXSwKZGlmZiAtLWdpdCBhL1dlYktpdC9DaGFuZ2VMb2cgYi9XZWJLaXQvQ2hhbmdl TG9nCmluZGV4IDJmOGYxOGYuLjJmM2QyZjcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTA5LTMwICBGdW1p dG9zaGkgVWthaSAgPHVrYWlAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBXZWIgU29ja2V0cyBpbiBjaHJvbWl1bSBi dWlsZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5 OTE3CisKKyAgICAgICAgKiBjaHJvbWl1bS9mZWF0dXJlcy5neXBpOgorCiAyMDA5LTA5LTI5ICBC cmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBK b2huIFN1bGxpdmFuLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL2ZlYXR1cmVzLmd5cGkg Yi9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQppbmRleCBhZGNiNTI3Li5kODVkZWNlIDEw MDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vZmVhdHVyZXMuZ3lwaQorKysgYi9XZWJLaXQvY2hy b21pdW0vZmVhdHVyZXMuZ3lwaQpAQCAtNTQsNiArNTQsNyBAQAogICAgICAgJ0VOQUJMRV9TVkdf Rk9SRUlHTl9PQkpFQ1Q9MScsCiAgICAgICAnRU5BQkxFX1NWR19GT05UUz0xJywKICAgICAgICdF TkFCTEVfVklERU89MScsCisgICAgICAnRU5BQkxFX1dFQl9TT0NLRVRTPTEnLAogICAgICAgJ0VO QUJMRV9XT1JLRVJTPTEnLAogICAgIF0sCiAgIH0s