29915 2009-09-30 02:33:27 -0700 Buildfix for platforms using JSVALUE32 2009-09-30 15:08:58 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 ossy webkit-unassigned barraclough eric ggaren oldest_to_newest 151197 0 ossy 2009-09-30 02:33:27 -0700 http://trac.webkit.org/changeset/48895 brakes build if using JSVALUE32. - In emit_op_add and emitSlow_op_add missing the declaration of types variable. - In emit_op_add there are two typo (and some unnecessary code). 151200 1 40352 ossy 2009-09-30 02:38:49 -0700 Created attachment 40352 proposed patch eg. ARM and Qt port on Windows use JSVALUE32 now. Patch tested on ARM. 151215 2 40359 ossy 2009-09-30 04:22:07 -0700 Created attachment 40359 proposed patch patch updated: "unnecessary" replaced with "unreachable" in ChangeLog In additional tested with QtWebKit-win. 151298 3 40359 ggaren 2009-09-30 11:21:12 -0700 Comment on attachment 40359 proposed patch r=me 151299 4 40359 commit-queue 2009-09-30 11:23:58 -0700 Comment on attachment 40359 proposed patch Rejecting patch 40359 from review queue. ggaren@apple.com does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py. 151303 5 ggaren 2009-09-30 11:27:10 -0700 Committed revision 48938. 151366 6 eric 2009-09-30 15:00:58 -0700 Geoff needs to be added to: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/modules/committers.py as a reviewer. I'll take care of it. 151367 7 eric 2009-09-30 15:08:58 -0700 I've added Geoff to the list of reviewers. bugzilla-tool (and thus the commit-queue) will recognize him as a valid reviewer now: http://trac.webkit.org/changeset/48949 If I've missed any other reviewers or committers they should feel encouraged to add themselves to that file w/o review. 40352 2009-09-30 02:38:49 -0700 2009-09-30 04:22:07 -0700 proposed patch armbuildfix.patch text/plain 2989 ossy ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlY2UzM2NkLi5hNTM2YTJiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMDktMDktMzAgIENzYWJhIE9zenRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGRm aXggZm9yIHBsYXRmb3JtcyB1c2luZyBKU1ZBTFVFMzIuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTkxNQorCisgICAgICAgIEFmdGVyIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzQ4OTA1IHRoZSBidWlsZCBicm9rZSBpbiBKU1ZBTFVF MzIgY2FzZS4KKworICAgICAgICAqIGppdC9KSVRBcml0aG1ldGljLmNwcDoKKyAgICAgICAgKEpT Qzo6SklUOjplbWl0X29wX2FkZCk6CisgICAgICAgICAtIERlY2xhcmF0aW9uIG9mICJPcGVyYW5k VHlwZXMgdHlwZXMiIG1vdmVkIGJlZm9yZSBmaXJzdCB1c2UuCisgICAgICAgICAtIFR5cG9zIGZp eGVkOiBkc3QgbW9kaWZpZWQgdG8gcmVzdWx0LCByZWdUMiBhZGRlZC4KKyAgICAgICAgIC0gVW5u ZWNlc3NhcnkgY29kZSByZW1vdmVkLgorICAgICAgICAoSlNDOjpKSVQ6OmVtaXRTbG93X29wX2Fk ZCk6CisgICAgICAgICAtIE1pc3NpbmcgZGVjbGFyYXRpb24gb2YgIk9wZXJhbmRUeXBlcyB0eXBl cyIgYWRkZWQuCisKIDIwMDktMDktMzAgIEphbm5lIEtvc2tpbmVuICA8amFubmUucC5rb3NraW5l bkBkaWdpYS5jb20+IAogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZm IC0tZ2l0IGEvSmF2YVNjcmlwdENvcmUvaml0L0pJVEFyaXRobWV0aWMuY3BwIGIvSmF2YVNjcmlw dENvcmUvaml0L0pJVEFyaXRobWV0aWMuY3BwCmluZGV4IDI0YjA3ZDMuLjdhZmMxZjIgMTAwNjQ0 Ci0tLSBhL0phdmFTY3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcAorKysgYi9KYXZhU2Ny aXB0Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAKQEAgLTI0MTIsMTIgKzI0MTIsMTMgQEAgdm9p ZCBKSVQ6OmVtaXRfb3BfYWRkKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24pCiAgICAg dW5zaWduZWQgcmVzdWx0ID0gY3VycmVudEluc3RydWN0aW9uWzFdLnUub3BlcmFuZDsKICAgICB1 bnNpZ25lZCBvcDEgPSBjdXJyZW50SW5zdHJ1Y3Rpb25bMl0udS5vcGVyYW5kOwogICAgIHVuc2ln bmVkIG9wMiA9IGN1cnJlbnRJbnN0cnVjdGlvblszXS51Lm9wZXJhbmQ7CisgICAgT3BlcmFuZFR5 cGVzIHR5cGVzID0gT3BlcmFuZFR5cGVzOjpmcm9tSW50KGN1cnJlbnRJbnN0cnVjdGlvbls0XS51 Lm9wZXJhbmQpOwogCiAgICAgaWYgKCF0eXBlcy5maXJzdCgpLm1pZ2h0QmVOdW1iZXIoKSB8fCAh dHlwZXMuc2Vjb25kKCkubWlnaHRCZU51bWJlcigpKSB7CiAgICAgICAgIEpJVFN0dWJDYWxsIHN0 dWJDYWxsKHRoaXMsIGN0aV9vcF9hZGQpOwotICAgICAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChv cDEpOwotICAgICAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChvcDIpOwotICAgICAgICBzdHViQ2Fs bC5jYWxsKGRzdCk7CisgICAgICAgIHN0dWJDYWxsLmFkZEFyZ3VtZW50KG9wMSwgcmVnVDIpOwor ICAgICAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChvcDIsIHJlZ1QyKTsKKyAgICAgICAgc3R1YkNh bGwuY2FsbChyZXN1bHQpOwogICAgICAgICByZXR1cm47CiAgICAgfQogCkBAIC0yNDM0LDE1ICsy NDM1LDcgQEAgdm9pZCBKSVQ6OmVtaXRfb3BfYWRkKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1 Y3Rpb24pCiAgICAgICAgIHNpZ25FeHRlbmQzMlRvUHRyKHJlZ1QwLCByZWdUMCk7CiAgICAgICAg IGVtaXRQdXRWaXJ0dWFsUmVnaXN0ZXIocmVzdWx0KTsKICAgICB9IGVsc2UgewotICAgICAgICBP cGVyYW5kVHlwZXMgdHlwZXMgPSBPcGVyYW5kVHlwZXM6OmZyb21JbnQoY3VycmVudEluc3RydWN0 aW9uWzRdLnUub3BlcmFuZCk7Ci0gICAgICAgIGlmICh0eXBlcy5maXJzdCgpLm1pZ2h0QmVOdW1i ZXIoKSAmJiB0eXBlcy5zZWNvbmQoKS5taWdodEJlTnVtYmVyKCkpCi0gICAgICAgICAgICBjb21w aWxlQmluYXJ5QXJpdGhPcChvcF9hZGQsIHJlc3VsdCwgb3AxLCBvcDIsIE9wZXJhbmRUeXBlczo6 ZnJvbUludChjdXJyZW50SW5zdHJ1Y3Rpb25bNF0udS5vcGVyYW5kKSk7Ci0gICAgICAgIGVsc2Ug ewotICAgICAgICAgICAgSklUU3R1YkNhbGwgc3R1YkNhbGwodGhpcywgY3RpX29wX2FkZCk7Ci0g ICAgICAgICAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChvcDEsIHJlZ1QyKTsKLSAgICAgICAgICAg IHN0dWJDYWxsLmFkZEFyZ3VtZW50KG9wMiwgcmVnVDIpOwotICAgICAgICAgICAgc3R1YkNhbGwu Y2FsbChyZXN1bHQpOwotICAgICAgICB9CisgICAgICAgIGNvbXBpbGVCaW5hcnlBcml0aE9wKG9w X2FkZCwgcmVzdWx0LCBvcDEsIG9wMiwgT3BlcmFuZFR5cGVzOjpmcm9tSW50KGN1cnJlbnRJbnN0 cnVjdGlvbls0XS51Lm9wZXJhbmQpKTsKICAgICB9CiB9CiAKQEAgLTI0NTIsNiArMjQ0NSw3IEBA IHZvaWQgSklUOjplbWl0U2xvd19vcF9hZGQoSW5zdHJ1Y3Rpb24qIGN1cnJlbnRJbnN0cnVjdGlv biwgVmVjdG9yPFNsb3dDYXNlRW50cnk+CiAgICAgdW5zaWduZWQgb3AxID0gY3VycmVudEluc3Ry dWN0aW9uWzJdLnUub3BlcmFuZDsKICAgICB1bnNpZ25lZCBvcDIgPSBjdXJyZW50SW5zdHJ1Y3Rp b25bM10udS5vcGVyYW5kOwogCisgICAgT3BlcmFuZFR5cGVzIHR5cGVzID0gT3BlcmFuZFR5cGVz Ojpmcm9tSW50KGN1cnJlbnRJbnN0cnVjdGlvbls0XS51Lm9wZXJhbmQpOwogICAgIGlmICghdHlw ZXMuZmlyc3QoKS5taWdodEJlTnVtYmVyKCkgfHwgIXR5cGVzLnNlY29uZCgpLm1pZ2h0QmVOdW1i ZXIoKSkKICAgICAgICAgcmV0dXJuOwogCg== 40359 2009-09-30 04:22:07 -0700 2009-09-30 11:29:34 -0700 proposed patch armbuildfix2.patch text/plain 3038 ossy ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBlY2UzM2NkLi5hNTM2YTJiIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMDktMDktMzAgIENzYWJhIE9zenRyb2dvbmFjICA8b3N6aUBpbmYudS1zemVnZWQuaHU+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQnVpbGRm aXggZm9yIHBsYXRmb3JtcyB1c2luZyBKU1ZBTFVFMzIuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yOTkxNQorCisgICAgICAgIEFmdGVyIGh0dHA6Ly90 cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzQ4OTA1IHRoZSBidWlsZCBicm9rZSBpbiBKU1ZBTFVF MzIgY2FzZS4KKyAgICAgICAgSW4gYWRkaXRpb25hbCB1bnJlYWNoYWJsZSBjb2RlIHJlbW92ZWQu CisKKyAgICAgICAgKiBqaXQvSklUQXJpdGhtZXRpYy5jcHA6CisgICAgICAgIChKU0M6OkpJVDo6 ZW1pdF9vcF9hZGQpOgorICAgICAgICAgLSBEZWNsYXJhdGlvbiBvZiAiT3BlcmFuZFR5cGVzIHR5 cGVzIiBtb3ZlZCBiZWZvcmUgZmlyc3QgdXNlLgorICAgICAgICAgLSBUeXBvcyBmaXhlZDogZHN0 IG1vZGlmaWVkIHRvIHJlc3VsdCwgcmVnVDIgYWRkZWQuCisgICAgICAgICAtIFVucmVhY2hhYmxl IGNvZGUgcmVtb3ZlZC4KKyAgICAgICAgKEpTQzo6SklUOjplbWl0U2xvd19vcF9hZGQpOgorICAg ICAgICAgLSBNaXNzaW5nIGRlY2xhcmF0aW9uIG9mICJPcGVyYW5kVHlwZXMgdHlwZXMiIGFkZGVk LgorCiAyMDA5LTA5LTMwICBKYW5uZSBLb3NraW5lbiAgPGphbm5lLnAua29za2luZW5AZGlnaWEu Y29tPiAKIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KZGlmZiAtLWdpdCBh L0phdmFTY3JpcHRDb3JlL2ppdC9KSVRBcml0aG1ldGljLmNwcCBiL0phdmFTY3JpcHRDb3JlL2pp dC9KSVRBcml0aG1ldGljLmNwcAppbmRleCAyNGIwN2QzLi43YWZjMWYyIDEwMDY0NAotLS0gYS9K YXZhU2NyaXB0Q29yZS9qaXQvSklUQXJpdGhtZXRpYy5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUv aml0L0pJVEFyaXRobWV0aWMuY3BwCkBAIC0yNDEyLDEyICsyNDEyLDEzIEBAIHZvaWQgSklUOjpl bWl0X29wX2FkZChJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQogICAgIHVuc2lnbmVk IHJlc3VsdCA9IGN1cnJlbnRJbnN0cnVjdGlvblsxXS51Lm9wZXJhbmQ7CiAgICAgdW5zaWduZWQg b3AxID0gY3VycmVudEluc3RydWN0aW9uWzJdLnUub3BlcmFuZDsKICAgICB1bnNpZ25lZCBvcDIg PSBjdXJyZW50SW5zdHJ1Y3Rpb25bM10udS5vcGVyYW5kOworICAgIE9wZXJhbmRUeXBlcyB0eXBl cyA9IE9wZXJhbmRUeXBlczo6ZnJvbUludChjdXJyZW50SW5zdHJ1Y3Rpb25bNF0udS5vcGVyYW5k KTsKIAogICAgIGlmICghdHlwZXMuZmlyc3QoKS5taWdodEJlTnVtYmVyKCkgfHwgIXR5cGVzLnNl Y29uZCgpLm1pZ2h0QmVOdW1iZXIoKSkgewogICAgICAgICBKSVRTdHViQ2FsbCBzdHViQ2FsbCh0 aGlzLCBjdGlfb3BfYWRkKTsKLSAgICAgICAgc3R1YkNhbGwuYWRkQXJndW1lbnQob3AxKTsKLSAg ICAgICAgc3R1YkNhbGwuYWRkQXJndW1lbnQob3AyKTsKLSAgICAgICAgc3R1YkNhbGwuY2FsbChk c3QpOworICAgICAgICBzdHViQ2FsbC5hZGRBcmd1bWVudChvcDEsIHJlZ1QyKTsKKyAgICAgICAg c3R1YkNhbGwuYWRkQXJndW1lbnQob3AyLCByZWdUMik7CisgICAgICAgIHN0dWJDYWxsLmNhbGwo cmVzdWx0KTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIApAQCAtMjQzNCwxNSArMjQzNSw3IEBA IHZvaWQgSklUOjplbWl0X29wX2FkZChJbnN0cnVjdGlvbiogY3VycmVudEluc3RydWN0aW9uKQog ICAgICAgICBzaWduRXh0ZW5kMzJUb1B0cihyZWdUMCwgcmVnVDApOwogICAgICAgICBlbWl0UHV0 VmlydHVhbFJlZ2lzdGVyKHJlc3VsdCk7CiAgICAgfSBlbHNlIHsKLSAgICAgICAgT3BlcmFuZFR5 cGVzIHR5cGVzID0gT3BlcmFuZFR5cGVzOjpmcm9tSW50KGN1cnJlbnRJbnN0cnVjdGlvbls0XS51 Lm9wZXJhbmQpOwotICAgICAgICBpZiAodHlwZXMuZmlyc3QoKS5taWdodEJlTnVtYmVyKCkgJiYg dHlwZXMuc2Vjb25kKCkubWlnaHRCZU51bWJlcigpKQotICAgICAgICAgICAgY29tcGlsZUJpbmFy eUFyaXRoT3Aob3BfYWRkLCByZXN1bHQsIG9wMSwgb3AyLCBPcGVyYW5kVHlwZXM6OmZyb21JbnQo Y3VycmVudEluc3RydWN0aW9uWzRdLnUub3BlcmFuZCkpOwotICAgICAgICBlbHNlIHsKLSAgICAg ICAgICAgIEpJVFN0dWJDYWxsIHN0dWJDYWxsKHRoaXMsIGN0aV9vcF9hZGQpOwotICAgICAgICAg ICAgc3R1YkNhbGwuYWRkQXJndW1lbnQob3AxLCByZWdUMik7Ci0gICAgICAgICAgICBzdHViQ2Fs bC5hZGRBcmd1bWVudChvcDIsIHJlZ1QyKTsKLSAgICAgICAgICAgIHN0dWJDYWxsLmNhbGwocmVz dWx0KTsKLSAgICAgICAgfQorICAgICAgICBjb21waWxlQmluYXJ5QXJpdGhPcChvcF9hZGQsIHJl c3VsdCwgb3AxLCBvcDIsIE9wZXJhbmRUeXBlczo6ZnJvbUludChjdXJyZW50SW5zdHJ1Y3Rpb25b NF0udS5vcGVyYW5kKSk7CiAgICAgfQogfQogCkBAIC0yNDUyLDYgKzI0NDUsNyBAQCB2b2lkIEpJ VDo6ZW1pdFNsb3dfb3BfYWRkKEluc3RydWN0aW9uKiBjdXJyZW50SW5zdHJ1Y3Rpb24sIFZlY3Rv cjxTbG93Q2FzZUVudHJ5PgogICAgIHVuc2lnbmVkIG9wMSA9IGN1cnJlbnRJbnN0cnVjdGlvblsy XS51Lm9wZXJhbmQ7CiAgICAgdW5zaWduZWQgb3AyID0gY3VycmVudEluc3RydWN0aW9uWzNdLnUu b3BlcmFuZDsKIAorICAgIE9wZXJhbmRUeXBlcyB0eXBlcyA9IE9wZXJhbmRUeXBlczo6ZnJvbUlu dChjdXJyZW50SW5zdHJ1Y3Rpb25bNF0udS5vcGVyYW5kKTsKICAgICBpZiAoIXR5cGVzLmZpcnN0 KCkubWlnaHRCZU51bWJlcigpIHx8ICF0eXBlcy5zZWNvbmQoKS5taWdodEJlTnVtYmVyKCkpCiAg ICAgICAgIHJldHVybjsKIAo=