29908 2009-09-29 17:33:16 -0700 Make assertion clearer for case where UTF8 is not supported by platform TextCodec 2009-09-29 18:08:34 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yong.li.webkit webkit-unassigned darin staikos oldest_to_newest 151115 0 yong.li.webkit 2009-09-29 17:33:16 -0700 UTF8Encoding() returns a static TextEncoding object. But if "UTF-8" is not registered by platform TextCodec, the encoding object will contain a null "m_name" and newTextCodec() will get a null "factory" function. There's already an ASSERT(factory.function) in newTextCodec(), but at that point, the encoding name is null. It's not so clear that the crash is due to missing UTF-8 support. ASSERT(factory.function) is supposed to detect the problem that the platform TextCodec forgets to register a factory for an encoding it has registered. So we think adding an ASSERT to UTF8Encoding() can be helpful. 151118 1 40337 yong.li.webkit 2009-09-29 17:39:43 -0700 Created attachment 40337 the patch the patch 151119 2 40337 darin 2009-09-29 17:40:55 -0700 Comment on attachment 40337 the patch Seems fine. 151130 3 yong.li.webkit 2009-09-29 18:08:34 -0700 Landed @48913 40337 2009-09-29 17:39:43 -0700 2009-09-29 18:08:11 -0700 the patch 29908.patch text/plain 964 yong.li.webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NzJkNmY2Yy4uMDVjOTYyMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0wOS0yOSAgWW9uZyBMaSAgPHlv bmcubGlAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEFkZCBhbiBBU1NFUlQgZm9yIFVURjhFbmNvZGluZygpLmlzVmFsaWQo KQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk5MDgK KworICAgICAgICAqIHBsYXRmb3JtL3RleHQvVGV4dEVuY29kaW5nLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlVURjhFbmNvZGluZyk6CisKIDIwMDktMDktMjkgIEVucmljYSBDYXN1Y2NpICA8ZW5y aWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGVsZSBQZXRlcnNvbi4KZGlm ZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9UZXh0RW5jb2RpbmcuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5jcHAKaW5kZXggYjc2ZjczOS4uYzVjOGNmZCAx MDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5jcHAKKysrIGIv V2ViQ29yZS9wbGF0Zm9ybS90ZXh0L1RleHRFbmNvZGluZy5jcHAKQEAgLTI2NCw2ICsyNjQsNyBA QCBjb25zdCBUZXh0RW5jb2RpbmcmIFVURjMyTGl0dGxlRW5kaWFuRW5jb2RpbmcoKQogY29uc3Qg VGV4dEVuY29kaW5nJiBVVEY4RW5jb2RpbmcoKQogewogICAgIHN0YXRpYyBUZXh0RW5jb2Rpbmcg Z2xvYmFsVVRGOEVuY29kaW5nKCJVVEYtOCIpOworICAgIEFTU0VSVChnbG9iYWxVVEY4RW5jb2Rp bmcuaXNWYWxpZCgpKTsKICAgICByZXR1cm4gZ2xvYmFsVVRGOEVuY29kaW5nOwogfQogCg==