29898 2009-09-29 14:58:46 -0700 update-webkit --chromium fails to set .gclient file 2009-09-29 18:46:45 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 yaar yaar commit-queue ddkilzer yaar oldest_to_newest 151061 0 yaar 2009-09-29 14:58:46 -0700 The error codes of exec calls in the update-webkit-chromium perl scripts are not captured correctly. 151064 1 40327 yaar 2009-09-29 15:01:44 -0700 Created attachment 40327 minor error handling changes exec(...) doesn't return the error codes we expect. reverted to using system(...) 151128 2 40327 ddkilzer 2009-09-29 18:01:59 -0700 Comment on attachment 40327 minor error handling changes > diff --git a/WebKitTools/Scripts/update-webkit b/WebKitTools/Scripts/update-webkit > } elsif (isChromium()) { > - system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die; > + system("perl", "WebKitTools/Scripts/update-webkit-chromium") == 0 or die $!; > } elsif (isAppleWinWebKit()) { > system("perl", "WebKitTools/Scripts/update-webkit-auxiliary-libs") == 0 or die; > } Someday we may be able to use something other than "perl" here. See Bug 29656 Comment #8. r=me 151144 3 40327 commit-queue 2009-09-29 18:46:37 -0700 Comment on attachment 40327 minor error handling changes Clearing flags on attachment: 40327 Committed r48916: <http://trac.webkit.org/changeset/48916> 151145 4 commit-queue 2009-09-29 18:46:45 -0700 All reviewed patches have been landed. Closing bug. 40327 2009-09-29 15:01:44 -0700 2009-09-29 18:46:36 -0700 minor error handling changes WK29898.diff text/plain 2180 yaar ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiYTZiN2E4Li5mOTEzYTczIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDkt MjkgIFlhYXIgU2Nobml0bWFuICA8eWFhckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4ZWQgaG93IGVycm9yIGNvZGVzIGFy ZSBoYW5kbGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9Mjk4OTgKKworICAgICAgICAqIFNjcmlwdHMvdXBkYXRlLXdlYmtpdDoKKyAgICAgICAgKiBT Y3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW06CisKIDIwMDktMDktMjkgIERhbiBCZXJuc3Rl aW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0IGIvV2ViS2l0VG9v bHMvU2NyaXB0cy91cGRhdGUtd2Via2l0CmluZGV4IDhmMmQ2YjEuLmU1NjJjYzAgMTAwNzU1Ci0t LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdAorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL3VwZGF0ZS13ZWJraXQKQEAgLTc3LDcgKzc3LDcgQEAgaWYgKC1kICIuLi9JbnRlcm5h bCIpIHsKICAgICBwcmludCAiVXBkYXRpbmcgSW50ZXJuYWxcbiIgdW5sZXNzICRxdWlldDsKICAg ICBydW5Tdm5VcGRhdGUoKTsKIH0gZWxzaWYgKGlzQ2hyb21pdW0oKSkgewotICAgIHN5c3RlbSgi cGVybCIsICJXZWJLaXRUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0iKSA9PSAw IG9yIGRpZTsKKyAgICBzeXN0ZW0oInBlcmwiLCAiV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUt d2Via2l0LWNocm9taXVtIikgPT0gMCBvciBkaWUgJCE7CiB9IGVsc2lmIChpc0FwcGxlV2luV2Vi S2l0KCkpIHsKICAgICBzeXN0ZW0oInBlcmwiLCAiV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUt d2Via2l0LWF1eGlsaWFyeS1saWJzIikgPT0gMCBvciBkaWU7CiB9CmRpZmYgLS1naXQgYS9XZWJL aXRUb29scy9TY3JpcHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0gYi9XZWJLaXRUb29scy9TY3Jp cHRzL3VwZGF0ZS13ZWJraXQtY2hyb21pdW0KaW5kZXggY2ZkNDEzZi4uYTBjYzE5YSAxMDA2NDQK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy91cGRhdGUtd2Via2l0LWNocm9taXVtCisrKyBiL1dl YktpdFRvb2xzL1NjcmlwdHMvdXBkYXRlLXdlYmtpdC1jaHJvbWl1bQpAQCAtMzcsMTggKzM3LDE1 IEBAIGlmIChub3QgYGdjbGllbnQgLS12ZXJzaW9uYCkgewogICAgIGRpZTsKIH0KIAotIyBJZiAu Z2NsaWVudCBjb25maWd1cmF0aW9uIGZpbGUgZG9lc24ndCBleGlzdCwgY3JlYXRlIGl0LgogY2hk aXIoIldlYktpdC9jaHJvbWl1bSIpIG9yIGRpZSAkITsKIGlmICghIC1lICIuZ2NsaWVudCIpIHsK KyAgICAjIElmIC5nY2xpZW50IGNvbmZpZ3VyYXRpb24gZmlsZSBkb2Vzbid0IGV4aXN0LCBjcmVh dGUgaXQuCiAgICAgcHJpbnQgIkNvbmZpZ3VyaW5nIGdjbGllbnQuLi5cbiI7Ci0gICAgbXkgJHJl c3VsdCA9IGV4ZWMoImdjbGllbnQiLCAKLSAgICAgICAgICAgICAgICAgICAgICAgICJjb25maWci LCAKLSAgICAgICAgICAgICAgICAgICAgICAgICItLXNwZWM9c29sdXRpb25zPVt7J25hbWUnOicu LycsJ3VybCc6Tm9uZX1dIik7Ci0gICAgaWYgKCEkcmVzdWx0KSB7Ci0gICAgICAgIGRpZSAiRXJy b3Igd2hpbGUgY29uZmlndXJpbmcgZ2NsaWVudCBmb3IgY2hyb21pdW0gcG9ydFxuIjsKLSAgICB9 CisgICAgc3lzdGVtKCJnY2xpZW50IiwgCisgICAgICAgICAgICJjb25maWciLCAKKyAgICAgICAg ICAgIi0tc3BlYz1zb2x1dGlvbnM9W3snbmFtZSc6Jy4vJywndXJsJzpOb25lfV0iKSA9PSAwIG9y IGRpZSAkITsKIH0KIAogIyBFeGVjdXRlIGdjbGllbnQgc3luYy4KIHByaW50ICJVcGRhdGluZyBj aHJvbWl1bSBwb3J0IGRlcGVuZGVuY2llcyB1c2luZyBnY2xpZW50Li4uXG4iOwotZXhlYygiZ2Ns aWVudCIsICJzeW5jIikgPT0gMCBvciBkaWU7CitzeXN0ZW0oImdjbGllbnQiLCAic3luYyIpID09 IDAgb3IgZGllICQhOwo=