29897 2009-09-29 14:26:49 -0700 REGRESSION(r47820-r47822): Profiles aren't added to the inspector unless the inspector is already open when the profile completes 2009-09-29 15:10:22 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver pfeldman mnaganov pfeldman timothy oldest_to_newest 151055 0 oliver 2009-09-29 14:26:49 -0700 When using the entry in the develop menu to start a profile, the profile is not inserted into the profile view unless the inspector has already been opened. To reproduce: 1. Go to a site with js 2. Develop | Start profiling JavaScript 3. wait a bit 4. Develop | Stop profiling JavaScript Result: The inspector opens to the profiler pane, but doesn't display the profile 151059 1 40326 pfeldman 2009-09-29 14:51:45 -0700 Created attachment 40326 patch Regression introduced in r47821. Thanks for the report. 151060 2 40326 oliver 2009-09-29 14:55:15 -0700 Comment on attachment 40326 patch how does this interact with alloc profiles? eg. if the first profile was an alloc profile would it display? 151062 3 pfeldman 2009-09-29 14:59:42 -0700 (In reply to comment #2) > (From update of attachment 40326 [details]) > how does this interact with alloc profiles? eg. if the first profile was an > alloc profile would it display? This obviously needs to be resolved when we add different profile flavors (heap profiles are behind the flag now). Adding a FIXME note there and landing. 151067 4 pfeldman 2009-09-29 15:10:22 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/ProfilesPanel.js Committed r48907 40326 2009-09-29 14:51:45 -0700 2009-09-29 14:55:15 -0700 patch profiles text/plain 1668 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NmUwOWE0NS4uOTRmY2E5MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxOCBAQAogMjAwOS0wOS0yOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yIFJFR1JFU1NJT04ocjQ3ODIwLXI0Nzgy Mik6IFByb2ZpbGVzIGFyZW4ndAorICAgICAgICBhZGRlZCB0byB0aGUgaW5zcGVjdG9yIHVubGVz cyB0aGUgaW5zcGVjdG9yIGlzIGFscmVhZHkgb3BlbgorICAgICAgICB3aGVuIHRoZSBwcm9maWxl IGNvbXBsZXRlcy4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9Mjk4OTcKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5l bC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnByb3RvdHlwZS5fcG9w dWxhdGVQcm9maWxlcyk6CisKKzIwMDktMDktMjkgIFBhdmVsIEZlbGRtYW4gIDxwZmVsZG1hbkBj aHJvbWl1bS5vcmc+CisKICAgICAgICAgUmV2aWV3ZWQgYnkgVGltb3RoeSBIYXRjaGVyLgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IEludHJvZHVjZSBpbnNwZWN0ZWQgb2JqZWN0IGdyb3VwcyBm b3IgY29uc29sZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2Zp bGVzUGFuZWwuanMgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5q cwppbmRleCBjMDEwMDMzLi5iY2FjZjdmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9m cm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1l bmQvUHJvZmlsZXNQYW5lbC5qcwpAQCAtMzk1LDcgKzM5NSw4IEBAIFdlYkluc3BlY3Rvci5Qcm9m aWxlc1BhbmVsLnByb3RvdHlwZSA9IHsKIAogICAgIF9wb3B1bGF0ZVByb2ZpbGVzOiBmdW5jdGlv bigpCiAgICAgewotICAgICAgICBpZiAodGhpcy5zaWRlYmFyVHJlZS5jaGlsZHJlbi5sZW5ndGgp CisgICAgICAgIHZhciBjcHVQcm9maWxlcyA9IHRoaXMuc2lkZWJhclRyZWUuY2hpbGRyZW5bMF07 CisgICAgICAgIGlmIChjcHVQcm9maWxlcy5jaGlsZHJlbi5sZW5ndGgpCiAgICAgICAgICAgICBy ZXR1cm47CiAKICAgICAgICAgdmFyIHByb2ZpbGVzID0gSW5zcGVjdG9yQ29udHJvbGxlci5wcm9m aWxlcygpOwpAQCAtNDA1LDggKzQwNiw4IEBAIFdlYkluc3BlY3Rvci5Qcm9maWxlc1BhbmVsLnBy b3RvdHlwZSA9IHsKICAgICAgICAgICAgIHRoaXMuYWRkUHJvZmlsZShwcm9maWxlKTsKICAgICAg ICAgfQogCi0gICAgICAgIGlmICh0aGlzLnNpZGViYXJUcmVlLmNoaWxkcmVuWzBdKQotICAgICAg ICAgICAgdGhpcy5zaWRlYmFyVHJlZS5jaGlsZHJlblswXS5zZWxlY3QoKTsKKyAgICAgICAgaWYg KGNwdVByb2ZpbGVzLmNoaWxkcmVuWzBdKQorICAgICAgICAgICAgY3B1UHJvZmlsZXMuY2hpbGRy ZW5bMF0uc2VsZWN0KCk7CiAKICAgICAgICAgZGVsZXRlIHRoaXMuX3Nob3VsZFBvcHVsYXRlUHJv ZmlsZXM7CiAgICAgfSwK