29894 2009-09-29 13:36:45 -0700 [CHROMIUM] Fix Chromium build following r48884 2009-09-30 08:15:25 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco dglazkov oldest_to_newest 151025 0 senorblanco 2009-09-29 13:36:45 -0700 Need to update the V8 side after r48884, ap@apple.com's change for JS event listeners. 151033 1 40322 senorblanco 2009-09-29 13:54:02 -0700 Created attachment 40322 Fix for Chromium build break. 151036 2 dglazkov 2009-09-29 13:59:49 -0700 This is almost there -- need the same changes for V8WorkerContextEventListener and V8WorkerContextObjectEventListener. 151044 3 40322 eric 2009-09-29 14:10:07 -0700 Comment on attachment 40322 Fix for Chromium build break. These are unrelated changes, they should be separate commits. You can commit your addition to committers.py w/o review assuming you actually have commit privs by now (which I would expect you do). The build fix also can be committed w/o review, assuming it's just a build fix. Review is always nicer, but not required for build fixes. 151048 4 dglazkov 2009-09-29 14:12:48 -0700 I asked to upload patch, so that I could take a look. 151249 5 senorblanco 2009-09-30 08:15:25 -0700 This was committed as r48904 and can be closed. 40322 2009-09-29 13:54:02 -0700 2009-09-29 14:10:07 -0700 Fix for Chromium build break. webkit_48884_webkit_fix.patch text/plain 3139 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0ODg5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMDktMjkgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQnVpbGQgZml4IGZvciBDaHJvbWl1bSwgZm9sbG93aW5nIHI0ODg4NC4KKworICAgICAg ICBbaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5ODk0XQorCisgICAg ICAgICogYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXI6OmhhbmRsZUV2ZW50KToKKyAgICAgICAg KiBiaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5lci5oOgorCiAyMDA5LTA5LTI5ICBE aW1pdHJpIEdsYXprb3YgIDxkZ2xhemtvdkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgTm8gcmV2 aWV3LCByb2xsaW5nIG91dCByNDg4OTQsIGJlY2F1c2UgcmV2aWV3IGRpc2N1c3Npb24gd2FzIG5v dCBjb21wbGV0ZS4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlz dGVuZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2 ZW50TGlzdGVuZXIuY3BwCShyZXZpc2lvbiA0ODg5NikKKysrIFdlYkNvcmUvYmluZGluZ3Mvdjgv VjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjQsNyArMTI0 LDcgQEAgdm9pZCBWOEFic3RyYWN0RXZlbnRMaXN0ZW5lcjo6aW52b2tlRXZlbgogICAgICAgICBl dmVudC0+cHJldmVudERlZmF1bHQoKTsKIH0KIAotdm9pZCBWOEFic3RyYWN0RXZlbnRMaXN0ZW5l cjo6aGFuZGxlRXZlbnQoRXZlbnQqIGV2ZW50KQordm9pZCBWOEFic3RyYWN0RXZlbnRMaXN0ZW5l cjo6aGFuZGxlRXZlbnQoU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogc2NyaXB0RXhlY3V0aW9uQ29u dGV4dCwgRXZlbnQqIGV2ZW50KQogewogICAgIC8vIEV2ZW50TGlzdGVuZXIgY291bGQgYmUgZGlz Y29ubmVjdGVkIGZyb20gdGhlIGZyYW1lLgogICAgIGlmIChkaXNjb25uZWN0ZWQoKSkKSW5kZXg6 IFdlYkNvcmUvYmluZGluZ3MvdjgvVjhBYnN0cmFjdEV2ZW50TGlzdGVuZXIuaAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4QWJzdHJhY3RFdmVudExpc3RlbmVyLmgJKHJldmlz aW9uIDQ4ODk2KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9WOEFic3RyYWN0RXZlbnRMaXN0ZW5l ci5oCSh3b3JraW5nIGNvcHkpCkBAIC01OCw3ICs1OCw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsK ICAgICAgICAgLy8gUmV0dXJucyB0aGUgb3duZXIgZnJhbWUgb2YgdGhlIGxpc3RlbmVyLgogICAg ICAgICBGcmFtZSogZnJhbWUoKSB7IHJldHVybiBtX2ZyYW1lOyB9CiAKLSAgICAgICAgdmlydHVh bCB2b2lkIGhhbmRsZUV2ZW50KEV2ZW50Kik7CisgICAgICAgIHZpcnR1YWwgdm9pZCBoYW5kbGVF dmVudChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgRXZlbnQqKTsKICAgICAgICAgdm9pZCBpbnZv a2VFdmVudEhhbmRsZXIodjg6OkhhbmRsZTx2ODo6Q29udGV4dD4sIEV2ZW50Kiwgdjg6OkhhbmRs ZTx2ODo6VmFsdWU+IGpzRXZlbnQpOwogCiAgICAgICAgIC8vIFJldHVybnMgdGhlIGxpc3RlbmVy IG9iamVjdCwgZWl0aGVyIGEgZnVuY3Rpb24gb3IgYW4gb2JqZWN0LgpJbmRleDogV2ViS2l0VG9v bHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL0NoYW5nZUxvZwkocmV2aXNp b24gNDg4OTcpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEs MyArMSwxMSBAQAorMjAwOS0wOS0yOSAgU3RlcGhlbiBXaGl0ZSAgPHNlbm9yYmxhbmNvQGNocm9t aXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBOZWVkIGEgc2hvcnQgZGVzY3JpcHRpb24gYW5kIGJ1ZyBVUkwgKE9PUFMhKQorCisgICAgICAg ICogU2NyaXB0cy9tb2R1bGVzL2NvbW1pdHRlcnMucHk6CisKIDIwMDktMDktMjkgIERhbiBCZXJu c3RlaW4gIDxtaXR6QGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVu LgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1pdHRlcnMucHkKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1pdHRlcnMucHkJKHJldmlz aW9uIDQ4ODk2KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1pdHRlcnMucHkJ KHdvcmtpbmcgY29weSkKQEAgLTY0LDYgKzY0LDcgQEAgY29tbWl0dGVyc191bmFibGVfdG9fcmV2 aWV3ID0gWwogICAgIENvbW1pdHRlcigiUGllcnJlIGQnSGVyYmVtb250IiwgInBkaGVyYmVtb250 QGZyZWUuZnIiKSwKICAgICBDb21taXR0ZXIoIlJ5b3N1a2UgTml3YSIsICJybml3YUB3ZWJraXQu b3JnIiksCiAgICAgQ29tbWl0dGVyKCJTaGluaWNoaXJvIEhhbWFqaSIsICJoYW1hamlAY2hyb21p dW0ub3JnIiksCisgICAgQ29tbWl0dGVyKCJTdGVwaGVuIFdoaXRlIiwgInNlbm9yYmxhbmNvQGNo cm9taXVtLm9yZyIpLAogICAgIENvbW1pdHRlcigiVG9ueSBDaGFuZyIsICJ0b255QGNocm9taXVt Lm9yZyIpLAogICAgIENvbW1pdHRlcigiWWFlbCBBaGFyb24iLCAieWFlbC5haGFyb25Abm9raWEu Y29tIiksCiAgICAgQ29tbWl0dGVyKCJZb25nIExpIiwgInlvbmcubGlAdG9yY2htb2JpbGUuY29t IiksCg==