29847 2009-09-29 05:30:01 -0700 [Qt] Add support for automatically creating new windows in QWebView 2010-08-27 16:15:39 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) Other All RESOLVED FIXED Qt P2 Enhancement --- 35784 1 vestbo tonikitoo ademar hausmann kenneth kent.hansen tonikitoo oldest_to_newest 150864 0 vestbo 2009-09-29 05:30:01 -0700 This bug report originated from issue QTBUG-2162 http://bugreports.qt.nokia.com/browse/QTBUG-2162 --- Description --- QWebView QWebPage - mainframe()-evaluateJavaScript("window.open('url')") doesn't open new browser window. When calling evaluateJavaScript("window.open('url')) on a mainFrame() or just load a webpage containing <script>window.open('http://www.trolltech.com/');</script> should open a new window containing the webpage. This is due to QWebView::createWindow() not creating a new window by default. We should consider adding a property to QWebView that enables the default implementation to create new QWebView instances, something along the lines of a 'bool autoCreateWindows' property. - How to reproduce: 1. Build and compile the code. 2. Start the application - Expected result: Two windows should appear. One containing the Trolltech webpage and one saying foo... ect. - Actual result: Only the last page containing: foo...before calling open foo...after calling open. A new window should have popped up showing the Trolltech webpage. Test case main.cpp for above ============================= class MainWidget : public QWidget { Q_OBJECT public: MainWidget(); private: QWebPage *page; QWebView *view; }; MainWidget::MainWidget(){ view = new QWebView(this); page = new QWebPage(this); QUrl url("test.html"); page->settings()->setAttribute(QWebSettings::JavascriptEnabled,true); // Make sure JavaScript is enabled page->mainFrame()->load(url); // Load the test case view->setPage(page); QVariant variant = page->mainFrame()->evaluateJavaScript("window.open('http://www.trolltech.com/');"); qDebug() << variant.toString(); // This doesn't return anything either. QVBoxLayout *layout = new QVBoxLayout; layout->addWidget(view); setLayout(layout); } int main(int argc, char *argv[]){ QApplication app(argc, argv); MainWidget mainWid; mainWid.show(); return app.exec(); } --- Comments --- Does this still occur when setting the property QWebSettings::JavascriptCanOpenWindows ? 165736 1 hausmann 2009-11-22 10:08:49 -0800 I disagree that by default we should create new windows. I think this is part of the application integrate that needs to be taken care of by the application developer. Allowing new top-level windows coming up by default (that can be controlled via JavaScript) sounds like the wrong default to me from a security POV. 165904 2 tonikitoo 2009-11-23 13:01:32 -0800 > --- Comments --- > > Does this still occur when setting the property > QWebSettings::JavascriptCanOpenWindows ? I just tested the sample application pasted here, and setting the property has no effect (and it ready shouldn't). so one who wants to make JavaScript to open new windows by default should set the 'JavascriptCanOpenWindows' to 'true' AND reimplement QWebPage's createWindow method ... it should get mentioned in DOCS in a clear way (if it is not yet there). (In reply to comment #1) > I disagree that by default we should create new windows. I think this is part > of the application integrate that needs to be taken care of by the application > developer. Allowing new top-level windows coming up by default (that can be > controlled via JavaScript) sounds like the wrong default to me from a security > POV. INVALID or WONTFIX then, simon ? 166074 3 hausmann 2009-11-24 07:46:10 -0800 (In reply to comment #2) > > --- Comments --- > > > > Does this still occur when setting the property > > QWebSettings::JavascriptCanOpenWindows ? > > I just tested the sample application pasted here, and setting the property has > no effect (and it ready shouldn't). > > so one who wants to make JavaScript to open new windows by default should set > the 'JavascriptCanOpenWindows' to 'true' AND reimplement QWebPage's > createWindow method ... > > it should get mentioned in DOCS in a clear way (if it is not yet there). > > (In reply to comment #1) > > I disagree that by default we should create new windows. I think this is part > > of the application integrate that needs to be taken care of by the application > > developer. Allowing new top-level windows coming up by default (that can be > > controlled via JavaScript) sounds like the wrong default to me from a security > > POV. > > INVALID or WONTFIX then, simon ? I'd say WONTFIX, but ideally RESOLVED/FIXED with a patch to the documentation ;-) 199064 4 kent.hansen 2010-03-12 08:22:51 -0800 (In reply to comment #1) > I disagree that by default we should create new windows. I think this is part > of the application integrate that needs to be taken care of by the application > developer. Allowing new top-level windows coming up by default (that can be > controlled via JavaScript) sounds like the wrong default to me from a security > POV. Creating new windows by default is not what the description suggests. It suggests adding a property that the default implementation (QWebView) can check. This property (e.g. autoCreateWindows) would be "false" by default, preserving the existing behavior. But regardless of whether this is implemented, the doc for QWebView::createWindow() should refer to QWebSettings::JavascriptCanOpenWindows (indeed, the testcase didn't enable this attribute, so createWindow() wasn't called regardless), and say what the default createWindow() implementation does (e.g. "always returns 0" or "depends on the autoCreateWindows property"). I'm in favor of just doing the doc update like Simon suggested. 270316 5 tonikitoo 2010-08-26 22:44:31 -0700 > I'm in favor of just doing the doc update like Simon suggested. Right. I will try something shortly ... 270318 6 65678 tonikitoo 2010-08-26 22:54:14 -0700 Created attachment 65678 patch v1 - fix the documentation If it is ok, it should be cherry-picked into both qtwebkit2.0 and qtwebkit2.1 branches. Kenneth, Simon, Kent, what are your takes on it? 270339 7 65678 hausmann 2010-08-26 23:49:11 -0700 Comment on attachment 65678 patch v1 - fix the documentation I'm okay with that, please make this bug block the release bugs. However there's a typo in this patch: QWebSettings::setJavaScriptCanOpenWindowsAutomatically doesn't exist and should be setAttribute(...) :) 270435 8 65701 tonikitoo 2010-08-27 05:23:47 -0700 Created attachment 65701 (commit r66217, r=hausmann)patch v2 - addressed simon's review 270461 9 65701 hausmann 2010-08-27 06:35:26 -0700 Comment on attachment 65701 (commit r66217, r=hausmann)patch v2 - addressed simon's review WebKit/qt/Api/qwebview.cpp:960 + \sa QWebPage::createWindow(), QWebSettings::setJavaScriptCanOpenWindowsAutomatically() There's one left :) Please fix before landing, otherwise r=me :) 270467 10 65701 tonikitoo 2010-08-27 06:47:01 -0700 Comment on attachment 65701 (commit r66217, r=hausmann)patch v2 - addressed simon's review Clearing flags on attachment 65701 Committed r66217: <http://trac.webkit.org/changeset/66217> 270468 11 tonikitoo 2010-08-27 06:47:37 -0700 (In reply to comment #9) > (From update of attachment 65701 [details]) > WebKit/qt/Api/qwebview.cpp:960 > + \sa QWebPage::createWindow(), QWebSettings::setJavaScriptCanOpenWindowsAutomatically() > There's one left :) > > Please fix before landing, otherwise r=me :) Done before landing... Thanks. 270473 12 ademar 2010-08-27 07:01:52 -0700 Revision r66217 cherry-picked into qtwebkit-2.1 with commit de555d5dc3ef9ad493ba5f8b874efacfc440b1dd 270475 13 kenneth 2010-08-27 07:02:46 -0700 "of QWebSettings to true in order to get it called." This sounds a bit bad. "in order for it to get called", would be better 270480 14 tonikitoo 2010-08-27 07:16:41 -0700 (In reply to comment #13) > "of QWebSettings to true in order to get it called." > > This sounds a bit bad. > > "in order for it to get called", would be better As per kenneth suggestion, changed in r66221. Committed r66221: <http://trac.webkit.org/changeset/66217> 270496 15 ademar 2010-08-27 07:44:52 -0700 Revision r66221 cherry-picked into qtwebkit-2.1 with commit c61bb8fd4eec94c5ffa7107bb48f0f360ae3c2d3 65678 2010-08-26 22:54:14 -0700 2010-08-27 05:23:47 -0700 patch v1 - fix the documentation 0001-2010-08-26-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 3680 tonikitoo RnJvbSBiMmViZTQ5YTAxMjM3ZjQ5NjVlZDgzOWQ2MzJjZmU3Mzk4YzFkNDI0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogRnJpLCAyNyBBdWcgMjAxMCAwMTo1MTo0OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDgtMjYgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gQWRkIHN1cHBvcnQgZm9y IGF1dG9tYXRpY2FsbHkgY3JlYXRpbmcgbmV3IHdpbmRvd3MgaW4gUVdlYlZpZXcKICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk4NDcKCiAgICAgICAgSW1w cm92ZWQgdGhlIGRvY3VtZW50YXRpb24gb2YgY3JlYXRlV2luZG93IG1ldGhvZHMgb2YgYm90aCBR V2ViVmlldyBhbmQKICAgICAgICBRV2ViUGFnZSBieSBtZW50aW9uaW5nIHRoYXQgZm9yIGFueSBv ZiB0aGVtIGJlIGNhbGxlZCwgUVdlYlNldHRpbmdzJwogICAgICAgIHNldEphdmFTY3JpcHRDYW5P cGVuV2luZG93c0F1dG9tYXRpY2FsbHkgbXVzdCBiZSBjYWxsZWQgd2l0aCB0cnVlIGJlaW5nCiAg ICAgICAgcGFzc2VkIGFzIHBhcmFtZXRlci4KCiAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgog ICAgICAgICogQXBpL3F3ZWJ2aWV3LmNwcDoKCiogQXBpL3F3ZWJwYWdlLmNwcDoKKiBBcGkvcXdl YnZpZXcuY3BwOgotLS0KIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIHwgICAgNiArKysrKy0K IFdlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwIHwgICAgNiArKysrKy0KIFdlYktpdC9xdC9DaGFu Z2VMb2cgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMjUg aW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBp L3F3ZWJwYWdlLmNwcCBiL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCmluZGV4IDg0NDM4NjMu LjIzZTNkYTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCisrKyBiL1dl YktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwCkBAIC0yMTYyLDcgKzIxNjIsMTEgQEAgdm9pZCBRV2Vi UGFnZTo6c2V0VXNlclBlcm1pc3Npb24oUVdlYkZyYW1lKiBmcmFtZSwgUGVybWlzc2lvbkRvbWFp biBkb21haW4sIFBlcm0KIAogICAgIElmIFxhIHR5cGUgaXMgV2ViTW9kYWxEaWFsb2csIHRoZSBh cHBsaWNhdGlvbiBtdXN0IGNhbGwgc2V0V2luZG93TW9kYWxpdHkoUXQ6OkFwcGxpY2F0aW9uTW9k YWwpIG9uIHRoZSBuZXcgd2luZG93LgogCi0gICAgXHNhIGFjY2VwdE5hdmlnYXRpb25SZXF1ZXN0 KCkKKyAgICBcbm90ZSBJbiB0aGUgY2FzZXMgd2hlbiB3aW5kb3cgY3JlYXRpb24gYXJlIGJlaW5n IHRyaWdnZXJlZCBieSBKYXZhU2NyaXB0LCBhcGFydCBmcm9tCisgICAgcmVpbXBsZW1lbnRpbmcg dGhpcyBtZXRob2QgKG9yIHRoZSB0aGUgY3JlYXRlV2luZG93KCkgbWV0aG9kIG9mIFFXZWJWaWV3 KSBhcHBsaWNhdGlvbiBtdXN0CisgICAgYWxzbyBjYWxsIHNldEphdmFTY3JpcHRDYW5PcGVuV2lu ZG93c0F1dG9tYXRpY2FsbHkodHJ1ZSkgbWV0aG9kIG9mIFFXZWJTZXR0aW5ncy4KKworICAgIFxz YSBhY2NlcHROYXZpZ2F0aW9uUmVxdWVzdCgpLCBRV2ViU2V0dGluZ3M6OnNldEphdmFTY3JpcHRD YW5PcGVuV2luZG93c0F1dG9tYXRpY2FsbHkoKSwgUVdlYlZpZXc6OmNyZWF0ZVdpbmRvdygpCiAq LwogUVdlYlBhZ2UgKlFXZWJQYWdlOjpjcmVhdGVXaW5kb3coV2ViV2luZG93VHlwZSB0eXBlKQog ewpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2Vidmlldy5jcHAgYi9XZWJLaXQvcXQvQXBp L3F3ZWJ2aWV3LmNwcAppbmRleCA1ZTcyNjVmLi5hOGFmMWExIDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvQXBpL3F3ZWJ2aWV3LmNwcAorKysgYi9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmNwcApAQCAt OTQ4LDEwICs5NDgsMTQgQEAgdm9pZCBRV2ViVmlldzo6cGFpbnRFdmVudChRUGFpbnRFdmVudCAq ZXYpCiAgICAgZWFjaCB0aW1lIHRoZSBwYWdlIHdhbnRzIHRvIGNyZWF0ZSBhIG5ldyB3aW5kb3cg b2YgdGhlIGdpdmVuIFxhIHR5cGUuIFRoaXMgbWlnaHQKICAgICBiZSB0aGUgcmVzdWx0LCBmb3Ig ZXhhbXBsZSwgb2YgYSBKYXZhU2NyaXB0IHJlcXVlc3QgdG8gb3BlbiBhIGRvY3VtZW50IGluIGEg bmV3IHdpbmRvdy4KIAorICAgIFxub3RlIEluIHRoZSBjYXNlcyB3aGVuIHdpbmRvdyBjcmVhdGlv biBhcmUgYmVpbmcgdHJpZ2dlcmVkIGJ5IEphdmFTY3JpcHQsIGFwYXJ0IGZyb20KKyAgICByZWlt cGxlbWVudGluZyB0aGlzIG1ldGhvZCwgYXBwbGljYXRpb24gbXVzdCBhbHNvIGNhbGwgc2V0SmF2 YVNjcmlwdENhbk9wZW5XaW5kb3dzQXV0b21hdGljYWxseSgpCisgICAgbWV0aG9kIG9mIFFXZWJT ZXR0aW5ncyBwYXNzaW5nIHRydWUgYXMgcGFyYW1ldGVyLgorCiAgICAgXG5vdGUgSWYgdGhlIGNy ZWF0ZVdpbmRvdygpIG1ldGhvZCBvZiB0aGUgYXNzb2NpYXRlZCBwYWdlIGlzIHJlaW1wbGVtZW50 ZWQsIHRoaXMKICAgICBtZXRob2QgaXMgbm90IGNhbGxlZCwgdW5sZXNzIGV4cGxpY2l0bHkgZG9u ZSBzbyBpbiB0aGUgcmVpbXBsZW1lbnRhdGlvbi4KIAotICAgIFxzYSBRV2ViUGFnZTo6Y3JlYXRl V2luZG93KCkKKyAgICBcc2EgUVdlYlBhZ2U6OmNyZWF0ZVdpbmRvdygpLCBRV2ViU2V0dGluZ3M6 OnNldEphdmFTY3JpcHRDYW5PcGVuV2luZG93c0F1dG9tYXRpY2FsbHkoKQogKi8KIFFXZWJWaWV3 ICpRV2ViVmlldzo6Y3JlYXRlV2luZG93KFFXZWJQYWdlOjpXZWJXaW5kb3dUeXBlIHR5cGUpCiB7 CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpp bmRleCA4NzFkN2FiLi5jZmY2NmIwIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisr KyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wOC0yNiAgQW50 b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gQWRkIHN1cHBvcnQgZm9yIGF1dG9tYXRp Y2FsbHkgY3JlYXRpbmcgbmV3IHdpbmRvd3MgaW4gUVdlYlZpZXcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5ODQ3CisKKyAgICAgICAgSW1wcm92ZWQg dGhlIGRvY3VtZW50YXRpb24gb2YgY3JlYXRlV2luZG93IG1ldGhvZHMgb2YgYm90aCBRV2ViVmll dyBhbmQKKyAgICAgICAgUVdlYlBhZ2UgYnkgbWVudGlvbmluZyB0aGF0IGZvciBhbnkgb2YgdGhl bSBiZSBjYWxsZWQsIFFXZWJTZXR0aW5ncycKKyAgICAgICAgc2V0SmF2YVNjcmlwdENhbk9wZW5X aW5kb3dzQXV0b21hdGljYWxseSBtdXN0IGJlIGNhbGxlZCB3aXRoIHRydWUgYmVpbmcKKyAgICAg ICAgcGFzc2VkIGFzIHBhcmFtZXRlci4KKworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6Cisg ICAgICAgICogQXBpL3F3ZWJ2aWV3LmNwcDoKKwogMjAxMC0wOC0yMCAgQWRlbWFyIGRlIFNvdXph IFJlaXMgSnIgIDxhZGVtYXIucmVpc0BvcGVuYm9zc2Eub3JnPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IEFyaXlhIEhpZGF5YXQuCi0tIAoxLjcuMC40Cgo= 65701 2010-08-27 05:23:47 -0700 2010-08-27 06:47:01 -0700 (commit r66217, r=hausmann)patch v2 - addressed simon's review 0001-2010-08-26-Antonio-Gomes-tonikitoo-webkit.org.patch text/plain 3283 tonikitoo RnJvbSBjZGM5MmJlZjk2NjZlMWFmMWFlOTE0ODJhOTZmNGZjMTdjYjVkN2U3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbnRvbmlvIEdvbWVzIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4K RGF0ZTogRnJpLCAyNyBBdWcgMjAxMCAwMTo1MTo0OCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIw MTAtMDgtMjYgIEFudG9uaW8gR29tZXMgIDx0b25pa2l0b29Ad2Via2l0Lm9yZz4KCiAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCgogICAgICAgIFtRdF0gQWRkIHN1cHBvcnQgZm9y IGF1dG9tYXRpY2FsbHkgY3JlYXRpbmcgbmV3IHdpbmRvd3MgaW4gUVdlYlZpZXcKICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk4NDcKCiAgICAgICAgSW1w cm92ZWQgdGhlIGRvY3VtZW50YXRpb24gb2YgY3JlYXRlV2luZG93IG1ldGhvZHMgb2YgYm90aCBR V2ViVmlldyBhbmQKICAgICAgICBRV2ViUGFnZSBieSBtZW50aW9uaW5nIHRoYXQgZm9yIGFueSBv ZiB0aGVtIGJlIGNhbGxlZCwgUVdlYlNldHRpbmdzJwogICAgICAgIEphdmFTY3JpcHRDYW5PcGVu V2luZG93cyBtdXN0IGJlIHNldCB0byB0cnVlLgoKICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6 CiAgICAgICAgKiBBcGkvcXdlYnZpZXcuY3BwOgotLS0KIFdlYktpdC9xdC9BcGkvcXdlYnBhZ2Uu Y3BwIHwgICAgNiArKysrKy0KIFdlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwIHwgICAgNiArKysr Ky0KIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgIHwgICAxNCArKysrKysrKysrKysrKwogMyBm aWxlcyBjaGFuZ2VkLCAyNCBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5j cHAKaW5kZXggODQ0Mzg2My4uYjY3ZmY5NSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2Vi cGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTIxNjIsNyArMjE2 MiwxMSBAQCB2b2lkIFFXZWJQYWdlOjpzZXRVc2VyUGVybWlzc2lvbihRV2ViRnJhbWUqIGZyYW1l LCBQZXJtaXNzaW9uRG9tYWluIGRvbWFpbiwgUGVybQogCiAgICAgSWYgXGEgdHlwZSBpcyBXZWJN b2RhbERpYWxvZywgdGhlIGFwcGxpY2F0aW9uIG11c3QgY2FsbCBzZXRXaW5kb3dNb2RhbGl0eShR dDo6QXBwbGljYXRpb25Nb2RhbCkgb24gdGhlIG5ldyB3aW5kb3cuCiAKLSAgICBcc2EgYWNjZXB0 TmF2aWdhdGlvblJlcXVlc3QoKQorICAgIFxub3RlIEluIHRoZSBjYXNlcyB3aGVuIHRoZSB3aW5k b3cgY3JlYXRpb24gaXMgYmVpbmcgdHJpZ2dlcmVkIGJ5IEphdmFTY3JpcHQsIGFwYXJ0IGZyb20K KyAgICByZWltcGxlbWVudGluZyB0aGlzIG1ldGhvZCBhcHBsaWNhdGlvbiBtdXN0IGFsc28gc2V0 IHRoZSBKYXZhU2NyaXB0Q2FuT3BlbldpbmRvd3MgYXR0cmlidXRlCisgICAgb2YgUVdlYlNldHRp bmdzIHRvIHRydWUgaW4gb3JkZXIgdG8gZ2V0IGl0IGNhbGxlZC4KKworICAgIFxzYSBhY2NlcHRO YXZpZ2F0aW9uUmVxdWVzdCgpLCBRV2ViVmlldzo6Y3JlYXRlV2luZG93KCkKICovCiBRV2ViUGFn ZSAqUVdlYlBhZ2U6OmNyZWF0ZVdpbmRvdyhXZWJXaW5kb3dUeXBlIHR5cGUpCiB7CmRpZmYgLS1n aXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJ2aWV3LmNwcCBiL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcu Y3BwCmluZGV4IDEwY2Y2MGMuLjg0MjczYjAgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9BcGkvcXdl YnZpZXcuY3BwCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYnZpZXcuY3BwCkBAIC05NTMsNyArOTUz LDExIEBAIHZvaWQgUVdlYlZpZXc6OnBhaW50RXZlbnQoUVBhaW50RXZlbnQgKmV2KQogICAgIFxu b3RlIElmIHRoZSBjcmVhdGVXaW5kb3coKSBtZXRob2Qgb2YgdGhlIGFzc29jaWF0ZWQgcGFnZSBp cyByZWltcGxlbWVudGVkLCB0aGlzCiAgICAgbWV0aG9kIGlzIG5vdCBjYWxsZWQsIHVubGVzcyBl eHBsaWNpdGx5IGRvbmUgc28gaW4gdGhlIHJlaW1wbGVtZW50YXRpb24uCiAKLSAgICBcc2EgUVdl YlBhZ2U6OmNyZWF0ZVdpbmRvdygpCisgICAgXG5vdGUgSW4gdGhlIGNhc2VzIHdoZW4gdGhlIHdp bmRvdyBjcmVhdGlvbiBpcyBiZWluZyB0cmlnZ2VyZWQgYnkgSmF2YVNjcmlwdCwgYXBhcnQgZnJv bQorICAgIHJlaW1wbGVtZW50aW5nIHRoaXMgbWV0aG9kIGFwcGxpY2F0aW9uIG11c3QgYWxzbyBz ZXQgdGhlIEphdmFTY3JpcHRDYW5PcGVuV2luZG93cyBhdHRyaWJ1dGUKKyAgICBvZiBRV2ViU2V0 dGluZ3MgdG8gdHJ1ZSBpbiBvcmRlciB0byBnZXQgaXQgY2FsbGVkLi4KKworICAgIFxzYSBRV2Vi UGFnZTo6Y3JlYXRlV2luZG93KCksIFFXZWJTZXR0aW5nczo6c2V0SmF2YVNjcmlwdENhbk9wZW5X aW5kb3dzQXV0b21hdGljYWxseSgpCiAqLwogUVdlYlZpZXcgKlFXZWJWaWV3OjpjcmVhdGVXaW5k b3coUVdlYlBhZ2U6OldlYldpbmRvd1R5cGUgdHlwZSkKIHsKZGlmZiAtLWdpdCBhL1dlYktpdC9x dC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDMwOGNlM2YuLmExMWZhMDQg MTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA4LTI2ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9v QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgW1F0XSBBZGQgc3VwcG9ydCBmb3IgYXV0b21hdGljYWxseSBjcmVhdGluZyBuZXcgd2lu ZG93cyBpbiBRV2ViVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9Mjk4NDcKKworICAgICAgICBJbXByb3ZlZCB0aGUgZG9jdW1lbnRhdGlvbiBvZiBj cmVhdGVXaW5kb3cgbWV0aG9kcyBvZiBib3RoIFFXZWJWaWV3IGFuZAorICAgICAgICBRV2ViUGFn ZSBieSBtZW50aW9uaW5nIHRoYXQgZm9yIGFueSBvZiB0aGVtIGJlIGNhbGxlZCwgUVdlYlNldHRp bmdzJworICAgICAgICBKYXZhU2NyaXB0Q2FuT3BlbldpbmRvd3MgYXR0cmlidXRlIG11c3QgYmUg c2V0IHRvIHRydWUuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAqIEFw aS9xd2Vidmlldy5jcHA6CisKIDIwMTAtMDgtMjYgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZC4gUmV2ZXJ0IHI2NjEwMyBzaW5jZSBR dCB0ZXN0cyBhcmUgZmFpbGluZy4KLS0gCjEuNy4wLjQKCg==