29844 2009-09-29 04:07:40 -0700 [Qt] QWebPage's autotest dependency 2009-09-29 07:07:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 29867 0 jedrzej.nowacki webkit-unassigned hausmann laszlo.gombos oldest_to_newest 150854 0 jedrzej.nowacki 2009-09-29 04:07:40 -0700 There is dependency between QWebPage autotest ::databese() and ::testEnablePersistentStorage(). It looks like database connection stay opened after test. ~/dev/webkit/WebKitBuild/Debug/WebKit/qt/tests/qwebpage$ ./tst_qwebpage database ********* Start testing of tst_QWebPage ********* Config: Using QTest library 4.6.0, Qt 4.6.0 PASS : tst_QWebPage::initTestCase() PASS : tst_QWebPage::database() PASS : tst_QWebPage::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped ********* Finished testing of tst_QWebPage ********* LEAK: 224 Structure LEAK: 5 WebCoreNode ~/dev/webkit/WebKitBuild/Debug/WebKit/qt/tests/qwebpage$ ./tst_qwebpage testEnablePersistentStorage ********* Start testing of tst_QWebPage ********* Config: Using QTest library 4.6.0, Qt 4.6.0 PASS : tst_QWebPage::initTestCase() PASS : tst_QWebPage::testEnablePersistentStorage() PASS : tst_QWebPage::cleanupTestCase() Totals: 3 passed, 0 failed, 0 skipped ********* Finished testing of tst_QWebPage ********* ~/dev/webkit/WebKitBuild/Debug/WebKit/qt/tests/qwebpage$ ./tst_qwebpage database testEnablePersistentStorage ********* Start testing of tst_QWebPage ********* Config: Using QTest library 4.6.0, Qt 4.6.0 PASS : tst_QWebPage::initTestCase() PASS : tst_QWebPage::database() ASSERTION FAILED: !m_database.isOpen() (../../../WebCore/storage/DatabaseTracker.cpp:78 void WebCore::DatabaseTracker::setDatabaseDirectoryPath(const WebCore::String&)) QFATAL : tst_QWebPage::testEnablePersistentStorage() Received signal 11 FAIL! : tst_QWebPage::testEnablePersistentStorage() Received a fatal error. Loc: [Unknown file(0)] Totals: 2 passed, 1 failed, 0 skipped ********* Finished testing of tst_QWebPage ********* Aborted 150857 1 vestbo 2009-09-29 05:12:11 -0700 Please follow the QtWebKit bug reporting guidlines: http://trac.webkit.org/wiki/QtWebKitContrib#ReportingBugs In particular: - All bugs related to the Qt port of WebKit should have the keyword 'Qt' - The 'WebKit Qt' component should only be used for the QtWebKit API layer 150859 2 40296 jedrzej.nowacki 2009-09-29 05:17:04 -0700 Created attachment 40296 Fix for autotest In patch I assume that some databases might be shared between different instances of QWebPage. If it's not the case, ~QWebPage should implicitly remove all opened databases. 150898 3 hausmann 2009-09-29 07:07:58 -0700 Committed r48872: <http://trac.webkit.org/changeset/48872> 40296 2009-09-29 05:17:04 -0700 2009-09-29 07:04:54 -0700 Fix for autotest database.diff text/plain 2108 jedrzej.nowacki ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmlu ZGV4IGZmNzY3MTUuLjRhZTA2ZWQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysr IGIvV2ViS2l0L3F0L0NoYW5nZUxvZwpAQCAtMiw2ICsyLDIwIEBACiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCiAKKyAgICAgICAgUVdlYlBhZ2UgZGVwZW5kZW5jeSBhdXRv dGVzdCBmaXguCisgICAgICAgIAorICAgICAgICBGaXggZm9yIGRhdGFiYXNlKCkgYXV0b3Rlc3Qu IEFsbCBvcGVuZWQgZGF0YWJhc2VzIHNob3VsZCBiZSByZW1vdmVkIGF0CisgICAgICAgIGVuZCBv ZiB0ZXN0LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yOTg0NAorCisgICAgICAgICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKyAg ICAgICAgKHRzdF9RV2ViUGFnZTo6ZGF0YWJhc2UpOgorCisyMDA5LTA5LTI5ICBKZWRyemVqIE5v d2Fja2kgIDxqZWRyemVqLm5vd2Fja2lAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFNvbWUgUVdlYkhpc3RvcnkgYW5kIFFXZWJQYWdl IGF1dG90ZXN0IGNyYXNoIGZpeGVzLgogICAgICAgICAKICAgICAgICAgU29tZSBjaGVja2luZyBm b3IgbV9tYWluRnJhbWUgd2VyZSBhZGRlZC4gTWFpbkZyYW1lIHNob3VsZCBiZSBjcmVhdGVkCmRp ZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcCBiL1dl YktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCmluZGV4IGNlM2E4MGYuLjgx M2RlMGUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2Uu Y3BwCisrKyBiL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCkBAIC00 NjQsMTUgKzQ2NCwyMCBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6ZGF0YWJhc2UoKQogICAgIG1fcGFn ZS0+bWFpbkZyYW1lKCktPmV2YWx1YXRlSmF2YVNjcmlwdCgidmFyIGRiMzsgZGIzPW9wZW5EYXRh YmFzZSgndGVzdGRiJywgJzEuMCcsICd0ZXN0IGRhdGFiYXNlIEFQSScsIDUwMDAwKTtkYjMudHJh bnNhY3Rpb24oZnVuY3Rpb24odHgpIHsgdHguZXhlY3V0ZVNxbCgnQ1JFQVRFIFRBQkxFIElGIE5P VCBFWElTVFMgVGVzdCAodGV4dCBURVhUKScsIFtdKTsgfSwgZnVuY3Rpb24odHgsIHJlc3VsdCkg eyB9LCBmdW5jdGlvbih0eCwgZXJyb3IpIHsgfSk7Iik7CiAgICAgUVRlc3Q6OnFXYWl0KDIwMCk7 CiAKKyAgICAvLyBSZW1vdmUgYWxsIGRhdGFiYXNlcy4KICAgICBRV2ViU2VjdXJpdHlPcmlnaW4g b3JpZ2luID0gbV9wYWdlLT5tYWluRnJhbWUoKS0+c2VjdXJpdHlPcmlnaW4oKTsKICAgICBRTGlz dDxRV2ViRGF0YWJhc2U+IGRicyA9IG9yaWdpbi5kYXRhYmFzZXMoKTsKLSAgICBpZiAoZGJzLmNv dW50KCkgPiAwKSB7Ci0gICAgICAgIFFTdHJpbmcgZmlsZU5hbWUgPSBkYnNbMF0uZmlsZU5hbWUo KTsKKyAgICBmb3IgKGludCBpID0gMDsgaSA8IGRicy5jb3VudCgpOyBpKyspIHsKKyAgICAgICAg UVN0cmluZyBmaWxlTmFtZSA9IGRic1tpXS5maWxlTmFtZSgpOwogICAgICAgICBRVkVSSUZZKFFG aWxlOjpleGlzdHMoZmlsZU5hbWUpKTsKLSAgICAgICAgUVdlYkRhdGFiYXNlOjpyZW1vdmVEYXRh YmFzZShkYnNbMF0pOworICAgICAgICBRV2ViRGF0YWJhc2U6OnJlbW92ZURhdGFiYXNlKGRic1tp XSk7CiAgICAgICAgIFFWRVJJRlkoIVFGaWxlOjpleGlzdHMoZmlsZU5hbWUpKTsKICAgICB9Ci0g ICAgUVRlc3Q6OnFXYWl0KDEwMDApOworICAgIFFWRVJJRlkoIW9yaWdpbi5kYXRhYmFzZXMoKS5z aXplKCkpOworICAgIC8vIFJlbW92ZSByZW1vdmVkIHRlc3QgOi0pCisgICAgUVdlYkRhdGFiYXNl OjpyZW1vdmVBbGxEYXRhYmFzZXMoKTsKKyAgICBRVkVSSUZZKCFvcmlnaW4uZGF0YWJhc2VzKCku c2l6ZSgpKTsKKyAgICBRVGVzdDo6cVdhaXQoMTAwMCk7ICAvLyA8LSB3aHkgPyEgaXQgbG9va3Mg YmFkIGJhZCBiYWQuLi4KIH0KIAogY2xhc3MgUGx1Z2luUGFnZSA6IHB1YmxpYyBRV2ViUGFnZQo=