29840 2009-09-29 00:49:07 -0700 4 layout tests failed by r48861 2009-09-29 18:56:39 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 ukai webkit-unassigned eric sam oldest_to_newest 150820 0 ukai 2009-09-29 00:49:07 -0700 4 layout tests failed by r48861. fast/dom/prototype-inheritance-2.html -> failed fast/dom/prototype-inheritance.html -> failed fast/dom/Window/window-properties.html -> failed fast/js/global-constructors.html -> failed 150826 1 40289 ukai 2009-09-29 01:49:10 -0700 Created attachment 40289 Fix 4 layout test failures by r48861 150829 2 40289 eric 2009-09-29 01:53:20 -0700 Comment on attachment 40289 Fix 4 layout test failures by r48861 Looks fine. Go ahead and commit. :) 150830 3 eric 2009-09-29 01:53:41 -0700 The commit-queue can't handle tree fixes yet, so this has to be landed by hand. 150832 4 ukai 2009-09-29 01:58:39 -0700 (In reply to comment #2) > (From update of attachment 40289 [details]) > Looks fine. Go ahead and commit. :) Thanks! Landed as r48863. 150954 5 sam 2009-09-29 10:45:54 -0700 Why is it ok for WebSocket to return undefined. This seems like it will give the impression that we support the feature. 151148 6 ukai 2009-09-29 18:56:39 -0700 (In reply to comment #5) > Why is it ok for WebSocket to return undefined. This seems like it will give > the impression that we support the feature. I believe a web developer checks the feature by checking it is undefined or not. If the feature is supported, it should be object (or function). If there any way to clear property (custom constructor) from DOMWindow at all in runtime, I'll do it. 40289 2009-09-29 01:49:10 -0700 2009-09-29 01:53:18 -0700 Fix 4 layout test failures by r48861 bug-29840-20090929174908.patch text/plain 4076 ukai ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA5ZjY1MDQyLi41ZWU0ZmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDktMDkt MjkgIEZ1bWl0b3NoaSBVa2FpICA8dWthaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IDQgbGF5b3V0IHRlc3QgZmFpbHVy ZXMgYnkgd2Via2l0IHI0ODg2MS4KKyAgICAgICAgaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9Mjk4NDAKKworICAgICAgICByNDg4NjEgaW50cm9kdWNlZCBleHBlcmltZW50 YWxXZWJTb2NrZXRzRW5hYmxlZCwgYW5kIGZhbHNlIGJ5IGRlZmF1bHQuCisgICAgICAgIFdoZW4g ZXhwZXJyaW1lbnRhbFdlYlNvY2tldHNFbmFibGVkIGlzIGZhbHNlLCB3aW5kb3cuV2ViU29ja2V0 IGlzCisgICAgICAgIHVuZGVmaW5lZCwgaW5zdGVhZCBvZiBhIGNvbnN0cnVjdG9yLgorCisgICAg ICAgICogZmFzdC9kb20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBmYXN0L2RvbS9wcm90b3R5cGUtaW5oZXJpdGFuY2UtMi1leHBlY3RlZC50eHQ6Cisg ICAgICAgICogZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLWV4cGVjdGVkLnR4dDoKKyAg ICAgICAgKiBmYXN0L2pzL2dsb2JhbC1jb25zdHJ1Y3RvcnMtZXhwZWN0ZWQudHh0OgorCiAyMDA5 LTA5LTI4ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGF2aWQgS2lsemVyLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3dpbmRvdy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zh c3QvZG9tL1dpbmRvdy93aW5kb3ctcHJvcGVydGllcy1leHBlY3RlZC50eHQKaW5kZXggZTQ4NjUw ZS4uYzgwZDVhNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3dpbmRv dy1wcm9wZXJ0aWVzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5k b3cvd2luZG93LXByb3BlcnRpZXMtZXhwZWN0ZWQudHh0CkBAIC0xNTIwLDEzICsxNTIwLDcgQEAg d2luZG93LldlYktpdFBvaW50IFtvYmplY3QgV2ViS2l0UG9pbnRDb25zdHJ1Y3Rvcl0KIHdpbmRv dy5XZWJLaXRQb2ludC5wcm90b3R5cGUgW29iamVjdCBXZWJLaXRQb2ludFByb3RvdHlwZV0KIHdp bmRvdy5XZWJLaXRUcmFuc2l0aW9uRXZlbnQgW29iamVjdCBXZWJLaXRUcmFuc2l0aW9uRXZlbnRD b25zdHJ1Y3Rvcl0KIHdpbmRvdy5XZWJLaXRUcmFuc2l0aW9uRXZlbnQucHJvdG90eXBlIFtwcmlu dGVkIGFib3ZlIGFzIHdpbmRvdy5FdmVudC5wcm90b3R5cGVdCi13aW5kb3cuV2ViU29ja2V0IFtv YmplY3QgV2ViU29ja2V0Q29uc3RydWN0b3JdCi13aW5kb3cuV2ViU29ja2V0LnByb3RvdHlwZSBb b2JqZWN0IFdlYlNvY2tldFByb3RvdHlwZV0KLXdpbmRvdy5XZWJTb2NrZXQucHJvdG90eXBlLkNM T1NFRCBbbnVtYmVyXQotd2luZG93LldlYlNvY2tldC5wcm90b3R5cGUuQ09OTkVDVElORyBbbnVt YmVyXQotd2luZG93LldlYlNvY2tldC5wcm90b3R5cGUuT1BFTiBbbnVtYmVyXQotd2luZG93Lldl YlNvY2tldC5wcm90b3R5cGUuY2xvc2UgW2Z1bmN0aW9uXQotd2luZG93LldlYlNvY2tldC5wcm90 b3R5cGUuc2VuZCBbZnVuY3Rpb25dCit3aW5kb3cuV2ViU29ja2V0IFt1bmRlZmluZWRdCiB3aW5k b3cuV2hlZWxFdmVudCBbb2JqZWN0IFdoZWVsRXZlbnRDb25zdHJ1Y3Rvcl0KIHdpbmRvdy5XaGVl bEV2ZW50LnByb3RvdHlwZSBbcHJpbnRlZCBhYm92ZSBhcyB3aW5kb3cuRXZlbnQucHJvdG90eXBl XQogd2luZG93LldvcmtlciBbb2JqZWN0IFdvcmtlckNvbnN0cnVjdG9yXQpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLTItZXhwZWN0ZWQudHh0 IGIvTGF5b3V0VGVzdHMvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLTItZXhwZWN0ZWQu dHh0CmluZGV4IDc4ZDhjNGIuLjY0NjZmNmIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qv ZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS0yLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0 cy9mYXN0L2RvbS9wcm90b3R5cGUtaW5oZXJpdGFuY2UtMi1leHBlY3RlZC50eHQKQEAgLTI5MSw3 ICsyOTEsNiBAQCBOZXZlciBmb3VuZCBUZXh0TWV0cmljcwogTmV2ZXIgZm91bmQgV2ViS2l0Q1NT TWF0cml4CiBOZXZlciBmb3VuZCBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZQogTmV2ZXIgZm91bmQg V2ViS2l0UG9pbnQKLU5ldmVyIGZvdW5kIFdlYlNvY2tldAogTmV2ZXIgZm91bmQgV29ya2VyCiBO ZXZlciBmb3VuZCBYTUxIdHRwUmVxdWVzdAogTmV2ZXIgZm91bmQgWE1MSHR0cFJlcXVlc3RVcGxv YWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5j ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2RvbS9wcm90b3R5cGUtaW5oZXJpdGFu Y2UtZXhwZWN0ZWQudHh0CmluZGV4IGZhNWNjMmQuLmJmNGI3MGQgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2Zhc3QvZG9tL3Byb3RvdHlwZS1pbmhlcml0YW5jZS1leHBlY3RlZC50eHQKKysrIGIv TGF5b3V0VGVzdHMvZmFzdC9kb20vcHJvdG90eXBlLWluaGVyaXRhbmNlLWV4cGVjdGVkLnR4dApA QCAtMzM3LDggKzMzNyw2IEBAIFBBU1MgaW5uZXIuV2ViS2l0UG9pbnQuaXNJbm5lciBpcyB0cnVl CiBQQVNTIGlubmVyLldlYktpdFBvaW50LmNvbnN0cnVjdG9yLmlzSW5uZXIgaXMgdHJ1ZQogUEFT UyBpbm5lci5XZWJLaXRUcmFuc2l0aW9uRXZlbnQuaXNJbm5lciBpcyB0cnVlCiBQQVNTIGlubmVy LldlYktpdFRyYW5zaXRpb25FdmVudC5jb25zdHJ1Y3Rvci5pc0lubmVyIGlzIHRydWUKLVBBU1Mg aW5uZXIuV2ViU29ja2V0LmlzSW5uZXIgaXMgdHJ1ZQotUEFTUyBpbm5lci5XZWJTb2NrZXQuY29u c3RydWN0b3IuaXNJbm5lciBpcyB0cnVlCiBQQVNTIGlubmVyLldoZWVsRXZlbnQuaXNJbm5lciBp cyB0cnVlCiBQQVNTIGlubmVyLldoZWVsRXZlbnQuY29uc3RydWN0b3IuaXNJbm5lciBpcyB0cnVl CiBQQVNTIGlubmVyLldvcmtlci5pc0lubmVyIGlzIHRydWUKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvanMvZ2xvYmFsLWNvbnN0cnVjdG9ycy1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9mYXN0L2pzL2dsb2JhbC1jb25zdHJ1Y3RvcnMtZXhwZWN0ZWQudHh0CmluZGV4IDBkMzE2YTIu Ljc0MjMyNWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvanMvZ2xvYmFsLWNvbnN0cnVj dG9ycy1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9qcy9nbG9iYWwtY29uc3Ry dWN0b3JzLWV4cGVjdGVkLnR4dApAQCAtMTYzLDcgKzE2Myw2IEBAIFBBU1MgV2ViS2l0Q1NTTWF0 cml4LnRvU3RyaW5nKCkgaXMgJ1tvYmplY3QgV2ViS2l0Q1NTTWF0cml4Q29uc3RydWN0b3JdJwog UEFTUyBXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZS50b1N0cmluZygpIGlzICdbb2JqZWN0IFdlYktp dENTU1RyYW5zZm9ybVZhbHVlQ29uc3RydWN0b3JdJwogUEFTUyBXZWJLaXRQb2ludC50b1N0cmlu ZygpIGlzICdbb2JqZWN0IFdlYktpdFBvaW50Q29uc3RydWN0b3JdJwogUEFTUyBXZWJLaXRUcmFu c2l0aW9uRXZlbnQudG9TdHJpbmcoKSBpcyAnW29iamVjdCBXZWJLaXRUcmFuc2l0aW9uRXZlbnRD b25zdHJ1Y3Rvcl0nCi1QQVNTIFdlYlNvY2tldC50b1N0cmluZygpIGlzICdbb2JqZWN0IFdlYlNv Y2tldENvbnN0cnVjdG9yXScKIFBBU1MgV2hlZWxFdmVudC50b1N0cmluZygpIGlzICdbb2JqZWN0 IFdoZWVsRXZlbnRDb25zdHJ1Y3Rvcl0nCiBQQVNTIFdvcmtlci50b1N0cmluZygpIGlzICdbb2Jq ZWN0IFdvcmtlckNvbnN0cnVjdG9yXScKIFBBU1MgWE1MRG9jdW1lbnQudG9TdHJpbmcoKSBpcyAn W29iamVjdCBEb2N1bWVudENvbnN0cnVjdG9yXSc=