29831 2009-09-28 15:38:32 -0700 Add Cairo WebKitLibraries dir to debug_wincairo.vsprops 2009-10-19 15:28:51 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows 7 RESOLVED FIXED P2 Normal --- 0 mculpepper webkit-unassigned commit-queue oldest_to_newest 150690 0 mculpepper 2009-09-28 15:38:32 -0700 This is an extension of https://bugs.webkit.org/show_bug.cgi?id=29661 This patch makes Win32/Cairo build using --debug from a vanilla setup 150693 1 40266 mculpepper 2009-09-28 15:42:44 -0700 Created attachment 40266 patch 150747 2 40266 eric 2009-09-28 17:23:12 -0700 Comment on attachment 40266 patch Every change requires a ChangeLog. See http://webkit.org/coding/contributing.html 150790 3 40280 mculpepper 2009-09-28 20:46:04 -0700 Created attachment 40280 patch #2 woops! ChangeLog added :) 151939 4 40280 eric 2009-10-02 12:39:08 -0700 Comment on attachment 40280 patch #2 You ChangeLog should have a newline after your entry like all the other ChangeLog entries. :) prepare-ChangeLog will generate the proper template for you. prepare-ChangeLog --bug 29831 even puts the bug information in the for you. You'll need to post a corrected patch if you want this auto-committed. 155626 5 41407 mculpepper 2009-10-19 02:58:18 -0700 Created attachment 41407 patch #3 Sorry about that, I actually used prepare-ChangeLog this time :) 155949 6 41407 eric 2009-10-19 15:18:04 -0700 Comment on attachment 41407 patch #3 LGTM. 155960 7 41407 commit-queue 2009-10-19 15:28:47 -0700 Comment on attachment 41407 patch #3 Clearing flags on attachment: 41407 Committed r49817: <http://trac.webkit.org/changeset/49817> 155961 8 commit-queue 2009-10-19 15:28:51 -0700 All reviewed patches have been landed. Closing bug. 40266 2009-09-28 15:42:44 -0700 2009-09-28 20:46:04 -0700 patch 0001-added-cairo-include-and-lib-directories-to-debug_win.patch text/plain 1018 mculpepper RnJvbSBlNTNmMTgzNTc2M2UxM2IzOTU1YzZmNWU4YWUxMjVlZmJlM2MyMzMzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBtYXJzaGFsbCA8bWN1bHBlcHBlckBhcHBjZWxlcmF0b3IuY29t PgpEYXRlOiBNb24sIDI4IFNlcCAyMDA5IDE3OjM3OjMwIC0wNTAwClN1YmplY3Q6IFtQQVRDSF0g YWRkZWQgY2Fpcm8gaW5jbHVkZSBhbmQgbGliIGRpcmVjdG9yaWVzIHRvIGRlYnVnX3dpbmNhaXJv LnZzcHJvcHMKCi0tLQogLi4uL3dpbi90b29scy92c3Byb3BzL2RlYnVnX3dpbmNhaXJvLnZzcHJv cHMgICAgICAgfCAgICAyICsrCiAxIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJv cHMvZGVidWdfd2luY2Fpcm8udnNwcm9wcyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNw cm9wcy9kZWJ1Z193aW5jYWlyby52c3Byb3BzCmluZGV4IDBlN2RiMTMuLjdkNDI0ZTYgMTAwNjQ0 Ci0tLSBhL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z193aW5jYWlyby52 c3Byb3BzCisrKyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z193aW5j YWlyby52c3Byb3BzCkBAIC0xMCwxMCArMTAsMTIgQEAKIAkJTWluaW1hbFJlYnVpbGQ9InRydWUi DQogCQlCYXNpY1J1bnRpbWVDaGVja3M9IjMiDQogCQlSdW50aW1lTGlicmFyeT0iMiINCisJCUFk ZGl0aW9uYWxJbmNsdWRlRGlyZWN0b3JpZXM9IiZxdW90OyQoV2ViS2l0TGlicmFyaWVzRGlyKVxp bmNsdWRlXGNhaXJvJnF1b3Q7Ig0KIAkvPg0KIAk8VG9vbA0KIAkJTmFtZT0iVkNMaW5rZXJUb29s Ig0KIAkJTGlua0luY3JlbWVudGFsPSIyIg0KKwkJQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmll cz0iJnF1b3Q7JChXZWJLaXRMaWJyYXJpZXNEaXIpXGxpYiZxdW90OyINCiAJLz4NCiAJPFVzZXJN YWNybw0KIAkJTmFtZT0iV2ViS2l0Q29uZmlnU3VmZml4Ig0KLS0gCjEuNi40LjIKCg== 40280 2009-09-28 20:46:04 -0700 2009-10-19 02:58:18 -0700 patch #2 0001-added-cairo-include-and-lib-directories-to-debug_win.patch text/plain 1645 mculpepper RnJvbSAxMWQ5NTA1OWRkMTI3NjRkZTUwNDA1NzVkN2U4NzIzZDAwZjY0MjM4IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJzaGFsbCBDdWxwZXBwZXIgPG1jdWxwZXBwZXJAYXBwY2Vs ZXJhdG9yLmNvbT4KRGF0ZTogTW9uLCAyOCBTZXAgMjAwOSAyMjo0MDowMSAtMDUwMApTdWJqZWN0 OiBbUEFUQ0hdIGFkZGVkIGNhaXJvIGluY2x1ZGUgYW5kIGxpYiBkaXJlY3RvcmllcyB0byBkZWJ1 Z193aW5jYWlyby52c3Byb3BzCgotLS0KIFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAgOCArKysrKysrKwogLi4uL3dpbi90b29scy92c3Byb3Bz L2RlYnVnX3dpbmNhaXJvLnZzcHJvcHMgICAgICAgfCAgICAyICsrCiAyIGZpbGVzIGNoYW5nZWQs IDEwIGluc2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViS2l0TGli cmFyaWVzL0NoYW5nZUxvZyBiL1dlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKaW5kZXggNmEzMzk0 My4uOWQzNWM0YiAxMDA2NDQKLS0tIGEvV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZworKysgYi9X ZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDktMjggIE1h cnNoYWxsIEN1bHBlcHBlciAgPG1jdWxwZXBwZXJAYXBwY2VsZXJhdG9yLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBhZGRlZCBjYWlybyBpbmNs dWRlIGFuZCBsaWIgZGlyZWN0b3JpZXMgdG8gZGVidWdfd2luY2Fpcm8udnNwcm9wcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mjk4MzEKKworICAgICAg ICAqIHdpbi90b29scy92c3Byb3BzL2RlYnVnX3dpbmNhaXJvLnZzcHJvcHM6IAogMjAwOS0wOS0y NSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gUm9iZW4uCmRpZmYgLS1naXQgYS9XZWJLaXRMaWJyYXJpZXMvd2luL3Rvb2xzL3ZzcHJv cHMvZGVidWdfd2luY2Fpcm8udnNwcm9wcyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNw cm9wcy9kZWJ1Z193aW5jYWlyby52c3Byb3BzCmluZGV4IDBlN2RiMTMuLjdkNDI0ZTYgMTAwNjQ0 Ci0tLSBhL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z193aW5jYWlyby52 c3Byb3BzCisrKyBiL1dlYktpdExpYnJhcmllcy93aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z193aW5j YWlyby52c3Byb3BzCkBAIC0xMCwxMCArMTAsMTIgQEAKIAkJTWluaW1hbFJlYnVpbGQ9InRydWUi DQogCQlCYXNpY1J1bnRpbWVDaGVja3M9IjMiDQogCQlSdW50aW1lTGlicmFyeT0iMiINCisJCUFk ZGl0aW9uYWxJbmNsdWRlRGlyZWN0b3JpZXM9IiZxdW90OyQoV2ViS2l0TGlicmFyaWVzRGlyKVxp bmNsdWRlXGNhaXJvJnF1b3Q7Ig0KIAkvPg0KIAk8VG9vbA0KIAkJTmFtZT0iVkNMaW5rZXJUb29s Ig0KIAkJTGlua0luY3JlbWVudGFsPSIyIg0KKwkJQWRkaXRpb25hbExpYnJhcnlEaXJlY3Rvcmll cz0iJnF1b3Q7JChXZWJLaXRMaWJyYXJpZXNEaXIpXGxpYiZxdW90OyINCiAJLz4NCiAJPFVzZXJN YWNybw0KIAkJTmFtZT0iV2ViS2l0Q29uZmlnU3VmZml4Ig0KLS0gCjEuNi40LjIKCg== 41407 2009-10-19 02:58:18 -0700 2009-10-19 15:28:47 -0700 patch #3 0001-added-cairo-include-and-lib-directories-to-debug_win.patch text/plain 1656 mculpepper RnJvbSBlZjAwOTcxNTA0MzlmMTZlZjQzNGMwYjY3NWJiZmYxODQ5Yzg5YzhkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJzaGFsbCBDdWxwZXBwZXIgPG1jdWxwZXBwZXJAYXBwY2Vs ZXJhdG9yLmNvbT4KRGF0ZTogTW9uLCAxOSBPY3QgMjAwOSAwNDo1NDowMCAtMDUwMApTdWJqZWN0 OiBbUEFUQ0hdIGFkZGVkIGNhaXJvIGluY2x1ZGUgYW5kIGxpYiBkaXJlY3RvcmllcyB0byBkZWJ1 Z193aW5jYWlyby52c3Byb3BzCgotLS0KIFdlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAgOSArKysrKysrKysKIC4uLi93aW4vdG9vbHMvdnNwcm9w cy9kZWJ1Z193aW5jYWlyby52c3Byb3BzICAgICAgIHwgICAgMiArKwogMiBmaWxlcyBjaGFuZ2Vk LCAxMSBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdExp YnJhcmllcy9DaGFuZ2VMb2cgYi9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCmluZGV4IGNmNTcz YzYuLjRlODJhNjUgMTAwNjQ0Ci0tLSBhL1dlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cKKysrIGIv V2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDA5LTEwLTE5ICBN YXJzaGFsbCBDdWxwZXBwZXIgIDxtY3VscGVwcGVyQGFwcGNlbGVyYXRvci5jb20+CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYWRkZWQgY2Fpcm8gaW5j bHVkZSBhbmQgbGliIGRpcmVjdG9yaWVzIHRvIGRlYnVnX3dpbmNhaXJvLnZzcHJvcHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTI5ODMxCisKKyAgICAg ICAgKiB3aW4vdG9vbHMvdnNwcm9wcy9kZWJ1Z193aW5jYWlyby52c3Byb3BzOgorCiAyMDA5LTEw LTE2ICBTdGV2ZSBGYWxrZW5idXJnICA8c2ZhbGtlbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYktpdExpYnJhcmllcy93aW4v dG9vbHMvdnNwcm9wcy9kZWJ1Z193aW5jYWlyby52c3Byb3BzIGIvV2ViS2l0TGlicmFyaWVzL3dp bi90b29scy92c3Byb3BzL2RlYnVnX3dpbmNhaXJvLnZzcHJvcHMKaW5kZXggMGU3ZGIxMy4uN2Q0 MjRlNiAxMDA2NDQKLS0tIGEvV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3BzL2RlYnVn X3dpbmNhaXJvLnZzcHJvcHMKKysrIGIvV2ViS2l0TGlicmFyaWVzL3dpbi90b29scy92c3Byb3Bz L2RlYnVnX3dpbmNhaXJvLnZzcHJvcHMKQEAgLTEwLDEwICsxMCwxMiBAQAogCQlNaW5pbWFsUmVi dWlsZD0idHJ1ZSINCiAJCUJhc2ljUnVudGltZUNoZWNrcz0iMyINCiAJCVJ1bnRpbWVMaWJyYXJ5 PSIyIg0KKwkJQWRkaXRpb25hbEluY2x1ZGVEaXJlY3Rvcmllcz0iJnF1b3Q7JChXZWJLaXRMaWJy YXJpZXNEaXIpXGluY2x1ZGVcY2Fpcm8mcXVvdDsiDQogCS8+DQogCTxUb29sDQogCQlOYW1lPSJW Q0xpbmtlclRvb2wiDQogCQlMaW5rSW5jcmVtZW50YWw9IjIiDQorCQlBZGRpdGlvbmFsTGlicmFy eURpcmVjdG9yaWVzPSImcXVvdDskKFdlYktpdExpYnJhcmllc0RpcilcbGliJnF1b3Q7Ig0KIAkv Pg0KIAk8VXNlck1hY3JvDQogCQlOYW1lPSJXZWJLaXRDb25maWdTdWZmaXgiDQotLSAKMS42LjQu MgoK